GitLab

I remove the dagger-android dependency (https://google.github.io/dagger/android).
It is supposed to simplify injection into Activities and other Android components, however it's questionable that it actually makes things simpler.
It seems, we can do very well without it and remove the extra bloat that it brings.

This also takes care of the problem with .info files not having been properly added when introducing dagger 2 in https://chromium-review.googlesource.com/1183903, which was then worked around in https://chromium-review.googlesource.com/1183903.

TBR=jochen

Bug: 787005
Change-Id: Ie6c0de694a7e73303be784dea25ccc0805c4a3f8
Reviewed-on: https://chromium-review.googlesource.com/1193362
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587607}

No need for the vector here

R=yosin@chromium.org,kojii@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I420acd918a937b1a01071f5fe9ada44db16a1d53
Reviewed-on: https://chromium-review.googlesource.com/1196369Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587606}

The new values are:
- RollbackAndRestoreIfPossible: always roll back, but try to save and
  restore data if possible.
- RollbackWithRestoreOnly: only roll back if it's possible to save and
  restore data.

Bug: 878736
Change-Id: I0455ee4c38537430cb27a86befe51d09d6e312ef
Reviewed-on: https://chromium-review.googlesource.com/1194124Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587605}

The latter is simpler, and allows for some code removal.

BUG=none

Change-Id: Ifaf2fd855e07c2c56cbc13920f17acd29055b9ed
Reviewed-on: https://chromium-review.googlesource.com/1196233Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587604}

This CL adds RecordHitTestData in SVGImagePainter to compute touch
action rects during paint. A layout test is also added.

This CL also put the RecordHitTestData in SVGModelObjectPainter
so that both SVGImagePainter and SVGShapePainter can call.

Bug: 876468
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6aabbad8ac10fc4fb25e4ec16b7a53cbc6cfff27
Reviewed-on: https://chromium-review.googlesource.com/1196903
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587603}

Update clang_version from 7.0.0 to 8.0.0 and remove the code to remove
the old library directory.

Remove the _LIBCPP_HIDE_FROM_ABI define, it is no longer needed.

R=hans@chromium.org,thakis@chromium.org

Bug: 871418, 872926
Change-Id: Ibf6734500aa75a349fa772b225b8b15fddfe3661
Reviewed-on: https://chromium-review.googlesource.com/1194698Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587602}

This CL changes the way the frame of the WebView is changed, moving the
implementation to the FullscreenMediator.

Bug: 836730
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Idc8b339ea61d4024268549789f18ec10c64f0d54
Reviewed-on: https://chromium-review.googlesource.com/1194226
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587601}

Nobody reads these params, and one is passed by non-const ref.

Change-Id: I6913edb40e9bdf5cb3e58b5827d49dd48861540c
Reviewed-on: https://chromium-review.googlesource.com/1188636Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587600}

While prefixes for integer encoding were always at least 4 bits long in HPACK,
QPACK needs a 3-bit prefix, see Sections 5.4.2.4. and 5.4.2.5. at
https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#rfc.section.5.4.2

This change is a no-op, because every line changed is test, or comment,
or making a DCHECK more premissive.

The encoding and decoding logic is generic enough that it does not need to be
changed.

This CL lands server change 209625672 by bnc.

BUG=488484

Change-Id: Ia4e046221b3e960827582f964a386d3027ce1797
Reviewed-on: https://chromium-review.googlesource.com/1190322
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587599}

Migrate from BrowserDistribution to install_static. No functional
change.

BUG=none
R=zmin@chromium.org

Change-Id: I3d10e621d223ccff16edeb39bdb3ad6322c5901b
Reviewed-on: https://chromium-review.googlesource.com/1196016Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587598}

This change updates the Windows Advertisement Payload for Cable to match
a more recent version of the Cable spec.

TBR=arnarb@chromium.org,kpaulhamus@chromium.org

Bug: 837088
Change-Id: Id670a6534c9d23cdeea241c364e3350f6c05cf1e
Reviewed-on: https://chromium-review.googlesource.com/1196512
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587597}

Fix a bug in which hitting the delete key
while an autocomplete suggestion was displayed
deleted the autocomplete suggestion and the
previous character.

Bug: 878485
Change-Id: If7e5486c098d3e9ce1c742dd4ed7ed228187160d
Reviewed-on: https://chromium-review.googlesource.com/1194988Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#587596}

The detectFilesToExtract was returning a list of paths to assets files.
Such path included a directory within assets (e.g. locales/en-US.pak)
but the code that is checking file existense is expecting just name here
(e.g. en-US.pak). This mismatch caused existense check to always fail.

BUG=877033

Change-Id: I93f2e2cdc529ae7f4bf15aac21730853e1ef265e
Reviewed-on: https://chromium-review.googlesource.com/1186465Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587595}

Replaces the "default app" boolean with an enum. If the enum has a
kFromPolicy value, the InstallationTask marks the installed app as
"policy installed" which means that the app will behave like other
policy installed apps e.g. won't sync, user won't be able to uninstall
them, etc.

Bug: 876173
Change-Id: I37821523387cdccd4150ac3c600c94dd9c510050
Reviewed-on: https://chromium-review.googlesource.com/1195181
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587594}

Using wpt-import in Chromium 60647a0f.
With Chromium commits locally applied on WPT:
b4c81942 "Upstream image_capture tests to WPT"
85f4b309 "Notify andruud on changes to wpt/css/css-properties-values-api."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23661

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I88c8432c656df9ac15a171755c06a7d1ab60ffce
Reviewed-on: https://chromium-review.googlesource.com/1196904
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587593}

The algorithm that performs the test between browser language preference
and the systemLanguage value has been modified
to implement a language-tag match based on the prefix,
making it consistent with BCP 47's basic filter operation and
as specified in the SVG 1.1 spec.

The previous behavior was:

- Tests whether the value of the attribute (e.g., "en-us") is a prefix
of the user preferred language (e.g., "en")
(which would evaluate to false)

The test was modified to compare in the opposite manner,
now user preferred language must be a prefix of the value.

- If the language tag length was not 2, the language tag
was not matched, (e.g. It did not match "en-us" to "en-us").
This check has been removed.

- The algorithm did not check for a trailing hyphen ("-").
We do not want langtag "it" matching langtag "ita",
but it is ok for "it" to match "it-it".
Now it does.

------------

The algorithm that performs the test between browser language preference
and the systemLanguage value has been modified
to implement a case insensitive language-tag match:

"en" matches "EN".

The previous behavior was case sensitive.

------------

Add Luca Di Domenico to AUTHORS

------------

Bug: 872378, 869440
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibe767644b5a92e8d79ffe4b7777f5f51851b3883
Reviewed-on: https://chromium-review.googlesource.com/1188314
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#587592}

This makes sure extension internal keep_alive_count counter decrement
when user clicks "Close" button on the Picture-in-Picture window.

Bug: 878743

Change-Id: I4a82ba3e0fa3c3de7241e73352ced30e14c59ca1
Reviewed-on: https://chromium-review.googlesource.com/1193877Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#587591}

The 'available offline content on net error page' experiment, we want to
hide the normal error text, and show it on a popup instead. See these slides for
context: (internal link)
http://slides/14nEG6dYBf0Cb3srp8by0g9Pw_hwM-1TTXQ836xnYvaY#slide=id.g3b90c04859_0_54

Bug: 852872
Change-Id: Id5c8d5d09bb3098a29f8564d30f15ea7f5f748dd
Reviewed-on: https://chromium-review.googlesource.com/1194261
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587590}

TBR: tedchoc@chromium.org
Bug: 879165
Change-Id: I3641bcb810ac915e837d469f0612bd37623fe076
Reviewed-on: https://chromium-review.googlesource.com/1196516Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587589}

This is an attempt to get rid of rare runtime crashes
in this function (see relevant bug entry for details).

The main idea is to get rid of the /proc/self/maps
parsing step in each WriteLinkMapField() invokation.
Since the page to be modified cannot be PROT_EXEC, simply
forcing it to PROT_READ|PROT_WRITE unconditionally
with mprotect() should be equivalent. And because the
function is now much faster, this should reduce the
chances of a racy conflict with the system linker.

Alas, it is not possible to completely remove races
here.

Also note that the previous code didn't handle the case
where the mprotect() failed, and would try to write to the
page nevertheless. This is fixed in this patch.

BUG=831403
R=pasko@chromium.org, rmcilroy@chromium.org, agrieve@chromium.org

Change-Id: Iafeb9e78af3cac5a0335dd9ba1950477566ecd0b
Reviewed-on: https://chromium-review.googlesource.com/1196505Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587588}

Bug: 847933
Change-Id: I8cd925a86d7c5eb15dc36dd67d639d13ed041541
Reviewed-on: https://chromium-review.googlesource.com/1194490
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587587}

This is to prevent the popup from growing on very long password fields.

TBR=rouslan@chromium.org

Bug: 873121
Change-Id: Ia45a59003405181f968897d2d333969b20c3f127
Reviewed-on: https://chromium-review.googlesource.com/1194010
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587586}

Bug: 877493
Change-Id: Ic7b2fafd81aa6b6d46bd390a560c26a4fd0f1c4f
Reviewed-on: https://chromium-review.googlesource.com/1191463Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587585}

Remove some unused code.  Rename and inline new method.

This CL lands server change 209092546 by bnc.

BUG=488484

Change-Id: Ief87a170554fe3829b5b1fe9e9d470af183889fe
Reviewed-on: https://chromium-review.googlesource.com/1190323
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587584}

This queues a report through the Reporting API whenever send() is called
on a synchronous XMLHttpRequest object from a frame in which sync-xhr is
not allowed according to feature policy.

Bug: 867471
Change-Id: If778ea5517fb5728992fe8287b278d1af729902f
Reviewed-on: https://chromium-review.googlesource.com/1191404Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587583}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/658ff786a213..669ac87aa7ab

$ git log 658ff786a..669ac87aa --date=short --no-merges --format='%ad %ae %s'
2018-08-29 dor1s [libFuzzer] Remove mutation stats and weighted mutation selection.
2018-08-29 morehouse Revert "[libFuzzer] Port to Windows"
2018-08-29 morehouse [libFuzzer] Port to Windows
2018-08-28 morehouse Revert "[libFuzzer] Port to Windows"
2018-08-28 morehouse [libFuzzer] Port to Windows
2018-08-27 phosek [sanitizer][fuzzer] Transition back to ZX_TIME_INFINITE
2018-08-17 morehouse Revert "[libFuzzer] Use std::discrete_distribution for input selection."
2018-08-17 morehouse [libFuzzer] Use std::discrete_distribution for input selection.

Created with:
  roll-dep src/third_party/libFuzzer/src

Bug: 854277
Change-Id: I1fc0d0ca35931df9f2af2b11b8ac360ee9d06bf3
Reviewed-on: https://chromium-review.googlesource.com/1196902Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587582}

The CL that generates this data is
https://chromium-review.googlesource.com/c/1105397

BUG=chromium:625387

Change-Id: Ib8439e0a3b9d41d4dd5ecbfe2d49888465cf89f9
Reviewed-on: https://chromium-review.googlesource.com/1179968Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587581}

This adds the plumbing that exposes the attribute dynamically. So that
it is only bound when a translate service is available. The translate
team will hook into the frame load request to grab the attribute
from the anchor.

Doc: https://github.com/dtapuska/html-translate
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/hmASm1yhi5s/7vqmt7CwDgAJ

BUG=872777

Change-Id: I0004fe33afeaf3255031bc87f47c7f4d1209ffc8
Reviewed-on: https://chromium-review.googlesource.com/1175031
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587580}

This change implements BluetoothAdapterWinrt::IsPowered(). While the UWP
APIs to retrieve a radio from the adapter are not yet available to
Chrome, it is possible to retrieve a DeviceInformation list
corresponding to powered radios on the system. This is used in this CL
to determine whether the default adapter is powered or not.

Bug: 821766
Change-Id: Iaff0799ced2d96bf7d4d6249f5ac7a294866d669
Reviewed-on: https://chromium-review.googlesource.com/1065824
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587579}

https://skia.googlesource.com/skia.git/+log/f7c723c93d26..cd7907b57d76


git log f7c723c93d26..cd7907b57d76 --date=short --no-merges --format='%ad %ae %s'
2018-08-30 bsalomon@google.com Revert "Reland "Add ability to specify different GP textures for each mesh in a draw.""


Created with:
  gclient setdep -r src/third_party/skia@cd7907b57d76

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:877598,chromium:877602,chromium:877610
TBR=stephana@chromium.org

Change-Id: If6695aa3f072747f8fd260b043e208214be01188
Reviewed-on: https://chromium-review.googlesource.com/1196842Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587578}

This bot is a debug build, so needs to pass the --debug flag to the
webkit_layout_tests script.

Bug: 876029
Change-Id: Iabb8e480607c8e2e5962f54fb20ccbb0efab05d0
Reviewed-on: https://chromium-review.googlesource.com/1195710
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587577}

This reverts commit 025bf217.

Reason for revert: Broke changes in //testing/buildbot. Will reland with a fix to that. Sheriffs should still not be alerted to failures on these bots in sheriff-o-matic even when this is reverted.

Original change's description:
> Remove Windows debug bots from consoles
> 
> They've been a bit flaky, and I don't want to bother sheriffs with them
> yet.
> 
> Bug: 878915
> Change-Id: Ia37db9742e3bf7e58a2efba8ab4032f7b121620e
> Reviewed-on: https://chromium-review.googlesource.com/1195926
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587409}

TBR=hinoka@chromium.org,nodir@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

Change-Id: Ib07cce63148a2f9f8de20bff0d8bf50d8c0acc2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878915
Reviewed-on: https://chromium-review.googlesource.com/1196983Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587576}

Using the transport switch drop-down menu, it is possible to cycle away
from and then back to the Touch ID sheet, which currently causes the
request to be dispatched onto the TouchIdAuthenticator each time the
sheet is shown. This sort of works in the production build (it restarts
the request, which will make the Touch ID dialog disappear and then
reappear). In debug, however, it crashes on a DCHECK.

We haven't defined whether a FidoAuthenticator should be able to handle
multiple invocations of MakeCredential/GetAssertion over the lifetime of
the instance. Hence, the UI should stop doing this.

Bug: 678128,847985
Change-Id: Id008de98bc8aa6477e9863ca2e22cd136316b423
Reviewed-on: https://chromium-review.googlesource.com/1196427
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587575}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ia5b169dae58a01205c35b10af4ff968383ad79b8
Reviewed-on: https://chromium-review.googlesource.com/1196923
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587574}

setBackground() changes the padding of the TextView to the one of the
background, so setPadding() has to be called after and not before.

Bug: 878670
Change-Id: I421a08ebfb4f06686dbbd151fbb9095f1af10d65
Reviewed-on: https://chromium-review.googlesource.com/1196546Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587573}

Submenus don't have command IDs AFAICT, so this will always fail.

Bug: None
Change-Id: I5bc7c4292c02f515fd11594b69871d2cbf342627
Reviewed-on: https://chromium-review.googlesource.com/1195829Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587572}

These conditions are no longer needed, as real import commits have
'No-Export: true' in their commit message.

Bug: 879128
Change-Id: I829373c595931d8b221066b4edbb55bcb4db8cb7
Reviewed-on: https://chromium-review.googlesource.com/1196447Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587571}

This CL contains extraction of boiler plate related to creating
of NewPasswordFormManager in a separate function. That's especially
convenient since a new constructor argument will be added in CL
https://chromium-review.googlesource.com/c/chromium/src/+/1169061.

Bug: 831123
Change-Id: I8144ea71a824e80ba37528f4b1c7d86d0ae40ce5
Reviewed-on: https://chromium-review.googlesource.com/1196502
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587570}

Bug: chromium:843903
Change-Id: I4c5cce82cec4d60cf1d5cd4508031601363f16aa
Reviewed-on: https://chromium-review.googlesource.com/1193225
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587569}

This CL uses ScopedBlockingCall to mark blocking calls in /components/signin.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=droger@chromium.org

Bug: 874080
Change-Id: I8299421165b4f9be1a6f45c8ba4e013853468073
Reviewed-on: https://chromium-review.googlesource.com/1191097Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587568}