GitLab

1. Take OAuth client ID in JSON
2. Use protocol from devsite (still needs work)

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/294793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271505 0039d316-1c4b-4281-b951-d872f2087c98

This is currently causing a top crasher; tfarina@ rebuilt on a branch
without this patch and have confirmed that reverting it fixes the crash.

Reverting at the request of the TPMs.

> Fix WebURLLoaderImpl::Context leak if a pending request is canceled.
> 
> Now, ResourceDispatcher::CancelPendingRequest will send
> ResourceHostMsg_CancelRequest and trigger OnRequestComplete. However,
> the request is pending and thus OnRequestComplete will be queued.
> 
> There are at least two problems if OnRequestComplete is not called:
> 1. WebURLLoaderImpl::Context will never be released.
> 2. request_info->buffer leaks. The buffer holds shared memory handle
>    (file descriptor). fd leaking may lead to HW video decode failure on
>    ChromeOS (detail in chrome-os-partner:27911#63)
> 
> This issue is similar to issue 328092.
> 
> BUG=chrome-os-partner:27911,chromium:369221,chromium:369128
> R=jam@chromium.org, mmenke@chromium.org
> 
> Review URL: https://codereview.chromium.org/268423002

BUG=372342
TBR=kcwu@chromium.org

Review URL: https://codereview.chromium.org/293823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369409

Review URL: https://codereview.chromium.org/293693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271503 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures. (https://codereview.chromium.org/274193004/)

Reason for revert:
This patch was landed speculatively due to the suspicion that the removal of the ScopedAllowIO was to blame for http://crbug.com/372017. The cause of that issue was found to lie elsewhere.

Original issue's description:
> Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures.
> 
> BUG=61827
> NOTRY=true
> NOTREECHECKS=true
> R=asanka@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269405

TBR=mef@chromium.org
BUG=61827

Review URL: https://codereview.chromium.org/292803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271502 0039d316-1c4b-4281-b951-d872f2087c98

Add test for SimpleGeolocation.

BUG=245075
TEST=none

Review URL: https://codereview.chromium.org/289313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271499 0039d316-1c4b-4281-b951-d872f2087c98

Also log bypass during via header checking and restart browser for each page.

BUG=374413

Review URL: https://codereview.chromium.org/292453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346957

Review URL: https://codereview.chromium.org/290053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271496 0039d316-1c4b-4281-b951-d872f2087c98

Will try to resolve soon.

BUG=374943
NOTRY=true
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/294773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271495 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/290703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271493 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=wjia@chromium.org

Review URL: https://codereview.chromium.org/298433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271491 0039d316-1c4b-4281-b951-d872f2087c98

Design Doc and Proposal here:
https://docs.google.com/a/google.com/document/d/1QWIzDvf_-iZJW8CINvhxzIERwwKeg72302hNUw0ZrSM/edit

This CL depends on https://codereview.chromium.org/275543005/

BUG=371966

Review URL: https://codereview.chromium.org/280023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271490 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271489 0039d316-1c4b-4281-b951-d872f2087c98

This broke the Google Chrome Mac build.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/18028

[3268/23724 | 168.537] RULE Generating binding from ../core/fileapi/FileReader.idl
FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/skia/src/gpu/effects/skia_library.GrDashingEffect.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=206824 -DENABLE_RLZ -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 -DSK_SUPPORT_LEGACY_GETTOPDEVICE -DSK_SUPPORT_LEGACY_N32_NAME -DSK_SUPPORT_LEGACY_BUILDMIPMAP -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0 -DSK_DISABLE_OFFSETIMAGEFILTER_OPTIMIZATION -DSK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK -DIGNORE_ROT_AA_RECT_OPT -DSK_IGNORE_BLURRED_RRECT_OPT -DSK_IGNORE_QUAD_RR_CORNERS_OPT -DSK_GDI_ALWAYS_USE_TEXTMETRICS_FOR_FONT_METRICS '-DSK_DEFAULT_FONT_CACHE_LIMIT=(20*1024*1024)' -DSK_USE_DISCARDABLE_SCALEDIMAGECACHE -DSK_BUILD_FOR_MAC -DSK_GAMMA_SRGB -DSK_GAMMA_CONTRAST=0.0 -DSK_HIGH_QUALITY_IS_LANCZOS -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DSK_IGNORE_UNDERLINE_POSITION_FIX -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/record -I../../third_party/skia/include/utils -I../../third_party/skia/src/core -I../../third_party/skia/src/opts -I../../third_party/skia/src/image -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../.. -I../../skia/config -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/include/utils/mac -I../../third_party/zlib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -O3 -gdwarf-2 -fvisibility=hidden -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wendif-labels -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wno-deprecated-register -Wno-absolute-value -Wno-selector-type-mismatch -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing  -c ../../third_party/skia/src/gpu/effects/GrDashingEffect.cpp -o obj/third_party/skia/src/gpu/effects/skia_library.GrDashingEffect.o
../../third_party/skia/src/gpu/effects/GrDashingEffect.cpp:142:5: error: use of undeclared identifier 'SkPaint2GrPaintShader'
    SkPaint2GrPaintShader(dev, paint, true, &grPaint);
    ^

> Skia roll 14765:14785
> 
> https://code.google.com/p/skia/source/list?num=19&start=14785
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/290713005

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/293803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271488 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/282373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271487 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/291893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271486 0039d316-1c4b-4281-b951-d872f2087c98

[OriginChip] Re-enable the chip when reverting the text in the omnibox.  This ensures that when we revert the text after a navigation or reload, the URL not only disappears but also the origin chip reappears.

BUG=371684

Review URL: https://codereview.chromium.org/293713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271485 0039d316-1c4b-4281-b951-d872f2087c98

TEST=AutomationApiTest.SanityCheck
BUG=360297
TBR=aboxhall,dtseng

Review URL: https://codereview.chromium.org/272923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271479 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271478 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=19&start=14785
TBR=
BUG=

Review URL: https://codereview.chromium.org/290713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271477 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271476 0039d316-1c4b-4281-b951-d872f2087c98

Fix the clock framework in end2end test to allow properly different clocks for sender and receiver.
Make the fake video codec behave more like our other codecs. (Instead of acting like 3-buffer mode)

Review URL: https://codereview.chromium.org/289083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271475 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13182: (sehr) Add android toolchain to the DEPs for native client.
r13183: (yyanagisawa) NO_NACL_GOMA is enabled by default on Windows.
r13184: (sehr) Add chromium_git variable to fix sync
r13186: (jvoung) Remove ImportHostDescCommon and use NaClDescIoDescFromDescAllocCtor instead.
r13187: (dyen) Added a way for toolchain_build to specify run conditions for commands.
r13188: (dschuff) Support windows and mac in buildbot_pnacl.py
r13189: (mseaborn) Fix typo in comment: "requires" -> "require"
r13190: (dschuff) Factor Setup{OS}Environment and SetupGypDefines into buildbot_lib
r13191: (noelallen) Breakout "Environment" for cleanup
r13192: (mseaborn) Cleanup: Use __builtin_trap() instead of dereferencing a null pointer
r13193: (mcgrathr) Set AT_BASE value in nacl_helper_bootstrap
r13194: (dschuff) Revert "PNaCl driver: Put intermediate temp files in system temp dir"
r13195: (mark) Improve nacl_host_desc_big_file_test.
r13196: (dschuff) Fix printing of NaClHandle values in sigpipe_test for Win64
r13197: (dschuff) Build PNaCl toolchain with toolchain_build_pnacl.py in cygwin
r13198: (jvoung) Make a NaClDesc ctor for creating descs from NaClFileInfo.
r13199: (noelallen) Roll Bionic

BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/290813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271474 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374349

Review URL: https://codereview.chromium.org/284223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271473 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a couple of issues with the installer script regarding
installing on machines that don't have both 2010 and 2012 installed.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/290013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144491

Review URL: https://codereview.chromium.org/282153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271470 0039d316-1c4b-4281-b951-d872f2087c98

Fix the flaky KioskAppManageTest::RemoveApp and UpdateAndRemove tests flaky issue caused by file deletion racing condition.

BUG=373473

Review URL: https://codereview.chromium.org/290023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271469 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/)

Reason for revert:
This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095

I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable

Original issue's description:
> [Refactor] Consolidate the logic for whether a widget can be activated.
>
> This is a first step towards giving tooltips their own WindowTreeHosts on Linux.
>
> BUG=353533
> TEST=None
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597

Review URL: https://codereview.chromium.org/297503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271468 0039d316-1c4b-4281-b951-d872f2087c98

R=tim@chromium.org

Review URL: https://codereview.chromium.org/285333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271467 0039d316-1c4b-4281-b951-d872f2087c98

Echo the config's version in uploads based on the config, so the server
can judge what frequency/type of reports to expect.

BUG=356791

Review URL: https://codereview.chromium.org/290473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271466 0039d316-1c4b-4281-b951-d872f2087c98

This broke Android:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/30310
FAILED: /mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Android_Builder/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/content/shell/app/content_shell_lib.shell_main_delegate.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_CONFIGURATION_POLICY -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DENABLE_MANAGED_USERS=1 -DVIDEO_HOLE=1 '-DCONTENT_SHELL_VERSION="19.77.34.5"' -DMOJO_USE_SYSTEM_IMPL -DLIBPEERCONNECTION_LIB=1 -DGTEST_HAS_POSIX_RE=0 -DMEDIA_DISABLE_LIBVPX -DPOSIX_AVOID_MMAP -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_GETTOPDEVICE -DSK_SUPPORT_LEGACY_N32_NAME -DSK_SUPPORT_LEGACY_BUILDMIPMAP -DSK_SUPPORT_LEGACY_SHADER_LOCALMATRIX -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_BUILD_FOR_ANDROID -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DSK_IGNORE_UNDERLINE_POSITION_FIX -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DCHROME_PNG_READ_PACK_SUPPORT -DMESA_EGL_NO_X11_HEADERS -DAPPCACHE_USE_SIMPLE_CACHE -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DANDROID -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -Igen -I../../third_party/WebKit -Igen/content -Igen/net -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../third_party/icu/source/i18n -Igen/ui/gl -I../../third_party/mesa/src/include -I../../v8/include -Igen/webkit -Igen/content/shell -fstack-protector --param=ssp-buffer-size=4 -Werror -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -march=armv7-a -mtune=generic-armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp -mthumb -fno-tree-sra -fno-partial-inlining -fno-early-inlining -fno-tree-copy-prop -fno-tree-loop-optimize -fno-move-loop-invariants -fno-caller-saves -Wno-psabi -mthumb-interwork -ffunction-sections -funwind-tables -g -fstack-protector -fno-short-enums -finline-limit=64 -Wa,--noexecstack --sysroot=/mnt/data/b/build/slave/Android_Builder/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm -I/mnt/data/b/build/slave/Android_Builder/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -funwind-tables -g1 -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-abi  -c ../../content/shell/app/shell_main_delegate.cc -o obj/content/shell/app/content_shell_lib.shell_main_delegate.o
../../content/shell/app/shell_main_delegate.cc: In static member function 'static void content::ShellMainDelegate::InitializeResourceBundle()':
../../content/shell/app/shell_main_delegate.cc:265:17: error: 'kInvalidPlatformFileValue' is not a member of 'base'
   if (pak_fd != base::kInvalidPlatformFileValue) {
                 ^

> Remove stray platform_file.h from webkit
> 
> BUG=322664
> 
> Review URL: https://codereview.chromium.org/289003006

TBR=rvargas@chromium.org

Review URL: https://codereview.chromium.org/293743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271464 0039d316-1c4b-4281-b951-d872f2087c98

If SharedWorkerHost's closed flag is true SharedWorkerServiceImpl::FindSharedWorkerHost() doesn't match the host.
So two SharedWorkerHosts of same SharedWorkerInstance could be created.
But EmbeddedWorkerDevToolsManager can't handle two SharedWorkerHosts of same SharedWorkerInstance.
So we have to remove instance from EmbeddedWorkerDevToolsManager when WorkerContextClosed is called.

BUG=374387

Review URL: https://codereview.chromium.org/287303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/291843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271462 0039d316-1c4b-4281-b951-d872f2087c98

The RenderViewHost creation today takes a CrossProcessFrameConnector pointer, which it uses to decide whether to create a top-level or child frame view. Replace this with a boolean and associate the CrossProcessFrameConnector with the view at a later point in time.

BUG=357747

Review URL: https://codereview.chromium.org/270883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350242

Review URL: https://codereview.chromium.org/286093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/289003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271459 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371805
TBR=mcasas@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/291923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271456 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271455 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271454 0039d316-1c4b-4281-b951-d872f2087c98