- 25 Apr, 2017 33 commits
-
-
hayato authored
This could save 10-20ms in the case (with ShadowRoot) of the bug 699838. See bug 713562 for details. We can do the similar technique for load events on img elements. That can be done as another CL. BUG=367276 Review-Url: https://codereview.chromium.org/2833733002 Cr-Commit-Position: refs/heads/master@{#466863}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=alemate@chromium.org Review-Url: https://codereview.chromium.org/2838603003 Cr-Commit-Position: refs/heads/master@{#466862}
-
dpapad authored
BUG=714824 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2836143004 Cr-Commit-Position: refs/heads/master@{#466861}
-
xiaochengh authored
The above mentioned function used to remove all markers, which is wrong. This patch fixes it to remove only spelling and grammar markers. BUG=713995 TEST=DocumentMarkerControllerTest.RemoveSpellingMarkersUnderWords Review-Url: https://codereview.chromium.org/2838733002 Cr-Commit-Position: refs/heads/master@{#466860}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=alemate@chromium.org Review-Url: https://codereview.chromium.org/2841633003 Cr-Commit-Position: refs/heads/master@{#466859}
-
sque authored
Reads from hwmon in sysfs. This does the same thing as ReadCPUTempInfo() in chrome/browser/chromeos/policy/device_status_collector.cc, but it is available to the rest of Chrome. BUG=chromium:709102 Review-Url: https://codereview.chromium.org/2823583002 Cr-Commit-Position: refs/heads/master@{#466858}
-
engedy authored
For now, the list will still have exactly one Configuration, the one that is parsed from the field trial configuration. Therefore the benefits of this change for now is that tests, which change the configuration after their WebContents is created, will no longer need to inject the new configuration manually into the classes under test, because those classes can now directly work with the authoritative global state. BUG=708181 Review-Url: https://codereview.chromium.org/2831373002 Cr-Commit-Position: refs/heads/master@{#466857}
-
amaralp authored
There is a bug where after "Select All" Smart Select will suggest a different (smaller) selection. This CL checks if the selection only has one word. Since longpress/double tap only selects one word, if we have multiple words we can assume it comes from "Select All" and not do Smart Select. BUG=714106 Review-Url: https://codereview.chromium.org/2838023002 Cr-Commit-Position: refs/heads/master@{#466856}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/302cd78d00c2..ef002c855212 $ git log 302cd78d0..ef002c855 --date=short --no-merges --format='%ad %ae %s' 2017-04-24 thestig Use fx_extension.h utilities in more places. 2017-04-24 thestig Add tests for BC_OnedCode128Writer encoding functions. 2017-04-24 tsepez Add FXSYS_wcsftime() to avoid termination on win. 2017-04-24 tsepez Use a pdfium-specific unittest main rather than gtest's 2017-04-21 tsepez Use unique_ptr in CFX_SizeGlyphCache 2017-04-24 dsinclair Nit cleanup in XFA widget code Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I363555382eeca929b42d7438a22e950abb3400d1 Reviewed-on: https://chromium-review.googlesource.com/486150 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#466855}
-
watk authored
Previously, after falling back to another decoder, we had to keep the old one alive in case it owned frames that were currently being displayed. Now all decoders produce frames that outlive themselves, so we can safely delete the decoder as soon as we no longer need it. This change also includes deletion of a related, but now unused, VideoFrame metadata value called DECODER_OWNS_FRAME. BUG=663988 Review-Url: https://codereview.chromium.org/2841553003 Cr-Commit-Position: refs/heads/master@{#466854}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72d17915..c76bb271 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2843643002 Cr-Commit-Position: refs/heads/master@{#466853}
-
vovoy authored
flag --tabset-repeat multiply the tab count of benchmark tab_switching to measure metrics on different tab count. ex: add flag --tabset-repeat=2 to double the tab count. BUG=689388 Review-Url: https://codereview.chromium.org/2819423002 Cr-Commit-Position: refs/heads/master@{#466852}
-
ben authored
Eliminate ChildThread InterfaceRegistry. Also cleans up ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface(). R=rockot@chromium.org Review-Url: https://codereview.chromium.org/2820883002 Cr-Commit-Position: refs/heads/master@{#466851}
-
dschuyler authored
This Cl moves UI elements in the content / site settings part of MD settings. Specifically it swaps the subpage arrow and the 'three-dots' action menu. BUG=713918 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2832153004 Cr-Commit-Position: refs/heads/master@{#466850}
-
hcarmona authored
TBR=robhogan@gmail.com BUG=714862 Review-Url: https://codereview.chromium.org/2837913003 Cr-Commit-Position: refs/heads/master@{#466849}
-
mstensho authored
BUG=700919 Review-Url: https://codereview.chromium.org/2840443003 Cr-Commit-Position: refs/heads/master@{#466848}
-
estade authored
View's native theme. This fixes a few bugs where we weren't using the right native theme, whether by not updating after the NativeTheme changes or by trying to access the NativeTheme before the View is added to a hierarchy (which yields the default NativeTheme --- for most platforms, this didn't effectively create a bug as there's only one NativeTheme). Best example is that now the sad tab respects the GTK native theme. Get rid of Ash's tray_constants::kBackgroundColor in favor of using the bubble background color from the NativeTheme. BUG=711183,693282 TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2816193002 Cr-Commit-Position: refs/heads/master@{#466847}
-
avallee authored
Adding temporary logging to the test to figure out why the test is flaky. This commit will likely be reverted once it shows up as flaky. BUG=713977 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2837213002 Cr-Commit-Position: refs/heads/master@{#466846}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/bb05f70b4be2..c1889823de68 $ git log bb05f70b4..c1889823d --date=short --no-merges --format='%ad %ae %s' 2017-04-24 bsalomon Add new GrVkBackendContext::Create explicitly requiring vk proc getters Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ib4c867ae1b8222aece8f92b23d0c63b68496b38a Reviewed-on: https://chromium-review.googlesource.com/486126Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#466845}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f0a16108160d..892a0b6a45cc $ git log f0a161081..892a0b6a4 --date=short --no-merges --format='%ad %ae %s' 2017-04-24 nednguyen Roll WPR to the lastest commit Created with: roll-dep src/third_party/catapult BUG=702194,711634 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie143bf24f0c15a8694009dcad6f5291560c7fe15 Reviewed-on: https://chromium-review.googlesource.com/486164 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#466844}
-
lukasza authored
Previous CL (https://crrev.com/2686943002) started putting WebContents created via ctrl-click into a new process. One case that was still broken is target="_blank" (or target="non-existant-name"). At first glance, it might seem arbitrary to decide which directive (ctrl-click VS target=_blank) wins and influences 1) process allocation behavior and 2) window.opener / browsing instance behavior. In reality, ctrl-click should win because: 1. This is the behavior desired by users (e.g. see https://crbug.com/23815). 2. This is the behavior of other browsers (e.g. see https://crbug.com/658386#c9). Before this CL, FrameLoader::load would ignore ctrl-click / NavigationPolicyNewForegroundTab and go through createWindowForRequest path if the named target frame didn't exist when the navigation is initiated. After this CL, ctrl-click "wins". This CL has to tweak 2 layout tests affected by the change. In both cases, the test expectation that a background-tab-navigation is handled by createView is no longer correct - now the navigation goes through OpenURL path rather than through CreateWindowForRequest. Accomodating the 2 tests also required adding support for handling WindowOpenDisposition::NEW_BACKGROUND_TAB in content::Shell::OpenURLFromTab. NOPRESUBMIT usage has been discussed in https://crrev.com/2680353005/#msg50 BUG=23815, 658386 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2680353005 Cr-Commit-Position: refs/heads/master@{#466843}
-
krasin authored
Revert of Enable ThinLTO and LLD for POSIX LTO by default on Linux. (patchset #4 id:60001 of https://codereview.chromium.org/2831213006/ ) Reason for revert: Code size increase: https://chromeperf.appspot.com/report?sid=7826328365affe1842778994c934cbe08c7f9b78ef5d8895ec85d3094bb8972d&start_rev=466555&end_rev=466782 Postmortem is coming. TL;DR: worse dead code elimination in ThinLTO Original issue's description: > Enable ThinLTO and LLD for POSIX LTO by default on Linux. > > Eventually, we will enable LLD on Linux even for regular > builds, but it's natural to make incremental steps here. > > ThinLTO brings multi-threaded linking for LinkTimeOptimization > builds, which allows to speed up codegen considerably (up to 4x). > ThinLTO also manages a cache inside out/<gn-config>/thinlto-cache > directory, that improves incremental linking as well. > > There's a cache pruning policy that will prevent the cache from > growing indefinitely. The policy is not yet finalized, and > complaints / suggestions are welcome. > > BUG=660216,607968 > > Review-Url: https://codereview.chromium.org/2831213006 > Cr-Commit-Position: refs/heads/master@{#466732} > Committed: https://chromium.googlesource.com/chromium/src/+/7997bbe88aef7eeca37111dcb8426f0430347fb5 TBR=dpranke@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660216,607968 Review-Url: https://codereview.chromium.org/2842683002 Cr-Commit-Position: refs/heads/master@{#466842}
-
sammiequon authored
Removed the setup pin link and put a button inside the radio button instead to fire up the setup pin dialog. https://screenshot.googleplex.com/Yvp9brRd2wS Upstream paper-radio-button PR: https://github.com/PolymerElements/paper-radio-button/pull/119 TEST=manual BUG=703998 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2823713002 Cr-Commit-Position: refs/heads/master@{#466841}
-
martiniss authored
Looks like this was added pre-swarming. It's unused, and undocumented, so just remove it. Review-Url: https://codereview.chromium.org/2842623002 Cr-Commit-Position: refs/heads/master@{#466840}
-
dfalcantara authored
* Adds a check to prevent showing branding if First Run hasn't completed. * Updates the widget so that it is updated when an AsyncInitializationActivity subclass calls onDeferredStartup(). * Changes the resource for the microphone to match the omnibox's, as well as uses its content description. * Adds tests to confirm that the search engine is updated once First Run completes. BUG=708844,710952 Review-Url: https://codereview.chromium.org/2834253002 Cr-Commit-Position: refs/heads/master@{#466839}
-
hansberry authored
Also, once a Wi-Fi network is removed (e.g. due to explicit config removal), remove its associated Tether network. BUG=672263 Review-Url: https://codereview.chromium.org/2821103003 Cr-Commit-Position: refs/heads/master@{#466838}
-
tguilbert authored
There are 4 types of renderers that are used by WMPI directly, with a potential fifth type in the works. Currently, a single RendererFactory is chosen at WMPI creation time, and bound for the lifetime of WMPI. However, there is a growing need to allow the smooth transition between the use of different renderer types, after WMPI’s creation. This CL introduces the RendererFactorySelector, which will allow us to choose between different RendererFactory types at runtime. Its purpose is to aggregate the signals and centralize the logic necessary to choose which RendererFactory should be used when creating a new Renderer. The interface is still extremelly simple, but it is expected to grow as the number of concurrent RendererFactory types grows. In other words, if there are 3+ renderer factories at play, some complexity is inevitable, and the right place for that complexity to live is in the RendererFactorySelector. NOTE: The RendererFactorySelector uses a FactoryType enum as a key, in order to avoid having to take dependencies on different (sometimes platform specific) RendererFactories. BUG=663503 Review-Url: https://codereview.chromium.org/2711153006 Cr-Commit-Position: refs/heads/master@{#466837}
-
erikchen authored
Despite the fact that the kernel implements physical footprint calculations on macOS 10.11, the syscall task_info(TASK_VM_INFO, ...) always returns 0. For more details [10.11.5], see xnu-3248.50.21/osfmk/kern/task.c:3418. BUG=713854 Review-Url: https://codereview.chromium.org/2838703003 Cr-Commit-Position: refs/heads/master@{#466836}
-
kbr authored
This will re-enable display of warnings that a test was expected to fail, but passed. BUG=710065 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2832383002 Cr-Commit-Position: refs/heads/master@{#466835}
-
wkorman authored
BUG=714825 TBR=pdr@chromium.org Review-Url: https://codereview.chromium.org/2838623003 Cr-Commit-Position: refs/heads/master@{#466834}
-
leon.han authored
This CL removes BatteryMonitorImpl content browser test, its renderer side test is covered by existing battery layout tests, and its browser side test is covered by the service test newly created in this CL. Thus we can eliminate the direct dependency on battery from content layer, then we can hide all battery monitor impl inside Device Service with a follow-up CL. BUG=684422 TEST=service_unittest TBR=timvolodine@chromium.org Review-Url: https://codereview.chromium.org/2819163002 Cr-Commit-Position: refs/heads/master@{#466833}
-
nrpeter authored
Origional CL (2499493004) was rolled back by sheriff due to failing MSAN tests. This initial patchset is a direct patch of 2499493004. Second patchset contains the fix. -Communicate which hosts are runtime blocked to all renderers -Blocks host permissions for specific hosts by specific extensions -Tests via blocking content script injection -Introduces new test class for use with ExtensionSettings policy BUG=624649 Review-Url: https://codereview.chromium.org/2833843004 Cr-Commit-Position: refs/heads/master@{#466832}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=vandebo@chromium.org Review-Url: https://codereview.chromium.org/2675773004 Cr-Commit-Position: refs/heads/master@{#466831}
-
- 24 Apr, 2017 7 commits
-
-
rnk authored
Accessing a unique_ptr in the same call expression that moves it is generally not safe, since different compilers evaluate have different orders of evaluation. BUG=714609 TBR=raymes@chromium.org,thakis@chromium.org Review-Url: https://codereview.chromium.org/2842493003 Cr-Commit-Position: refs/heads/master@{#466830}
-
stevenjb authored
BUG=710265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2826303002 Cr-Commit-Position: refs/heads/master@{#466829}
-
dpranke authored
As part of #466704, I changed some logic in mb.py to sort the inputs that MB hands to GN, in an attempt to make the debugging output a little easier to follow. It turns out that the way I did this was broken, as there was a dependency on the ordering of the unsorted values. As a result, MB started remapping GN's analyze results back to the wrong targets, and we've been running the wrong test steps since #466704 landed :(. TBR=kbr@chromium.org, jam@chromium.org BUG=714336 NOTRY=true Review-Url: https://codereview.chromium.org/2843663002 Cr-Commit-Position: refs/heads/master@{#466828}
-
aluo authored
BUG=711424 Review-Url: https://codereview.chromium.org/2819563003 Cr-Commit-Position: refs/heads/master@{#466827}
-
dgozman authored
This turns InspectorOverlay into InspectorOverlayAgent with respective lifetime and domain: - rendering domain merges into overlay; - Page.configureOverlay moves to overlay; - highlighting and inspect mode move from DOM to overlay. BUG=none TBR=skyostil@chromium.org Review-Url: https://codereview.chromium.org/2819183002 Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#465422} Committed: https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae58cff1c787bec Review-Url: https://codereview.chromium.org/2819183002 Cr-Original-Original-Commit-Position: refs/heads/master@{#465812} Committed: https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a689648621fa29f14 Review-Url: https://codereview.chromium.org/2819183002 Cr-Original-Commit-Position: refs/heads/master@{#466489} Committed: https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4122f4d50246a Review-Url: https://codereview.chromium.org/2819183002 Cr-Commit-Position: refs/heads/master@{#466826}
-
dschuyler authored
This CL removes CSS for .tertiary-button which is no longer used. (Code health) BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2837883005 Cr-Commit-Position: refs/heads/master@{#466825}
-
zijiehe authored
This is a trivial change to move IMMNotificationClient implementation out of AudioCapturerWin. Now the new DefaultAudioDeviceChangeDetector can unregister itself from IMMDeviceEnumerator in destructor. BUG=669070 Review-Url: https://codereview.chromium.org/2809293006 Cr-Commit-Position: refs/heads/master@{#466824}
-