GitLab

* Implement handling of the
  chromium.cast.UrlRequestRewriteRulesProvider API in CastRunner.
* Remove handling of the fuchsia.web.AdditionalHeadersProvider API in
  CastRunner as it is deprecated.
* Adapt the integration test to use the new API.

Bug: 976975
Change-Id: If1e97c474f79a4b6f3f0c03428b85557e3e73460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770434
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695766}

The reset occurred under the previous assumption that the toolbar
heights only change for navigation to/from the NTP, where the primary
toolbar height is 0.0.  This assumption is incorrect because the heights
can also be updated due to trait collection changes.  The navigation
case for NTP is already handled by FullscreenWebStateObserver::
DidFinishNavigation(), so removing the calls to ResetForNavigation()
does not break that case.

Bug: 896675
Change-Id: I2fd1b101f3057e6f3f3bb61802fc1683a1ab0862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1328234
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695765}

This change fixes an infinite loop in `OneShotAccessibilityTreeSearch`.
If the search starts at the root of a tree, goes backwards, and wraps
around to the last node, it will loop forever in `SearchByWalkingTree`.

The problem is that `stop_node` is set to NULL, so it is never matched.

The fix is to ensure that stop_node gets set to the root element (i.e.,
the start_node) so that we don't loop through the tree more than once.

Bug: 1001200
Change-Id: I67d8abd5e6044b2a125a633d39c7581e45cc7411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790255Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695764}

The shortcut handler is already executed when application becomes
active.
Executing it in performActionForShortcutItem will result in two
execution which can cause issues (e.g. if action is to trigger camera).

Bug: 1000940
Change-Id: Id89a1c1c88fc9594599772cb0170c7c6e08deded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789523Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695763}

This reordering allows us to issue SwapBuffers a little bit sooner
by moving DDL destructor after.

Bug: 974359
Change-Id: Iba9a81815cf1166d3d31bd9312adc8e0834bf512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797175Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695762}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/dom_distiller.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=bengr@chromium.org

Bug: 891670
Change-Id: Id769068426f8af6e23a32f62202883e3a2a8789e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787106
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695761}

We currently have no way of tracking usage of this tool. Tagging the
builds created by it should allow us to do some basic estimation of
usage numbers.

Change-Id: Ie73a2a8019a5eb79a9b7f4e0f004b81f05251f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797699Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695760}

This CL adds implementation to CreateSharedImage overload with
|pixel_data| to SharedImageBackingFactoryAHB.

Bug: 1002057
Change-Id: I246284c6df5f75c25bbedd69658d4fdfaac0f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792579
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695759}

This reverts commit 250c173e.

Reason for revert: <reverting did not fix crbug.com/999467>

Original change's description:
> Revert "Migrate pinned icons in ImplicitApp subdirs."
> 
> This reverts commit 4105186f.
> 
> Reason for revert: <crbug.com/999467>
> 
> Original change's description:
> > Migrate pinned icons in ImplicitApp subdirs.
> >
> > Chrome migrates pinned icons in UserPinned/Taskbar dir, but not the
> > subdirectories of UserPinned/ImplicitAppShortcuts. It's unclear to me why
> > Windows puts some pinned icons in the ImplicitAppShortcuts subdirectories,
> > but we should handle them.
> >
> > Bug: 980239
> > Change-Id: Ia41c3853b2a4bb78781a39733f388915f58c02eb
> > TBR:
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710722
> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> > Reviewed-by: Greg Thompson <grt@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#681035}
> 
> TBR=msarda@chromium.org,grt@chromium.org,davidbienvenu@chromium.org
> 
> Bug: 980239
> Change-Id: I2b19e825ccd0f1bd2975678d9acb1ad7ff90cc6a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787560
> Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693898}

TBR=davidbienvenu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 980239
Change-Id: Ibe0af2947a119bdccea80067fe86f0d1d5bb7af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797692Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695758}

https://swiftshader.googlesource.com/SwiftShader.git/+log/5f1b4c0ba92e..5a5ffe52a944

git log 5f1b4c0ba92e..5a5ffe52a944 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 capn@google.com Update link to dEQP repository
2019-09-11 capn@google.com Fix OpenGL/EGL entry function calling convention

Created with:
  gclient setdep -r src/third_party/swiftshader@5a5ffe52a944

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/137875321,chromium:b/140700303
Change-Id: Idfa6f95ef7341f1b02c7ee017af3f904bf385df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695757}

Bug: 988538
Change-Id: I8f85d926afe39c75a8a34449a1fa8f57f52ff245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732895Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695756}

Writes of large blocks of memory can cause kernel address-space pressure
which can be fatal on 32-bit Windows. Yes, we still have some customers
using 32-bit Windows.

This change updates PEResource::WriteToDisk to write a maximum of 8 MiB
at a time. This should not affect performance and will avoid failures.

This change also updates the mini_installer copy of this file to use
nullptr for consistency.

Bug: 1001022
Change-Id: Icca3122a7decc7ce6ce89cc742c988d68737ff28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793531
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695755}

This CL wraps a inner class in NotificationSceduler class to track all
notification display flow, and invoke the TaskFinishCallback when
all display flows are finished.

Also, fixed an issue that InitHelper should be owned by
NotificationScheduler or we may use invalid pointer when the service
is destroyed.

Bug: 998980
Change-Id: I5d3dfa488eaeaf8b99649987c4982ddb279a4504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791274Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695754}

e3bf3a5fde91 Roll crashpad/third_party/mini_chromium/mini_chromium/
             588976752..660b43a77 (2 commits)
9a6234461201 [Log minidump] OutputStream interface and zlib
             implementation
9b314d5fa819 cros: Pass a dir for minidumps to crash_reporter
fc44a3747cf5 linux: Allow configuring unhandled signals
abeccef1efdb [fuchsia] fix
             crashpad_use_boringssl_for_http_transport_socket path
06fdbdecdc5d android, chromeos: fix build breakages

Change-Id: I16d519153599cbf960a0171957cdf58be1c37713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797705
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695753}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/spellcheck.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=groby@chromium.org

Bug: 891670
Change-Id: I49d8195a5ecb42ceacf78c3721550747cd501486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786946
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Rachel Blum <groby@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695752}

This adds support for reporting 3 new page load metrics
(largest contentful paint, first input delay, and
cumulative layout shift) to embedders on Android.

Change-Id: I3e49c4ca8cddbc6471d215cb8fc17a6a2ebcc5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785882Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695751}

Change-Id: I325e45c4a6131b09d04ec14836cf7290ad329fc5
Bug: 856777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793982
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695750}

This change adds the interface definition for a Touch To Fill View which
will is intended to be implemented on Android in a follow-up CL.

Bug: 957532
Change-Id: I819e8178db21c32d577560da82c64d79856a59cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798356
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695749}

Refactoring from composition to using CRTP to simple inheritance.

Drive-by: Rework TraceNodes to allow inlining and constant folding
ShouldTracePersistentNode in the case of regular Persistents (in
PersistentRegion).

Change-Id: I1306218f71ea0fea11783b6b8832be84cc3c8480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789588Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695748}

This was causing an msan failure (use of uninitialized var).

Bug: 1003006
Change-Id: Iad05067b34e8289ce0809d6bc2ce935b58f0397b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797060
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695747}

Mark conformance/rendering/blending.html as Failure

BUG=1002997
TEST=bot
TBR=kbr@chromium.org

Change-Id: I54598a0d4f8991d42420fd81e9e05d9433b7dcf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798871Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695746}

This is a reland of 62e19745 with the component
build fixed.

Original change's description:
> [fuchsia] Implement fuchsia.web.Frame/SetUrlRequestRewriteRules.
>
> * Implement the fuchsia.web.Frame/SetUrlRequestRewriteRules API.
> * Add a mojo interface to provide the renderers with new rules.
>   * This interface is implemented in the browser in
>     UrlRequestRewriteRulesManager, which also takes care of validating
>     and converting the rules from FIDL to Mojo, and providing them to
>     the WebEngineURLLoaderThrottles in the browser.
>   * In the renderer, there is one rules receiver per RenderFrame,
>     implemented in UrlRequestRulesReceiver. They cache the rules and
>     provide them to the WebEngineURLLoaderThrottles in the renderer.
> * Add unit tests and browser tests for the new API.
>
> Bug: 976975
> Change-Id: I446ea4838d50e65c568e7e2cbcd32c23d64af426
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659677
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#695298}

Bug: 976975, 1002719
Change-Id: I8ea6fda911b6efb89eff8f33182525ed99a20cc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797338
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695745}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chromecast.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=servolk@chromium.org

Bug: 891670
Change-Id: Iaa04676f2f42a2be1353c0ac67cfeba6086143b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786985
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695744}

This change converts LockManager mojom interface client in blink to use
BrowserInterfaceBroker. RenderProcessHost now has a CreateLockManager() method,
which is called by handlers for frames and workers.

Bug: 936482

Change-Id: I1f3b38549d352593eea27a9a3f12d14fe7681f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785621
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695743}

This would occur due to the pin button appearing after the item was
hovered. This change makes this no longer an issue since the pin button
will always be visible.

Bug: 1001617
Change-Id: If0c5886b2cd7cd33379bbe70ae58cb2c408acb9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798669Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695742}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chrome/utility/image_writer.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=haven@chromium.org

Bug: 891670
Change-Id: Id42c705ac4a5dba6785b770aa62c377b029e1faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786968
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695741}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Icd0a3462102e7bbd3c5335175f1c67e117fc6b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797491Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695740}

When merging report context, make sure to handle the the new context as
a dictionary and make sure to merge sub keys.

Bug: 1002764
Change-Id: I5216de7ce5cbf45f08ce75bfe2b1a9290c59628c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797547Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695739}

Using wpt-import in Chromium 7d12c3fa.
With Chromium commits locally applied on WPT:
cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`"
30dde1e3 "[LayoutNG] Fix `vertical-align: top/bottom` with leading"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
meade@chromium.org:
  external/wpt/web-animations
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I10878fecaf57a6de2d7775f6e2ed73454727b041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798277Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695738}

Bookmark and history suggestions can be inline autocompleted and be the default
match only when the user inputs a prefix of the URL. Document providers can't be
autocompleted at all.

E.g., if you’ve visited https://en.wikipedia.org/wiki/Space_Shuttle_Discovery,
typing ‘space shuttle di’ won’t autocomplete the suggestion, though typing
‘en.wikipedia.org/wiki/space_Shuttle_Di’ will.

This has multiple negatives:

1) It’s tedious and inaccurate to type URLs containing symbols and domains that
the user isn’t concerned about. E.g. Typing “Bon Jovi” is more natural and
shorter than “en.wikipedia.org/wiki/Bon%20Jovi”, which contains details such as
‘en.’, ‘%20’, and ‘wiki/’ that most users do not memorize.

2) Navigating the dropdown causes a delay, not only because it requires either
more keystrokes or mouse input, but also because it requires scrolling past a
variable length of search suggestions; i.e. it’s difficult to commit to muscle
memory: type “jon bovi”, press down 3 times, press enter.

3) Users who expect their input is sufficient to reliably determine their
intended navigation may prematurely press “enter” before realizing the default
suggestion is incorrect.

With this CL, when the input is a prefix of a bookmark, history, or doc title,
then the omnibox autocompletes the `title - URL` and allows defaulting the
suggestion.

Bug: 549677
Change-Id: Ie17ce879f27e1128be2c0fc09a840da6dcde5637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711634
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695737}

ProfileManagerObserver::OnProfileAdded() can serve as the signal that
the Profile is fully created.

This patch also adjusts OwnerSettingsServiceChromeOSFactory to make
it more obvious that off the record profiles (both guest and incognito)
don't get a service instance.

TBR=bartfab@chromium.org,rdevlin.cronin@chromium.org

Bug: 268984
Change-Id: I2048d85828863cc9611b724c5b7c5c0b114089ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794273Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695736}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cc6f585f055a..2ae039a065a6

git log cc6f585f055a..2ae039a065a6 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 apolito@google.com Add support for multi argument ands and ors, and the same precedence with

Created with:
  gclient setdep -r src/third_party/depot_tools@2ae039a065a6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:905740
Change-Id: I5aede2a51b480fd875402798a6e65d60ec54047d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797055Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695735}

As the splitting process for RenderWidget/RenderView continues, it is
becoming necessary for RenderWidget to access "page global" state.
RenderView has historically held this data. Adding a new PageProperties
interface for "page" level concepts will provide the needed access
without opening the door to full API coupling that historically
occurred when RenderWidgets had full access to the RenderViewImpl
interface.

Bug: 998273
Change-Id: I2d532e0e88256b04b8c9e3f49607e0e59bc93113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792795
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695734}

Adjust the test expectation of ForceNetworkInProcessTest when run from network_service_in_process_browser_tests.

Bug: 1002752
Change-Id: Ibeb63eb2044f8a565b29b7821add891d5a4fc339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797337
Auto-Submit: Eric Roman <eroman@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695733}

Bug: 618334
Change-Id: Ib6350c3238689eff8af6dc0bb707f61397a32b0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783116
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695732}

https://chromium.googlesource.com/angle/angle.git/+log/d9456b258e20..8ac49e182aa0

git log d9456b258e20..8ac49e182aa0 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 timvp@google.com Fix dEQP renderbuffer unspecified attachment test.

Created with:
  gclient setdep -r src/third_party/angle@8ac49e182aa0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC syoussefi@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Bug: None
Change-Id: I4303d0ef18dee761343b876173dba92a22068135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797178Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695731}

This CL forwards FrameTimingDetails to the CompositorFrameReporter
within the Viz client. The timestamps contained in FrameTimingDetails
will be used by CompositorFrameReporter in a future CL to measure and
report on rendering pipeline stages within the GPU process.

Bug: 963787, 971712
Change-Id: I062bf74885a42bca07d542f170615ed6654751d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789471Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695730}

This CL adds destructors to the MediaNotificationController and
MediaNotificationContainer interfaces.

Bug: 1002746
Change-Id: Ic5d2f7725168bc504827565ac2fbfc9eb8351ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798499
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695729}

BUG=1002988
TEST=bot
R=kbr@chromium.org

Change-Id: I3f940a19a067fe9a5aac9c7ca8aababb55b5c13f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798842Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695728}

https://chromium.googlesource.com/catapult.git/+log/c5f9c0682125..fc09aa89b962

git log c5f9c0682125..fc09aa89b962 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 perezju@chromium.org [Telemetry] Uncaught exceptions should interrupt benchmark

Created with:
  gclient setdep -r src/third_party/catapult@fc09aa89b962

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: chromium:973837
Change-Id: Ia6011a0ecb3d5abba06234fffce15b7ed9d8d9ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797176Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695727}