- 20 Aug, 2018 40 commits
-
-
Christian Biesinger authored
This code previously skipped NG layout objects for performance reasons (https://codereview.chromium.org/2666663002 and https://chromium-review.googlesource.com/1073408). However, we do need to prelayout orthogonal roots if their containing block is legacy so that we can correctly compute the intrinsic widths of such containing blocks. This should not cause double layouts because nothing will mark the NG object as needing layout in this case. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I63f8384170fe815780c79510b96e436014c39797 Reviewed-on: https://chromium-review.googlesource.com/1180714Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584496}
-
Maks Orlovich authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I16776c61094689602525122d2c70a08481093443 Reviewed-on: https://chromium-review.googlesource.com/1148470 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584495}
-
Lukasz Anforowicz authored
r584254 removed differences between waterfall/cq and official bots (by removing testing/variations/fieldtrial_testing_config.json entries related to site-per-process and making site-per-process the default even in absence of field trials). This makes it possible to remove the |#if defined(OFFICIAL_BUILD)|-related expectations from WebDriverSitePerProcessPolicyBrowserTest. r581059 removed the not_site_per_process_browser_tests step from the bots. This makes it possible to remove the kDisableSiteIsolationTrials-related expectations from WebDriverSitePerProcessPolicyBrowserTest Bug: 874998 Tbr: pastarmovj@chromium.org Change-Id: I87988884dfe945f16e10680637b26fb4efcf3f2c Reviewed-on: https://chromium-review.googlesource.com/1181526 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584494}
-
Tommy C. Li authored
Bug: 842236 Change-Id: Iba7afb45322ea3e446203274b2fe87bd6c80e9f9 Reviewed-on: https://chromium-review.googlesource.com/1178621Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#584493}
-
Jennifer Apacible authored
TBR=xiyuan@chromium.org NOTRY=true (disabling tests) Bug: 875920 Change-Id: I59417725ab57ef2306671470ac78ae25d9a74ebc Reviewed-on: https://chromium-review.googlesource.com/1181650Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584492}
-
Ryan Daum authored
Cleans up some more remnants from our fork of TtsController/Platform from Chrome. - Remove VoicesChangedDelegate support, as we don't use this or need it. - Remove 'copied from chrome' comment as we are pretty thoroughly forked now. - Remove more code related to the tts_extension pieces we don't support - Remove a chromeos only test that was never compiled anyways. Bug: none Test: unit test and manual Change-Id: I410603b58dac41772442af31597be7dda78be898 Reviewed-on: https://chromium-review.googlesource.com/1181174Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#584491}
-
David Black authored
We expect the lifecycle of a query to be: - Pend: occurs on interaction start - Commit: occurs on query finalize - Activate: occurs on query response received When LibAssistant error'd out, due to connectivity loss for example, the order of events delivered caused us to miss stages in the query lifecycle. Now, we will maintain the expected lifecycle and show an error message to the user when this occcurs. Bug: b:112600782, b:112056476 Change-Id: Ib01860564d88326110db285e09d15470bed58598 Reviewed-on: https://chromium-review.googlesource.com/1176976 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584490}
-
Farah Charab authored
Follow up patch for comment on line 215 in sequence_manager_processor.h for https://chromium-review.googlesource.com/c/chromium/src/+/1165145/4. We move some interfaces from SequenceManagerFuzzerProcessor to ThreadData to hide member variables of ThreadData. Change-Id: I4793fe7d7514a4730d1bfc08deba8b92b68667a1 Reviewed-on: https://chromium-review.googlesource.com/1176087 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584489}
-
Ted Choc authored
This CL: https://chromium-review.googlesource.com/1162674 Introduced adding a space when refining queries, and that breaks the same as typed check. The fix is to just trim the typed text before the comparison. BUG=875756 Change-Id: Ie7d55d6a0322d7be4fb6d62cd146eeaa79d34a03 Reviewed-on: https://chromium-review.googlesource.com/1181501Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#584488}
-
Sam Maier authored
We would like to get rid of all usages of execute() since it is unclear whether it goes to SERIAL_EXECUTOR or THREAD_POOL_EXECUTOR (many assume THREAD_POOL_EXECUTOR, but it actually goes to SERIAL_EXECUTOR). This is just cleaning up this test usage. Bug: 869907 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Id783526b0daead7f413f55bb443e9d9792142667 Reviewed-on: https://chromium-review.googlesource.com/1181540 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584487}
-
Xing Liu authored
This CL completes the plumbing of OfflineContentProvider::GetShareInfoForItem and implements share flow for offline page. The core logic now lives in OfflinePageShareHelper, which is basically a combination of the offline page sharing logic in DownloadUtils.prepareForSharing and DownloadUtils.createShareIntent. Bug: 850780 Change-Id: I3865e4f3ed893c0f6be0a18e9f1883d4dfc710ea Reviewed-on: https://chromium-review.googlesource.com/1174923Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584486}
-
Balazs Engedy authored
The CL implements the following changes: -- The illustration now fills the top half of dialogs entirely, so there is no space on the left, right, and top edge. -- The description text is now using views::style::STYLE_SECONDARY. -- The back arrow button has the same distance to the left and top dialog border. -- The padding between dialog title and description has been reduced to 8 pt instead of 16 pt. -- Item separators in the transport selection list now use GGray300. Bug: 849323 Change-Id: I17c0b45e5155610993dd159229f56e5b3081efd1 Reviewed-on: https://chromium-review.googlesource.com/1181047Reviewed-by:Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584485}
-
Weidong Guo authored
Changes: Offset y position by 100px and change the opacity between 1.0f and 0.0f for everything in app list except background shield when switching from/to overview mode. Demo: https://drive.google.com/open?id=1x1_qHnhGxnVZf1I6lAdMykrsTZ7SXCEA Bug: 875373 Change-Id: I13e495cd97b23ab13d1908245a3c74ddadf95c62 Reviewed-on: https://chromium-review.googlesource.com/1180169 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584484}
-
Eric Boren authored
Bug: skia:8233,skia:8234 Change-Id: I10a6994ea1543b91191b11dc5581bc379fe8af76 Reviewed-on: https://chromium-review.googlesource.com/1181242Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org> Cr-Commit-Position: refs/heads/master@{#584483}
-
Anna Offenwanger authored
Untraced should be avoided where possible. Bug: 874627 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e9c4ed7e800362f3a4b9a7ecd5aaf148ddd8a9a Reviewed-on: https://chromium-review.googlesource.com/1180166Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584482}
-
Aldo Culquicondor authored
Bug: 875291 Change-Id: Ib09533c0d81d6646084d8d4fc52978c7f5ae946a Reviewed-on: https://chromium-review.googlesource.com/1181170Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#584481}
-
Peter Beverloo authored
This still lived in PlatformNotificationServiceImpl but has no reason to be there. We can move it to the PersistentNotificationHandler, which is far more appropriately scoped for this functionality. Change-Id: I7b7d9001fa80c196aee2953556f0609849e39d8b Reviewed-on: https://chromium-review.googlesource.com/1127998 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#584480}
-
Kushagra Sinha authored
Bug: 816954 Change-Id: I6cc712e2322f64c9efeca285244d6964a22dd8d4 Reviewed-on: https://chromium-review.googlesource.com/1180210Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#584479}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: Iadfd17c687682a52786753c0a8e7c8c5229a40ec Reviewed-on: https://chromium-review.googlesource.com/1177712Reviewed-by:
-
Philip Rogers authored
TBR=chrishtr@chromium.org Bug: 875884 Change-Id: I09e605403a5b068d9b2db0510289538a4f22b731 Reviewed-on: https://chromium-review.googlesource.com/1181507 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584477}
-
Yuzu Saijo authored
This CL expands the page_set of memory.leak_detection to 200 and introduces sharding. Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I6d562fcc80df8089887236363c7d5b0fdf2b879e Reviewed-on: https://chromium-review.googlesource.com/1180788Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#584476}
-
Rayan Kanso authored
The WebApkServiceClient was overwriting the small icon in the notification builder. This change checks whether there was already a provided small icon bitmap before overwriting. This is the CL that introduced the bug: https://chromium-review.googlesource.com/c/chromium/src/+/978126 It will always call setSmallIconForRemoteApp on the notification builder for PWAs. For Android M+ this will overwrite the provided small icon bitmap. Bug: 867351 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If65970f3349e6a0738003d89e2721e3b2568afdc Reviewed-on: https://chromium-review.googlesource.com/1181043Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#584475}
-
Ryan Sleevi authored
This moves the handling for CRLSets out of the CertVerifier::Verify() set of parameters and makes it an explicit part of the CertVerifier::Config. Notification for CRLSet changes are now plumbed through the NetworkService to all of its NetworkContexts, rather than being a singleton on the SSLConfigService. In the process, this disables CRLSets for the chrome.platformKeys.verifyTLSServerCertificate API, but that is consistent with that API not observing other user or system configuration settings, and is part of the documented "subject to change at any time". TBR: jamiewalch@chromium.org Bug: 861849, 854635 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I818be91106274c736e074fc81947c5cb51c57564 Reviewed-on: https://chromium-review.googlesource.com/1132706 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584474}
-
Peter E Conn authored
Moving Trusted Web Activities over to CustomTabActivity gets us PostMessage for free. Unfortunately we're not ready to launch that, so disable it for the time being. Bug: 871266 Change-Id: Iaef2c08aea87be888cd98b102aeb4a87e888fd04 Reviewed-on: https://chromium-review.googlesource.com/1181139Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#584473}
-
Chris Mumford authored
Previously SimpleURLLoader would always upload the entire file. This allows the caller to specify a portion of the file to be uploaded. Bug: 844979 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8c2d6267fb65a5012f49c9f3ce943c44dc4837db Reviewed-on: https://chromium-review.googlesource.com/1180072 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
UnifiedConsent.ConsentBump.Action is added for iOS. It has already been added into Chromium with: crrev.com/c/1143185 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieda1e49c547182c6f044effdcf66e294f946c875 Reviewed-on: https://chromium-review.googlesource.com/1174832Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Charlene Yan authored
The calculations for bookmark bar icons should only impact the start y location of the icons and not the height. Regression mentioned in comment #5 in the bug is due to removing kBookmarkBarBottomMargin in the previous CL for the bug. The underlying reason for this is that GetPreferredHeight() was being used for both the bookmark height as well as the button heights. Bug: 865555 Change-Id: Ief5328a2a3a8c23ebfbaa9a393f1c3af4c7a6920 Reviewed-on: https://chromium-review.googlesource.com/1170226 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#584470}
-
Scott Haseley authored
TabLoadTracker unit tests were enabled only on non-Android platforms, but TabLoadTracker is included on Android builds. Bug: 861800 Change-Id: I571298a10dbc5113aaabde47a8288ad675c87e8b Reviewed-on: https://chromium-review.googlesource.com/1129461Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#584469}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/31458a557486..e8964a2cd375 git log 31458a557486..e8964a2cd375 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 wangge@google.com Explicitly read/write command line file as_root. Created with: gclient setdep -r src/third_party/catapult@e8964a2cd375 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:871748 TBR=sullivan@chromium.org Change-Id: I9c8a898f3350a755e26c31b50d24551477ddbdb0 Reviewed-on: https://chromium-review.googlesource.com/1181184Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584468}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12e3df13cfa5..7c42e01cedb9 git log 12e3df13cfa5..7c42e01cedb9 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 borenet@google.com [infra] Speculative fix for vpython cache 2018-08-20 fmalita@chromium.org [skottie] Pre-flight animation in-point, out-point 2018-08-20 borenet@google.com [docs] Remove outdated section about automatic tree closures Created with: gclient setdep -r src/third_party/skia@7c42e01cedb9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Id17ad05e3c0b8cadc8ee97a27729c4efa4e0208c Reviewed-on: https://chromium-review.googlesource.com/1181183Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584467}
-
Mostyn Bramley-Moore authored
These two files both define a TestCase struct in the anonymous namespace: payment_details_validation_unittest.cc payments_validators_unittest.cc These can conflict in jumbo builds. Let's isolate one of them by using a file-specific namespace instead of the anonymous namespace. Change-Id: Ic8e3fa255dde091311c02f73273a244782c4d2c3 Reviewed-on: https://chromium-review.googlesource.com/1180212Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584466}
-
Dominick Ng authored
It becomes more complicated, but web_app_provider.cc becomes simpler. Change-Id: I976ac72d40c1e153ba8cbb15f42931885a453ee1 Reviewed-on: https://chromium-review.googlesource.com/1170145 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Misha Efimov authored
Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ied0c3de493c817e0836fcf42e09736509acbd2d1 Reviewed-on: https://chromium-review.googlesource.com/1086127 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
-
Annie Sullivan authored
Bug: 738854 Change-Id: If29018f3125540bd3abe15f46b5a13994215066b TBR: tdresser@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174633 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584463}
-
Gauthier Ambard authored
This CL changes the VoiceSearch LayoutGuide to position it using frames instead of autolayout as the autolayout positioning is introducing a bug on 3x devices. Bug: 874017 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I451e3c787065347a1b0ece28fb4f68de7c31b8e4 Reviewed-on: https://chromium-review.googlesource.com/1181049Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#584462}
-
Devlin Cronin authored
Relanding since the CL wasn't the cause of test flakiness. Original change's description: > [Extensions] Introduce common client initialization > > In order to extract apps-specific code from extensions, we'll need to > be able to add extra information to the extensions client from outside > extensions code. This will require having a centralized initialization > for the extensions client. > > Introduce a single method, EnsureExtensionsClientInitialized(), which > constructs and sets the ChromeExtensionsClient. Remove the old way of > constructing the client, ChromeExtensionsClient::GetInstance(). Update > all callers to construct the client via the new method. > > While we're at it, update the client to use base::NoDestructor instead > of LazyInstance. > > Bug: 873937 > Change-Id: I47147cd5f33ea44079c0a319626c57f3c5813af8 > Reviewed-on: https://chromium-review.googlesource.com/1175459 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583217} TBR=thestig@chromium.org,rdevlin.cronin@chromium.org Bug: 873937 Change-Id: Idf8fdc2ca89e3f0e481fbfd310c5ebc6067311f1 Reviewed-on: https://chromium-review.googlesource.com/1181162Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584461}
-
stkhapugin@chromium.org authored
Ignores the scroll events caused by the updated suggestions. Bug: 813025 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I10bee25484c964ded91afe47e7f51f8146e16f7b Reviewed-on: https://chromium-review.googlesource.com/1181131Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 816318, 874515 Change-Id: I8d165ec355036f8c190bb21e1c50ee8f9b6a4d5a Reviewed-on: https://chromium-review.googlesource.com/1176389Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This test is already disabled for all other platforms but (as linked in the bug) Windows bots also reported flakes. Therefore, disable it for windows as well. TBR=clamy@chromium.org Bug: 665296 Change-Id: I3991d966d72509324c00c28d82ace55d698eecb4 Reviewed-on: https://chromium-review.googlesource.com/1181262Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584458}
-
Dominic Battre authored
This CL disables manual password generation in the context menu in case the user has disabled the password manager or the site has an SSL problem (in which case Chrome would not fill the credential). Bug: 875751 Change-Id: I900590e6674ba0d039033fb5bacfb83f39bcba52 Reviewed-on: https://chromium-review.googlesource.com/1180966Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#584457}
-
