GitLab

We added some #ifdefs in https://codereview.chromium.org/501153003 to support compiling these components with no libvpx to get the GN build linking.

Now that chrome links in GN with libvpx, we can remove these since this isn't a configuration we want to support.

Review URL: https://codereview.chromium.org/608013004

Cr-Commit-Position: refs/heads/master@{#297083}

When we apply a perspective to a div, we could end up with a
situation where the mapped points end up behind the view.  When
this happened we would DCHECK, but since this a valid scenario
and the rendered results look correct (as far as I can tell),
I'm removing the DCHECK.

Please see http://jsfiddle.net/kkryf2v4/ for an example where
we animate from non-clipped to clipped div.

BUG=416367

Review URL: https://codereview.chromium.org/610603003

Cr-Commit-Position: refs/heads/master@{#297082}

BUG=408650
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/567743005

Cr-Commit-Position: refs/heads/master@{#297081}

Mostly change things to check for existence of surface id as well as a frame provider. Also fix compositor lock handling and OnDelegatedFrameDamage handling.

Review URL: https://codereview.chromium.org/606033003

Cr-Commit-Position: refs/heads/master@{#297080}

This provides an interface for special handling of "whitelisted" URLs
in internal code.

It also denies local file access for Chromecast, except on Android
(with a flag).

R=lcwu@chromium.org,byungchul@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/598303002

Cr-Commit-Position: refs/heads/master@{#297079}

BUG=122753
TEST=navigate to madeupsite.com , error message should display normally

Review URL: https://codereview.chromium.org/599653003

Cr-Commit-Position: refs/heads/master@{#297078}

This will pretty much always result in a bad build but is only a warning
in ninja.

Review URL: https://codereview.chromium.org/455193003

Cr-Commit-Position: refs/heads/master@{#297077}

can take some time to complete, the re-use of a raw pointer stored as
member variable (Socket*) is likely to be the root cause of this crash.

This can happen is a socket is destroyed in between a call to "connect"
(or "send") and the DNS resolution callback is invoked.

Both the SocketConnectFunction and SocketSendFunction used to keep
a raw pointer to the Socket instance. A call to "destroy" at the
"right" time would free the socket instance, leaving both function
to access a released object.

The fix in this CL is to re-aquire the Socket instance using a
socket_id instead of re-using the Socket* instance. If the socket
has been destroyed, the socket_id is invalid, and the function fails
gracefully.

BUG=416741

Review URL: https://codereview.chromium.org/608083002

Cr-Commit-Position: refs/heads/master@{#297076}

BUG=413101

Review URL: https://codereview.chromium.org/601663003

Cr-Commit-Position: refs/heads/master@{#297075}

Revert of Suppress Uninitialized access in ExtensionManagement::Refresh (patchset #2 id:20001 of https://codereview.chromium.org/608063002/)

Reason for revert:
The Clang roll that caused the Valgrind error was reverted in https://chromium.googlesource.com/chromium/src/+/3c80ac9fd48da3d11852eecd6999053d6d84c56c

Original issue's description:
> Suppress Uninitialized access in ExtensionManagement::Refresh
>
> BUG=418234
> TBR=miu@chromium.org
>
> Committed: https://crrev.com/459b9796ff2ba105e8a6bae4c7e63508ea83bb67
> Cr-Commit-Position: refs/heads/master@{#297028}

TBR=miu@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418234

Review URL: https://codereview.chromium.org/610753002

Cr-Commit-Position: refs/heads/master@{#297074}

Revert of Roll Clang 216630:217949 (patchset #5 id:80001 of https://codereview.chromium.org/587433002/)

Reason for revert:
Reverting due to http://crbug.com/418234. Clang was branching on undefined values.

Original issue's description:
> Roll Clang 216630:217949
>
> Also make the script revert local changes before 'svn co'
> rather than afterwards to avoid merge conflicts if a previously
> patched file changes upstream.
>
> BUG=410810
>
> Committed: https://crrev.com/ba4cf8bb6dc77ea033fe13989eb604d6069daa97
> Cr-Commit-Position: refs/heads/master@{#296870}

TBR=thakis@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410810

Review URL: https://codereview.chromium.org/614453002

Cr-Commit-Position: refs/heads/master@{#297073}

This adds support to use nullptr to construct, assign, or return a
scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
of a move-only constructor.

The changes are:

- Add a constructor that takes decltype(nullptr) as a parameter. This
allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
function with return type scoped_ptr<T> to "return nullptr;" instead
of "return scoped_ptr<T>();".

- Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
empty and deletes anything it held.

- Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
constructing a scoped_ptr from another using move-only semantics. This
piece is critical for allowing the function returning nullptr to be
assigned to some other scoped_ptr at the callsite. In particular, take
the following code:
  scoped_ptr<T> Function() { return nullptr; }
  scoped_ptr<T> var = Function();
In this case the constructor which takes a nullptr allows Function() to
be written, but not to be used. The move-only constructor allows the
assignment from Function() to var. See "C++11 feature proposal:
Move-only constructors" on chromium-dev for more explanation why.

The scoped_ptr<T> class already had a constructor which took
scoped_ptr<U,E> as an argument, so this was changed to be
scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
constructor, so a scoped_ptr&& constructor was added. These match
the constructors found on the unique_ptr class.

- Remove the RValue type and the contructor that constructs a
scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
instead of a scoped_ptr::RValue, to avoid the type conversion and
remove some complexity. This is done with a new emulation macro that
still provides Pass() and makes the type go down the MoveOnlyType
path in base::Callback code.

This adds base_unittests to demonstrate and use these changes.

The use of Pass() remains unchanged until std::move() is written
or allowed. At that time std::move() could be used instead of Pass.

R=brettw@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/599313003

Cr-Commit-Position: refs/heads/master@{#297072}

There is nothing worse than stepping through the debugger and suddenly
hitting the watchdog timer DCHECK. If you're running under a debugger
seems like you don't care about the watchdog thread. So, make it so we
don't start watchdog in this case.

BUG=none
TEST=none
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/573683003

Cr-Commit-Position: refs/heads/master@{#297071}

H264 is useful for some users that cannot use VP8.

BUG=chromium:414567
TEST=run apprtc and ensure it still uses VP8 where available

Review URL: https://codereview.chromium.org/603263004

Cr-Commit-Position: refs/heads/master@{#297070}

A BrowserActionView can set its image view for the first time in UpdateState(),
but UpdateState() only called SchedulePaint(), and not Layout() (which is
necessary for the image). Coincidentally, with all the Layout()s called on
BrowserActionsContainer, this only manifested itself in Windows 8 Metro Mode
(likely because race conditions caused the image to be updated after all calls
to Layout()).

BUG=409782

Review URL: https://codereview.chromium.org/608013002

Cr-Commit-Position: refs/heads/master@{#297069}

BUG=418226

Review URL: https://codereview.chromium.org/606923002

Cr-Commit-Position: refs/heads/master@{#297068}

Revert of PDF: Add some CHECKS to help debug a crash. (patchset #2 id:20001 of https://codereview.chromium.org/457873003/)

Reason for revert:
No longer needed.

Original issue's description:
> PDF: Add some CHECKS to help debug a crash.
>
> BUG=402035
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289822

TBR=gene@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402035

Review URL: https://codereview.chromium.org/607743005

Cr-Commit-Position: refs/heads/master@{#297067}

Unfortunately, they are broken as implemented in MSVS 2013.

Review URL: https://codereview.chromium.org/609963004

Cr-Commit-Position: refs/heads/master@{#297066}

When building the native libraries, insert the version string into
native libraries as a section .chromium.verson.

BUG=417510

Review URL: https://codereview.chromium.org/599093005

Cr-Commit-Position: refs/heads/master@{#297065}

owners file.

Ronghua, let me know if you want to be in OWNERS file.

R=ronghuawu@chromium.org,lally@chromium.org,ldixon@chromium.org

Review URL: https://codereview.chromium.org/607973003

Cr-Commit-Position: refs/heads/master@{#297064}

BUG=409443
TEST=Set up Easy Unlock.  Once finished, there shouldn't be an "All set!" notification shown.
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/537823002

Cr-Commit-Position: refs/heads/master@{#297063}

The key to the fix is adding a category of 'nav' to the entering/exiting
dialog notifications.

BUG=408821
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/596033002

Cr-Commit-Position: refs/heads/master@{#297062}

BUG=401365

Review URL: https://codereview.chromium.org/515813002

Cr-Commit-Position: refs/heads/master@{#297061}

The (clang) compiler is smart enough to catch this error at compile-time, which
is better than waiting until runtime.

BUG=none
TEST=none
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/575343002

Cr-Commit-Position: refs/heads/master@{#297060}

Adds a RestrictSchedTarget parameter restriction which only allows
sched_* syscalls if the pid argument is the sandboxed process's pid or
if the pid is 0, which means the current thread.  glibc's pthread
implementation sometimes calls these syscalls with pid equal to the
current tid.  On these calls, the policy triggers a SIGSYS, and the
SIGSYS handler reruns the syscall with a pid argument of 0.

R=jln@chromium.org
BUG=413855

Review URL: https://codereview.chromium.org/590213003

Cr-Commit-Position: refs/heads/master@{#297059}

The metro_driver should not block the UI thread while waiting for the Chrome browser IPC channel to be initialized.

This causes the taskbar to become unresponsive for a bit on Windows 7. Windows 8 also has the same
problem. However it is not as visible as on Windows 7.

Fix is to do the IPC channel dance in a timer.

BUG=417100
R=cpu

Review URL: https://codereview.chromium.org/593353003

Cr-Commit-Position: refs/heads/master@{#297058}

BUG=375191
TEST=none

Review URL: https://codereview.chromium.org/608963002

Cr-Commit-Position: refs/heads/master@{#297057}

Review URL: https://codereview.chromium.org/599103008

Cr-Commit-Position: refs/heads/master@{#297056}

Optimized 94/647 files in 01:55:24s
Result: 98336 => 60415 bytes (37921 bytes: 38%)

BUG=418208
TBR=msw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/611663002

Cr-Commit-Position: refs/heads/master@{#297055}

As an important modifier on Chrome OS, this cl makes it possible to use sequenced and locked sticky key modes with the search key.

BUG=416964
TEST=manual

Review URL: https://codereview.chromium.org/598733002

Cr-Commit-Position: refs/heads/master@{#297054}

BUG=418035
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/610623002

Cr-Commit-Position: refs/heads/master@{#297053}

This is a slight cleanup after d9a02e76.

BUG=

Review URL: https://codereview.chromium.org/611623002

Cr-Commit-Position: refs/heads/master@{#297052}

This should fix the linux bots which are confused
by the existing folder that isn't git checkout
at all.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/606113002

Cr-Commit-Position: refs/heads/master@{#297051}

Optimized 53/55 files in 00:40:39s
Result: 142384 => 91688 bytes (50696 bytes: 35%)

BUG=418208
TBR=msw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/612543002

Cr-Commit-Position: refs/heads/master@{#297050}

Currently paddles show up when distilling a web page. This CL disables
that part of the feature, to ensure no paddles show up.

BUG=418240

Review URL: https://codereview.chromium.org/611463004

Cr-Commit-Position: refs/heads/master@{#297049}

Use newly allowed features to cleanup some audio code:
- auto for iterator based for loop.
- nullptr for NULL.

Additionally const& cleanup found while cleaning.

BUG=none
TEST=unittests pass.

Review URL: https://codereview.chromium.org/602193003

Cr-Commit-Position: refs/heads/master@{#297048}

This cleans up the README file to clearly indicate which certificates are real world certificates, which are generated by hand / by other sources, and which are generated via script (and which script).

Additionally, several test certificates that were previously generated by hand and several test CRLSets that were hardcoded are now generated automatically by the scripts.

BUG=401365

Review URL: https://codereview.chromium.org/515583004

Cr-Commit-Position: refs/heads/master@{#297047}

BUG=418039

Review URL: https://codereview.chromium.org/612453002

Cr-Commit-Position: refs/heads/master@{#297046}

This is used to find out the GCM usage from non-signed-in users.

BUG=384041
TEST=none

Review URL: https://codereview.chromium.org/605363002

Cr-Commit-Position: refs/heads/master@{#297045}

Resources added only for Chrome OS build.
This is a temporary place for the definitions. When http://crbug.com/418199 is
fixed, I will move them to ui/webui/resources.

BUG=375191

Review URL: https://codereview.chromium.org/608863002

Cr-Commit-Position: refs/heads/master@{#297044}