GitLab

BUG=103737

Review-Url: https://codereview.chromium.org/2803563008
Cr-Commit-Position: refs/heads/master@{#463001}

After sync, the test did not install pending apps on the synced client.

BUG=689662

Review-Url: https://codereview.chromium.org/2799783007
Cr-Commit-Position: refs/heads/master@{#463000}

 cp third_party/WebKit/Source/modules/shapedetection/OWNERS services/shape_detection/

BUG=659138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801893006
Cr-Commit-Position: refs/heads/master@{#462999}

Revert of [reland] Do not block in SimpleThread::Start(). (patchset #1 id:1 of https://codereview.chromium.org/2801073005/ )

Reason for revert:
Speculatively reverting hoping to resolve lots of random failures on 2 bots, starting with the builds below:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24574

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/40019

Original issue's description:
> [reland] Do not block in SimpleThread::Start().
>
> This CL is identical to https://codereview.chromium.org/2664953004.
> The race condition that it highlighted in a TaskScheduler test the
> first time that it landed was fixed by
> https://codereview.chromium.org/2798373002/
>
> There is no good reason to block in SimpleThread::Start().
> In addition to introducing unnecessary latency, blocking in
> Start() prevents a non-joinable DelegateSimpleThread from
> being deleted from Run() without external synchronization
> (it is wrong to delete SimpleThread while Start() is waiting
> on the |event_| member).
>
> BUG=
> TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2801073005
> Cr-Commit-Position: refs/heads/master@{#462912}
> Committed: https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b566ceb5d3441

TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2804393002
Cr-Commit-Position: refs/heads/master@{#462998}

ActiveProfilePrefService attempts to bind connections to the active profile.
However Incognito profiles do not register with the preference service. This
was leading to ServiceManagerConnectionImpl rejecting the connection, as there
was no registered service.

This change switches to using the original profile for the connection. Incognito
profile is backed by a base ProfileImpl. All ProfileImpl properly register as a
service.

This change also reenables the ash::shell connection to the pref service.

This change also reverts https://codereview.chromium.org/2795413002 which was
landed to deal with possible race condition of request handlers. However this
was not the root cause.

TESTING=device actually boots now, ash::shell receives its connection to prefs.
User can login.
BUG=707321

Review-Url: https://codereview.chromium.org/2802093005
Cr-Commit-Position: refs/heads/master@{#462997}

The Android MockDownloadController was added in:
https://codereview.chromium.org/1217223006

However, it seems to have been incorrectly added to our prod target
instead of something only for tests. This is unnecessary since
it is never used in prod.

This CL moves it to //chrome/browser:test_support, which is already
depsed in for the target that the single unit test that uses it
(DownloadResourceThrottleTest) is part of.

BUG=None

Change-Id: I70e7c06e603d38f858aadcffb47ac9bbd256e656
Reviewed-on: https://chromium-review.googlesource.com/471927Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#462996}

Without this we dispatch events to containers, which does nothing.
This also makes it so the right frame is created in mushrome mode.

BUG=none
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2807683002
Cr-Commit-Position: refs/heads/master@{#462995}

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

elementCannotHaveEndTag is a utility function used in serializers
and since it is used in multiple places, and MarkupFormatter is
not a good place for it, let us put it in EditingUtilities.

BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2804943002
Cr-Commit-Position: refs/heads/master@{#462994}

Some small changes:
1. Document some prerequisites for running the script.
2. Disable the OverrideDns() portion of the reverse tethering script
   as it hasn't worked in years, aborts the script, and isn't
   necessary.
3. Rename quic_server option as per crrev.com/2532083005
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2799743009
Cr-Commit-Position: refs/heads/master@{#462993}

This cleans up the output for SubresourceFilterComponentInstallerTest.TestComponentRegistrationWhenFeatureEnabled

[ RUN      ] SubresourceFilterComponentInstallerTest.TestComponentRegistrationWhenFeatureEnabled
[128216:55036:0407/120537.046:3889874656:ERROR:default_component_installer.cc(363)] Component registration failed for Subresource Filter Rules

Review-Url: https://codereview.chromium.org/2803983004
Cr-Commit-Position: refs/heads/master@{#462992}

Affected tests:
Pixel_OffscreenCanvasTransferToImageBitmap
Pixel_OffscreenCanvasTransferToImageBitmapWorker

BUG=696224, 585607
TBR=xlai@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2804323002
Cr-Commit-Position: refs/heads/master@{#462991}

This CL prevents the controls from hiding by resetting the hide timer on events in two places:

1) Listening for focusin and input events on the MediaControls via defaultEventHandler, which get fired as the user tabs through the controls and as the user changes the timeline/volume sliders respectively.

2) Listening for keypress events on the media panel via adding an event listener to the panel element in MediaControlsMediaEventListener, which gets fired when the user mutes/unmutes, turns CC on/off, etc.

BUG=701440

Review-Url: https://codereview.chromium.org/2757323002
Cr-Commit-Position: refs/heads/master@{#462990}

BUG=708165,708044,708961

Review-Url: https://codereview.chromium.org/2797333002
Cr-Commit-Position: refs/heads/master@{#462989}

Revert of media: Implement MediaDrmStorageImpl with tests (patchset #4 id:60001 of https://codereview.chromium.org/2791903004/ )

Reason for revert:
This CL causes MediaDrmStorageImplTest failing on chromium.linux/Android Tests:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/40330

BUG=709601

Original issue's description:
> media: Implement MediaDrmStorageImpl with tests
>
> Implement MediaDrmStorageImpl using PrefService.
>
> TBR=sdefresne@chromium.org
> BUG=493521
> TEST=New unit tests added.
>
> Review-Url: https://codereview.chromium.org/2791903004
> Cr-Commit-Position: refs/heads/master@{#462929}
> Committed: https://chromium.googlesource.com/chromium/src/+/d0b7b3b7e9f7d4e4c1f8276c5b416eaa05ac9bb0

TBR=yucliu@chromium.org,sdefresne@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493521

Review-Url: https://codereview.chromium.org/2808563002
Cr-Commit-Position: refs/heads/master@{#462988}

BUG=709409
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2805283002
Cr-Commit-Position: refs/heads/master@{#462987}

BUG=537099

Review-Url: https://codereview.chromium.org/2808503003
Cr-Commit-Position: refs/heads/master@{#462986}

This is a test for the urgent fix landed in crrev.com/2791513002.

BUG=704410
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2807753002
Cr-Commit-Position: refs/heads/master@{#462985}

Most of the changes replace canvas read pixels call in favor
of first getting the bitmap, and then doing a readpixels on that.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2792133002
Cr-Commit-Position: refs/heads/master@{#462984}

BUG=709529

TBR=rouslan@chromium.org

Review-Url: https://codereview.chromium.org/2805913002
Cr-Commit-Position: refs/heads/master@{#462983}

As agreed on https://chromium-review.googlesource.com/465440
the tests that are considered manual due to the "interact" flag,
but that the feature hasn't been implemented yet ":focus-within"
are skipped for now.

There's one manual test "hover-001-manual.html"
that is also skipped in this patch.

BUG=706118

Review-Url: https://codereview.chromium.org/2803213002
Cr-Commit-Position: refs/heads/master@{#462982}

[ RUN      ] RequestSenderTest.RequestSendSuccess
[54568:29108:0407/114750.146:3888807750:FATAL:url_request_filter.cc(54)]
Check failed: 0u == hostname_interceptor_map_.count(make_pair(scheme, hostname)) (0 vs. 1)

After enabling PingManagerTest, the subsequent RequestSenderTest may fail because the
PingManagerTest does not unregister its interceptors correctly.

TBR=waffles@chromium.org
BUG=349547

Review-Url: https://codereview.chromium.org/2805903003
Cr-Commit-Position: refs/heads/master@{#462981}

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This adds an Observer interface by which parts of Reporting can observe
cache updates. Expected users are the DeliveryAgent and Serializer.

BUG=704259

Review-Url: https://codereview.chromium.org/2778373003
Cr-Commit-Position: refs/heads/master@{#462980}

HostSharedBitmapManager is shifted to components/display_compositor.
ChildSharedBitmapManager is shifted to services/ui/public/cpp/bitmap.

The Mojo messages used in allocating shared bitmap is decoupled from
render_message_filter.h and moved to cc/ipc/shared_bitmap_manager.mojom.

Note that the SharedBitmapManager is an associated mojo interface of
RenderMessageFilter so as to maintain the existing FIFO order of mojo
messages between the two SharedBitmap allocation functions and the
rest of RenderMessageFilter functions.

BUG=670162
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2717213004
Cr-Commit-Position: refs/heads/master@{#462979}

Here we are implementing one IAccessibility method, accLocation(), in terms of
ui::AXPlatformNodeWin. The idea is that we can forward IAccessibility calls to
ui::AXPlatformNodeWin and then slowly trim down, and maybe remove,
BrowserAccessibilityWin.

This CL adds a small helper method that allows the cast conversation of
platform_node_, which is created in AXPlatformNode, from a AXPlatformNode to
AXPlatformNodeWin. If this result is nullptr, we will fall back to using the
BrowserAccessibilityWin implementation.

BUG=703369

Review-Url: https://codereview.chromium.org/2763043002
Cr-Commit-Position: refs/heads/master@{#462978}

Also renames PageInfoPopupViewBrowserTest to PageInfoBubbleViewBrowserTest.

BUG=708379

Review-Url: https://codereview.chromium.org/2797923003
Cr-Commit-Position: refs/heads/master@{#462977}

Design doc:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE

To test:
1) Install BobPay.apk from
https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNc1FCNlZkN3FMMWs/view?usp=sharing
2) Enable chrome://flags/#android-payment-apps.
3) Navigate to https://rsolomakhin.github.io/pr/bob/.
4) Click "Buy" button on the webpage.

BUG=707246

Review-Url: https://codereview.chromium.org/2807733002
Cr-Commit-Position: refs/heads/master@{#462976}

This CL records the network data use for downloading favicons. Also the
size of non 200 responses for favicon requests are recorded.

BUG=698347

Review-Url: https://codereview.chromium.org/2764893003
Cr-Commit-Position: refs/heads/master@{#462975}

BUG=578344
R=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2805893003 .
Cr-Commit-Position: refs/heads/master@{#462974}

https://pdfium.googlesource.com/pdfium.git/+log/1e8c39f18df6..6a5c20cd0874

$ git log 1e8c39f18..6a5c20cd0 --date=short --no-merges --format='%ad %ae %s'
2017-04-07 npm Remove the ICC transform where it is never initialized.

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2796303010
Cr-Commit-Position: refs/heads/master@{#462973}

BUG=526463

Review-Url: https://codereview.chromium.org/2802993003
Cr-Commit-Position: refs/heads/master@{#462972}

In converting accLocation() in BrowserAccessibility to use AXPlatformNode, we
found that the simple model of using local coordinates plus a global offset just
doesn't work.

In Views we've been able to get away with this simple model because Views do not
have the same nested transformations that the web can like rotation and scaling.

This change also allows us to remove GetGlobalCoordinateOffset() as
the  x.() and y.() of the result of GetScreenBoundsRect() can be used instead.

BUG=703369

Review-Url: https://codereview.chromium.org/2795543002
Cr-Commit-Position: refs/heads/master@{#462971}

This CL add two assertions that abstracts the checks for JavaScript
traits.

 - should().ownProperty()
 - should().inheritFrom()

BUG=702708
TEST=webaudio/unit-tests/audit.html

Review-Url: https://codereview.chromium.org/2805773002
Cr-Commit-Position: refs/heads/master@{#462970}

Because of the implementation specific of the layout opportunity iterator
an empty opportunity can mean 2 things:
- search for layout opportunities is exhausted.
- opportunity has an infinite size. That's because CS is infinite.

This patch fixes DCHECK crashes when we return an infinite opportunity.

BUG=635619

Review-Url: https://codereview.chromium.org/2801053004
Cr-Commit-Position: refs/heads/master@{#462969}

This CL updates third_party/checkstyle to 7.6.1 so checkstyle would
work with Java 8 lambda features.

BUG=703238

Review-Url: https://codereview.chromium.org/2799303003
Cr-Commit-Position: refs/heads/master@{#462968}

BUG=661799

Review-Url: https://codereview.chromium.org/2800563002
Cr-Commit-Position: refs/heads/master@{#462967}

Added EscapeString() to convert certain characters into XML escape (&xxx;) sequences

BUG=708705

Review-Url: https://codereview.chromium.org/2803613003
Cr-Commit-Position: refs/heads/master@{#462966}

TBR=jbudorick@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2800113002
Cr-Commit-Position: refs/heads/master@{#462965}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/d0783b8..32cfddc

BUG=685232, 701060, 709351

TEST=bots

TBR=zmo@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2798083005
Cr-Commit-Position: refs/heads/master@{#462964}

This CL updates WebApkInstaller so that the murmur2 hash of the best
badge icon would be calculated and passed to the WAM server in WebAPK
proto along with the url of the best badge icon.

BUG=649771

Review-Url: https://codereview.chromium.org/2676863002
Cr-Commit-Position: refs/heads/master@{#462963}

BUG=695306

Review-Url: https://codereview.chromium.org/2802303002
Cr-Commit-Position: refs/heads/master@{#462962}