- 26 Sep, 2018 40 commits
-
-
Leonard Grey authored
macOS 10.14 changed the method signature of a block parameter to application:continueUserActivity:restorationHandler: by introducing a lightweight generic. Since the parameter is unused and the protocol specified by the new generic is 10.14+, this change ignores the mismatched parameter. Bug: 887214 Change-Id: I4a111cdb69ac4fcc22a78448b3efb5bc7c0536e9 Reviewed-on: https://chromium-review.googlesource.com/1246322Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#594365}
-
Torne (Richard Coles) authored
Remove the old variable names now that downstream is using the new, consistent-with-Chrome names. Change-Id: I55a3e80c25b30b505504ff5268ec86da39a0e2c5 Reviewed-on: https://chromium-review.googlesource.com/1241015Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594364}
-
Hans Wennborg authored
The builds were failing like: ERROR at //third_party/crashpad/crashpad/util/BUILD.gn:657:20: Item not found sources -= [ "stdlib/string_number_conversion_test.cc" ] ^---------------------------------------- You were trying to remove "stdlib/string_number_conversion_test.cc" from the list but it wasn't there. See //chrome/installer/setup/BUILD.gn:114:7: which caused the file to be included. "//third_party/crashpad/crashpad/util", ^------------------------------------- GN gen failed: 1 thakis excluded this file in https://chromium-review.googlesource.com/1113664 jperaza then upstreamed that in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1195567 but put it outside the crashpad_is_win clause When the upstream change was rolled into chromium in https://chromium-review.googlesource.com/c/chromium/src/+/1195670 we ended up with the file exclusion *both* in the crashpad_is_win_clause and outside it, causing this gn error. Bug: 856174 Change-Id: I5b812567e6a9be54ce622b9a221b61dc6a27f1b6 Reviewed-on: https://chromium-review.googlesource.com/1245463Reviewed-by:Scott Graham <scottmg@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#594363}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bdf1431686c2..90b47106a6e1 git log bdf1431686c2..90b47106a6e1 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6aad6a769d20..d73b871379e0 (1 commits) 2018-09-26 jvanverth@google.com Make line distance more robust Created with: gclient setdep -r src/third_party/skia@90b47106a6e1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I1e5ef576cbe8fd2299e449f717a2a2b50832cf7b Reviewed-on: https://chromium-review.googlesource.com/1246262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594362}
-
Peter E Conn authored
Bug: 871266 Change-Id: I142b570be0a17df00d9b43cf96fddc8c09c21a0d Reviewed-on: https://chromium-review.googlesource.com/1238463 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#594361}
-
Kevin Marshall authored
This script uses the metadata JSON files in the SDK to generate a BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is regenerated whenever a new SDK is downloaded using "gclient sync". Only FIDL libraries are migrated for now. Additional metadata types can be migrated in followup CLs. Bug: 888753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If87010006cd23e90d970da4cb84e6de35804b7dd Reviewed-on: https://chromium-review.googlesource.com/1241842Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Android instrumentation tests detect folder by the absence of the url field in the produced JSON for debugging. Therefore, the produce specifics from BookmarkNode shouldn't have url set at all instead of assigning an empty url. Bug: 516866 Change-Id: Ia61ebf6d67c04c2b2accad5f8ffc73c9125f0355 Reviewed-on: https://chromium-review.googlesource.com/1243810 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594359}
-
Becky Zhou authored
Bug: 888129 Change-Id: I4000a8b4f25e1a853d882090cdc3a09e8719dd7b Reviewed-on: https://chromium-review.googlesource.com/1246464Reviewed-by:
-
Daniel Bratell authored
This caused a link error, duplicate symbols, in a jumbo build experiment. How it ever worked in normal builds we'll never know. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4136a153aa989f2187d745f291658ac4e05fa6db Reviewed-on: https://chromium-review.googlesource.com/1244461Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#594357}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9004e51..ba614d6f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If55c7a37c139e0af92164493d8ea90dcd1ac8e1c Reviewed-on: https://chromium-review.googlesource.com/1246242Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594356}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/846ae9bff247..8498332d304e git log 846ae9bff247..8498332d304e --date=short --no-merges --format='%ad %ae %s' 2018-09-26 cphlipot0@gmail.com trace-viewer: Fix crash in timeline process filter. Created with: gclient setdep -r src/third_party/catapult@8498332d304e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I912956dea10c8a919992c0999d4e53e4620834f2 Reviewed-on: https://chromium-review.googlesource.com/1246141Reviewed-by:
-
Devlin Cronin authored
As mentioned here: https://chromium-review.googlesource.com/c/chromium/src/+/1222917/5/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api.h#36 TBR=thestig@chromium.org (c/b/browser_process_impl.cc, c/test/base/, c/common/) TBR=msarda@chromium.org (c/b/profiles/) TBR=achuith@chromium.org (c/b/chromeos/login/) Bug: None Change-Id: I37d5fc0aec77e539e7decbd6de3b948e0205bda8 Reviewed-on: https://chromium-review.googlesource.com/1228949 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#594354}
-
danakj authored
This moves RenderViewImpl-specific code out of RenderWidget up into RenderViewImpl. RenderViewImpl does the message to the ViewHost to get the RenderWidget's routing id, and sets up the ShowCallback to itself. This also centralizes the widget creation responsibility in RenderView as we have done for the RenderViewHost side. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: Ic4fa4a1a1c73368f108550db4c15dc2b23e842ce Reviewed-on: https://chromium-review.googlesource.com/1231825Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594353}
-
Roman Sorokin authored
* Use oobe-dialog instead of gaia-card To try follow go/streamlinesteps BUG=chromium:865474, chromium:853571 TEST=manual + existing tests TBR=poromov@chromium.org Change-Id: Ibd59001096b5378f69a61a41cb7a9e14a7c5f32f Reviewed-on: https://chromium-review.googlesource.com/1151305 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#594352}
-
Nicolas Pena authored
There is a spike in M69 in crashes caused by assuming that |document_loader| is not null during a call to WindowPerformance::CreateNavigationTimingInstance. Remove the DCHECK and add a null check. Bug: 889020 Change-Id: Ib07ca35810f4512cb251311fb82aee5b5cce17d8 Reviewed-on: https://chromium-review.googlesource.com/1246081Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#594351}
-
Max Moroz authored
This requires that fuzz targets use "-fsanitize=fuzzer-no-link" instead of "-fsanitize=fuzzer". All Chromium fuzz targets should do this already; projects rolling in this change need to change from the latter to the former. Removes 1.7MB library on Linux, 1.5MB on Mac, 7.7MB on Windows Bug: 870331 Change-Id: I124207477d0e8338f0502a794200edcd5102bd45 Reviewed-on: https://chromium-review.googlesource.com/1244802 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594350}
-
Sylvain Defresne authored
To allow incremental conversion from function pointer to callbacks, add overloads to BKCSF's SetTestingFactory and SetTestingFactoryAndUse that receive a base::Callback<> instead of a function pointer. Bug: 809610 Change-Id: I6d29e85a6711ba99b0d84aa5cb7355b26fbb4779 Reviewed-on: https://chromium-review.googlesource.com/1243072 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#594349}
-
Ivan Šandrk authored
Currently the description incorrectly states that the policy defaults to the old "Public Sessions" behaviour (it actually defaults to the new "Managed Sessions" behaviour), correct it. The policy is named DeviceLocalAccountManagedSessionEnabled. Bug: 865947 Change-Id: I018f6cf2769e7b860682a0f2e61fe814d2566811 Reviewed-on: https://chromium-review.googlesource.com/1240537Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#594348}
-
Sigurdur Asgeirsson authored
Bug: 874968 Change-Id: Ifefec30eb6701cd6da584c54682fd4488a7e3527 Reviewed-on: https://chromium-review.googlesource.com/1246282Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594347}
-
Eugene But authored
data: URLs can be used for Calendar events and Contacts. These URLs are supported by Safari and Chrome on other platforms. This change will regress crbug.com/712206 (which is a minor bug), so CRWWebControllerDownloadTest.DataUrlResponse test was removed. Also updated FakeDownloadTaskImplDelegate to set mock expectations earlier, because CreateSession is now called much later to avoid creating sessions for data:// URLs. Bug: 712206, 666211, 604533 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iddbd7b8e58b781c1d093e35539db8fe5ec8841c4 Reviewed-on: https://chromium-review.googlesource.com/1244976 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594346}
-
Scott Graham authored
See linked bug for reliable repro and investigation. TBR: fdoray@chromium.org Bug: 856900 Change-Id: Ibb112c9a573ea4a2451edebffba63cccc80918de Reviewed-on: https://chromium-review.googlesource.com/1246463Reviewed-by:
-
Christopher Cameron authored
Remove the remaining places where code that is going to be moved into ui/views_bridge_mac includes a file from ui/views. This includes * The enum used by BridgedNativeWidgetImpl::SetTransitionsToAnimate. This is changed to a mojo enum and added to a mojo interface. * BridgedNativeWidgetImpl::RunMoveLoop. This is changed to a bool, and still relies on a raw pointer to invoke (does not work over mojo yet). * BridgedNativeWidgetImpl::OnWindowNativeThemeChanged, changed to a mojo method calling BridgedNativeWidgetHostImpl Bug: 859152 Change-Id: I62424b46825788cbb9367ebf9e62c54bace1e6af Reviewed-on: https://chromium-review.googlesource.com/1244822Reviewed-by:
-
David Bertoni authored
For unpacked extensions, all static icons are checked at load time and a stat is logged. In the future, this will force an error if they are not sufficiently visible. Bug: 805600 Change-Id: I8ff54a209aee174bcded5b8c4dc220db2254361b Reviewed-on: https://chromium-review.googlesource.com/1214179Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594343}
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/a2d200e6a..a305a5eb8 $ git log a2d200e6a..a305a5eb8 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 metzman [fuzzer] Replace FuzzerExtFunctionsDlsymWin.cpp with FuzzerExtFunctionsWeakAlias.cpp 2018-09-17 morehouse [libFuzzer] Avoid fuzzer symbols being hidden. Bug: 884559 Change-Id: Iabcc2d7517171dc90626b0836953951b289f4322 Reviewed-on: https://chromium-review.googlesource.com/1239460 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594342}
-
Zach Helfinstein authored
Bug: 884547 Change-Id: I70ec39bc231981432fd4f2902263855b37d44a2d Reviewed-on: https://chromium-review.googlesource.com/1241568 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#594341}
-
Mark Cogan authored
MainCoordinator existed as an abstraction to service several possible root view controllers for the app; this is no longer needed. MainController was already depending on the root coordinator being a TabGridcoordinator, so this CL makes that explicit (it will be cleaned up later). TabGridCoordinator used to subclass MainCoordinator; now it just directly subclasses ChromeRootCoordinator (MainCoordinator's superclass). Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3a7705d284519047fb9a09baf0746ac2561867a3 Reviewed-on: https://chromium-review.googlesource.com/1246101 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#594340}
-
David Davidović authored
Switched KeyDerivationParams to class (from struct) and defined operator!= on it. Removed a DCHECK which could theoretically trigger when the server sends invalid data. Merged some very similar tests for SyncEncryptionHandlerImpl. Fixed some formatting. Change-Id: Ia4d6a0baec984872c8c53cdc27bdd870aa3c9f57 Reviewed-on: https://chromium-review.googlesource.com/1236340 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#594339}
-
Ryan Cui authored
This reverts commit 5b8e2622. Reason for revert: crbug.com/884589 is now fixed. Try to re-enable ASAN browser tests for SingleProcessMash. Original change's description: > Temporarily remove single_process_mash_browser_tests from LSan/Asan builder > > We are seeing lots of flaky failures on the builder. They are being looked > at, but until they are fixed remove the tests from the builder to reduce > maintainence burden on the broader team. > > Bug: 885309 > Change-Id: I421702ec6155a2bf1d117ab77a286870e3e7b443 > Reviewed-on: https://chromium-review.googlesource.com/1234795 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592655} TBR=sky@chromium.org,rcui@chromium.org Bug: 885309 Change-Id: Ia1d693add60d30399df595a35cae2a1fb56bf7a3 Reviewed-on: https://chromium-review.googlesource.com/1240860Reviewed-by:
-
Finnur Thorarinsson authored
Images are loaded on a worker thread and stored in an LRU cache, which is discardable under memory pressure. Bug: 860467 Change-Id: I5bbd1a3839d22282c1ee3ef2350058d9248f4d2f Reviewed-on: https://chromium-review.googlesource.com/1243286Reviewed-by:
-
Mark Cogan authored
Removes team members no longer working on Chrome from OWNERS files, removing the file if there are no other owners. Fixes typos. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I63cffdc99638be8ee02bee780848cd9796940c31 Reviewed-on: https://chromium-review.googlesource.com/1243116Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594336}
-
Vadym Doroshenko authored
For checking whether to upload votes for a form, FormStructure::ShouldBeUploaded is called both from Autofill and Password Manager code. Because Password Manager uploads votes rarely it's ok to upload Password Manager votes for any form, so call of this function might be skipped in Password Manager code. On other hand, ShouldBeUploaded has a check on |has_password_field_| and as result uploads for any password form are treated as Password Manager uploads, while they may come from Autofill. This CL implements: 1.Removing call of ShouldBeUploaded in Password Manager code. 2.Removing checks on has_password_field_ in ShouldBeUploaded. Bug:882941 Change-Id: Iba9ab1f74451520f0a636e0748f795d73e922ce7 Reviewed-on: https://chromium-review.googlesource.com/1219710 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#594335}
-
Mythri Alle authored
Add component to v8_browsing benchmarks to streamline bug triaging process Change-Id: I407b692776dc889aaf16e4965aafcb627ed7aa37 Reviewed-on: https://chromium-review.googlesource.com/1235996 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#594334}
-
Lei Zhang authored
The build config for pdf_unittests needs to stay in sync with the "pdf" target. Extract out the build config into "pdf_common_config". BUG=866182 Change-Id: I9fa8f5e89cd74ad28e7297dedce73a3aab143137 Reviewed-on: https://chromium-review.googlesource.com/1244977Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#594333}
-
Joshua Bell authored
Bug: 837308 Change-Id: Ib5a7e51781c46f1e06336c12ab9f4fa0f443f390 Reviewed-on: https://chromium-review.googlesource.com/1244597 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#594332}
-
Nicolas Pena authored
This CL is a minimal change to use swap time instead of presentation time in PageLoad.PaintTiming.NavigationToFirstContentfulPaint. This is a tentative fix for the unexpected regressions in the metric. The change is minimal since it may require a merge to Stable. A followup change will record the presentation timestamp, or the delta with the swap timestamp, in a separate metric. Bug: 870707 Change-Id: I1b48968d010bbd6120a6fbac59e26dc789d23394 Reviewed-on: https://chromium-review.googlesource.com/1244371Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
A Olsen authored
Removing chrome/browser deps from c/b/chromeos/settings code that, so that the code can eventually be moved to src/chromeos/settings: - Delete some chrome/browser includes that are now completely unused in chrome/browser/chromeos/settings. - Change SystemSettingsProvider to use UserManager, instead of ProfileManager and LoginState, since UserManager does not depend on chrome/browser Bug: 446937 Change-Id: I5d1edb34643d6c48a8b8351af68ec9ae5c0118b4 Reviewed-on: https://chromium-review.googlesource.com/1238450 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
-
John Budorick authored
TBR=hinoka@chromium.org Bug: 889399,861396,885799 Change-Id: I7cb770cbe0d4b94f3de501c1e8bc55e37ccd77ce Reviewed-on: https://chromium-review.googlesource.com/1246283Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#594329}
-
Gauthier Ambard authored
This CL moves the clean and adaptive toolbar files to the toolbar folder directly. Now that there is only one toolbar implementation, it is no longer needed to separate the files. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I348caff07d9d7fd7759e447ec615e3d3ec7f337f Reviewed-on: https://chromium-review.googlesource.com/1245712Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#594328}
-
Nico Weber authored
Views mode is enabled by default now, so ScopedMacViewsBrowserMode{true} is a no-op. No behavior change. Bug: 832676 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5e89efb62080dafd4340097e5f70af045e31c4c8 Reviewed-on: https://chromium-review.googlesource.com/1245924Reviewed-by:Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594327}
-
Donna Wu authored
This CL converted USB requests in UsbChooserController to mojom interfaces through UsbChooserContext. Bug: 699790 Change-Id: Ib55b8ab0d9a2e891227886eb68cdc29992779f45 Reviewed-on: https://chromium-review.googlesource.com/1235613 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594326}
-
