- 31 Oct, 2017 40 commits
-
-
Yutaka Hirano authored
Bug: 695939 Change-Id: If45e944d34eba2f9cd81f8e0a3e60cebc73e365b Reviewed-on: https://chromium-review.googlesource.com/737498Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#512801}
-
chrome://flagsEdward Jung authored
layer Switched to a relative positioned container. Bug: 777348 Change-Id: I4dd615d2ae067481536ca5106b598345868be27c Reviewed-on: https://chromium-review.googlesource.com/744204Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#512800}
-
tzik authored
As WTF::BindInternal no longer does lots of things, this CL inlines it into WTF::Bind and blink::CrossThreadBind. As a preparation to remove WTF::Function for same thread usage. Bug: 771087 Change-Id: I7b24c106d3ce9676b074a19521628107b7fe7b89 Reviewed-on: https://chromium-review.googlesource.com/745742Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#512799}
-
Hajime Hoshi authored
This is one step of all replacings at https://chromium-review.googlesource.com/c/chromium/src/+/743663 Bug: 777775 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ife29c5e5a6ae5f27e296e962251fc6aefef8e765 Reviewed-on: https://chromium-review.googlesource.com/746621Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512798}
-
Pawel Osciak authored
A protected gpu memory buffer is a buffer that can be referred to by a GpuMemoryBufferHandle, which does not provide access to the buffer's contents. Such handle can be shared with and received from clients that should not have access to the buffer's contents. When such handle is passed to the ProtectedGpuMemoryBufferManager service by its privileged client, it can be translated into another GpuMemoryBufferHandle, which allows access to the buffer. Also, implement a ProtectedMemoryManager to provide an allocation and lookup service for such buffers for gbm. Finally, add secure mode API to the ArcVideoAccelerator stack and integrate it with the above, to provide a secure codec mode implementation. TEST=E2E video playback tests BUG=b:27174405,b:62575861,b:27204780 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I80259db35463f7ed0cc3acc28bf767e55e46c8b8 Reviewed-on: https://chromium-review.googlesource.com/689818Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Owen Lin <owenlin@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#512797}
-
Peiyong Lin authored
This is a reland of 8a3a84dc Original change's description: > Make resource_coordinator/ strongly typed. > > This patch: > 1. Added CU relation manipulation methods in mojo interface and public APIs; > 2. Created one type of *ResourceCoordinator for each coordination unit type; > 3. Removed generic CoordinationUnit mojo interface and implementation; > 4. Replaced every call of SetProperty and SendEvent with new public APIs; > 5. Added more tests. > > BUG=775691 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I10b5c6a5ce9d8f0fbe3c2c3afef4ee4da7da0757 > Reviewed-on: https://chromium-review.googlesource.com/736036 > Commit-Queue: lpy <lpy@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512654} TBR=dcheng@chromium.org, oysteine@chromium.org, peter@chromium.org, zhenw@chromium.org Bug: 775691 Change-Id: I39a8879739c67e630ae8c8e6e92b939cc4acdfd5 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/745361Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#512796}
-
tzik authored
This CL refactors CancelbaleCallback into CancelableRepeatingCallback and CancelableOnceCallback for OnceCallback support. Change-Id: I40a3079bae598d440e84a737b7f7082a2c5e44bf Reviewed-on: https://chromium-review.googlesource.com/737399 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#512795}
-
Marina Ciocea authored
Split GetPreferredAudioParameters functions to improve readability, move helper functions to unnamed namespace, fix typo. R=maxmorin@chromium.org, olka@chromium.org Bug: 774998 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I630e02dc73152eaf662a94ef0e1a4150a8ebcec9 Reviewed-on: https://chromium-review.googlesource.com/743361Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#512794}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/19ada67d..7382dc26 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie3d4749805433fc17cc791f2a96b26c5146ca801 Reviewed-on: https://chromium-review.googlesource.com/746522Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512793}
-
Makoto Shimazu authored
TBR=lazyboy@chromium.org Bug: 779973 Change-Id: I63f4805d5d4907b4339c83b6cd310447d40526e0 Reviewed-on: https://chromium-review.googlesource.com/746601Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512792}
-
Matt Menke authored
SafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata: new test. SSLUITestCommittedInterstitials.ErrorPageType: new test. virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html: old test, flaking a lot (And did my last shift, too). TBR=mmenke@chromium.org Bug: 729849,756009,756089,778857 Change-Id: I08ef0853db0d709e57ce2eb4ca1d3ac3960b6bcc Reviewed-on: https://chromium-review.googlesource.com/746363Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512791}
-
tzik authored
This removes WTF::ParamStorageTraits, as its type conversion is no longer used. Its type assertions are moved to CheckGCedTypeRestriction. Bug: 771087 Change-Id: I405fa4c38ae051dda6a1a75d3dbdd8c4a46586c7 Reviewed-on: https://chromium-review.googlesource.com/745762Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#512790}
-
Kinuko Yasuda authored
These tests almost never succeeded: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=SSLUITestCommittedInterstitials.ErrorPageType%2CSafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata SSLUITestCommittedInterstitials.ErrorPageType SafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata TBR=jam@chromium.org NOTRY=true Bug: 729848 Change-Id: Icc2f009f2825f72e49c9fcbc87eb5843258d0b6a Reviewed-on: https://chromium-review.googlesource.com/746624Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512789}
-
Jérôme Lebel authored
To solve crbug.com/770424#c5, -[SigninInteractionController cancel] has to be an asynchronous call. Switching from using SigninInteractionController to Chrome commands, will help to solve the bug only in one place. After this patch, the issue will have to be solved only in MainController. Bug: 770424 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I238b51d80430bab644f84fc27f4fc4e2d4bc573d Reviewed-on: https://chromium-review.googlesource.com/739387Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#512788}
-
Kinuko Yasuda authored
From flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&showFlaky=true&builder=chromium.fyi%3AMojo%20Linux There're more, but adding a few ones that often show flakes (which is confusing while looking into other flaky issues) TBR=jam@chromium.org NOTRY=true Bug: 729849 Change-Id: I1d862a944f7e1c3a5b792f9783ae56b31ddfdeed Reviewed-on: https://chromium-review.googlesource.com/746053Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512787}
-
Takashi Toyoshima authored
b/<id> link seems not working because the system recognizes it as a relative URL. Adding http:// should work (for Googlers). Change-Id: I6348dffa99318ab5eef0a74e20d9fc3c25b23b1c Reviewed-on: https://chromium-review.googlesource.com/746485Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#512786}
-
Alex Clarke authored
This refactor should not change behaviour. Bug: 777763 Change-Id: I73e68c4b1d29afded6bda984cbbb0c33cb7cebbd Reviewed-on: https://chromium-review.googlesource.com/743626Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512785}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ic7efbc16779a1eda83755289c2e8f18256ddfabe Reviewed-on: https://chromium-review.googlesource.com/746501Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#512784}
-
Yoshifumi Inoue authored
This patch Introduces FlatTreeTraversal::InclusiveAncestorsOf() as |NodeTraversal|. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/737981: Introduce TextOffsetMapping to simplify word/paragraph selection Change-Id: I5ec0043887b0d72816bd2b0701a3e6cbe40ff28e Reviewed-on: https://chromium-review.googlesource.com/742770 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#512783}
-
Takashi Toyoshima authored
Now we have three kinds of CORS error enum types, but these error groups are comprehensive yet and will need different error groups. To avoid introducing many minor error types, I would merge them into a single enum type, CORSError. Bug: 736308 Change-Id: Ib14d0359a73efa6b6a3e9db7021ca57952980666 Reviewed-on: https://chromium-review.googlesource.com/742829 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512782}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/9088557fe47e..722bfb51d591 $ git log 9088557fe..722bfb51d --date=short --no-merges --format='%ad %ae %s' 2017-10-26 oetuaho Fix detecting duplicate field names in structures Created with: roll-dep src/third_party/angle Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8e0cbfeb3b24723f04195988fc348e7d26b874ec Reviewed-on: https://chromium-review.googlesource.com/746028Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512781}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/6fd9f08dcb0b..d62be5b8d845 $ git log 6fd9f08dc..d62be5b8d --date=short --no-merges --format='%ad %ae %s' 2017-10-30 sadrul telemetry smoothness: Ignore the renderer for frame times. 2017-10-30 wkorman Increase timeout for expensive JS operations. 2017-10-30 charliea Remove more MSR-focused Telemetry power code 2017-10-27 oysteine py_vulcanize: Support a list of scripts to ignore Created with: roll-dep src/third_party/catapult BUG=779316 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I826b95dfe8129dd4c42b2e6d96294738e67b3d90 Reviewed-on: https://chromium-review.googlesource.com/745823 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512780}
-
Matt Menke authored
This reverts commit e60ebbd1. Reason for revert: Caused ~60 browser_tests and content_browsertests to fail with the network service enabled. Original change's description: > Reland "Always send subresource ULF on navigation" > > This is a reland of bba21f27 > Original change's description: > > Always send subresource ULF on navigation > > > > This changes the Network Service-enabled browser-side navigation path > > to always send a default subresource URLLoaderFactory to the render > > frame on navigation commit. > > > > In addition to sending a default ULF, we also send one for blobs. > > Ultimately the idea here is to have the browser, at navigation time, > > send a frame everything it will need to request any accessible > > subresources, making it easier to reason about what subresource > > capabilities any given frame has. > > > > This set of capabilities is encapsulated by a new > > URLLoaderFactoryBundle type, which can be serialized over mojom and is > > now passed in new-document navigation commit messages. > > > > Follow-up usage of URLLoaderFactoryBundle will support loading things > > like file:// and chrome-extension:// subresources when appropriate. > > > > Note that this does not yet change how workers acquire ULFs for their > > own resource requests. > > > > Bug: 721414,759230 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > > Change-Id: I47b0897c7c012292633d5f08c874a18cc0fb1dcb > > Reviewed-on: https://chromium-review.googlesource.com/740904 > > Commit-Queue: Ken Rockot <rockot@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#512459} > > Bug: 721414, 759230 > Change-Id: Ie13bcd97b7a5af8dbe4263a70239ba124205da15 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > > TBR=dcheng@chromium.org > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ie13bcd97b7a5af8dbe4263a70239ba124205da15 > Reviewed-on: https://chromium-review.googlesource.com/744222 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512706} TBR=dcheng@chromium.org,jam@chromium.org,rockot@chromium.org Change-Id: Iee7d5a63f105ac4c15d8320668a33d66972820b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414, 759230 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/746302Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512779}
-
Greg Thompson authored
This makes handling of Chrome's own fatal messages consistent with handling of system errors. BUG=764415 R=siggi@chromium.org,sky@chromium.org Change-Id: If60f3366d38d719741918982ce02265a766a3c08 Reviewed-on: https://chromium-review.googlesource.com/741232Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#512778}
-
Makoto Shimazu authored
These leyout tests flaky time out on Linux Leak bots. Marked as flaky. TBR=junov@chromium.org Bug: 779956 Change-Id: I5fca85d3e385f020c026b8db50ac5cc225ddf675 Reviewed-on: https://chromium-review.googlesource.com/746486Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512777}
-
Yutaka Hirano authored
Share the logic with MimeSniffingResourceHandler. Bug: 778721 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4a90beee86a5182b0a8d1c6225c4aaa711abed7d Reviewed-on: https://chromium-review.googlesource.com/745661 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512776}
-
Eric Willigers authored
We add use counters for the following attributes: attribute DOMString? selectedStylesheetSet; readonly attribute DOMString? preferredStylesheetSet; BUG=690600,690609 Change-Id: I0edf7fc6ec5e3e9295d36f18ad5853ffabfa6c1e Reviewed-on: https://chromium-review.googlesource.com/745322Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#512775}
-
Gyuyoung Kim authored
This CL removes calls to RuntimeEnabledFeatures:::SetLayoutNGEnabled and instead uses scoped settings setters to ensure test settings aren't used in next tests. To use that, this CL introduces NGLayoutTest that inherits RenderingTest and ScopedLayoutNGForTest. Then child NGFooClass inherit it instead of RenderingTest. Bug: 769541 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6f73077a694dd10750e458cd2bc619005cce1a42 Reviewed-on: https://chromium-review.googlesource.com/737597Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512774}
-
Sadrul Habib Chowdhury authored
This is a reland of c74bc225 Original change's description: > glx: Fix a crash during teardown. > > Two notable changes: > . Do not immediately destroy the GLContextGLX when MakeCurrent() fails. > This follows the pattern in GLContextEGL, where MakeCurrent() does > not immediately destroy the context on failure. > . Notify TextureManager about lost context early during tear down. This > is necessary because FramebufferManager is destroyed first, and > during its destruction, some gpu::gles2::Texture objects can be > destroyed. But TextureManager is destroyed later, and is notified of > the lost context only during destruction. As a result, Texture > destruction does glDeleteTextures() while there's no context, causing > a crash. > > BUG=777594 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I664e43c297cded17c223d3ee1ac4e32ca28ffd42 > Reviewed-on: https://chromium-review.googlesource.com/734945 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512651} TBR=piman@, since the fix for the revert is a trivial nullcheck Bug: 777594 Change-Id: I0d02ef632e0754ab9cf398a349048108b1a05ed9 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/746241Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#512773}
-
Darren Shen authored
This reverts commit 1fb83262. Reason for revert: Doesn't seem to improve performance. Original change's description: > [CSSParser] Reject properties that cannot use the fast path. > > When parsing CSS property values, we first do a quick scan to see if the > value is simple enough to avoid tokenizing. This works well for things > like lengths, where the values have predictable structure. If the scan > failed, we do tokenization and parsing as fallback. Hence, for properties > that don't use the fast path, we do some extra work. > > This patch adds an early exit for the fast path code for properties that > we know will almost never use the fast path. > > Bug: 605792 > Change-Id: Iba211c844d5faa2c7272d10fd02b127d5c6abe1b > Reviewed-on: https://chromium-review.googlesource.com/701957 > Reviewed-by: nainar <nainar@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#511324} TBR=nainar@chromium.org,shend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 605792 Change-Id: If73e39e891c892aef1b745b95f45df8ba242af8c Reviewed-on: https://chromium-review.googlesource.com/746421Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512772}
-
Jose Dapena Paz authored
CSSStickyPosition runtime flag has been shipped as stable from at least m56. This patch removes the flag and make the dependent code unconditional. BUG=402536 Change-Id: I325da511415dd2d7aad7b1602e32bc8205489ac0 Reviewed-on: https://chromium-review.googlesource.com/738773Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#512771}
-
Scott Graham authored
Includes https://fuchsia-review.googlesource.com/c/zircon/+/80476 which should make time work on ARM64. Bug: 779668 Change-Id: I1488b2e595f6f2f0159ed6662f31dc6f8ef8f2d1 TBR: kmarshall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/746027 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512770}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca564c07..19ada67d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic86daa849f8584dc8be6e764e7dfa94122c3f88e Reviewed-on: https://chromium-review.googlesource.com/746361Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512769}
-
Hiroki Nakagawa authored
Bug: 738769 Change-Id: I8e15f7c05d64a98e6fdd7e3b69e2047902e04aad Reviewed-on: https://chromium-review.googlesource.com/694723Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#512768}
-
Joel Hockey authored
Bug: Change-Id: I1fffda120fd4ad18437501e55a5ea01bbb3a0086 Reviewed-on: https://chromium-review.googlesource.com/746050 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#512767}
-
Trent Apted authored
It flakes out on 10.10 (only) at a sufficiently annoying rate. TBR=tapted@chromium.org,ellyjones@chromium.org Bug: 777247 Change-Id: I01fb8f576804f76f419976825d68c711aa81d964 Reviewed-on: https://chromium-review.googlesource.com/746382 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#512766}
-
Makoto Shimazu authored
TBR=dougarnett@chromium.org Bug: 779934, 773834 Change-Id: I40632e362538aee524161b5d1fa9bcd824273dfa Reviewed-on: https://chromium-review.googlesource.com/746063Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512765}
-
Takashi Toyoshima authored
WTF::Optional is just an alias of base::Optional for some valid use cases, but it does not compile for use cases that are not compatible with Oilpan. To take the advantage of this safe type check, we should use WTF::Optional in Blink core instead of direct use of base::Optional. Also base::Optional in Blink core causes presubmit check errors. Change-Id: Ie5b97645cccccbef3464c0d07e3a95d3135cd9d9 Reviewed-on: https://chromium-review.googlesource.com/743821Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#512764}
-
Trent Apted authored
This fails on 10.10 only because the system bold font doesn't change its width enough to cause the test expecations to fail. But we don't care about styled LabelButtons on Mac -- just MdTextButton, so just disable on Mac. TBR=ellyjones@chromium.org Bug: 779937 Change-Id: I941c6b0ce9ee7bd6e4794519c7a6129e0dace7d5 Reviewed-on: https://chromium-review.googlesource.com/746064Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#512763}
-
Gregory Chatzinoff authored
Adds a feature flag to control whether the canonical URL is shared. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5b70667ab1743af8ea5845f541dfc0f621ba9314 Reviewed-on: https://chromium-review.googlesource.com/744973 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#512762}
-