GitLab

Revert of Start calling show/hide onStart/onStop in DocumentActivity (patchset #1 id:1 of https://codereview.chromium.org/1455343002/ )

Reason for revert:
BUG=559197

This was causing an early tab.show call which made the test think the activity is in the foreground.

Reverting my CL for now. Will have to figure out a proper way to hide/show to reland.

Original issue's description:
> Start calling show/hide onStart/onStop in DocumentActivity
>
> This logic in documents diverge from CHromeActivity behavior for
> archaic reasons (crbug.com/451672). Making documents show/hide
> in the same time as all other ChromeActivities with this change.
> Verified that the previous bug that caused the bheavior divergence
> no longer exists after this CL.
>
> BUG=546182
>
> Committed: https://crrev.com/e548d4580bbd915716a855f9195b6f5f2d63d2a1
> Cr-Commit-Position: refs/heads/master@{#360581}

TBR=dfalcantara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=546182

Review URL: https://codereview.chromium.org/1464313003

Cr-Commit-Position: refs/heads/master@{#361223}

R=michaelpg@chromium.org,apacible@chromium.org
TBR=isherman@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1468623004

Cr-Commit-Position: refs/heads/master@{#361222}

The internal Attribute and AttributeCollection need not know anything
about the web-exposed Attr.

Since Attr::qualifiedName() is not just a trivial getter, calling that
outside of the loop is probably a good idea anyway.

Review URL: https://codereview.chromium.org/1467143004

Cr-Commit-Position: refs/heads/master@{#361221}

BUG=internal b/21639416

Review URL: https://codereview.chromium.org/1473003002

Cr-Commit-Position: refs/heads/master@{#361220}

This problem was already fixed in r360646, but was broken again due
incorrect merge in r361205.

TBR=kelvinp@chromium.org

Review URL: https://codereview.chromium.org/1468283002

Cr-Commit-Position: refs/heads/master@{#361219}

If the frame that called the chrome.webstore.install method to begin an
inline install gets deleted before the user accepts from the dialog, we
don't want the install to continue because a navigation could make it
look like the install request was coming from some unrelated site.

One downside of this approach is that the dialog stays around even after
the frame is deleted, and hitting either accept or cancel buttons both
just cancel the install. It would be better if the dialog is
automatically cancelled, but doing that would involve a lot more
refactoring. The approach in this CL was easier and is probably worth
getting out, and we can improve on it in the future.

BUG=550047

Review URL: https://codereview.chromium.org/1403293008

Cr-Commit-Position: refs/heads/master@{#361218}

One layout test needs rebaselining with the next Skia roll:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/79661/layout-test-results/results.html

BUG=559240
NOTRY=true
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1468053003 .

Cr-Commit-Position: refs/heads/master@{#361217}

This fixes a bunch of positioning and cropped selection bugs.

BUG=548087

Review URL: https://codereview.chromium.org/1461783003

Cr-Commit-Position: refs/heads/master@{#361216}

Force full invalidation after layoutScope.setNeedsLayout() in PaintLayerScrollableArea::finalizeScrollDimensions()

This is a partial revert of https://codereview.chromium.org/799093002
which caused the bug.

This is a temporary measure to workaround crbug.com/560418
for crbug.com/535161.

BUG=535161,560418

Review URL: https://codereview.chromium.org/1471453002

Cr-Commit-Position: refs/heads/master@{#361215}

WKWebView sets the title to blank when the web process dies; ignore that
update so that the navigation item won't end up with a blank title.

BUG=558178

Review URL: https://codereview.chromium.org/1461413004

Cr-Commit-Position: refs/heads/master@{#361214}

Add info to the network part of the timeline flamechart.

BUG=528489

Review URL: https://codereview.chromium.org/1463393003

Cr-Commit-Position: refs/heads/master@{#361213}

SecTrust API is used to make load/no-load decision for certs, while
CertVerifier is used to get rejection reason. Using CRLSets to get
rejection reason is impractical, because iOS blacklist is very
different from Chrome blacklist as well as cost to store CRLSets on
disk is very high.

BUG=None

Review URL: https://codereview.chromium.org/1465513002

Cr-Commit-Position: refs/heads/master@{#361212}

This also makes //win8/* pass "gn check".

BUG=512864,512869

Review URL: https://codereview.chromium.org/1464263003

Cr-Commit-Position: refs/heads/master@{#361211}

Cryptohome does not report this action. We can remove it from
extract_actions.py.
The action is also marked as deprecated in actions.xml.

BUG=560497

Review URL: https://codereview.chromium.org/1470083002

Cr-Commit-Position: refs/heads/master@{#361210}

- only do scrollIntoViewIfNeeded() in a rAF callback to avoid forcing layout;
- get rid of TreeElement.onreveal() as most implementation were a no-op just
    repeating what the call site has already done;
- added `center' parameter to TreeElement.reveal()
- do not center when scrolling with keyboard or searching;

BUG=

Review URL: https://codereview.chromium.org/1461283004

Cr-Commit-Position: refs/heads/master@{#361209}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/01158a14..437819f9

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1470003003

Cr-Commit-Position: refs/heads/master@{#361208}

The InputHandlerProxy in content/renderer implements the logic for
sending the intercepted web input events to the compositor. Move this
logic to ui to be used by mus/blimp.

BUG=550531

Review URL: https://codereview.chromium.org/1415953004

Cr-Commit-Position: refs/heads/master@{#361207}

This is never used outside of //content.

BUG=376003

Review URL: https://codereview.chromium.org/1463013003

Cr-Commit-Position: refs/heads/master@{#361206}

VideoFramePump will not be used for WebRTC-based connection. In a separate
change I plan to move creation of the VideoFramePump to IceConnectionToHost
so the host layer will not need to know when VideoFramePump needs to be
used.

Review URL: https://codereview.chromium.org/1462063004

Cr-Commit-Position: refs/heads/master@{#361205}

pkg_config can't be nested inside a source set. pull out in
media/audio/BUILD.gn

BUG=559487

Review URL: https://codereview.chromium.org/1467843002

Cr-Commit-Position: refs/heads/master@{#361204}

Review URL: https://codereview.chromium.org/1470783003

Cr-Commit-Position: refs/heads/master@{#361203}

BUG=295792
TBR=zmo@chromium.org,jmadill@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1469173002

Cr-Commit-Position: refs/heads/master@{#361202}

This feature is only operative on OS X 10.10 and later, as directed by
CrashpadClient::StartHandler(). This limitation is enforced because the
handler restarter can cause the browser process to become an unreapable
pseudo-zombie on earlier OS versions if it crashes while a handler
restart is pending.

Review URL: https://codereview.chromium.org/1470073002

Cr-Commit-Position: refs/heads/master@{#361201}

Destructuring will be turned on soon in v8, and that will cause
these three tests to start "failing" (though they're actually passing
more, since we support new syntax). Will rebaseline them after the
change rolls successfully into Chromium.

BUG=560503
TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/1471653005 .

Cr-Commit-Position: refs/heads/master@{#361200}

Rename the internal NormalizingConsumer to SVGPathNormalizer and move
the class declaration to SVGPathParser.h. This will allow simplifying
the "path processor" (SVGPathParser) a bit in later CLs.
Also modify the normalizer so that it normalizes into a new
PathSegmentData, to make it more "stackable" and reusable.

BUG=467592

Review URL: https://codereview.chromium.org/1472853005

Cr-Commit-Position: refs/heads/master@{#361199}

This makes it so that the command will always produce the same output
given the same inputs.

BUG=

Review URL: https://codereview.chromium.org/1452843002

Cr-Commit-Position: refs/heads/master@{#361198}

Using a sysroot was already the default for official
build and when cross compiling (e.g. arm, mips, x86-32).
This change makes it the default in all cases.

The old behavior of building against local
system libraries can still be achieved by
setting use_sysroot=0

BUG=504446

Review URL: https://codereview.chromium.org/1464983003

Cr-Commit-Position: refs/heads/master@{#361197}

isolate it to skia/ext/ for simpler refactoring.

I took the opportunity to also change calls to the deprecated
SkCanvas::getDeviceSize() to the preferred replacement,
SkCanvas::getBaseLayerSize().

R=fmalita@chromium.org,junov@chromium.org
BUG=543755
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1432443004

Cr-Commit-Position: refs/heads/master@{#361196}

It is now legal for Blink to provide an implementation of cc::LayerClient.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/1468753002

Cr-Commit-Position: refs/heads/master@{#361195}

Doing this prevents us from logging bogus values (for duplicate and could_fire) in case of failure.

BUG=559143

Review URL: https://codereview.chromium.org/1465533006

Cr-Commit-Position: refs/heads/master@{#361194}

This guarantees that any throttling-specific errors do no affect no-throttling scenario.

BUG=none

Review URL: https://codereview.chromium.org/1461403003

Cr-Commit-Position: refs/heads/master@{#361193}

Allow usage of |std::begin| and |std::end|. This is useful for iterating
fixed-size arrays.

Discussion thread: https://groups.google.com/a/chromium.org/d/topic/cxx/5iFNE8P5qT4/discussion

Furthermore, this CL replaces home-brewn |std::end|-like functions in
base/trace_event with |std::end| to verify that <iterator> is supported
on all platforms.

Review URL: https://codereview.chromium.org/1471683002

Cr-Commit-Position: refs/heads/master@{#361192}

net::TCPServerSocket::Listen will close its internal socket if it fails
to bind and begin listening. This leaves the extensions socket object in
a bad state. Instead reset the socket so that an application can try to
bind it again.

BUG=559368

Review URL: https://codereview.chromium.org/1463293004

Cr-Commit-Position: refs/heads/master@{#361191}

The action uses the NaCl IRT files as inputs, but lacks the
necessary dependencies on the the targets that build them.

BUG= 512869
R=dpranke@chromium.org, gab@chromium.org

Review URL: https://codereview.chromium.org/1460113002

Cr-Commit-Position: refs/heads/master@{#361190}

BUG=559530
NOTRY=true

Review URL: https://codereview.chromium.org/1470023002

Cr-Commit-Position: refs/heads/master@{#361189}

This bug reproduces at times with multiple monitors and occurs when our attempt to
retrieve the taskbar edge information via the ABM_GETAUTOHIDEBAR appbar message fails.
msdn recommends using the ABM_GETAUTOHIDEBAREX call with the monitor rectangle for the multiple
monitor case. However that does not work.

The following fallback does work though.
1. Query for the auto hide status of the taskbar.
2. Retrieve its position and check if the edge information returned in this call matches the
   edge we are looking for. This along with the monitor check is sufficient.

BUG=472139
TEST=Set taskbar to autohide. Connect multiple monitors to the machine and start chrome on the
primary monitor and attempt to reproduce this case. If it does not repro then move chrome to
the other monitor and attempt the test case. If that fails, disconnect the secondary monitor
exit chrome and try. One of these cases should reproduce the problem.

Review URL: https://codereview.chromium.org/1462373003

Cr-Commit-Position: refs/heads/master@{#361188}

cl/1436373002 removed this field from the response, which created
inconsistent behavior between service_discovery_client_impl.cc
and service_discovery_client_mac.mm.

Also added test expectations to catch the regression.

BUG=560448
R=vitalybuka@chromium.org
CC=wez@chromium.org

Review URL: https://codereview.chromium.org/1467393002

Cr-Commit-Position: refs/heads/master@{#361187}

BUG=559338

Review URL: https://codereview.chromium.org/1469503002

Cr-Commit-Position: refs/heads/master@{#361186}

Telemetry's find_dependencies has reached the end of its deprecation cycle, and
the version in tools/perf is now the recommended one to use.

BUG=528331

Review URL: https://codereview.chromium.org/1472923003

Cr-Commit-Position: refs/heads/master@{#361185}

BUG=

Review URL: https://codereview.chromium.org/1465283002

Cr-Commit-Position: refs/heads/master@{#361184}