- 22 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dcc28c9f5a3d..9f82884d032c 2020-09-22 alexrudenko@chromium.org Fix the color of selected breadcrumbs in Elements panel 2020-09-22 tvanderlippe@chromium.org Add isRequestFilteredOut function for layout tests 2020-09-22 liviurau@chromium.org Whitespace to trigger builders 2020-09-22 alexrudenko@chromium.org Add focus outline to checkboxes in Layout panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9af8eb7d56eb7db961bac29015738a18cab35190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809348}
-
Raymond Toy authored
The debugging in https://chromium-review.googlesource.com/c/chromium/src/+/2411424 doesn't provide any new information. Thus, change the DCHECKs into CHECKs to see if something is out-of-bounds. Only do this for a short time and revert if nothing is found since this has performance implications. Bug: 1116104 Change-Id: I89c385c24694de5c01edd6a3856743a658282d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422890 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809347}
-
Anupam Snigdha authored
This change added width and height of the virtual keyboard rectangle to the CSS environment variables reported in the geometrychange event defined for VK. This was a feedback from TAG review as well as from web devs who are experimenting with VK APIs. https://github.com/w3ctag/design-reviews/issues/507 Bug:1127746 Change-Id: Ib3eaefa4f92b5e7482f30c0c6643ccd470728a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422701Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809346}
-
Viktor Semeniuk authored
This change adds string for timestamp with the last time issues were found. Bug: 1075494 Change-Id: Iedc0afa38bb690d44bc937d6c43e1a552c7f6a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362752 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#809345}
-
Dominique Fauteux-Chapleau authored
This should not change deep scanning behaviour with Connectors. Bug: 1103390 Change-Id: Ie96093e3eb654f8b68d20d287d7786b73641a6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410538Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#809344}
-
Olivier Yiptong authored
Small code cleanup: the temporary structure declared in the base FontEnumerationCache class is moved to the Windows implementing class, FontEnumerationCacheWin, because it's the only class that uses it. Bug: 1043306 Change-Id: Ia6145f26a223d64a79920042c57e231eca575fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422470 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809343}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600689096-6bb040ccfec21a14348d3421fe3415a00ad5226f.profdata to chrome-win64-master-1600754349-e20db2f8d281c7f1a24165725105bb03ea6ece36.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia548b30b8ce73c6ea1f075f3e2d61a67aa7873d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423532Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600678560-73f022cb15ffdf2af0536df3a108de473267405b.profdata to chrome-win32-master-1600754349-faa1edece0f28695a43c5cb3d7e6ca8a741e4346.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic8cf5a8265865527b1c67bcec43bc5d296f91f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423529Reviewed-by:
-
Jonathan Ross authored
This reverts commit ff8d2bea. Reason for revert: This change was temporary to unblock https://chromium-review.googlesource.com/c/chromium/src/+/2422181 which has now landed. Original change's description: > Temporarily re-add content/renderer/input/OWNERS > > When content/renderer/input was moved[1] it removed the OWNERS file. However > content/renderer/android/OWNERS lists it as a dependency. > > This leads to any changes to content/renderer/android to fail presubmit, due to > the missing file. This includes changes to remove that dependency in the OWNERS. > > This change temporarily re-adds the file so that the dependency can be removed. > > Removing the dependency will be done in a follow-up[2]. After which this change will be reverted. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2411941 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/2422181/ > > Bug: 1097816 > Change-Id: Ic318ebdd5c9e845afb6047776a2b9ebb0b5d746a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422141 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809307} TBR=danakj@chromium.org,jonross@chromium.org,dtapuska@chromium.org Change-Id: Ia0354dc195f82ecde02548b31194e2d64bab7e5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424384Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#809340}
-
Palak Agarwal authored
WebRtcVideoCaptureServiceEnumerationBrowserTest. AddingAndRemovingVirtualDeviceTriggersMediaElementOnDeviceChange is flaky on ChromeOS. Bug: 1126373 Change-Id: I60a41db047d73d45cc3075130fda47ff9977fb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421499 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#809339}
-
Clemens Arbesser authored
Instead, users will be able to swipe down the sheet to dismiss the lite script entirely. Example video is in the linked bug. Bug: b/168706237 Change-Id: Ib0e584bd4186a861cde045aa3a9e8938858009b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421892 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809338}
-
Leonard Grey authored
This reverts commit 28310fb5. Reason for revert: [Sheriff] Failing deterministically on ios-simulator-noncq Example: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/12130 Original change's description: > Remove updatesCollectionView from grid view controller. > > In order to allow the tab thumbnails to be up to date when the thumb > strip is visible, the grid's collection view needs to be updated even > when other view controllers are obscuring it. When selecting a new item > from the collection view (blue highlight around the thumbnail), the item > that is currently selected needs to be deselected to prevent multiple > simultaneous selection. > > Bug: 1127604 > Change-Id: Ic1e4a2dd4d0f2c269031b9d27b47b38c56b07a40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410494 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Roberto Moura <mouraroberto@google.com> > Auto-Submit: Roberto Moura <mouraroberto@google.com> > Cr-Commit-Position: refs/heads/master@{#809263} TBR=gambard@chromium.org,mouraroberto@google.com Change-Id: Ia7c8b2a2946424754838f5d2fdcd76d203745e59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423170Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#809337}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 627dabbe. With Chromium commits locally applied on WPT: 434c646e "[mathml] Make math display values on pseudo elements compute to flow" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Idcc99809bdf90783e2e8ced3d63e6c32777ec134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424063Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809336}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6a7c1f2e304e..ac231dd664d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: lgrey@google.com,rsorokin@google.com Change-Id: Ia57edf658d69e21b566aece1a0ed74350b901d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423970Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809335}
-
Maksim Sisov authored
This is a reland of fa06bf45 Fix: disable CloseWithAppMenuOpen for lacros. See https://crbug.com/1126339 Original change's description: > ozone/wayland: gracefully shutdown the browser on protocol error. > > Wayland may disconnect the client if it hits an unrecoverable > error. That is, it prints an error message and client cannot > do anything about that after that except shutting itself down. > > Thus, while watching the display fd, always check for errors. If > a protocol error is set, trigger |shutdown_cb| and also stop > watching the fd. > > Bug: 1127278 > Change-Id: Ie324af93d455c0c83f8e75cdecfafe2254da1972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404931 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807775} Bug: 1127278, 1126339 Change-Id: I9c72d2f72b331d278ef0ece89e6954b6f3850e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416355 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#809334}
-
Alexander Surkov authored
--active-tab is a handy way to dump accessible tree of an active tab in a browser and allows to reduce bulky output from the browser UI. The selector is intended to be used in conjunction with other selectors, for example, ax_dump_tree --firefox --active-tab will dump accessible tree of a selected tab in Firefox browser. Bug: 1124366 Change-Id: I5ddfa333d44d0e854e5b38d98f52e226a9a53e06 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416773Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#809333}
-
Peter Qiu authored
Required for supporting GpuMemoryBuffer backed by NV12 dmabuf. Bug: b/166284508 Test: Manually on cast device Change-Id: I18201b53fbd77e0f1e4c4947a346b68ee6895eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417508 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809332}
-
Hua, Chunbo authored
Bug: 880486 Change-Id: Ia10f8917c02adff50747ad722a8d8a2174edbba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422325Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#809331}
-
Eugene But authored
The data is retrieved from PreviousSessionInfo singleton and includes the following fields: - free_disk_in_kb - memory_warning_in_progress Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2414784 Bug: 1103752 Change-Id: I6e9b543be19634d08596a4b83368d800605c9cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422143 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809330}
-
Sigurd Schneider authored
This CL adds the IO agent to all kinds of workers. Bug: chromium:1069378 Change-Id: Ic8ad45f2c9f5a19a81c6ac8231871e1a087a952c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421369 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#809329}
-
Etienne Pierre-doray authored
To let the user do special handling on the main thread e.g. Scavenging uses different tracing categories for background/foreground threads. Change-Id: I001b669e318bf88f39358ddb96482ec5ed4b62a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418986Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#809328}
-
Aaron Krajeski authored
CanvasResourceProvider::CreateSharedImageProvider receives a weak pointer to the ContextProviderWrapper and returns nullptr if it does not exist. Unfortunately SharedGpuContext::IsGpuCompositingEnabled can re-create the ContextProviderWrapper after this check happens, leading to potential use-after-frees. To me it simply makes the most sense to not create a CRP if context is lost, as the created provider would be invalid and nullptr would get returned anyway. Bug: 1126424 Change-Id: Ic92709d7a38d94e5e7529efac3a09405d64eaa34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417097Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809327}
-
Sahel Sharify authored
Before: PaymentRequestSpec.java stores duplicates of payment details to be used in its getters. This is error prone since the variables on c++ side and their duplicates on java side need to kept synced. After: PaymentRequestSpec.java always retrieves most updated payment details from c++ implementation. Bug: 1129708 Change-Id: Ia106446bc08e91a6fcdcfc3875f078d2fd6ed6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417543Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#809326}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600754349-f2bf1ecbd6b189476a5e50362abd5d7f8ec183c4.profdata to chrome-mac-master-1600775907-1d0a614b540ad15c6823911f93c081428c564ce9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4e376d4a9d268a7b8c1fd301fb7b5f6e9ca4715c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423967Reviewed-by:
-
Esmael El-Moslimany authored
When removing a download entry, a toast is shown. Some download entries are considered dangerous or to be mixed content. Those entries can be removed. Undo can bring back what was removed, but this does not include dangerous or mixed content entries. This CL hides the undo button if the single entry removed is dangerous or mixed content. Or in the case for clear all, if all entries are dangerous or mixed content, the undo button is also not shown in the toast. Bug: 1116329 Change-Id: If4cb9dc81764c6e8bce7329267aa95fd477e20ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416741Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809324}
-
Lukasz Anforowicz authored
This CL excludes from the rewrite source code in directories that contain the following substrings: third_party/blink/ /renderer/ Bug: 1069567 Change-Id: I11e05452418eed416dbf1f6787333f9b4dfe89cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416402Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#809323}
-
Mugdha Lakhani authored
Add TODOs for web platform support tasks which are being tracked by a shared label for easy tracking. Bug: None Change-Id: I84b24f9582b734e6a36bc5dd7e443a7e2d7f9669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424143 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809322}
-
Aaron Leventhal authored
Previously, the document lifecycle changed at least once per node that is either dirty or an event source, during SendPendingAccessibilityEvents(). This updates SendPendingAccessibilityEvents() to only update the main document and popup document lifecycles only once. In addition, detailed DCHECKs are performed to ensure that the layout layout tree state is up to date for each node accessed during this process. AX-Relnotes: n/a Bug: None Change-Id: I45cdcb1c03e5284c43fd94a8c5ac4d58d837566f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187136 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Found while doing an audit of WebContents::GetMainFrame(). web_contents->GetMainFrame()->GetParent() will always return null. Change-Id: Idc5d2ed719a400a300198b9c36ab4e3307934556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422440 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#809320}
-
Jonathan Ross authored
Currently content/renderer/android/OWNERS lists a dependency on content/renderer/input which was removed. That owner file is being temporarily re-added[1]. As without it all changes to content/renderer/android fail, including updating the owners file. This change removes the dependency, and places dtapuska@ as an OWNER. This will be followed by a revert of the temporary re-add of content/renderer/input/OWNERS [1] https://chromium-review.googlesource.com/c/chromium/src/+/2422141/ Bug: 1097816 Change-Id: I06a554dc52dfd9820048eb14af79163db97e40ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422181Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#809319}
-
Sky Malice authored
Adding skym@ and wenyufu@, who have recently made feature modifications to the firstrun. Removing yusufo@ who is not currently making changes in this space and is also an OWNER in a parent folder anyways. Change-Id: I9343df6eb96a52fa3e381b9859ec8c2198485a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417300Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#809318}
-
Boris Sazonov authored
Fixes two separate issues with the unconsented primary account sign-out flow within PrimaryAccountMutator and PrimaryAccountManager: 1. Check HasUnconsentedPrimaryAccount in PrimaryAccountMutator so that the PrimaryAccountManager::SignOutXYZ is actually invoked even if there's no sync consent. 2. Make sure PrimaryAccountMutator calls GoogleSignedOut using a correct account info - before this change, it would be invoked with an empty account info if there's no sync consent. Bug: 1130526 Change-Id: I9019faeb602a32a499ae7fd3cab09f5634fc69ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421739 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809317}
-
Joshua Pawlicki authored
This data is already sent in the <app> element, but sending it in <request> ties it to the updater and enables Omaha's cross-product monitoring and logging to be more aware of this updater. Bug: 1110339 Change-Id: Ib4ec718a281664e3732f6ca060be7300902fa1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418474 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#809316}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/566821cb0e58..44623aeccd06 2020-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 60ce96e2ff10 to 125b64241909 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I76a9dd1465dd6a584a565dc6764b8859affb0d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423542Reviewed-by:
-
Vladimir Levin authored
This patch ensures that we don't try and update assignments if the layout view is locked in its parent frame. If the view is locked, it means that we skipped processing prepaint for it, which means that the contents here might not have the LocalBorderBoxProperties (created during prepaint). However, the assignment needs the properties to do its work. Since the frame walk here is unconditional, there is no need to keep track of the dirty bit flags, as long as we don't clear the flags on the compositor itself. This is similar to how the throttling logic behaves. R=chrishtr@chromium.org Bug: 1128790 Change-Id: Ic325b618161c68d5886d0a5c0926cbd29e81d38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422265 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#809314}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600754349-bb0b36845adda8f601cf43d9095b0eb5c5334e61.profdata to chrome-linux-master-1600775907-52df3750a6dec0d6a74672a50b3faa88175a1e9e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ibbad7da619409ff8fc0365cfdab25f45ac3291de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423968Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I73e93914aedf3fcce9a61766c21f91973e709358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423406Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809312}
-
Aaron Leventhal authored
Do not create or initialize accessibility objects at the wrong time. Bug: 1125186 Change-Id: I14110615efb4e18a22ebccf2e67b64ce6f258e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399317Reviewed-by:
-
Antonio Gomes authored
This header is included by pepper and chromecast code, and won't move out of the Blink API any soon. BUG=787252 R=guidou@chromium.org, haraken@chromium.org TBR=spang@chromium.org Change-Id: I7bc274541ef242cf6146b9988b7c29cf10869145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418798 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
-
Aaron Krajeski authored
Merging this CL with TODOs to keep this CL small. TODOs: - Single radius version of function called without an array - Accept generic dictionaries with "x" and "y" values as arguments - Add WPT tests Bug: 1123971 Change-Id: I41816beca0678b7df873310d16f826f2f3ed5e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388151Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809309}
-
