- 14 Jul, 2017 40 commits
-
-
mrefaat authored
Set the pendingItemIndex to the last committed item in case of page reload and on the case of application open/tab out of memory reopened. This doesn't solve the PendingItem being null problem entirely there are still couple cases when that can happen and they are not page reloads. CL 1/2 BUG=676129 Review-Url: https://codereview.chromium.org/2931833004 Cr-Commit-Position: refs/heads/master@{#486777}
-
Elly Fong-Jones authored
This code only works when USE_AURA, which is when gfx::NativeView is an aura::Window. BUG=None Change-Id: I6fd619acb4bcf854a111d43295ed20186d47f872 Reviewed-on: https://chromium-review.googlesource.com/565300 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#486776}
-
Emil A Eklund authored
In r484771 the painting logic for table cells and rows with a background image was inadvertently changed as a part of a refactoring. This in turn led to the wrong ImageClient being used in cases where the background is set on the table row as opposed to the cell. The bug was introduced between patch set 3 and 4 of the original change. This CL restores the original behavior by using the correct ImageClient. TEST=fast/table/backgr_on_table_row.html BUG=742053 R=pdr@chromium.org Change-Id: I7316ddf34698ba78d43067dd46610ece628ef7fe Reviewed-on: https://chromium-review.googlesource.com/571158 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486775}
-
Tim Volodine authored
In this patch: - Refactoring in order to use a PrefService for obtaining and updating the preference values related to the interstitials. - Use the pref service for setting the default values (for the display options). - Enable user opt-in (using a check box) for the extended reporting when the interstitial is shown. - Update AwSafeBrowsingUIManager::SetExtendedReportingAllowed to modify the corresponding PrefService preference (instead of keeping a boolean inside the class). BUG=700351, 688629 Change-Id: Ifa2e2c692670213e792d05c5d3cb0ba7facc74f7 Reviewed-on: https://chromium-review.googlesource.com/567144Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#486774}
-
Mostyn Bramley-Moore authored
BUG=741927,735587 Change-Id: Ib95bd85e2f1ad14e27ba8fa76f8b52f8e137e830 Reviewed-on: https://chromium-review.googlesource.com/569159Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#486773}
-
Edward Lemur authored
This will make it easier to control what's being updated. Bug: None Change-Id: Ic8509707f1c6448aa897345bd3ea85d1a38bec9e Reviewed-on: https://chromium-review.googlesource.com/570399Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#486772}
-
Jonathan authored
One third of CQ runs of mash_browser_tests are failing when hitting the NOTREACHED in Compositor:DidFailToInitializeLayerTreeFrameSink so I'm disabling it while the cause is researched. TBR=sadrul@chromium.org TEST: mash_browser_tests Bug: 742966, 743028 Change-Id: I9363ebfbdeac594d26696b5426004cbafcec9c9b Reviewed-on: https://chromium-review.googlesource.com/571274Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#486771}
-
Wei-Yin Chen (陳威尹) authored
BUG=733500 Change-Id: Iee053126ab61bdb99ba78bdc74e720ff179febc6 Reviewed-on: https://chromium-review.googlesource.com/567729Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486770}
-
Michael Thiessen authored
Headset NFC scan can pause and resume (without stopping) us while we're already in VR, so we stay in VR while this is happening. However, when we get paused we want to cancel VR entry so we don't enter VR while paused. This CL just adds a check to see if we're in VR before attempting to cancel entry. Bug: 742509 Change-Id: Ib0cdac3c7e10e5206410835f949f318c73e9349f Reviewed-on: https://chromium-review.googlesource.com/570742Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#486769}
-
Dirk Pranke authored
This change may affect the following builders: - chromium.chromiumos - Linux ChromiumOS Builder - Linux ChromiumOS Builder (dbg) - Linux ChromiumOS Full - chromium.fyi - Mojo ChromiumOS - chromium.gpu.fyi - Linux ChromiumOS Builder - Linux ChromiumOS Ozone Builder - chromium.memory - Linux Chromium OS ASan LSan Builder - Linux Chromium OS ASan LSan Tests (1) - Linux ChromiumOS MSan Builder - Linux ChromiumOS MSan Tests (1) - tryserver.chromium.linux - linux_chromium_chromeos_asan_rel_ng - linux_chromium_chromeos_compile_dbg_ng - linux_chromium_chromeos_compile_rel_ng - linux_chromium_chromeos_dbg_ng - linux_chromium_chromeos_msan_rel_ng - linux_chromium_chromeos_ozone_rel_ng - linux_chromium_chromeos_rel_ng The main difference from the last attempt is that this version removes ash_unittests, ash_content_unittests, browser_tests, interactive_ui_tests, and unit_tests from the ASan LSan Tests config, as they appear to be all kinds of busted. From the original CL (crrev.com/7385c63e): > Ozone is now on by default on all CrOS builds, and we don't > need to test the old x11 config any more. This CL flips > all of the CrOS builders to (implicitly) be building for Ozone, > so that we can then remove the explicit Ozone builders in a > follow-up CL. > > This builder also removes the > linux_chromium_chromeos_ozone_rel_ng builder from the CQ > since would otherwise be redundant with the > linux_chromium_chromeos_rel_ng builder. > > This CL also removes a couple of commented-out CQ entries for > builders that were removed as part of the work in bug 669297 > (linux_chromium_chromeos_compile_dbg_ng and linux_chromium_clobber_rel_ng); > at the time I had planned to re-add them once the capacity > issues were resolved, but at this point it's unclear how > important those configs are and we may want to use the > capacity for other things, and so these comments were misleading. BUG=671355, 742623 R=kylechar@chromium.org TBR=achuith@chromium.org, xdai@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng,linux_chromium_chromeos_msan_rel_ng Change-Id: I27377846c8a7ad915b68ca99abb944de58631683 Reviewed-on: https://chromium-review.googlesource.com/571195Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486768}
-
Eric Seckler authored
Bug: Change-Id: I9b060df69df9893e65d90a58676d77bd3ec0da42 Reviewed-on: https://chromium-review.googlesource.com/571745Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#486767}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/2b918c8d05c9..57f228d75275 $ git log 2b918c8d0..57f228d75 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 janeliulwq Updated pdfium_test's WriteAnnot() 2017-07-14 npm More unique_ptrs in JBIG2 code part 2 Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I436579b6010f9dac42382eff322824ce7fbdd6ee Reviewed-on: https://chromium-review.googlesource.com/571848 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486766}
-
Dominic Battre authored
This CL introduces a new UKM metric User.ActionSimplified that corresponds to what is recorded in PasswordManagerActionsV3. I have called it ActionSimplified because I want to introduce a more detailed action but don't know whether I can build that before the branch point. Bug: 732846 Change-Id: I766ec456de100e93b61a63c0ede6fd65dbd36156 Reviewed-on: https://chromium-review.googlesource.com/571003Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#486765}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/90038eee6f25..b63abe05c654 $ git log 90038eee6..b63abe05c --date=short --no-merges --format='%ad %ae %s' 2017-07-14 xunjieli [wpr-go] fix content-encoding check Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5b3512ed3221aae77be46dc5b2a197a6a6dc09e6 Reviewed-on: https://chromium-review.googlesource.com/571502 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486764}
-
ymalik authored
This CL starts CTA for VR with a custom animation to keep it hidden while we enter VR mode. This is needed to hide the 2D Chrome UI while the phone is already in the VR headset (e.g when we're deep-linking from Daydream). The animation alone is not sufficient, so we add a black overlay until we're ready to show the WebVR page. BUG=721857 Review-Url: https://codereview.chromium.org/2969923002 Cr-Commit-Position: refs/heads/master@{#486763}
-
huangs authored
This CL adds main_utils.*, which has the framework to dispatch Zucchini commands and print help messages. This is used by the Zucchini main program, and is not part of Zucchini library. - Add ::Command: A struct containing command name (e.g., "-gen", "-apply"), help message, and a base::Callback containing code for the main command. This allows Zucchini command dispatch without bulky bulky class hierarchy and superfluous instantialization. - Add ::CommandRegistry: A class to manage ::Command instances and dispatch commands, or print help messages. - Add ::ResourceUsageTracker: A class instantiated in main() to track resource usage for valid command invocations, and and print them at end. Specifically: - Zucchini.PeakPagefileUsage (KiB) - Zucchini.PeakWorkingSetSize (KiB) - Zucchini.TotalTime (s) Also add "-quiet" switch to disable this. - Add stubs for Zucchini-gen and Zucchini-apply, to be populated later. - Starting to use LOG(INFO) to display output. This requires updating PRESUBMIT.py to add Zucchini as an exception. Bug: 729154 Change-Id: Id5263435100dc73b2d8917ca2bcd04245ed41934 Reviewed-on: https://chromium-review.googlesource.com/567492 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486762}
-
Bernhard Bauer authored
Bug: 741882 Change-Id: Iac67445a218dd98a3d0a21fdf79588d0682c94e9 Reviewed-on: https://chromium-review.googlesource.com/570168 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#486761}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/83d118550f72..cf79ee5626dd $ git log 83d118550..cf79ee562 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 rmistry Publish uploaded RecreateSKPs CL Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I49e94ec456b566d09c9708f326625548e70782bc Reviewed-on: https://chromium-review.googlesource.com/570733Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486760}
-
Hidehiko Abe authored
While migrating ArcService into BrowserContextKeyedService, it turned out the boilerplate looks much bigger than what we expected. To minimize it reasonably, this CL introduces ArcBrowserContextKeyedServiceFactoryBase and use it for already migrated service classes. BUG=739097 TEST=Ran trybot. Ran on DUT. Change-Id: I13a1e7019c06ea64fa48cec6ecf7a9e589e84b00 Reviewed-on: https://chromium-review.googlesource.com/569847Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486759}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a97abb90..3921afc2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iaa2269f32243c34ca9813ed72c2650a4ab3f34db Reviewed-on: https://chromium-review.googlesource.com/571271Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486758}
-
nednguyen authored
Bug: 742422 Change-Id: If2f10cf42ffad4c9767571b076242388d86c11c5 Reviewed-on: https://chromium-review.googlesource.com/570679 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#486757}
-
jdoerrie authored
This is a reland of 37c3e0b6 Original change's description: > Add Dictionary API to base::Value > > This change introduces |FindKey|, |FindKeyOfType|, |SetKey|, |DictEnd| and > |DictItems| to base::Value. These methods are part of the new API proposal and > abstract away the pointer based underlying storage of Dictionary Values. > > Bug: 646113 > Change-Id: I09150f3b2fd47e24074caa50a30a058fc4f558a7 > Reviewed-on: https://chromium-review.googlesource.com/561682 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486709} TBR=brettw@chromium.org Bug: 646113 Change-Id: I76ee2149f18da83474a16586ee77b8e6be185814 Reviewed-on: https://chromium-review.googlesource.com/571805Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#486756}
-
Alexei Svitkine (slow) authored
This reverts commit 34b11e87. Reason for revert: Causing crashes: crbug.com/742707 Original change's description: > Add the VariationsFieldTrialCreator class > > This is part 3 of 6 for FieldTrial refactoring for WebView > > Part 1: https://chromium-review.googlesource.com/c/562098/ > Part 2: https://chromium-review.googlesource.com/c/561920/ > Part 3: https://chromium-review.googlesource.com/c/561922/ > Part 4: https://chromium-review.googlesource.com/c/561980/ > Part 5: https://chromium-review.googlesource.com/c/562417/ > Part 6: https://chromium-review.googlesource.com/c/562021/ > > This CL creates the VariationsFieldTrialCreator class. This class > contains the code previously in VariationsService that > is needed by both Chrome and WebView, mainly the portions > needed to call CreateTrialsFromSeed. The VariationsService > class now contains an instance of this new class. > > BUG=678288 > > Change-Id: Ic4340d5a0396cca56892a3b541e4cf6115bb8afb > Reviewed-on: https://chromium-review.googlesource.com/561922 > Commit-Queue: Kyle Milka <kmilka@google.com> > Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486590} TBR=asvitkine@chromium.org,timav@chromium.org,paulmiller@chromium.org,kmilka@google.com Change-Id: Idf0f12b5bd6d1bb7edf41cbdc6f767f8790de6e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 678288 Reviewed-on: https://chromium-review.googlesource.com/571920Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#486755}
-
rbpotter authored
Add tests to verify print preview behaves as expected when the "Open PDF in Preview" link is clicked on MacOS, and when "Print with System Dialog" is clicked on Windows. Bug: 741341, 741528 Change-Id: I1174ec935eeea1b90e7853eb1e13d1fe3c596809 Reviewed-on: https://chromium-review.googlesource.com/570831 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486754}
-
Adam Rice authored
This CL was generated by running pyformat and then applying manual fixes to the result. The command-line used was: pyformat --indent_size=4 -r -i --force_quote_type single . Long comments, strings, if conditions and assignments that had been left behind by pyformat were manually broken to make the pep8 tool happy. There are still some things the pep8 tool complains about: * pyformat wraps to 80 columns, but pep8 wants lines to be at most 79 characters. 80-column lines have been left as-is as it doesn't seem worth fixing. * handshake-fail-by-maxlength_wsh.py and handshake-fail-by-prepended-null_wsh.py have copyright messages with lines longer than 80 columns. Not changed. Bug: 237056 Change-Id: I8ff73bc1e677975e1a99d86815971750b275a0a3 Reviewed-on: https://chromium-review.googlesource.com/570080Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#486753}
-
Michael van Ouwerkerk authored
Bug: 739664 Change-Id: I0f847bec2b9034206588aad4aedfc3703d49ee7c Reviewed-on: https://chromium-review.googlesource.com/571001 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486752}
-
Vaclav Brozek authored
Vasilii is the password manager team's expert on Objective C, knows password manager code thoroughly and has experience in iOS codebase as well. An ideal //ios/chrome/browser/passwords/OWNERS. Bug: None Change-Id: I5725b9da385fd73d97e71e8b9368841da3974130 Reviewed-on: https://chromium-review.googlesource.com/571224Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486751}
-
Bernhard Bauer authored
This works around an issue where in official builds of unit_tests the ThreadTaskRunnerHandle is null when calling into native code from Java. Bug: 739510 Change-Id: Ide93e67076f905d03a6a9271a812e49553dcf0d8 Reviewed-on: https://chromium-review.googlesource.com/570251Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486750}
-
Brian White authored
This is temporary to try to discover the source of the memory corruption and possible deduce where it is happening. Bug: 736675 Change-Id: I08f3b8cbfe1ae47b6872694300a7eb87c14fa7f0 Reviewed-on: https://chromium-review.googlesource.com/570458Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#486749}
-
Friedrich Horschig authored
Following Mac10.10, Mac10.11 broke, too. Mark flaky for all Mac platforms so sheriffs don't have to look for this when it hits Mac10.9. TBR=dcheng@chromium.org TBR_REASON=Update test expectations NOTRY=true Bug: 676229,742742 Change-Id: Iecda3eb55b891dc35ed47552b43786e80f9f4aa3 Reviewed-on: https://chromium-review.googlesource.com/571788Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#486748}
-
Becca Hughes authored
Record the Media Engagement score at playback to a histogram so we can see if the playback would have been blocked. BUG=740106 Change-Id: I7ed9659e64fd9ffcae3eafaccdf32e6755165ccb Reviewed-on: https://chromium-review.googlesource.com/566862 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#486747}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a29b8877..a97abb90 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I8f2f3087cca1f5aa2da0edeef6f65e6ed829bdd6 Reviewed-on: https://chromium-review.googlesource.com/571260Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486746}
-
Takashi Toyoshima authored
Current implementation dispatch MIDIConnectionEvent synchronously, but this should be done asynchronously according to the spec. BUG=735058 Change-Id: If49d588e36e092aa6fc40625fd88483c9ae1719d Reviewed-on: https://chromium-review.googlesource.com/545577 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486745}
-
dskiba authored
> Reason for revert: > This broke Win 64: > https://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder%20%28dbg%29&number=56316 > > Original issue's description: > > [tracing] Add heap profiler perftests. > > > > This CL creates a generic place for heap profiler perftests, and adds > > couple of stack frame deduplicator related perftests. > > > > BUG=739378 > > > > Review-Url: https://codereview.chromium.org/2976843002 > > Cr-Commit-Position: refs/heads/master@{#486544} > > Committed: https://chromium.googlesource.com/chromium/src/+/f43d398eac5c9d4c2bccda6d2630d108bbed1c99 > > TBR=primiano@chromium.org,dskiba@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=739378 > > Review-Url: https://codereview.chromium.org/2981833002 > Cr-Commit-Position: refs/heads/master@{#486555} TBR=primiano@chromium.org BUG=739378 Review-Url: https://codereview.chromium.org/2975133004 Cr-Commit-Position: refs/heads/master@{#486744}
-
Nicolas Dossou-gbete authored
In addition to the All Dismissed item, we now also hide the footer that holds the Learn More link and the space at the bottom of the NTP when remote suggestions are disabled. Bug: 721407 Change-Id: I660f627c0d6fb0f9370e9604437d43227a5dafae Reviewed-on: https://chromium-review.googlesource.com/570447 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486743}
-
Hector Dearman authored
A refactor (crrev.com/c/555497) I made to ProcessMetricsMemoryDumpProvider which split logic out by platform introduced a bug. The bug caused us to double count rss anon bytes and never count vm swap bytes when computing the 'private footprint' UMA on all processes on Linux and Android. This produced a large increase in those UMA metrics. This fixes the bug. Bug: 742958 Change-Id: I893774e95154f50be0f30698b17c01ec4bfbcb1d Reviewed-on: https://chromium-review.googlesource.com/571804 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486742}
-
Mounir Lamouri authored
Adding the necessary scaffolding to compute the CTR of media controls elements with as much precision as possible. This is not computing CTR using visibility to the user but hypothetical visibility on the page in the sense that the element was displayed in the controls but maybe never scrolled into view. In order for an element to be marked as displayed, the element has to have metadata downloaded or be set to not preload by the page or the browser. This CL also removes the CTR code for the download button and the cast overlay button given that this code is more precise and more generic. Bug: 651644 Change-Id: I86c2bc4d1a19ab99a211082d8b3546b79ea71144 Reviewed-on: https://chromium-review.googlesource.com/567194 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486741}
-
Hiroki Nakagawa authored
To improve code maintainability, this CL clarifies thread affinity of initialization and shutdown functions in worker classes. This does not change any existing behavior. Bug: 741227 Change-Id: I25fe7278130c90292b79cdd5607f10a0ef92f198 Reviewed-on: https://chromium-review.googlesource.com/567609 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#486740}
-
tommi authored
Revert of Override rtc::Event with Chromium's implementation (patchset #2 id:20001 of https://codereview.chromium.org/2975553002/ ) Reason for revert: Reverting temporarily until the webrtc change can be rolled with it. Original issue's description: > Preparation of overriding WebRTC's rtc::Event with Chromium's implementation. > This change will give WebRTC the benefits of Chromium's checks and integration with thread and sequence runners (e.g. io and waitable checks). > > Followup changes include enabling the code from the WebRTC side (requires build file changes) and integrating the TaskQueue implementation in Chromium with sequence runners. > > BUG=689520 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2975553002 > Cr-Commit-Position: refs/heads/master@{#486737} > Committed: https://chromium.googlesource.com/chromium/src/+/07019da77f12dc06fd8a2e66061c8a79c90bc439 TBR=grunell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689520 Review-Url: https://codereview.chromium.org/2981863002 Cr-Commit-Position: refs/heads/master@{#486739}
-
Rob Buis authored
Bug: 402536 Change-Id: I502447b230e2b587e4fd5f921be86053cf9830ed Reviewed-on: https://chromium-review.googlesource.com/568564Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#486738}
-