- 28 Oct, 2020 40 commits
-
-
Alice Wang authored
This CL cleans up criteria in account picker bottom sheet tests that use ambiguous views in the view state refactoring later. Bug: 1138824 Change-Id: Ibf8d3dcf40c5d387d2befbd90b89a114e09fbabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502429Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821735}
-
Shengfa Lin authored
No-Try: True Bug: 1123907 Change-Id: I5faf2a3bde9610df72062a888cb40c157a6ec623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505913Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#821734}
-
Regan Hsu authored
Currently, if the dialog does not receive a 'Connecting' status, it will not advance to the next state. This may happen if there is no bluetooth connection. This CL ensures that the dialog shows the next page upon requesting a connection instead of being stuck in the initial state. Bug: 1141596, 1106937 Change-Id: If671d9c3d5bf2561944707b5686f2dd4a71bb47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499368 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821733}
-
Fredrik Söderqvist authored
Since LayoutObject::SetStyle sets needs-paint-property-update based on StyleDifference we can rely on that and drop the double-work. Make changes to the 'mask' property also set the property-specific mask-changed flag to have it be handled by the generic code. Add LayoutSVGResourceContainer::StyleDidChange matching the tail of the folded function. Bug: 1028063 Change-Id: I010232520ec051e6df1bd21408ae64083d91900d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504314Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#821732}
-
Maggie Chen authored
The bug for CHECK_EQ() was fixed. Remove this TODO. Bug: 622080 Change-Id: I72dcd92171e73854b2be5c7c01a526a4bdb47f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504068 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821731}
-
Yuta Hijikata authored
Lacros team has decided to rename gn variable is_ash|lacros and macro IS_ASH|LACROS as is_chromeos_ash|lacros and IS_CHROMEOS_ASH|LACROS respectively. This is to make it clearer that these variables are Chrome OS related variables. Bug: 1052397 Change-Id: I7e74ef50af0695809340f9d3645de6487494334e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502061 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821730}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b14f2f6e971..270b5c04c234 2020-10-28 johnstiles@google.com Reland "Update the SkSL pool interface to take an allocation size." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I154224bd73ac03707297996f52bc3a8a38bc36cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821729}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/40c5681ab92e..804e625def2c 2020-10-28 wl@gnu.org [truetype] Minor update to forthcoming OpenType 1.8.4 standard. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I569a2e4cba118bdd0c446496b27e51c1f44c9f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505589Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821728}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84b39fecd0ec..d81fd3dbd55e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nicolaso@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1143238 Tbr: nicolaso@google.com,drott@google.com Change-Id: Iab3aea2f27b4f2974e629c3503059abbf48ff58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505731Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821727}
-
Mike Wittman authored
Top level Chrome owners don't have good insight into this code. Delegate ownership to the profiler owners. Change-Id: Ic64be4bbac1cea90af8cabbecb085aa1e1c1905b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499174Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821726}
-
Kushagra Sinha authored
This is a reland of c9feddbc Original change's description: > Fix use-after-move in AccountManager > > Fix use-after-move in chromeos::AccountManager::GetAccountEmailInternal > callback. > > Change-Id: I463165fe2e642ffed07c5c11c26984d99daf5815 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495060 > Reviewed-by: Anastasiia N <anastasiian@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820199} Change-Id: I84cd0a4c2737ff3544bcd8bae8a1418332475fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505889Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#821725}
-
Anders Hartvoll Ruud authored
An @scroll-timeline rule may reference elements with selector(#id) syntax. Whenever the element represented by the selector() function changes, the "effective" CSSScrollTimeline produced by the @scroll-timeline rule changes as well. This CL solves this problem by registering IdTargetObservers for the IDs a CSSScrollTimeline depends on. The IdTargetObservers are registered when at least one Animation is attached, and unregistered when the last Animation is detached. This is similar to how the ScrollTimeline itself is registered/ unregistered with the resolved scroll source when Animations attach/detach. Marking the animation target elements for style recalc (non-animation-style-change) means we'll re-evaluate the @scroll-timeline rule against the current DOM state, and consider whether or not we need a new CSSScrollTimeline for the animation. Bug: 1074052 Change-Id: Iab0c6b8d8b57d7d63283e97355ee5d9948b831a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356506 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821724}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603831993-ad45cd294d298c80e2b0aad0e49861b0d50b053b.profdata to chrome-win32-master-1603864709-4a33e3e79ae73b19f7bf177e8a5b86afe3924d66.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I645fe7febe6487f98f339a400b6f463a7e1a43c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505116Reviewed-by:
-
Steven Bennetts authored
The remaining code only cares about CaptivePortalStatus. This also eliminates the |service_path| argument from GetCaptivePortalState (now GetCaptivePortalStatus) which was unused, and eliminates per-network tracking of state/status in NetworkPortalDetectorImpl. TBR=msarda@chromium.org for minor change to identity_apitest.cc Bug: 1133369 Change-Id: I79bda2d4ec2654725ddad52cbf1f4285283001be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490669 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Kartik Hegde <khegde@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#821722}
-
Sorin Jianu authored
This allows COM RPC to call back during non-blocking object calls and eliminates the dependency on IUpdateObserver in the ControlServiceProxy. There are only two interface types in the IDL related to the ControlServiceProxy: IUpdaterControl and IUpdaterControlCallback. A future CL will split the IDL along that seam, to break the definition of public and internal updater interfaces. As a side issue, this CL is fixing a race condition on the ControlServiceProxy destruction. A list of interfaces is also provided to the setup and install code to avoid code duplication of a data structure which needs to match in those two cases. Bug: 1140562 Change-Id: Icfd07f0345a5068fcff8b44119508eb1ae68f0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500522Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821721}
-
sandromaggi authored
Bug: b/171782156 Change-Id: I032f22571e342e47a2d6c8b33ce735fab40acf88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504313 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#821720}
-
Rainhard Findling authored
Bug: 1087263,1139806 Change-Id: I2bafbcb8b9fdd9a806e7d5bef68d200dd025ab4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505137Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821719}
-
Mathias Bynens authored
Fixed: chromium:1143205 Change-Id: I95d7797c33c98de901b5c88904ddaac0e757df4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503695Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#821718}
-
Arthur Hemery authored
ProcessLock.ToString() has grown in size with information such as their cross-origin isolation status and locked origin. To be able to record the full information the crash keys need to be bumped to 256B. Bug: 1142391 Change-Id: Ibdedf81ef4315248337b323734c8241361a8fbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502331Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#821717}
-
Dominik Lang authored
Calling MemoryAllocatorDump::AsProtoInto was causing a DCHECK failure. Bug: 1098746 Change-Id: Iac11e583b7888dfe7e0b673bf47894f3ad038df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501481Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#821716}
-
arthursonzogni authored
The origin stored inside and outside blink uses a different convention for the "unspecified" port. ┌──────────────────┬───────────┐ │ port unspecified │ port zero │ ┌─────────────────────┼──────────────────┼───────────┤ │url::Origin │ -1 │ 0 │ ├─────────────────────┼──────────────────┼───────────┤ │blink::SecurityOrigin│ 0 │ 0 │ └─────────────────────┴──────────────────┴───────────┘ As a result, this property do not survive the conversion in between those types. This patch temporary provide different expectations, so that the fuzzer can continue to explore more cases. Fixed: 1143052 Bug: 1136678,1143052 Change-Id: Ibbc9f5757a190c52fdb0d8c26c0b98cc30f353fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505649Reviewed-by:Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821715}
-
Kuo-Hsin Yang authored
When the ram_vs_swap_weight file is not available, the ram_swap_weight varialbe is zero. CalculateAvailableMemoryUserSpaceKB uses the ram_swap_weight variable as denominator and crashes. Always set ram_swap_weight to non-zero value to avoid the dividing by zero issue. Bug: b/171033232 Change-Id: I82e2cfd28ea21e57f3e6dd40f8cd68ee9f265c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503914 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821714}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603864709-80e0b66faf89b1f5bb0f1645a135a447551ec59a.profdata to chrome-linux-master-1603884477-6bc4961628956c25c92dc091d1c24520abfa529f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5681402c6a80ddc7991aa2ad20388add906517b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505572Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ecbac8fd..3f40a48d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4204fafcf5c6ab5f671012317ad19b3994bae63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505450Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821712}
-
Oriol Brufau authored
NextVisuallyDistinctCandidateAlgorithm used to iterate forwards and return the first candidate whose MostForwardCaretPosition was different than the MostForwardCaretPosition of the original position. However, it could happen that the returned candidate and the original position had the same MostBackwardCaretPosition, leading to crashes. Therefore, this patch ensures that both the forward and backward caret positions of the candidate are different. And for consistency, the same is done for PreviousVisuallyDistinctCandidateAlgorithm, even though I couldn't find a problematic case. Bug: 1138054 TEST=VisibleUnitsTest.nextPositionOfTable Change-Id: I1e97e42765d58f5db70fb79410c8e471582a9d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501041 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821711}
-
Marc Treib authored
PasswordManager.SaveUIDismissalReason has a base version (without suffix), and also suffixed versions split by PasswordAccountStorageUserState. Before this CL, the split versions were only recorded if features::kEnablePasswordsAccountStorage was enabled. That didn't really make sense: Some of the UserStates don't exist without that feature, but for the remaining states, the split histograms still make sense. So this CL adds recording of these histograms for users with that feature disabled. Bug: 1142797 Change-Id: I969bfe48f2337377deba6f102208e0c59ddf2309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503519Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#821710}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603864709-845b29927599ab12682abdf7fcfbf1ec60b2364e.profdata to chrome-mac-master-1603884477-73d70e68a4c2b6db53055c0ce78d0123cab0e9a7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I08fb86dbd14cc49fa407dee5168b5148b0c9ce02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505571Reviewed-by:
-
Aya ElAttar authored
Given that ClipboardDataEndpoint and ClipboardDlpController will be used for both clipboard and drag&drop, so - Used DataTransfer prefix instead as it refers to both; drag&drop and clipboard. - Renamed ClipboardDataEndpoint to DataTransferEndpoint. - Renamed ClipboardDlpController to DataTransferPolicyController. - Renamed EnterpriseClipboardDlpController to DataTransferDlpController. Bug: 1141488 Change-Id: Ib9a5be48384c6bc04a8bfd0de02b78652d9930a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489889 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#821708}
-
Sadrul Habib Chowdhury authored
The bugs for cc/metrics currently get assigned under the incorrect component (Internals>Compositing). So add a DIR_METADATA for the directory with the correct component (Internals>GPU>Metrics). BUG=none Change-Id: I63cd83b265938d21a5807bc1e7e0428e514b50c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499202 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821707}
-
Dave Tapuska authored
One of the last RenderWidget messages handled, move it to WidgetHost. Remove widget_messages.h since it is no longer needed. BUG=1097816 Change-Id: Ic8512f82ab82eeb4687594d090002b56750be9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490346 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821706}
-
Andreea Costinas authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/acf8878dcf83..763dc305cc96 $ git log acf8878dc..763dc305c --date=short --no-merges --format='%ad %ae %s' 2020-10-19 acostinas system_api: Update system-proxy D-Bus API 2020-10-19 kevinptt runtime_probe: align mmc_stroage fields with Python probe 2020-10-02 stevenjb shill: Add PortalDetectionFailedStatusCode Created with: roll-dep src/third_party/cros_system_api Change-Id: I5c4cf1674cae7886f6071ea9a68c4274d16e9982 Bug: 1132247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498582Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#821705}
-
Hiroshige Hayashizaki authored
This CL fixes html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials.sub.html and html/semantics/scripting-1/the-script-element/module/credentials.sub.html by: - Using `set-cookie.py` instead of `document.cookie = 'same=1';`, and - Passing `origin` parameter instead of relying on Origin request header, as Firefox doesn't send Origin header in same-origin requests. This CL also adds credentials mode tests for dynamic imports from classic scripts and setTimeout(with a string argument). Bug: 1133238, 1114988 Change-Id: I18dce474f46e79c7d4161461760f0739806a1984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437556Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#821704}
-
Michael van Ouwerkerk authored
TBR=mahmoudi@chromium.org Bug: 1143219 Change-Id: If6ac545238ff7c11f883294ed1fb6d96df2254fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505629 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#821703}
-
Guido Urdaneta authored
Also rename to PushableMediaStreamVideoSource. This class is a generic building block that will be used by Raw Access Insertable Streams (a.k.a. Breakout Box). This class is very generic, so the mediastream module is a natural place for it. Bug: 1142955 Change-Id: Ibceb38dfae8638a49ce87dc735c2114a2e863145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503511 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#821702}
-
Fergal Daly authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/docs/render_document.md When RenderDocument for subframes is enabled, 2 tests fail: - AdsPageLoadMetricsObserverTest.HeavyAdCpuInterventionInBackground - AdsPageLoadMetricsObserverTest.HeavyAdNetworkInterventionInBackgrounded Failures can be seen in the CQ of this change which enables RD for subframes: - https://crrev.com/c/2241368/6 They fail because the timing changes and SendInterventionReport ends up being processed before FlushForTesting is called. At that point there is no quit closure and so the message is dropped. This is fixed by storing the message even if there is no quit closure. This then requires a fix for HeavyAdPolicyProvided because it reuses the same FrameRemoteTester for many tests and some messages from one iteration linger for the next. This flushes the pipe at the start of each iteration. Also added a SCOPED_TRACE to this loop so you know which test failed when one fails. Bug: 1064944 Change-Id: I67b38f48e562ba4ecd4fad25afdc58cfb18f2b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500975 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Kyle Williams authored
Adds GetService to ServiceAdaptor to access CfM services from the CfmServiceContext. BUG=chromium:1105567, b:165864612 TEST='autoninja -C out/Default/ chrome/test:unit_tests && \ xvfb-run ./out/Default/unit_tests \ --gtest_filter=CfmServiceAdaptorTest.*' Change-Id: I33368364c7aaf2532f0bd593439ee3be21d415dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480583Reviewed-by:Alexander Alekseev <alemate@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#821700}
-
Sebastien Lalancette authored
Connected the Bling link-to-text JavaScript code with the open-sourced text-fragments-polyfill library. Moved out the response handling logic from LinkToTextTabHelper into LinkToTextResponse and utility functions. This enabled better readability, testability, and made it simpler to handle error cases. In error cases, the desired UX is to show an alert to the user. This first CL sets-up the handling of link-to-text link generation failures. A subsequent CL will be adding an alert coordinator to BrowserContainerCoordinator to handle showing the alert. Bug: 1136043 Change-Id: Icf204c55457e1f1bfef116d7a9986ec0cefdbd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492241Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#821699}
-
Matt Menke authored
Also update RenderFrameHostImpl to pass in the correct NIK. Other callers have been left as TODOs. Bug: 993805 Change-Id: Ie127842ada00e7e21dfd74f3039f1ecfb0356d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488000Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#821698}
-
Anders Hartvoll Ruud authored
We are currently able to create new CSSAnimations linked to CSSScrollTimelines, but we can not change the timeline of a CSSAnimation that is already running. There are three types of changes that can trigger a timeline change for a running animation: 1. When a @scroll-timeline rule is inserted, either via DOM mutation, or via a change in @media query evaluation. 2. When the computed value of 'animation-timeline' changes. 3. When the elements referenced by a @scroll-timeline rule changes, for example 'source:selector(#foo)' references an element with #foo, hence we need a new timeline if #foo is reassigned to point to a different element. This CL implements "timeline change detection" in CSSAnimations, which can discover whether a new timeline is needed or not. This detection runs whenever there's a non-animation-style-change, in other words, whenever something is marked for regular style style recalc, we will check if the timeline currently associated with an animation is up-to-date, and create a new one if needed. In this CL, only Item 1 in the above list is fully solved. However, since this adds the general capability to reconsider previous timeline choices upon style recalc, it also lays the groundwork for solving Item 2 & 3. InertEffect makes things a bit awkward, as usual: we basically have to predict the effect setTimeline will have on the current time of the Animation, without actually calling setTimeline. Hence there's a rather complicated if-statement which makes this prediction. We should ideally try to get rid of InertEffect and do the setTimeline call right away. In the WPT I'm also trying to cover both the result produced by InertEffect, _and_ the result produced by setTimeline. Hence each test is run twice: once for the result produced the same frame the style recalc took place, and once again after scrolling a bit. Bug: 1074052 Change-Id: Ida36a00eb91e26b493c1e70c20dc7b23be7c9a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335282 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: -
Anton Bikineev authored
This reduces the average PCScan time on the renderer process (with PA as a malloc) from 269ms to 29ms (9x). Bug: 11297512 Change-Id: I445f609751e25d943ed779453aa07a0142cbf5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498464 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821696}
-
