- 28 Apr, 2017 40 commits
-
-
tkent authored
https://heycam.github.io/webidl/#legacy-callback-interface-object Legacy callback interface needs an interface object, but it has no instances and no prototype. This CL fixes 19 failures in external/wpt/dom/. Implementation: * This CL adds WrapperTypeInfo for NodeFilter, but we never make wrappers for NodeFilter. * Add kWrapperTypeNoPrototype window.NodeFilter should not have a prototype, but it should be a constructor. V8PerContextData::ConstructorForTypeSlowCase() rejected to return a constructor if the type had no prototype. This CL introduces kWrapperTypeNoPrototype to avoid this issue. * Add new legacy_callback_interface.*.tmpl Because NodeFilter can't use generated methods for callback interface for now. * Source/bindings/tests/idls/core/TestLegacyCallbackInterface.idl Add it for quick check of legacy callback interface generation. BUG=591919 Review-Url: https://codereview.chromium.org/2837923003 Cr-Commit-Position: refs/heads/master@{#467963}
-
delphick authored
This reverts the non-test part of https://codereview.chromium.org/2738773004/ but leaves most of the test changes in place since they should now work regardless of the setTimeout behaviour. BUG=711044 Review-Url: https://codereview.chromium.org/2853493002 Cr-Commit-Position: refs/heads/master@{#467962}
-
treib authored
Hidden behind a new feature "OneGoogleBarOnLocalNtp". BUG=583292 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2819553003 Cr-Commit-Position: refs/heads/master@{#467961}
-
senorblanco authored
R=kbr@chromium.org BUG=670098 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2852453002 Cr-Commit-Position: refs/heads/master@{#467960}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2844993005 Cr-Commit-Position: refs/heads/master@{#467959}
-
primiano authored
Revert of [tools/perf] Disable load:tools:drive system health story (patchset #1 id:1 of https://codereview.chromium.org/2848573002/ ) Reason for re-enabling the story: The V8 CL that was causing the crash has been reverted in https://crrev.com/2852623002 Original issue's description: > [tools/perf] Disable load:tools:drive system health story > > Story shows a high failure rate on many different perf bots. > > TBR=nednguyen@google.com > BUG=715936 > > Review-Url: https://codereview.chromium.org/2848573002 > Cr-Commit-Position: refs/heads/master@{#467640} > Committed: https://chromium.googlesource.com/chromium/src/+/3721c3608a5aef73b1762e6906257c9d9f8e0d36 BUG=715936 Review-Url: https://codereview.chromium.org/2851703003 Cr-Commit-Position: refs/heads/master@{#467958}
-
maxmorin authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f66bef3..5515dcd $ git log f66bef3..5515dcd --date=short --no-merges --format=%ad %ae %s 2017-04-28 denicija@webrtc.org iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. 2017-04-28 henrik.lundin@webrtc.org Add NetEqInput::PacketData::ToString method 2017-04-28 henrik.lundin@webrtc.org NetEq tests: BUILD target reorg 2017-04-27 zijiehe@chromium.org Forward capturer_id between DesktopFrame and its implementations 2017-04-27 glaznev@webrtc.org Reland of Support adding and removing MediaRecorder to camera 2 session. (patchset #1 id:1 of https://codereview.webrtc.org/2844233002/ ) 2017-04-27 mbonadei@webrtc.org Hiding problematic targets from chromium 2017-04-27 ossu@webrtc.org Have AudioSendStream register CNG payload types with the RtpRtcpModule. 2017-04-27 brandtr@webrtc.org Add warning about timestamp non-monotonicity in the frame buffer. 2017-04-27 hewwatt@gmail.com This CL adds RTCMTLVideoView.h and RTCCameraVideoCapturer.h to WebRTC.h in order to fix a build issue that comes up when using WebRTC.framework from swift code. 2017-04-27 kwiberg@webrtc.org Run some peer connection end-to-end tests with an empty audio decoder factory 2017-04-27 magjed@webrtc.org Revert of Support adding and removing MediaRecorder to camera 2 session. (patchset #5 id:80001 of https://codereview.webrtc.org/2833773003/ ) 2017-04-27 ossu@webrtc.org Injectable audio encoders: WebRtcVoiceEngine and company 2017-04-27 ossu@webrtc.org Normalize codec names to those used by AcmCodecDatabase. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2849793002 Cr-Commit-Position: refs/heads/master@{#467957}
-
altimin authored
Run task queue observer callback even when there is immediate work availaible. This will prevent some renderers from stucking in a throttled state with a fence. This is a temporary solution enabling delphick@ to revert his patch. A proper fix and test coverage will come later. R=skyostil@chromium.org CC=delphick@chromium.org BUG=710095 Review-Url: https://codereview.chromium.org/2844223004 Cr-Commit-Position: refs/heads/master@{#467956}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/63f6c513..e353f66b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2851673003 Cr-Commit-Position: refs/heads/master@{#467955}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/778079b344c8..e80a730b1b1b $ git log 778079b34..e80a730b1 --date=short --no-merges --format='%ad %ae %s' 2017-04-28 nednguyen [Telemetry] Switch Android platform to no longer uses test ca Created with: roll-dep src/third_party/catapult BUG=716084,711634 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9b908c4f313ffe12cf8d75c317a490e5f6fe61cf Reviewed-on: https://chromium-review.googlesource.com/489618 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467954}
-
rmcilroy authored
BUG=chromium:496164 Review-Url: https://codereview.chromium.org/2844253005 Cr-Commit-Position: refs/heads/master@{#467953}
-
ericwilligers authored
The 'motion-rotation' property has been replaced by 'offset-rotate'. 'motion-rotation' is among the properties disabled in M58. BUG=711937 Review-Url: https://codereview.chromium.org/2840943003 Cr-Commit-Position: refs/heads/master@{#467952}
-
gambard authored
Addressing the comments raised in https://codereview.chromium.org/2808873002/ BUG=none Review-Url: https://codereview.chromium.org/2851713002 Cr-Commit-Position: refs/heads/master@{#467951}
-
dgn authored
Some content suggestions categories are hidden when no content is available. The UI used to completely ignore them, when when checking that the list of categories didn't change, that caused the UI's data to be always considered stale. We now keep track of these hidden categories, blacklisting them when they should not be shown, and removing them from the blacklist when we get notified of a change about them. BUG=689962 Review-Url: https://codereview.chromium.org/2846123002 Cr-Commit-Position: refs/heads/master@{#467950}
-
eugenebut authored
BUG=583682 Review-Url: https://codereview.chromium.org/2852673002 Cr-Commit-Position: refs/heads/master@{#467949}
-
peconn authored
Revert "Revert of
📺 Move fullscreen web content to a new Activity. (patchset #11 id:200001 of https://codereview.chromium.org/2807663002/ )" This reverts commit d0f88cff. TBR=bauerb@chromium.org BUG=709042 Review-Url: https://codereview.chromium.org/2847823005 Cr-Commit-Position: refs/heads/master@{#467948} -
olivierrobin authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2808873002 Cr-Commit-Position: refs/heads/master@{#467947}
-
gambard authored
Automatically generated ARCMigrate commit Notable issues:static_cast changed to __bridge cast. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2819283004 Cr-Commit-Position: refs/heads/master@{#467946}
-
i-ts authored
System default string resouce R.string.item_is_selected with expected pattern %s is changed to %d on Samsung's 5.x devices (S4, S5, Note 3, Core Prime etc.). This small change causes String.format() to throw exception when SimpleMonthView's content description is requested (for example Accessibility/TalkBack is ON). In case of Chromium this view is used only at DatePickerDialog. The solution is to suppress this exception on 5.x devices and give fixed string to view. This fix is based on: http://stackoverflow.com/q/28618405 R=mlamouri@chromium.org, leandrogracia@chromium.org, tkent@chromium.org BUG= crbug.com/710950 Review-Url: https://codereview.chromium.org/2790423002 Cr-Commit-Position: refs/heads/master@{#467945}
-
sdefresne authored
BUG=None Review-Url: https://codereview.chromium.org/2849783002 Cr-Commit-Position: refs/heads/master@{#467944}
-
dullweber authored
BUG= Review-Url: https://codereview.chromium.org/2847663004 Cr-Commit-Position: refs/heads/master@{#467943}
-
bsazonov authored
This CL makes several minor changes to MockAccountManager: 1. Add 'Delegate' to the name, because it implements AccountManagerDelegate and should be used with AccountManagerHelper. 2. Replace 'Mock' with 'Fake' in the name. 3. Remove redundant testContext from constructor arguments. BUG=698258 Review-Url: https://codereview.chromium.org/2845113003 Cr-Commit-Position: refs/heads/master@{#467942}
-
tkent authored
It was possible to show it in media query listener. BUG=714849 Review-Url: https://codereview.chromium.org/2845273002 Cr-Commit-Position: refs/heads/master@{#467941}
-
gambard authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2838213002 Cr-Commit-Position: refs/heads/master@{#467940}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f20a4f79..63f6c513 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2846173003 Cr-Commit-Position: refs/heads/master@{#467939}
-
dgozman authored
BUG=none Review-Url: https://codereview.chromium.org/2844383003 Cr-Commit-Position: refs/heads/master@{#467938}
-
sacomoto authored
BUG= Review-Url: https://codereview.chromium.org/2849493002 Cr-Commit-Position: refs/heads/master@{#467937}
-
shanmuga.m authored
Validating a qualified name should only throw InvalidCharacterError, not NamespaceError, after: https://github.com/whatwg/dom/issues/319 https://github.com/w3c/web-platform-tests/issues/5161 https://github.com/whatwg/dom/issues/423 Latest spec: https://dom.spec.whatwg.org/#validate Webkit Patch: http://trac.webkit.org/changeset/215701/webkit BUG=702077 Review-Url: https://codereview.chromium.org/2841393003 Cr-Commit-Position: refs/heads/master@{#467936}
-
dtrainor authored
Adds the IPH that points to the data saver preview infobar. This includes three main changes: - Adding support for determining which kind of infobar is showing in Java. - Hooking up the info bar show code to log an event saying it was shown. - Hooking up the info bar show code to a function which can pick (if any) a feature and string to show which will point to that infobar. BUG=710648 Review-Url: https://codereview.chromium.org/2815653003 Cr-Commit-Position: refs/heads/master@{#467935}
-
Kenichi Ishibashi authored
Before this CL we used V8PrivateProperty to avoid cyclic references between V8 and Blink. Now we have trace wrapper and DOM object can have a reference to V8 objects. Use trace wrapper for CustomEvent BUG=501866,700680 Change-Id: I9089d9cf0828bb979467cc5bd859e460847b6c28 Reviewed-on: https://chromium-review.googlesource.com/484162 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#467934}
-
jif authored
BUG=None Review-Url: https://codereview.chromium.org/2850453002 Cr-Commit-Position: refs/heads/master@{#467933}
-
apisarev authored
There is callback map in extension function dispatcher, which store pointers on callback wrappers. But it force to remember to delete wrapper after erase from map. This may lead to memory leak. To prevent it, raw pointer in map was replaced by unique_ptr (like in other callback map in same class). BUG=None R=finnur Review-Url: https://codereview.chromium.org/2850533002 Cr-Commit-Position: refs/heads/master@{#467932}
-
jianli authored
We check the content's MIME type. If it is not meant for HTML page,we route to DownloadManager. BUG=673635 Review-Url: https://codereview.chromium.org/2841823004 Cr-Commit-Position: refs/heads/master@{#467931}
-
dtrainor authored
Simple improvements to make the throttle work in a more expected way. - Calling any method to update the underlying contents of the throttle will allow the all queued updates to flush. - Calling updates infrequently will not queue. Instead we track the time since the last update and don't queue if the time has been long enough. - Hook the throttle into the JNI bridge for the Android OfflineContentProvider. BUG=715669 Review-Url: https://codereview.chromium.org/2835323005 Cr-Commit-Position: refs/heads/master@{#467930}
-
dtrainor authored
In Java persisting the ContentId required it to be a guid. This removes that dependency. Note that legacy downloads still have their own checks for requiring the id to be a guid, but if the download isn't associated with a legacy download the checks should not occur. BUG=691805 Review-Url: https://codereview.chromium.org/2843073002 Cr-Commit-Position: refs/heads/master@{#467929}
-
shanmuga.m authored
Update the comment with spec link http://www.ecma-international.org/ecma-262/6.0/#sec-arraybuffer-constructor BUG=701391 Review-Url: https://codereview.chromium.org/2847873003 Cr-Commit-Position: refs/heads/master@{#467928}
-
dgozman authored
This is a speculative attempt to fight memory regression after recent overlay refactoring. I suspect that InspectorOverlayAgent is retained either by InspectorOverlayHost or InspectorPageOverlayDelegate. This patch tries to clean them up in Dispose and ensure that nothing will be created after that point (disposed_ field). BUG=715266 Review-Url: https://codereview.chromium.org/2850623002 Cr-Commit-Position: refs/heads/master@{#467927}
-
oka authored
TEST=run_compiler BUG=636289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2852633003 Cr-Commit-Position: refs/heads/master@{#467926}
-
jianli authored
WebContents might not be loaded in some case, i.e. tab switcher. We need to check for that. BUG=715751 Review-Url: https://codereview.chromium.org/2847863003 Cr-Commit-Position: refs/heads/master@{#467925}
-
aleksandar.stojiljkovic authored
R16_EXT is supported on desktop core profile (OSX and Linux), and via OpenGL ES 3.1 GL_EXT_texture_norm16 extension (including ANGLE on Windows). Update khronos headers to get GL_R16_EXT definition. It is not exposed through WebGL but only used internally. Brings significant performance improvement, cutting the time spent on WebGL TexImage2D from ~1.2ms to ~0.2ms - see https://crbug.com/624436. BUG=624436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2767063002 Cr-Commit-Position: refs/heads/master@{#467924}
-