GitLab

This reverts commit fa5503b8.

Reason for revert: Causing visual glitches on non-low-end webview (issue 816356). Also causing a larger than expected memory regression (issue 815270). Will fix and re-land.

Original change's description:
> Use glUnpremultiplyAndDitherCopyCHROMIUM in GPU Raster
> 
> This change addresses banding issues by using the newly added
> glUnpremultiplyAndDitherCopyCHROMIUM.
> 
> In cases where we previously rasterized into a RGBA4444 target, we
> instead rasterize into a temporary RGBA8888 target, then do an
> unpremultiply/dither copy into the RGBA4444 target.
> 
> This means that tiles may be either unpremultiplied or premultiplied, so
> we need a way to pipe this information to the GLRenderer so it can
> blend correctly. This change introduces a is_premultiplied property to
> ContentDrawQuadBase to handle this.
> 
> Bug: 789153
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I8bb2af2a94934ca7fe79a180d65bff253163c98c
> Reviewed-on: https://chromium-review.googlesource.com/899866
> Reviewed-by: enne <enne@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538686}

TBR=kenrb@chromium.org,enne@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 789153, 815270, 816356
Change-Id: I4faf63e575471c6830fcb5475b35870cf436c398
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/937883Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539255}

This CL changes how |sampleRate| in AudioWorkletGlobalScope is updated.

Previously, the sample rate was updated when the first processor was
created, thus accessing the sample rate in the class definition phase
gives 0 value. With this CL, the sample rate is initialized as soon
as the global scope is created, before the script is loaded/parsed.

Bug: 815313
Test: http/tests/webaudio/audio-worklet/global-sample-rate.html
Change-Id: I994ee70c10ed93618b28c7d29df42b5d458c74f8
Reviewed-on: https://chromium-review.googlesource.com/935747
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539254}

Consolidate the frame-sink registration in one place in aura (Window),
for aura. It used to be spread between aura (WindowPort*), and content
(DelegatedFrameHost), which made it tricky to follow. This then makes
it easier to move all FrameSinkId management inside the aura::Window
(from the various WindowPort implementations).

BUG=none

Change-Id: I37943eace983a31485dc6c0587d90619781b7021
Reviewed-on: https://chromium-review.googlesource.com/935490Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539253}

Previously we recorded the exact pak compression ratios in .size files.
This results in minor changes to 1k+ unrelated symbols due to changes in
compression. Use a mostly accurate static constant instead to make .size
files comparable across runs.

Bug: 814078
Change-Id: I63c78379898ef02885ae86e0b95df95d51965918
Reviewed-on: https://chromium-review.googlesource.com/938122Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539252}

external/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html
regressed after the change in bug.

TBR=jochen@chromium.org

Bug: 816556
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic8e15dbe0c629dcbb3f35859cb614525a1427683
Reviewed-on: https://chromium-review.googlesource.com/937903
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539251}

settings-toggle-button, and cr-toggle need to be migrated from 'click' to 'tap'
at the same time, otherwise calling stopPropagation() has no effect.

Bug: 815173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I847ca9892de3c108269995c10647ff16d935d8a5
Reviewed-on: https://chromium-review.googlesource.com/937904Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539250}

Using wpt-import in Chromium ff1d9bfd.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12964

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure

TBR=danyao

No-Export: true
Change-Id: Ic624f75dcffd6df1f5162c8efda1e22518fb1114
Reviewed-on: https://chromium-review.googlesource.com/937571
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539249}

This CL adds a download button for development purpose in
chrome://download-internals.

Also remove the incognito check because incognito support is work in
progress now.

Bug: 766299
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib2cbeac0f4b41d8769ee5991fb650bfa71a56938
Reviewed-on: https://chromium-review.googlesource.com/927832
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539248}

When Chrome is in the foreground, it treats onLowMemory() as
CRITICAL pressure and ignores TRIM_MEMORY_RUNNING_CRITICAL
trim level.

Turned out this is an oversight, and in fact according to UMA
RUNNING_CRITICAL is delivered 6 times more frequently than
onLowMemory(). See the bug for more details.

This CL treats RUNNING_CRITICAL trim level as CRITICAL pressure,
and adds tests.

Bug: 813909
Change-Id: I7e6d650881ed6e67b171f2cb29d593fc1b4acd3b
Reviewed-on: https://chromium-review.googlesource.com/935669Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539247}

https://chromium.googlesource.com/catapult.git/+log/766143cf63df..4607515962f8

$ git log 766143cf6..460751596 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 charliea Delete obsolete comment about BattOr perf bots

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I5ffe4cd25217055eba74ecb173c4709d5d188d79
Reviewed-on: https://chromium-review.googlesource.com/937882
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539246}

LayoutText::PositionForCaretOffset() and ::CaretOffsetForPosition() hit
DCHECK when called on LayoutWordBreak. This patch adds LayoutWordBreak
handling on them so that the functions can be called normally.

The handling simply assumes that LayoutWordBreak is fully collapsed text,
which matches the behavior in legacy layout.

No fixing to NGOffsetMapping is needed, as it already (unintentionally)
treats LayoutWordBreak as collapsed.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Bug: 811418
Change-Id: I23061a63e386e522841626fa36e3cd24e1431afc
Reviewed-on: https://chromium-review.googlesource.com/936433Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539245}

This allows BVC to intercept the animated fullscreen disabling action
for new foreground tabs.

Bug: 809120
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8b3e4865a98cde6eeb36cd8fbd6d1ec05983d5ce
Reviewed-on: https://chromium-review.googlesource.com/935442Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539244}

The bit is sent to all subframes instead of only the main frame. This is
a quick fix until a better one is found that will not break OOPIF.

This CL also de-recursify `HasBeenActivated()`

Bug: 810822
Change-Id: Ib8f494749221da5ec27f5a9b92d531de6d06a5d9
Reviewed-on: https://chromium-review.googlesource.com/934451Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539243}

select_to_speak.js was getting too messy so this moves
automation node related logic into a separate class.

Bug: 803160
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6867864f5ccefc14f4a5b98a31af5220d16f8259
Reviewed-on: https://chromium-review.googlesource.com/937802
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539242}

This patch updates the position on screen of non-root anchored layers
for interest rect calculation. This is needed, because the paint clip
always uses (0, 0) positioned viewport, so for content that is larger
than 4k pixels in height that is scrolled, we clip out the tail of
the content because we're not accounting for the scroll.

R=wangxianzhu@chromium.org, szager@chromium.org

Bug: 813835
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3dabcd4fdb907c949593bed7a076e88cdabed53a
Reviewed-on: https://chromium-review.googlesource.com/933731Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539241}

https://chromium.googlesource.com/angle/angle.git/+log/3582c0e2c3c1..b52fac03f438

$ git log 3582c0e2c..b52fac03f --date=short --no-merges --format='%ad %ae %s'
2018-02-21 geofflang Refactor ImageIndex to have separate type and target members.
2018-01-30 yunchao.he ES31: support stencil texture via DEPTH_STENCIL_TEXTURE_MODE.
2018-02-22 oetuaho Add 32-bit hash helper to ImmutableString
2018-01-25 oetuaho Clean up unnecessary use of TString

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ice87665b7cdafb12d0f1cd2e1c7670f616b47f1a
Reviewed-on: https://chromium-review.googlesource.com/937804Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539240}

This reverts commit 68d73438.

Reason for revert: 
Landed this with intent to revert. Got expected memory regression alerts for this experiment, but no other perf bugs filed.

Bug:815149


Original change's description:
> Add MemoryAblation to field_trial_config
> 
> Bug: 
> Change-Id: I9224213ed8c00e710f065dd0f24e2b20ec9332e6
> Reviewed-on: https://chromium-review.googlesource.com/775321
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538587}

TBR=asvitkine@chromium.org,mariakhomenko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ic617234d0831cf14f81daacf1c6a1682c71fc777
Reviewed-on: https://chromium-review.googlesource.com/937783Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539239}

For an image with a repetition count of n, it should animate for
n+1 loops. But the compositor only performs n loops. Fix this by
specifying the actual repetition count of PaintImage.

R=chrishtr@chromium.org

Bug: 815038
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I450d435ed38a3beba30276fa4dbabdcb5a68a944
Reviewed-on: https://chromium-review.googlesource.com/934968Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539238}

Now EnableIf works with imports. Update the documentation on this.

BUG=676224

Change-Id: Ib3cee7bbca3584fe1b537afc26b31a10d8d51dec
Reviewed-on: https://chromium-review.googlesource.com/937943Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539237}

Change-Id: Ie66c10418cb1c60defc806fd23f86c9d5af7cdac
Reviewed-on: https://chromium-review.googlesource.com/938026Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539236}

Also add a note about a helpful `cipd` command when the SDK is
downloaded via CIPD.

TBR: wez@chromium.org
Change-Id: If3ce6e1f7eb0e66c8375bef317def280342a2f11
Reviewed-on: https://chromium-review.googlesource.com/937989Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539235}

20 rebaselines for image failures from a manual review of the ToT
bot result at:
https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/3954/layout-test-results/results.html

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I04454fc301af31a723a93e1fe2ba78a7d920d0aa
Reviewed-on: https://chromium-review.googlesource.com/937742
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539234}

This API can be used to replace download_to_file functionality in
the network stack (currently only used by XHR) by letting blink
instead pass the data pipe that is the result of fetching some data
to the blob system.

Bug: 754493, 712693, 791702
Change-Id: I75c5289a6e7e7823e32838d9ada76d74028d8e40
Reviewed-on: https://chromium-review.googlesource.com/916731
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539233}

https://pdfium.googlesource.com/pdfium.git/+log/1dbea185e709..9141116074f9

$ git log 1dbea185e..914111607 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 dsinclair Fixup AFSimple_Calculate indexing bug

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I9bbbfc27d5877342a1a0413390e559d9f29a14d6
Reviewed-on: https://chromium-review.googlesource.com/937885
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539232}

ScrollAnimator continues to call ShouldUseIntegerScrollOffset and
UpdateScrollOffset indirectly through the base class ScrollableArea.

Bug: 815135
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I495f8ae408022b4e170b17b4392480224cd8114e
Reviewed-on: https://chromium-review.googlesource.com/935041Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539231}

1) Fix crashes caused by premature/forbidden usage of javascript.
Given that we don't need or want to produce a real exception, this is
accomplished using DummyExceptionStateForTesting.
2) Add checks for layoutBox() truthiness.
3) Save the relative offset in FindAnchor so that it updates properly.
4) Make the implementation work nicely with root layer scrolling by
adding RestoreAnchor to ScrollableArea, implementing it on
PaintLayerScrollableArea, and calling restore on the view's
LayoutViewportScrollableArea.

Bug: 810161,810897,810474
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I820e572cef543ed85156622fd574684109488eec
Reviewed-on: https://chromium-review.googlesource.com/922384
Commit-Queue: Patrick Noland <pnoland@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539230}

Change-Id: I395f06f8c709c56c2e69e4a0706b437c51ec2ed7
Reviewed-on: https://chromium-review.googlesource.com/935265Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539229}

This test flakily hangs, appearing to live-lock in a worker-thread
creation/teardown cycle.

TBR: gab
Bug: 816575, 810464
Change-Id: I22c42740a2e9af229400bc2da077ae962a287804
Reviewed-on: https://chromium-review.googlesource.com/937984Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539228}

Cache the sticky settings until the destination capabilities are known.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic7b11b3e8cb1378a9d5c5f62f5e7d2d96c82ea70
Reviewed-on: https://chromium-review.googlesource.com/935082
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539227}

e.g. "Google password" instead of "google password",
make the occurences of "users" and "the user" more consistent.
b/73625708, b/73611799

Bug: 804490
Change-Id: I6313787f940230a228e7b66476ab49949cf4be9b
Reviewed-on: https://chromium-review.googlesource.com/929343
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539226}

sandboxed_service_extra_flags is only used to set
visibleToInstantApps=true, which should always be true for both WebView
and Monochrome. Just set the attribute in the manifest directly and
remove the variable entirely to simplify the configuration and remove
the possibility that someone makes a new target which forgets to set it
(since the breakage caused by not setting this is subtle and easy to
miss).

Bug: 797014
Change-Id: Iec2075c23c4e71302a10d1f15b83b290618f1a32
Reviewed-on: https://chromium-review.googlesource.com/920262Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539225}

In StackLayout, which implements the Android tab picker, we currently have two
places that implement essentially the same piece of logic for deciding whether
a drag event should be interpreted as switching between the two stacks, or
closing a tab in the current stack. Besides the redundancy making the code
unnecessarily confusing, there are three other problems:

- The inline logic in computeInputMode() computes switchDelta using x + dx or
  y + dy, but isDraggingStackInWrongDirection() uses x or y without the delta
  term. This introduces a small amount of judder when dragging a tab back and
  forth between the "swipe to close" and "swipe to change stacks" directions.

- isDraggingStackInWrongDirection() always prohibits dragging if the horizontal
  movement is smaller than the vertical movement...even in landscape mode. This
  means swiping between stacks barely works in landscape mode (it only works if
  you put your finger on the other tab to start; this case works because it
  hits the "currentIndex != getViewportParameters().getStackIndexAt(x, y)"
  logic earlier in the method.

- isDraggingStackInWrongDirection() is broken for RTL mode.

This CL makes the code easier to follow and fixes these three problems.

Change-Id: Idb507b75f2977859c561a93d13c7737dfd84b97a
Reviewed-on: https://chromium-review.googlesource.com/935450Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539224}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5a0a9a1d..c1be8e2e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I3cba15d38a524ef3581f47a735ef349466308795
Reviewed-on: https://chromium-review.googlesource.com/937686Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539223}

Add more property tests. Most test failures are because our Blink
implementation for these properties are lagging behind spec. The only
weird one is line-height, which seems to return 'normal' for negative
values even though the spec doesn't say that anywhere.

Bug: 774887
Change-Id: I9d4a6918b5e9b5772230999b18c6eec4934bcf19
Reviewed-on: https://chromium-review.googlesource.com/936821Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539222}

This metric tracks how long the user has to wait for a visible image to
load completely. This metric will help understand how much delay does
lazyload of images incurs users.

Bug: 812684
Change-Id: Ic97c9a192254a2b64d9f2427d8694d6e36759db9
Reviewed-on: https://chromium-review.googlesource.com/831530
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#539221}

These are all unused by gpu/config/gpu_driver_bug_list.json and
so can be removed from the code.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie55daa02700f69b51c7e5c16bfc52962308b69be
Reviewed-on: https://chromium-review.googlesource.com/935480Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539220}

This CL moves a few windows-specific files from //media/gpu to the
(existing) //media/gpu/windows. I stumble upon these files while
reading code during bug scrub.

Run those commands in 15':

$ git mv media/gpu/d3d11_* media/gpu/windows/
$ git mv media/gpu/dxva_* media/gpu/windows/
$ git mv media/gpu/media_foundation_* media/gpu/windows/
$ tools/git/mass-rename.py

TBR=avi@chromium.org and sergeyu@chromium.org for the automatic
path updates in gpu_main.cc and //remoting/

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0eb8b8923d446a74c2e5c4e5cda8d1910d414355
Reviewed-on: https://chromium-review.googlesource.com/937569
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539219}

All the SVGGeometryElements share the same code-sequence for
invalidation of attributes that define the geometric shape.
Move this code to SVGGeometryElement::GeometryAttributesChanged.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I78eabe6245eff618dff810d7bcfc120b9a99f545
Reviewed-on: https://chromium-review.googlesource.com/931802Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#539218}

If the last transaction in a Writers object is released, then free it. There
is no need to wait for any pending cache writes or network reads to finish
before truncating. Otherwise we wind up holding on to resources for far longer
than necessary.

Bug: 804868
Change-Id: I9480a801b0314c3be9d2aa4cbb579b96503ce638
Reviewed-on: https://chromium-review.googlesource.com/928845
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539217}

Bug: 809637
Change-Id: Ia3f111f1fc3840474be31150a1d3cb2028a28dc7
Reviewed-on: https://chromium-review.googlesource.com/919158
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539216}