- 11 Dec, 2017 40 commits
-
-
Hui(Andy) Wu authored
After a phone number field is marked as fill_only_when_focused by rationalization, we should log the quality metrics differently compared to normal fields. For example, if a field is left empty and being fill_only_when_focused, it should be logged as true negative, meaning we anticipated this field will be left empty. Bug: 780471 Change-Id: I3457b6381430055c7c4cb8431f0da193f396065d Reviewed-on: https://chromium-review.googlesource.com/786340 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#523172}
-
Dale Curtis authored
There's really no reason for us to be posting this for every single Render() call. They can be updated nearly as quickly during each FrameReady() call. There's also no reason for us to create a new PipelineStatistics structure every time either. Instead replace a multitude of member variables with a PipelineStatistics member. This is an optimization of PipelineStatistics usage so that we can add a Decoder enum value later. BUG=793151 TEST=existing tests pass. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5375acf74a625e1095e6631e177b4a04a4a0e54d Reviewed-on: https://chromium-review.googlesource.com/816019Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#523171}
-
Eric Lawrence authored
Update the Critical section of the Security Severity FAQ. Change-Id: I167cb99f3778e8c1f68c65de65a81a6354a5a346 Reviewed-on: https://chromium-review.googlesource.com/820172Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#523170}
-
David Tseng authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0356476340d3ad2f6bc9a41f99bd904b4fcab79f Reviewed-on: https://chromium-review.googlesource.com/817755Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#523169}
-
Julien Isorce authored
Instead of hardcoding GL_TEXTURE_EXTERNAL_OES or GL_TEXTURE_2D This will be useful for the subsequent CL, https://chromium-review.googlesource.com/c/chromium/src/+/766787 Bug: 785201 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2678181b4b9389c39999d07cb9e56c102fc5f299 Tests: media_unittests --gtest_filter=*VaapiVideoDecodeAcceleratorTest* Reviewed-on: https://chromium-review.googlesource.com/819131Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#523168}
-
Aga Wronska authored
Override virtual keyboard overscrolling for view based lock and login screens. Virtual keyboard overscrolling is interfering with resizing window properly. The override is used in web based lock and login screens. See crbug.com/363635 for context. Bug: 791817 Change-Id: Ic04b0823db1ffc2f4e96983f0ac9606ee6dadbb2 Reviewed-on: https://chromium-review.googlesource.com/818628Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#523167}
-
Kevin Cernekee authored
The ARC VPN feature will go live in M64. Leave the flag in place in case it causes trouble, but enable the feature by default. BUG=696865 TEST=buildbots Change-Id: If64e60945d299f5ef6c538471e07a41e47024ea1 Reviewed-on: https://chromium-review.googlesource.com/812499Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Kevin Cernekee <cernekee@chromium.org> Cr-Commit-Position: refs/heads/master@{#523166}
-
Stephen Chenney authored
A recent change caused us to display the broken image for src="" in img tags. Revert that case because other browsers (Safari, Firefox) display nothing. R=chrishtr@chromium.org BUG=793206 Change-Id: Iaa531976d76b7b20b238f23d1bf220126a82b64b Reviewed-on: https://chromium-review.googlesource.com/817960 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523165}
-
Henrique Nakashima authored
The following metrics are added: - The bookmarks panel is opened - Any bookmark is followed - Change page by typing the number on the toolbar - Rotate - Fit to width - Fit to page We need these metrics to make informed decisions about tweaks to our current UI and an upcoming overhaul. Bug: 768982 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia871b4d390ea7dc28f9017780c9622fb5d54cbce Reviewed-on: https://chromium-review.googlesource.com/801634 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523164}
-
Elliot Glaysher authored
This reverts commit 3738ee85. Reason for revert: Patch is wrong, and is probably causing a crash on device. When running ash, target is actually set correctly. It's not set correctly in the unit tests though. Original change's description: > Start fixing ImmersiveFullscreenController tests. > > The OnPointerEventObserved() interface acts differently between mash and > mus/classic. In mus/classic, the target window is taken from the > LocatedEvent's target(), relying on previous event dispatch metadata. On > mash, this event came from a remote service which hasn't been targeted, > target is therefore the top of the window tree. In the --mash case only, > target the event on the window and use that as the window we pass to the > rest of the system. > > Bug: 698085 > Change-Id: I8a1859055d9427b269cd5256c7ff114a1e97574d > Reviewed-on: https://chromium-review.googlesource.com/801976 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Elliot Glaysher <erg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521090} TBR=jamescook@chromium.org,erg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 698085, 793839 Change-Id: I5d9325b72853c8793f5ce1f3e66fe74461eea9be Reviewed-on: https://chromium-review.googlesource.com/820290Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523163}
-
Miguel Casas-Sanchez authored
Automatic comment fixing: sed -i -e 's|(crbug.com|(https://crbug.com|' `grep -rn "(crbug" media/gpu/ | cut -d: -f1 | uniq` sed -i -e 's| crbug.com| https://crbug.com|' `grep -rn " crbug" media/gpu/ | cut -d: -f1 | uniq` git cl format ..because otherwise cs.chromium.org doesn't linkify them. TEST: No new code. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icc0244dd61031cbd51a53044ef2d7aca77d2a3cc Reviewed-on: https://chromium-review.googlesource.com/818192 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#523162}
-
Sergey Ulanov authored
Some WebRTC tests were failing when executed in the same process with others because they were leaving base::TaskScheduler intialized. Updated WebRTC tests to use ScopedTaskEnvironment to ensure that TaskScheduler is destroyed. Bug: 750940 Change-Id: I7420aba0c2a990ecfd2fd44df7ac014a76a73ba7 Reviewed-on: https://chromium-review.googlesource.com/817525Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523161}
-
Yuzhu Shen authored
This change also puts some more files that don't expose public interfaces into mojo/public/js/lib. BUG=699569 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia84ec62323140c374fbe3def41152758a51cd337 Reviewed-on: https://chromium-review.googlesource.com/812106Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523160}
-
Gheorghe Comanici authored
This CL fixes a small typo that was not spotted in https: //chromium-review.googlesource.com/c/chromium/src/+/798192 Change-Id: Id76e38416a3634e18e5edb9cd2c20f81996879e6 Reviewed-on: https://chromium-review.googlesource.com/804434Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Cr-Commit-Position: refs/heads/master@{#523159}
-
Rune Lillesveen authored
In order to support CSS counters in a display:contents context, we need to track current element instead of LayoutObject in FindPlaceForCounter since display:contents do not have LayoutObjects. Also corrected documentation and variable/method names according to coding style. Bug: 766650 Change-Id: I399511184f3a22a19b6279a6c921787b96b84cef Reviewed-on: https://chromium-review.googlesource.com/818341Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#523158}
-
Finnur Thorarinsson authored
And finish the rest of the permutations, since they're easy to implement... Bug: 789067, 656015 Change-Id: I32893ff6ce2ef1d0221abc117a42a09e8ee7b136 Reviewed-on: https://chromium-review.googlesource.com/813916Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#523157}
-
Will Chen authored
Bug: 667560 Change-Id: I87aee8e9e35a01c4be655f43cf07fed1da3cb6d2 Reviewed-on: https://chromium-review.googlesource.com/780781 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523156}
-
Matthew Jones authored
This change removes the 60 second time restriction from the info-promo and adds a shared preference to determine whether it was shown. As to not conflict with the opt-in/out promo, when that experiment is disabled, the info preference is set so that promo will not be presented to the user. BUG=789685 Change-Id: Iabe72822dd6e51b35427719454b48e1fb7818bd3 Reviewed-on: https://chromium-review.googlesource.com/809344 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#523155}
-
Peter Collingbourne authored
Bug: 507755 Change-Id: I369d942e9c9afe3d600885377ce79e09f91ccaea Reviewed-on: https://chromium-review.googlesource.com/818529Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523154}
-
Ahmed Fakhry authored
Convert the native event location to the target's host if it's different from the source's host. BUG=714578 Change-Id: I09d64fe043c9d872331dd35babd41ca62280f9c7 Reviewed-on: https://chromium-review.googlesource.com/804954Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#523153}
-
Florent Castelli authored
Fix reporting a size of 2x2 on the video element during the loading phase. Bug: 684288 Change-Id: Id4adceefaf4c3df57a1ba41fd285862d72792b1a Reviewed-on: https://chromium-review.googlesource.com/806215 Commit-Queue: Florent Castelli <orphis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#523152}
-
Ilya Sherman authored
Caching the network state is dangerous, because a single missed network connection update can indefinitely block all subsequent requests. Moreover, there is no benefit to caching the state – it's just extra overhead. R=pauljensen@chromium.org Bug: 793103 Change-Id: I21d6318b3b85fb7125cc53b8e3d54842c2ce7564 Reviewed-on: https://chromium-review.googlesource.com/818527Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523151}
-
Tarun Bansal authored
Remove a test-only method from DataReductionProxyServer, and update the callers. Bug: 760294 Change-Id: Ib90a4fb896df9b14839373aa8741ac8ca2ff8ed1 Reviewed-on: https://chromium-review.googlesource.com/814855 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#523150}
-
Daniel Bratell authored
X11 header files are infamous for creating macros with common names such as None, True, False, Status, Bool, ... To save oursaves the mess that creates, they are now wrapped in a header, ui/gfx/x/x11.h, which puts those symbols in the x11 namespace and removes the global macros. This means we can remove various undefs in files that have had problems in the past. Bug: 782184 Change-Id: Ie48fe619e3101344d53ea837b0b21570516185ca Reviewed-on: https://chromium-review.googlesource.com/814676Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523149}
-
Katie Dektar authored
Adds recordBoolean and recordEnumerationValue to metricsPrivate. Bug: 792744 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id4f3e2baf8f15b6010af1115b34c89f542712f66 Reviewed-on: https://chromium-review.googlesource.com/815296Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Katie D <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#523148}
-
Ovidio Henriquez authored
This change removes the functions using TestRunner from bluetooth-helpers.js and places them in a separate bluetooth-fake-adapter.js file. For the mean time, the new file will be loaded in loadChromiumResources until all the tests that depend on TestRunner are converted to use Web Platform Tests. This will allow us to migrate tests that use bluetooth-helpers.js into the wpt/ directory since references to TestRunner should not exist in wpt/. This change also updates the cross-origin-iframe.html test to load the new bluetooth-fake-adapter.js file in order for the test to run properly. BUG=509038 Change-Id: Ic0bc7f5309123f77d7627abf7b63dbd0e6e9dadd Reviewed-on: https://chromium-review.googlesource.com/817694 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#523147}
-
Daniel Bratell authored
cache_storage and notifications both had "CurrentWorkerId()" with the same (trivial) implementation but used differently. For jumbo builds to not have those clash, this patch renames the one in notifications -> NotificationWorkerId() Bug: 746953 Change-Id: Ic00a4e23448bd2d50315a5561f798ed40be56fdc Reviewed-on: https://chromium-review.googlesource.com/819558 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523146}
-
Pavel Yatsuk authored
The issue is that during initialization HistoryBackend passes raw pointer of HistoryDatabase to TypedURLSyncBridge. Later when database error is detected HistoryBackend resets HistoryDatabase object leaving TypedURLSyncBridge with invalid pointer. When updates from server arrive TypedURLSyncBridge tries to write them to database causing crash. The fix is to notify TypedURLSyncBridge about database error, reset sync_metadata_database_ pointer and report error to sync so that datatype is disabled and doesn't receive updates from server. BUG=789876 R=skym@chromium.org Change-Id: Ic62709f37eef24f19e7f729998cee56943024084 Reviewed-on: https://chromium-review.googlesource.com/815880Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#523145}
-
Sky Malice authored
SyncService::TriggerRefresh() and ProfileSyncService::RefreshTypesForTest() did the exact same thing, eventually unifying on the sync thread inside SyncBackendHostCore::DoRefreshTypes. This change just replaces the less frequently used version of the two with the other. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4de6c51f3290d7c8324053cd4cf3379bac35acdd Reviewed-on: https://chromium-review.googlesource.com/818201Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#523144}
-
Mathias Bynens authored
The plumbing was added in 94f2d621 (https://chromium-review.googlesource.com/c/chromium/src/+/693518) BUG=v8:6827 Change-Id: Id29b36d702eb0857fdfb63d52c3494871ee06501 Reviewed-on: https://chromium-review.googlesource.com/819632Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#523143}
-
Daniel Bratell authored
In jumbo many files compile together in the same translation unit and then they share anonymous namespace so if they use the same constant name, such as kMaxNumberOfBuffers or kDefaultNumberOfBuffers, they will clash. Bug: 746953 Change-Id: I0ce707eac13d4f928e482ee62f0d112c69900dae Reviewed-on: https://chromium-review.googlesource.com/819830 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523142}
-
Fredrik Söderquist authored
LayoutSVGText would not compute the correct transform if subjected to a transform-origin (or transform) with percentages, since the transform had to be computed early in UpdateLayout in order to allow a font to be chosen based on the current transform. Rearrange the code in LayoutSVGText::UpdateLayout a bit to allow the transform computation to use the correct bounding box, but also compute a tentative transform before updating the font and its metrics. Remove the special-case in SVGElement::CalculateTransform and simplify accordingly. Bug: 225799 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I34728dfeaafba72c9f3195a29fbdd14673d186c2 Reviewed-on: https://chromium-review.googlesource.com/817734Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#523141}
-
Hui(Andy) Wu authored
At the moment autofill refuses to fill anything if the web site is asking for a complete phone number but what user has saved is considered as invalid by libphonenumber. We should relex this restriction and fill the phone field with exactly what the user has saved, as long as it's a field expecting complete number. Phone number components field will still be left empty. Bug: 793400 Change-Id: Ief7689185dfdf8c29526f620f80f95fed9a6d69c Reviewed-on: https://chromium-review.googlesource.com/818015 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#523140}
-
Conley Owens authored
Debian builds require this package to be installed in order to build. Change-Id: I6066fb1f3a39842ec076ec82495f0a44a2e17e93 Reviewed-on: https://chromium-review.googlesource.com/817649Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#523139}
-
Evan Stade authored
Reland 37bd8dbf with changes: 1. Destroy the NotificationDisplayServiceTester before the profile goes down (to fix the error). 2. Make the extension storage monitor depend on the notification service (for correctness --- doesn't help fix this error). 3. Don't explicitly remove notifications when the profile goes down. The NotificationDisplayService should remove all transient notifications for its profile when it's destroyed, which happens when the profile is destroyed. This part is necessary because when you remove a testing factory it doesn't reinstate the normal, non-testing factory, so we get a null deref. See KeyedServiceFactory::testing_factories_ TBR=stevenjb@chromium.org Bug: 793548 Change-Id: I834091ad6c53aaf923756e723a234013f92b1cd9 Reviewed-on: https://chromium-review.googlesource.com/817657 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523138}
-
Francois Doray authored
This method avoids casts from RenderWidgetHost to RenderWidgetHostImpl. Bug: 668690 Change-Id: I9618a61d9582e104b3041698d8368a8b14525d7f Reviewed-on: https://chromium-review.googlesource.com/797010 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523137}
-
gogerald authored
This bug is introduced when adding 'user-hint'. Add more tests to cover it. Bug: 793476 Change-Id: I16f4c965a0982ec0015a0a6ecd0aab9fda2b6282 Reviewed-on: https://chromium-review.googlesource.com/818120Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#523136}
-
Tetsui Ohkubo authored
In https://crrev.com/c/748983 , sidebar implementation is added to WebNotificationTray behind the flag. Unfortunately, null check condition in WebNotificationTray::HideMessageCenter() was changed in a way that affects environment with the flag disabled. As a result, several crash bugs are introduced becuase |message_center_bubble_| is not freed even after the tray is closed. TEST=manual BUG=792583 Change-Id: I96de43ca3e2bbdfc19519c3b296d29d445a17fcf Reviewed-on: https://chromium-review.googlesource.com/816778 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#523135}
-
Eugene But authored
This test did not fail on flaky device bots recently. Perhaps because of recent fixes in detecting pending navigations. Bug: 787872 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic47a3e174d3c7fc923b9aaa1dea957012f22e63b Reviewed-on: https://chromium-review.googlesource.com/819910Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#523134}
-
Katie Dektar authored
Bug: 792557 Change-Id: Ic1ae08f42822a54707b76bcfd54b450f9ef04008 Reviewed-on: https://chromium-review.googlesource.com/815538Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie D <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#523133}
-