GitLab

No one seems to know why we have BrowserActionView and BrowserActionButton.
Let's combine them for simplicity.

BUG=402526

Review URL: https://codereview.chromium.org/411063003

Cr-Commit-Position: refs/heads/master@{#289092}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289092 0039d316-1c4b-4281-b951-d872f2087c98

The contents_changed_since_last_frame and is_replica fields are not
used. Also removes RenderSurfaceImpl's ContentsChanged() as this method
was only used in determining the value of
contents_changed_since_last_frame.

Unfortunately now RenderPassDrawQuad is only the largest quad type on
64-bit builds. So, adds kLargestQuadType to cc/quads/ and moves the
largest-quad-type unit test there verifying that kLargestQuadType is
the largest now, instead of RenderPassDrawQuad.

R=enne
BUG=401481
NOTRY=true

Review URL: https://codereview.chromium.org/448133002

Cr-Commit-Position: refs/heads/master@{#289091}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403073
R=krstnmnlsn@chromium.org

Review URL: https://codereview.chromium.org/466153002

Cr-Commit-Position: refs/heads/master@{#289090}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402766
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/465083002

Cr-Commit-Position: refs/heads/master@{#289088}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289088 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: UNADDRESSABLE ACCESS reported on memory bot. See crbug.com/403070 for more details.

> Content browsertest for verifying that a black frame is sent on a peerconnection if a track is disabled.
> 
> BUG=398844,403070
> 
> Review URL: https://codereview.chromium.org/442313002

TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/466983002

Cr-Commit-Position: refs/heads/master@{#289083}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289083 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (patchset #1 of https://codereview.chromium.org/462083003/)

Reason for revert:
The CL turns out to be innocent. Reverting the revert

Original issue's description:
> Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (https://codereview.chromium.org/457003002/)
> 
> Reason for revert:
> Speculatively reverting CL in case it is causing WebNavigationApiTest.OpenTab to fail http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebNavigationApiTest.OpenTab
> 
> Original issue's description:
> > site isolation: cross-site transfers should track the RenderFrameHost, not the View
> > 
> > This fixes some issues that came up while debugging bug 400850, which inadvertently caused OOPIF-like view reuse in RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap.
> > 
> > 1. Make navigation_suspended state be per-RenderFrameHost. What was happening, was that we'd suspend navigations on the non-main frame of the view, and upon resume, we'd switch frames.
> > 
> > 2. Make the map of pending cross site requests be a map of RenderFrameHost IDs instead of RenderViewHost IDs, instead of just assuming that it's the main frame of the view that's navigating.
> > 
> > 3. Add a pending_main_rfh() to the test apparatus, for use by unittests that query the navigation_suspended state.
> > 
> > BUG=304341, 400850
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288867
> 
> TBR=creis@chromium.org,nick@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=304341, 400850
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289049

TBR=creis@chromium.org,nick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=304341, 400850

Review URL: https://codereview.chromium.org/466933003

Cr-Commit-Position: refs/heads/master@{#289082}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289082 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289081}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289081 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary workaround to fix desktop capture with HW encoder
at non-multiple-of-16 resolution without an extra memcpy.

BUG=402151
R=hclam@chromium.org
TBR=sergeyu@chromium.org
TEST=verify that desktop capture works on non-multiple-of-16 resolution

Review URL: https://codereview.chromium.org/469493002

Cr-Commit-Position: refs/heads/master@{#289078}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399696
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/466113002

Cr-Commit-Position: refs/heads/master@{#289076}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289076 0039d316-1c4b-4281-b951-d872f2087c98

b7e5a5c MIPS: detect mips32r6 and disable mips32r1 code
Part of 0524d9e that got missed in previous cherry-pick

BUG=400684,374343

Review URL: https://codereview.chromium.org/460303002

Cr-Commit-Position: refs/heads/master@{#289075}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289075 0039d316-1c4b-4281-b951-d872f2087c98

Hiding the async_waiter in a static makes it difficult to deal with
different threads running potentially different loop types running in
the same process. Making this explicit in the create call is much easier.
This assumes that callers will want to permantently bind a context with
a particular async waiter. In the case that we end up with a caller that
wishes to create a context on a thread using one async waiter type and
then bind that context to a thread using a different async waiter type
we can add another version of MakeCurrent, but that seems like a fairly
remote possibility at this point.

R=piman@chromium.org

Review URL: https://codereview.chromium.org/428413002

Cr-Commit-Position: refs/heads/master@{#289074}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289074 0039d316-1c4b-4281-b951-d872f2087c98

This generally matches the behavior before r276566.
See before/after pics at http://crbug.com/402814#c4

BUG=402814
TEST=Hindi and tall font tab titles look okay on Views.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/464943002

Cr-Commit-Position: refs/heads/master@{#289073}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289073 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289072}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289072 0039d316-1c4b-4281-b951-d872f2087c98

(Also simplify things a bit.)

R=morrita@chromium.org

Review URL: https://codereview.chromium.org/459613009

Cr-Commit-Position: refs/heads/master@{#289071}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289071 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/458873002

Cr-Commit-Position: refs/heads/master@{#289070}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372381

Review URL: https://codereview.chromium.org/462043002

Cr-Commit-Position: refs/heads/master@{#289069}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/456353002

Cr-Commit-Position: refs/heads/master@{#289068}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289068 0039d316-1c4b-4281-b951-d872f2087c98

Including cpu_brand, gl_vendor, gl_renderer, gl_extension, driver_vendor,
and machine_model_name.

BUG=396578
TBR=piman@chromium.org
TEST=gpu_unittests

Review URL: https://codereview.chromium.org/452293002

Cr-Commit-Position: refs/heads/master@{#289067}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387394
TBR=gab@chromium.org

Review URL: https://codereview.chromium.org/466083002

Cr-Commit-Position: refs/heads/master@{#289066}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289066 0039d316-1c4b-4281-b951-d872f2087c98

This CL separates the UMA histograms used for user and device policy
invalidation.

BUG=358699
TEST=Extended unit tests

Review URL: https://codereview.chromium.org/465433002

Cr-Commit-Position: refs/heads/master@{#289065}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289065 0039d316-1c4b-4281-b951-d872f2087c98

Implements Split Screen mode and window cycling behavior.
Resubmit of https://codereview.chromium.org/420603011/

TBR=oshima@chromium.org,mukai@chromium.org

BUG=383421

Review URL: https://codereview.chromium.org/461503002

Cr-Commit-Position: refs/heads/master@{#289064}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289064 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the breakpad client target wasn't getting compiled.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/462813005

Cr-Commit-Position: refs/heads/master@{#289063}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394920

Review URL: https://codereview.chromium.org/415813003

Cr-Commit-Position: refs/heads/master@{#289062}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401569
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/456243002

Cr-Commit-Position: refs/heads/master@{#289061}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289061 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Video capture should set visible size and coded size separately. (https://codereview.chromium.org/457823003/)

Reason for revert:
Broke 1080p and 480p tab capture on desktop.


Original issue's description:
> Video capture should set visible size and coded size separately.
> 
> The coded size should always be rounded up to multiples of 16 pixels to accomodate
> alignment requirements of HW encoders, while the visible size reflects the actual
> content size.
>     
> BUG=402151
> TEST=verify that non-multiple-of-16-pixel capture works and no black border is shown
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288565

TBR=sergeyu@chromium.org,posciak@chromium.org,hshi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402151

Review URL: https://codereview.chromium.org/460283003

Cr-Commit-Position: refs/heads/master@{#289059}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289059 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403013
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/465013002

Cr-Commit-Position: refs/heads/master@{#289058}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289058 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Speculative revert, attempting to diagnose timing out Blink layout tests on Windows.

Original issue's description:
> Adds some CHECKs to MessagePumpMojo
> 
> The thread watcher appears to be kicking on when we're trying to
> remove a handle. Not sure why. This converts some DCHECKs to CHECKs
> and fixes handling of the deadline. I suspect none of this will help,
> but it's worth a shot.
> 
> BUG=399769
> TEST=none
> R=darin@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288949

TBR=darin@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399769

Review URL: https://codereview.chromium.org/461133002

Cr-Commit-Position: refs/heads/master@{#289057}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289057 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289055}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289055 0039d316-1c4b-4281-b951-d872f2087c98

WorkerDevToolsSanityTest.InspectSharedWorker times out a lot on Windows. Disable
it.

BUG=403007
TEST=Bots green more often
NOTRY=true
TBR=dgozman

Review URL: https://codereview.chromium.org/459103006

Cr-Commit-Position: refs/heads/master@{#289054}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289054 0039d316-1c4b-4281-b951-d872f2087c98

Currently chrome://flags only exposes #enable-avfoundation as an enable
link. This CL exposes instead a tristate compose of Default/Enable/Disable.



BUG=356106, 396764

Review URL: https://codereview.chromium.org/460113006

Cr-Commit-Position: refs/heads/master@{#289053}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289053 0039d316-1c4b-4281-b951-d872f2087c98

Small followup from https://codereview.chromium.org/423333002

This allows the test to compile on a greater range of toolchains (some
of which break when using types defined in a function with arraysize).

Review URL: https://codereview.chromium.org/456403002

Cr-Commit-Position: refs/heads/master@{#289051}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289051 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (https://codereview.chromium.org/457003002/)

Reason for revert:
Speculatively reverting CL in case it is causing WebNavigationApiTest.OpenTab to fail http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebNavigationApiTest.OpenTab

Original issue's description:
> site isolation: cross-site transfers should track the RenderFrameHost, not the View
> 
> This fixes some issues that came up while debugging bug 400850, which inadvertently caused OOPIF-like view reuse in RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap.
> 
> 1. Make navigation_suspended state be per-RenderFrameHost. What was happening, was that we'd suspend navigations on the non-main frame of the view, and upon resume, we'd switch frames.
> 
> 2. Make the map of pending cross site requests be a map of RenderFrameHost IDs instead of RenderViewHost IDs, instead of just assuming that it's the main frame of the view that's navigating.
> 
> 3. Add a pending_main_rfh() to the test apparatus, for use by unittests that query the navigation_suspended state.
> 
> BUG=304341, 400850
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288867

TBR=creis@chromium.org,nick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=304341, 400850

Review URL: https://codereview.chromium.org/462083003

Cr-Commit-Position: refs/heads/master@{#289049}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289049 0039d316-1c4b-4281-b951-d872f2087c98

Preference can be deleted during sync rollback if the preference was not set before
first signin. Clear the preference if that happens.

BUG=362679

Review URL: https://codereview.chromium.org/444763005

Cr-Commit-Position: refs/heads/master@{#289048}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388517
NOTRY=true

Review URL: https://codereview.chromium.org/465643003

Cr-Commit-Position: refs/heads/master@{#289047}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289047 0039d316-1c4b-4281-b951-d872f2087c98

Remove |kAltInstantURLPath| from search.cc and retain the default Instant search base url path when the |kUseAltInstantURL| flag is enabled. 

BUG=382694
TEST=Run chrome with the following field trial flag and observe the Instant search base page url.
     --force-fieldtrials="EmbeddedSearch/Group1 use_alternate_instant_url:1 /"

Review URL: https://codereview.chromium.org/453573002

Cr-Commit-Position: refs/heads/master@{#289046}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289046 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the ExternalPopupMenu content browser 
tests for the changes in https://codereview.chromium.org/415343003/. This 
will be applicable on Mac port, as it uses 
ExternalPopupMenu to show dropdown menu.

BUG=398051
R=keishi@chromium.org

Review URL: https://codereview.chromium.org/447503002

Cr-Commit-Position: refs/heads/master@{#289045}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289045 0039d316-1c4b-4281-b951-d872f2087c98

TBR=alecflett@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/469463002

Cr-Commit-Position: refs/heads/master@{#289044}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289044 0039d316-1c4b-4281-b951-d872f2087c98

https://github.com/timothycrosley/isort

I ran isort -sl on files that does not contain util.AddDirToPythonPath.

BUG=

Review URL: https://codereview.chromium.org/445793004

Cr-Commit-Position: refs/heads/master@{#289043}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289043 0039d316-1c4b-4281-b951-d872f2087c98

Many slaves are shared between rel/dbg builders with the same build directory names. This makes sure we are testing what we intend to test.
BUG=401781
R=navabi@chromium.org, luqui@chromium.org

Review URL: https://codereview.chromium.org/452263002

Cr-Commit-Position: refs/heads/master@{#289042}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289042 0039d316-1c4b-4281-b951-d872f2087c98

This is an optimization for systems where there is more than one
physical pixel per logical pixel (e.g., Chromebook Pixel, Mac Retina).
On these systems, the render widget should be "preferably" sized such
that its physical size will match that of the tab capture frame size.

Because the entire graphics pipeline is handling N^2 less data, and also
will no longer need to down-scale images, users should see huge tab
capture performance improvements (e.g., higher frame rates, lower CPU
utilization and fan noise).

Expected side effect: Fullscreen-Within-Tab widgets will appear shrunk.
However, since content renderers are still DIP-aware, any UI controls
within the widget will appear right-sized.  In other words, user
interaction will not be diminished by this change.

Testing: Confirmed Fullscreen-Within-Tab and tab capture output is
correct by varying --force-device-scale-factor=X.

Review URL: https://codereview.chromium.org/461443003

Cr-Commit-Position: refs/heads/master@{#289040}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289040 0039d316-1c4b-4281-b951-d872f2087c98