- 20 Dec, 2019 35 commits
-
-
Tomasz Wiszkowski authored
This change addresses an old problem where suggestion icons and text were slightly misaligned. Change-Id: Ie2b9eb70cbfccf37787bc181fdf6bd23dced20b7 Doc: http://doc/1S80-WgirGxZaV3u4917MF6av7AbQpOIhWwrRxRo-eok Bug: 986584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977003Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#726638}
-
Ahmed Fakhry authored
If BrowserView::Layout() gets called multiple times while sliding the top controls is in progress, it could break sliding altogether, or at least will make its initiation janky. This CL allows only a single layout to go through once sliding begins. BUG=1034047, 950981 TEST=Manually, and expanded an existing test. Change-Id: I7b906fc2956aa455b573083d7cdaa40812141bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968320Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#726637}
-
David Black authored
This is part of a multi-CL effort to clean up the Assistant UI element modeling/rendering pipeline. This CL simply moves the ElementAnimator implementations that were previously in UiElementContaienrView into AssistantUiElement. In the future, UiElementContainerView will have no concept of AssistantTextElementView or AssistantCardElementView, it will only understand AssistantUiElementView. More details of the effort in the bug. Bug: b:145003512 Change-Id: I0228556d5837f5466ca8fd5f9fc59c6ffd1239a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954666 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#726636}
-
Kevin Marshall authored
Adds some JS resources served under chrome://resources/, which are included by other WebUI pages like chrome://gpu. Bug: 1017316 Change-Id: Iaa76bc6d561dea2fef63d4145e8224c35ae9b30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976592Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726635}
-
Kent Tamura authored
EvaluationContext had |bool had_type_conversion_error| field, and we had to copy the field manually whenever we cloned an EvaluationContext object to propagate an error to the top-level EvaluationContext. This CL changes the field to a mutable reference to bool, and it is shared between cloned EvaluationContext objects. Change-Id: I5f7e71a25337cfaf413ca98fccc9d3f16a04dba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975472 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#726634}
-
Emily Stark authored
Same-document navigations shouldn't clear content status flags, because if there was mixed content on the page, it's still there after a same-document navigation. In many same-document navigation cases, this fix doesn't matter because content status flags are copied as part of cloning the original NavigationEntry to create the new one (see the NavigationEntry::CloneAndReplace call in NavigationControllerImpl::RendererDidNavigateToNewPage). However, not all same-document navigations involve cloning an existing entry, and in these cases it is important to copy over the previous entry's content status flags. (See linked bug for an example.) Bug: 959571 Change-Id: I353995ea153b10736020e24f29eca6f7e7be9ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977395 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#726633}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7b55aac3b366..fe2ed33a56dd git log 7b55aac3b366..fe2ed33a56dd --date=short --first-parent --format='%ad %ae %s' 2019-12-19 syoussefi@chromium.org Translator: Output memory qualifiers in OutputTree 2019-12-19 lehoangq@gmail.com Metal: correctly clamp stencil reference values Created with: gclient setdep -r src/third_party/angle@fe2ed33a56dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I49ae1998ba6882b04a2d5ece0f1da3b3da6b75c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726632}
-
Jinsuk Kim authored
This CL takes care of the crash when preview tab is closed by 'close all incognito tabs' from Android notification UI. There are 2 problems: 1) |destroy| of BottomSheetContent that preview tab is built with needs to invoked only by BottomSheetController when the controller finds it not used any more. Removes the redundant (and unnecessary) destruction in the preview tab coordinator. 2) An incognito profile instance shared by multiple ProfileDestroyers was destroyed twice when it is triggered from RenderProcessHostObserver::RenderProcessHostDestroyed. This CL delays the actual destruction task all the way to the ProfileDestroyer dtor (which ensures the pending destroyer list is updated properly before the deletion), and uses DestroyOffTheRecordProfileNow to null out the pending object's pointer to the profile to be deleted, which helps avoid UAF. Bug: 1029677 Change-Id: I2710bb5ec2c35973da362c850434f71753175a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971031 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#726631}
-
Meilin Wang authored
This CL adds Assistant key to the supported accelerator list used in AutotestPrivateActivateAcceleratorFunction, so that we can mimic the key press to open/close the Assistant UI in the integration test through that API. Related CL using this API: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1975040 Misc: fixes Linter warnings. Bug: b/145218971 Test: local compile. Change-Id: Icafcaea356e55319ff7ccf4300a2b6a2ee697d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977192 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726630}
-
David Black authored
This is part of a multi-CL effort to clean up the AssistantUiElement modeling/rendering pipeline. Once complete, UiElementContainerView will only know about AssistantUiElementViews, not inheriting subclasses. More details in the bug. Bug: b:145003512 Change-Id: I6b9b96af2f7f7e73a19785d58104049f287616df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953700 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Ken MacKay authored
Changes the effective clock rate by interpolating samples online; does not require memory allocation. Intended to replace our AudioResampler. Test: cast_media_unittests Change-Id: I6563672f936c0d7e9cdf687f42fb42f1bbec1863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974600 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726628}
-
Michael Crouse authored
This change sets the default value for host model features to be an value that the prediction model can interpret as unknown (-1 in this case). This will improve the model accuracy when host model features are unvailable for the current navigation. Bug: 1036025 Change-Id: Iff7dab042829a540c06854f9ea7e84e187dbc7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977189Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#726627}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a436532f. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." 9899425d "[css-layout-api] IntrinsicSizes Implementation" d75fede5 "[EventTiming] Fix crossiframe test" 93b03639 "Roll WebGPU CTS" 01fd8522 "XPath: Fix normalize-space()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ibedf0d608dbd96588e655809068e60c32d6a2458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976852Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726626}
-
Anand K. Mistry authored
Bug: 1007788 Change-Id: Ic449af55f727461f70e7d130f0d489f86a731572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974297 Commit-Queue: Anand Mistry <amistry@chromium.org> Auto-Submit: Anand Mistry <amistry@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#726625}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifcbca772e2434935a7d78b43cbe75f2ff3170dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977322Reviewed-by:
-
Kristi Park authored
ImageEditorCoordinator will be renamed to ImageEditorDialogCoordinator and will be used to create the editor DialogFragment (ImageEditorCoordinator is used internally by the DialogFragment). Bug: 1024586 Change-Id: I29822893395022bdb661f535d87dbac35757b4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975110Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#726623}
-
Regan Hsu authored
Currently, ctrl+= (zoom in) and ctrl+- (zoom out) are ignored while the Screen lock pin keyboard dialog is onscreen. This CL ensures that when the user hits '-' or '=' with ctrl on, zoom in and zoom out occurs. Fixed: 1032527 Change-Id: I4e0e79bb732b05bc15508e8668e32022efc1ddd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976904Reviewed-by:
-
Xinghui Lu authored
Metrics added in this CL: 1. SafeBrowsing.RT.HasValidCacheManager This metrics is for checking if cache manager is valid when real time url check is enabled. 2. SafeBrowsing.RT.GetCacheResult This metrics is useful to identify the cache hit rate and the proportion between safe verdicts and dangerous verdicts. 3. SafeBrowsing.RT.GetCache.Time This metrics is useful to identify if the time to get cache is too long compared with its effectiveness. Bug: 1030989 Change-Id: I616ac3ad3bc207c907bd401801a09a9e46742818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974843 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726621}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f0ff36f6b2cb..78047ef063bb git log f0ff36f6b2cb..78047ef063bb --date=short --first-parent --format='%ad %ae %s' 2019-12-19 eirage@chromium.org Input replay Created with: gclient setdep -r src/third_party/devtools-frontend/src@78047ef063bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7c7e1e4bd5432eab2a4d00110af466be75b79d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976880Reviewed-by:
-
Avery Musbach authored
You shall be able to start dragging a window (not from overview), drag from one display to another, and snap. Also, WorkspaceWindowResizer shall meet the expectation documented in Issue 995413. Fixed: 986870 Bug: 995413 Change-Id: I7835c3762486c73fc9ab04a04f14d693e442f2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972170 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#726619}
-
Lucas Gadani authored
headers in the browser process. Bug: 759184 Change-Id: Iefb33fa8ec2264f3e224d5a3ab92417160848fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958692Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
James Cook authored
SplitSettingsSync changes Chrome OS settings to use a new URL for the sync config sub-page (chrome://os-settings/osSync). Change IsOSSettingsSubPage() to return false for "syncSetup", which will allow future CLs to call chrome::ShowSettingsSubpage(kSyncSetupSubPage) to open the browser sync settings. Bug: 1013466 Change-Id: Ica4fd4dc87befe402907f3ecbacb370655414401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977139Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#726617}
-
Bettina authored
The string had an "and" that wasn't needed and instead needed a "," in between the two domains. Bug: 1035811 Change-Id: Icc7e307389005f9860d1012bec050411c015de65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976853Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#726616}
-
chrome://extensionsArchana Simha authored
Bug: 986368 Change-Id: I2fe3a93d911bfac94f04ba62863bf80fad830514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924724 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726615}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/750660e15c3c..6d29348ddb7e git log 750660e15c3c..6d29348ddb7e --date=short --first-parent --format='%ad %ae %s' 2019-12-19 sugoi@google.com Enable filtering depth only formats Created with: gclient setdep -r src/third_party/swiftshader@6d29348ddb7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3d99f51c92eae7094c9c9d06dc1cb8ce2f2ccc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976918Reviewed-by:
-
Jiawei Shao authored
This patch adds all BC formats to Blink so that they can be used when the extension "textureCompressionBC" is enabled. BUG=chromium:996713 Change-Id: Ic35e9b6570d12273d09c8e688718509b4a88999a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975299Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#726613}
-
Alan Cutter authored
Change-Id: Ibf17313912ad4ce5f0b41cb1b9032dc70ec16690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971291 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#726612}
-
Victor Costan authored
Change-Id: I51596508f1db19f83dee2234b14f9f1a52a87b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975152 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#726611}
-
Nate Fischer authored
The WebViewClientTest#testOnSafeBrowsingHit() is flaky due to a subtle timing change when we switched to Network Service. This disables the test for now, while we look for a fix. This test was added in OMR1 (which we don't run CTS tests for in chromium waterfall), so we don't need to do anything for earlier API levels. The flaky part of the test was split out into testOnSafeBrowsingHitBackToSafety in Q, which we're already skipping in the JSON config. Bug: 1006953 Test: android_webview/tools/run_cts.py (on P device) Change-Id: I2c3e197484b1678722573ee052aed83150148417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975156 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726610}
-
Sajjad Mirza authored
Add definitions for tester machines for Windows coverage. Add buildbot definitions so the tryjob can run tests. Bug: 1033753 Change-Id: I3d933b1beaedd24ad206c9e5d2528ed5e4496b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972753Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#726609}
-
Xiaoqian Dai authored
To be consistent with the name of other WindowResizers. Bug: None Change-Id: I557b3beb6840fe60bd960490e1cf324bc910eeee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977184Reviewed-by:
-
Emily Stark authored
Currently, all cert error decisions (i.e., when a user clicks through a certificate error) are stored in ContentSettings, associated with a Profile. This means that if a user clicks through a certificate error in a <webview> in a Chrome App, that decisions propagates to normal browsing. Persisting decisions within a <webview> is undesirable on its own (because there's no UI to remind the user that they've done so and to allow them to revoke the decision), and it's especially undesirable for that decision to affect normal browsing. Therefore, this CL isolates cert error decisions by storage partition. Decisions made for the default storage partition are remembered in the normal way (ContentSettings for the Profile); decisions for other storage partitions are remembered in memory only. Bug: 639173 Change-Id: If1cca181c80f8d07f5411fbb0d3707cf3755c5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974698Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1ba8de1a..7f890a8e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I334028b5c8bab641c3dd635e429006b3c3bec86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977279Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726606}
-
Darwin Huang authored
Bug: 1035371, 1034695 Change-Id: Ia845e059d69417bcccf3f9ad6982d4df94fe5b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975290Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726605}
-
sczs authored
- Adds verifyFolderExists to BookmarkEarlGrey and its AppInterface. - Adds ScrollToTop to ChromeActions to be used on Bookmark Folder test. - Deletes BookmarkEarlGreyUtils since its no longer used. Change-Id: Ia1eeb07bcfa80f03e263c49d4f89b2592c338903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976490 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726604}
-
- 19 Dec, 2019 5 commits
-
-
Miguel Casas authored
This CL adds 4K resolution to the Fake Video Capture Device, a.k.a. the rolling pacman. TEST= unittests and ./out/desktop/chrome --use-fake-device-for-media-stream https://codepen.io/miguelao/full/bGNgOYq Bug: 1010457 Change-Id: Ibcab5e83a8bb09dbf4f1e6866951f1ccb9e41f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974995 Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#726603}
-
Kai Ninomiya authored
Using the "SafeEjectGPU" tool, we can see that when the "responsible" process (the browser process) has a GPUEjectPolicy of 'wait', any subordinates using the GPU (i.e. the GPU process) get the 'rwait' GPUEjectPolicy: "Eject actions apply to the responsible process, who in turn deals with subordinates to eliminate their ejecting eGPU references." [man 8 SafeEjectGPU] Empirically, the browser does not relaunch. Once the GPU process exits, it appears that the browser process is no longer considered to be using the GPU, so it "succeeds" the "wait". Documentation: https://developer.apple.com/documentation/metal/gpu_selection_in_macos/handling_external_gpu_additions_and_removals Change-Id: Ia44c2ed864d1bdbb52d82ad72e14cbfcb4e32108 Bug: 1035619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974856Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#726602}
-
Manas Verma authored
Bug: 949269 Change-Id: I914b20bc5532a4df59120f6954235b1a5daa9013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977185Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#726601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5acad7aa14e2..330a8816909a Created with: gclient setdep -r src-internal@330a8816909a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029520,chromium:984162 Tbr: jbudorick@google.com Change-Id: I12e810a1d1e6fb72bf726936dc6ee9b9112b7e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977080Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726600}
-
Alexey Baskakov authored
Observe OnWebAppWillBeUninstalled instead of OnWebAppUninstalled. It's too late to obtain the app pointer from the registrar after a web app uninstall (deletion) happened. Bug: 1029221 Change-Id: I7794ed4fa7ed52ac396949eed88bd4514ed2154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975473Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#726599}
-
