- 05 Oct, 2020 40 commits
-
-
Kaustubha Govind authored
Extending the Cookie.ExpirationDurationMinutes* metrics through mid-2021. This data will be helpful in informing potential future work on limiting lifetime of cookies. Also, splitting up the histogram based on whether the 'Secure' attribute is specified, since we may target intervention on non-secure cookies, as per draft-west-cookie-incrementalism.html#rfc.section.3.6 Bug: 1088694 Change-Id: Ief1fe0b732df34b71d29f5e0a72dfb40fd9a0851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445910Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Cr-Commit-Position: refs/heads/master@{#813950}
-
Oleh Lamzin authored
Fix typo in session_manager_types.h by renaming SESSION_STATE_LOGIN_PRIMARY to LOGIN_PRIMARY. Also this change helps to be consistent within the file when mention states in comments. Change-Id: I268421fc01d79fa712da41da6a97ea04f253430f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450072 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#813949}
-
Mehran Mahmoudi authored
Bug: 1135054 Change-Id: Idec0ddfab4877137e6a7deca395370b6619a9206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450717 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813948}
-
Yulun Wu authored
This addresses the changes in these CLs https://chromium-review.googlesource.com/c/chromium/src/+/2363799 Bug: 1134854 Change-Id: I522e5ebe9228bec7e12b9037ee4a4b95b2593c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446547Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813947}
-
Chris Thompson authored
This reverts commit 8fd53893 (which reverted the original change in commit 0d9bc827). The cause for the revert was fixed in commit 06c4cc74. Original change's description: > Remove net::ct::CTVerifyResult and merge with net::CertVerifyResult > > As part of moving CT verification to occur within the state machine > of cert verification, move the CTVerifyResult fields into the > CertVerifyResult as appropriate. > > As a nice side benefit, this allows CT verification details to be > handled in browser tests using ContentMockCertVerifier. > > Bug: 848277, 1016635 > Change-Id: I365358ca12ecd9205d8103ed0e3396cdb48144b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423060 > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810364} TBR=rsleevi@chromium.org,kouhei@chromium.org,estark@chromium.org,cthomp@chromium.org,rmcelrath@chromium.org Bug: 848277, 1016635 Change-Id: I170cafdd9aed46fed4de0e6afa34b3308ebbd6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450735Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813946}
-
Sam Sebree authored
This change updates the styling for the link controls in dark mode. Bug: 1107287 Change-Id: I62b7a05320c9a6e2597614411eee627bc72e4813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437822 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#813945}
-
Nate Fischer authored
No change to logic for Chrome, this only affects WebView. This adds an option to VariationsSeedStore to configure it to avoid accessing the "first run" Java SharedPreferences. Any access to SharedPreferences may perform disk IO; since WebView initializes variations on the UI thread, this causes a strictmode violation. WebView doesn't use the first run prefs, so this adds a configuration parameter to completely avoid SharedPreferences. This also adds unit tests to verify SharedPreferences are not modified when this parameter is passed. Fixed: 1131941 Test: out/Default/bin/run_components_unittests -f VariationsSeedStore* Test: android_webview/tools/run_cts.py -m CtsWebViewStartupApp.apk Test: Locally add 'assert false' next to SharedPreferences access, verify WebView doesn't crash Change-Id: I137fcbc49b4619dcde84fa1d0375edf6d421c8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444473 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813944}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f0c89bd5660..eacbd972ab7e 2020-10-05 alessiob@webrtc.org AGC2 logs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I34c7e6b0cd5d56b25ed982dec225be1cef321986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813943}
-
minch authored
Bug: 1133762 Change-Id: I98c7f1323e46abf81b1349272cef1865b9575c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441809 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#813942}
-
John Lee authored
A drop event is not fired if a drag interaction did not have any x/y pointer movement. This CL moves the contextmenu call to the dragend, as the dragevent is consistently sent at the end of every drag flow. Bug: 1117652 Change-Id: I9e3fc078fcc2843808d3db454feb39084b97794d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446353 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#813941}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/df909306835a..b04a92f01be0 2020-10-05 enga@chromium.org Add a per-thread proc table using thread local storage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I5b8a66c618951312fdc5d3ede4f0c861ef17cd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450581Reviewed-by:
-
Chris Sharp authored
on Linux TBR=ghazale@chromium.org BUG=1134506 Change-Id: Id490ab99c96ea5eadf7dc4dfc564a23f7172e186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450953Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813939}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601899131-feda22e3411bdb75c005a38c5197b1e76964f668.profdata to chrome-linux-master-1601920728-6028d40b51a1c3ae51d439d61f82d0425613d326.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I34aa50af4524c1182188002006702aafadca8f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450791Reviewed-by:
-
Yuwei Huang authored
This is a simpler approach to tackle (workaround) the blocked network thread issue when compared to CL 2436278. This CL simply creates a base::Watchdog that arms before closing the peer connection, and disarms after the peer connection is closed. If thread join takes longer than expected then it will crash the host so that the daemon process can respawn it. Bug: 1130090 Change-Id: Ib2400e17b848ed07df902a02b344efbf5e15c588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446840Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#813937}
-
Ramin Halavati authored
Incognito dynamic quota has been enabled by default. The feature and experimental test code are cleaned up. Bug: 1017120 Change-Id: I18895ae16dbd2641cf67d8f113b56509da67c7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426570Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#813936}
-
Adam Ettenberger authored
This change was split out of the following CL after it was reverted : https://chromium-review.googlesource.com/c/chromium/src/+/2346933 Reland "Fix Role::kButton name invalidation when descendant text is modified" This change wraps inserting into memoized sets in BrowserAccessibilityManagerWin with a method and adds DCHECKs to ensure the sets are only inserted within the scope of OnAccessibilityEvents. - FireUiaTextContainerEvent made it possible to fire text events more than once for a given text provider so it has been removed. - Instead, populate a set |text_changed_events_| which contains the text providers via |GetUiaTextPatternProvider| and fire the UIA text events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents - |text_selection_changed_events_| could also potentially end up with the same double-event problem, so it uses GetUiaTextPatternProvider now as well. - Removing usage of std::unordered_set based on the guidance in base/containers/README.md. In general these sets shouldn't grow large enough to benefit from being unordered. Bug: none Change-Id: Ic41ced4dede40c4597d5f79aa4b7f36a7d0c994a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391766 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813935}
-
Jamie Madill authored
The Linux/Win OS was missing from several bots. Needed to use 'linux_args' for SwANGLE tests. Bug: angleproject:5124 Change-Id: I075ce275d4f7ed49c71189db55a3f807d45a4b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446995Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#813934}
-
David Bertoni authored
This CL parameterizes the existing Metrics API test to run as both a persistent background page and Service Worker-based extension. Bug: 1093066 Change-Id: Iaf610882e7e4780298a58a66aac1a994015449cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441192 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#813933}
-
Caitlin Fischer authored
Also, add http://crbug/1134146 to clean up the feature-related code in media/blink/video_frame_compositor_unittest.cc. Bug: 1126640 Change-Id: Ibaaacb382ac80c443a25c7c27d3f943bb789cc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442870Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813932}
-
Jimmy Gong authored
Responsible for sending the the cros state to the user's phone. Bug: 1106937 Test: chromeos_components_unittests Change-Id: Ibe730b1796dd6d100db27def461821da8f9bbcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443758 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813931}
-
Greg Thompson authored
- Add a second owner to some histograms. - Remove GoogleUpdate.UnexpectedState since it was never hit. - Push expiry of the other GoogleUpdate.* histograms out one milestone. - Switch to histogam functions since these are low-frequency histograms. - Mark a few related histogram enum values as deprecated. - Add a few popular values to the "Hresult" enum. - Fix the names of a pair of enum values. BUG=1088811 R=chromium-metrics-reviews@google.com Change-Id: Iec95d1ba80a2cad16e9dd086a0d663393c7c6f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438535Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813930}
-
Weilun Shi authored
Add assertion to generate_expired_histograms_array to make sure the --inputs always keeps in sync with |histogram_paths.ALL_XMLS|. Otherwise, the script will fail and ask users to update build targets --inputs. Bug: 1134434 Change-Id: I586c967e553aae9a7aba7bec5a887947aef4e7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446205 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Matt Reynolds authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. BUG=1018739 Change-Id: I1eb15302d1c881068f59edffe1f0c85c4a2c1349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442199Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#813928}
-
Dana Fried authored
Bug: 1122214 Change-Id: Iabebb62c8bcdfcd2e65dda6f09fa99869648c316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450712 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813927}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e61500059aa7..7a7bec371a3c 2020-10-05 johnstiles@google.com Capitalize static class methods. 2020-10-05 ethannicholas@google.com fixed Google3 build failure 2020-10-05 ethannicholas@google.com moved SkSL ForStatement data into IRNode 2020-10-05 bungeman@google.com Reland "Remove use of legacy display globals." 2020-10-05 herb@google.com add pixel xl to skpbench 2020-10-05 nigeltao@google.com Have SkWuffsCodec use PIXEL_BLEND__SRC_OVER 2020-10-05 bsalomon@google.com Remove unused variant of SkImage::MakeFromYUVAPixmaps 2020-10-05 ethannicholas@google.com Revert "Revert "moved SkSL Field data into IRNode"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I54690ccc0e72951e5f40742091cfac929c9ce801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450790Reviewed-by:
-
Francois Doray authored
setTimeout(..., 0) can be used to schedule a continuation. Opting out these timers from throttling reduces latency to receive notifications on some background pages and does not significantly affect speed or resource usage. Full cleanup will happen after the 1% Stable Experiment is complete. Experiment results: https://docs.google.com/document/d/1frGCY_ZCM0VYwThAVAxNRvEDnd5hbAHDgkyA5Tsawts/edit?usp=sharing Bug: 1075553 Change-Id: I0c1546d13e0aa8891479370ffb1706b75c9c77d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443230 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#813925}
-
Christopher Cameron authored
Restrict this to macOS 10.11 and above. In theory the function should not compile when targeting macOS 10.10. In practice it does, because the CoreMedia constants are preprocessor defined to their CoreVideo equivalents (which are defined). This function is nearly identical to media::GetImageBufferColorSpace, but instead operates on a CMFormatDescriptionRef. Add DCHECKs that the behavior of the two functions be the same, that is, the kCVImageBuffer-prefixed and kCMFormatDescription-prefixed constants be equal. Use base::mac::CFCast instead of reinterpret_casts. The next patch in this sequence will move these two functions over to media/base/mac, because it will be accessed in capture. Bug: 959962 Change-Id: Iea9d8d357dec72ddc928b7e1fd3a631c131ade74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449934Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#813924}
-
Austin Eng authored
On Linux, WebGPU shared images require a Vulkan GrContext. The current webgpu_decoder_unittest doesn't have a way to request this whereas webgpu_mailbox_unittest can correctly set up the context with shared image support. Move the tests so we can enable them on Linux. Bug: 976495 Change-Id: I11283e556d36a641e183857c087ca35f87e1e6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443975 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#813923}
-
Daniel Hosseinian authored
This is the last step before rolling out the feature to 100% stable. Bug: 696650 Change-Id: If76f9d1d1c54c51515ee891560d43c003699a623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450950 Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#813922}
-
George Steel authored
Because composited animations are inaccessible from js, reftests are necessary to test their behavior. In this set, the file transform-interpolation-reftests.js defines the tests themselves and several wrapper html files each run a subset of them (this structure is due to the lack of support for test variants in reftests). As these tests are specifically meant for testing compositor animations, add css-transforms to the virtual/threaded suite to test with threaded compositing. As this has found several errors, bugs have been filed and linked to the threaded cases in TestExpectations Bug: 1131196, 1133901, 1131252 Change-Id: I9c6d92727e52a3ec11fe56f3375fc352baeadf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443209Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813921}
-
David Tseng authored
R=akihiroota@chromium.org sticky mode won't toggle off/on when encountering text fields even with Smart Sticky mode on. Bug: none Change-Id: I7e06c30daefa70835e6f09cce33867fcf3c3c46f AX-Relnotes: When performing ChromeVox's read from here (Search+R) command, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448061Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813920}
-
Andre Le authored
- Remove kConnecting and add timer to track requested state in find my device controller. - Edit FakeFindMyDeviceController to use for unit test. - Remove a TODO in enable hotspot since unnecessary. BUG=1106937,1126208 Change-Id: Ic5a5dd2126313b2b22885ce8a23237fe281e762a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446815 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#813919}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I02b373fe9b872292f634f87aa587727c3f9ccd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450490Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#813918}
-
Tina Wang authored
1. Added EG tests for the managed items and click actions. 2. Added constants to autofill_constants and formatted the existing ones. 3. Improved the helper api by: - adding scroll action to avoid issue while testing on small screens. - simplify the parameters. Bug: 131052 Change-Id: Ibe507443a07b1fe7e5c2374bf8b5a1436b43461b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441191Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813917}
-
manukh authored
Rich AC uses FindAtWordbreak and split rich AC (future CL) will use 2 additional utility methods regarding searching for terms in strings. This CL adds the latter 2 methods and moves the 3 methods to inline_autocompletion_util.cc. Bug: 1062446 Change-Id: I49a90c9ce8a17c0ff81a18c56c5151ca6c2f8608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450700Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#813916}
-
David Tseng authored
This getter returns an instance of Cursor, but it should return an instance of either Cursor or WrappingCursor. R=akihiroota@chromium.org of a page that has a text field at the end. Bug: none Change-Id: Id52523c4b391d175303130c3f5494a1bf63c2f13 AX-Relnotes: ChromeVox will now wrap correctly when moving forward from the end Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450209Reviewed-by:
-
Caitlin Fischer authored
This is done by updating the histograms config model and by uncommenting the call to ExpandHistogramsOWNERS() in merge_xml.py. This ensures <owner>src/dir/OWNERS</owner> is expanded into actual owners, e.g. <owner>name1@google.com</owner> and <owner>name2@chromium.org</owner>. Uncommenting this allows components to be extracted from OWNERS files as well. That way, component info, if available in an OWNERS file, is added to histogram expiry bugs, e.g. http://crbug/1088985. Also, add component documentation and add a component to two Variations.Headers.* histograms. Support was previously added for component tags, see http://crbug/989112 for details, but it wasn't explicitly used. Bug: 1133699 Change-Id: I572c877be8929923fd14df352e762a7a293ca5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442136Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813914}
-
Chris Sharp authored
TBR=qinmin@chromium.org Bug: 1106059 Change-Id: Ie241c0a80c0f6b6788f8a8ee6df7208f57f42d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449911Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/745402dd650a..96edaff6ceb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kristipark@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073584,chromium:1129255 Tbr: kristipark@google.com,csharp@google.com Change-Id: I8522a9d6cd92e9e6d353bdc85db4d7e68b342ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813912}
-
Muyao Xu authored
The user can start a new cast session by clicking on the cast device button. If the session starts successfully, the GMC dialog will be closed. If the session fails to start, an error message will show up as the subtitle on the button (This is implemented by the CastDialogController class. Bug: b/161610050, 1107162 Change-Id: Ibaad612115ba73d8e883455cf89ec6e1a6cda401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441107Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
