- 06 Apr, 2018 40 commits
-
-
Fredrik Söderquist authored
Update FontDescription::BolderWeight and LighterWeight to match the table in https://drafts.csswg.org/css-fonts-4/#font-weight-prop . Bug: 809956 Change-Id: I18cb9a10ef3d86f68113bb0663e5364d0120a739 Reviewed-on: https://chromium-review.googlesource.com/997592 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#548741}
-
Vaclav Brozek authored
IOSFormParser is a class used on iOS to turn a HTML description of password forms into an internal PasswordForm structure. The class has no data members and the only method, Parse(), is thus effectively static. It was created as a class for two reasons: (1) to allow mocking, and (2) to enable holding some server-supplied state. I chatted with dvadym@ and we agreed that once this actually needs being mocked, we can assess the concrete needs, and perhaps change some alternative (e.g., providing a fake result for testing) to mocking which would still require adding a virtual interface and other boilerplate. Holding the server-supplied state might also likely end up in PasswordFormManager. Because it is confusing to create IOSFormParser instances in the current code and the two concerns above seem addressed, this CL turns IOSFormParser into a single static function, ParseFormData(), following the existing pattern found in components/password_manager/core/browser/import/csv_reader.h. Bug: 827945 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idbbd5087f301bb07974364f7b8bd324ed42a0fa5 Reviewed-on: https://chromium-review.googlesource.com/990333 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#548740}
-
Matt Falkenhagen authored
This adds support for: * Service worker intercepting the main script request for a shared worker. * Service worker intercepting subresource requests from a shared worker (i.e., importScripts, fetch/xhr). These tests now pass: external/wpt/service-workers/service-worker/claim-shared-worker-fetch.https.html external/wpt/service-workers/service-worker/shared-worker-controlled.https.html Here is the basic flow: 1) Renderer (Main): calls new SharedWorker() 2) Browser (UI): SharedWorkerServiceImpl starts preparing the shared worker. 3) Browser (IO): With this patch, here we create the ServiceWorkerProviderHost for the shared worker, and SharedWorkerScriptLoaderFactory (a URLLoaderFactory subclass) for loading the main script. 4) Renderer (Main): SharedWorkerFactory::Start is called by the browser. The URLLoaderFactory and provider host info are passed into it. It starts the shared worker, creating the shadow page and ServiceWorkerNetworkProvider. The network provider uses the browser-assigned provider_id. The shared worker uses the URLLoaderFactory to load the main script, via WebServiceWorkerNetworkProviderForSharedWorker::CreateURLLoader. 5) Browser (IO): SharedWorkerScriptLoaderFactory creates a SharedWorkerScriptLoader for the request. This loader behaves like NavigationURLLoaderNetworkService: it allows ServiceWorkerControlleeRequestHandler to interept the request (setting the controller and dispatching a fetch event), or goes to network. On redirects, it repeats for the new URL. 6) Renderer (Worker): After the worker starts up, it can make requests using importScripts() or fetch/xhr. importScripts() go to the main thread's WebServiceWorkerNetworkProviderForSharedWorker::CreateURLLoader like before, which forwards the request to the controller. fetch/xhr go through off-main-thread fetch, which also forwards the request to the controller. Unlike navigations, this doesn't pass SubresourceLoaderParams along with the response. This means the controller info (sent via the SetController IPC) can be received after the script response. To guarantee the controller info is received before starting the worker, a ping/pong to the ServiceWorkerContainerHost interface is performed after the script is received. Once the pong is received, we know the SetController IPC must have been received, so we can continue starting the worker. Design doc: https://docs.google.com/document/d/1KuzxwHMSgj4w-QH6f_Ks1QFcGjM36mEomGp6X-T3tqc/edit?usp=sharing Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia064cd694a41491cf4023202e44e96dba759e969 Bug: 796819 Reviewed-on: https://chromium-review.googlesource.com/981845 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#548739}
-
Max Morin authored
Bug: None No-Try: true Change-Id: Id77f44682a682c7edbf0df365392737870ecfb5b Reviewed-on: https://chromium-review.googlesource.com/997744 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#548738}
-
Ramin Halavati authored
Change-Id: I57a7aab0e1dead805863f974aca238d09aa3162d Reviewed-on: https://chromium-review.googlesource.com/999487Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#548737}
-
arthursonzogni authored
Add a new Chrome Apps test. It tries to open a new window using chrome.app.window.create() with a file that does not exist. The callback must be called with createdWindow == undefined. Bug: 820995 Change-Id: Iaffe9373e2f19f30d473f3bd165c1a2822f85073 Reviewed-on: https://chromium-review.googlesource.com/986437 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#548736}
-
Marina Ciocea authored
Add implementation of media::mojom::AudioInputStream to audio service. This implementation is not used yet, it will be used in a future CL introducing input stream factory. UserInputMonitor is also not used, and will be moved to audio service in a future CL. Also removed AIC::Create branch that returns null if params are invalid, as params are verified many times along the way to AIC and should be valid. Bug: 803102 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib0b3c381bb9d5493e22047f13d093a87c252229c Reviewed-on: https://chromium-review.googlesource.com/975642 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548735}
-
Yuta Kitamura authored
This class is Blink's public interface, so its name should start with "Web". This is a follow-up of crrev.com/c/986112. Bug: 826203 Change-Id: I88933aa86fbe64c695cc10a76ce36edc1b981f7a Reviewed-on: https://chromium-review.googlesource.com/989386Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#548734}
-
Michael van Ouwerkerk authored
This reverts commit 023aea51. Reason for revert: Causing downstream compile failure. Bug:755921,710720,828968,829765 Original change's description: > Custom Tabs: permanently disable prerender from custom tabs. > > Removes the ability to set a prerender speculation mode for custom tabs, > making the background (hidden) tab the only option. Where appropriate, > method names mentioning "prerender" have been changed to > generically refer to "speculation". In one case shims for > shouldPrerenderOnCellularForSession, etc, have been left in so that > downstream code can be changed in a future CL. > > Bug: 755921,710720, 828968 > Change-Id: I7234fad18a9616ae65f20af39da4a0261cf75935 > Reviewed-on: https://chromium-review.googlesource.com/979992 > Commit-Queue: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548717} TBR=pasko@chromium.org,bauerb@chromium.org,gayane@chromium.org,lizeb@chromium.org,mattcary@chromium.org Change-Id: Ib6105a4f7f5d1721374e2b27ba818a86640b7903 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755921, 710720, 828968 Reviewed-on: https://chromium-review.googlesource.com/998895Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#548733}
-
Elad Alon authored
RunFunction() was verifying whether a value was returned, then the test bodies were also verifying the same thing. This CL fixes. Bug: 814402 Change-Id: I177053ee53d1f651ad0cda986b78148759ddcea9 Reviewed-on: https://chromium-review.googlesource.com/986266Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548732}
-
Erik Chen authored
The out of process heap profiler only requires modules to be dumped, not every single virtual memory region. This CL modifies the interface to support this, and updates the macOS implementation to be much faster. The other OSes currently still perform full address space dumps - this can be changed in the future if it proves to be a performance issue. Bug: 826913 Change-Id: Ibaa03d3dfae71a2b6d090aed0ab2ffdc4bb090a9 Reviewed-on: https://chromium-review.googlesource.com/986680 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#548731}
-
Daniel Bratell authored
Earlier this year, all kSha2Hash got longer names but two kSha256Hash must have remained, and now they ended up in the same translation unit and jumbo on Windows stopped compiling. This renaming follows the pattern of earlier renames. TBR=thestig@chromium.org Change-Id: I95b7d6b7e5f43f25bee8e98aa3eeeb4de9d7e55f Reviewed-on: https://chromium-review.googlesource.com/999415Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#548730}
-
Philip Jägenstedt authored
Bug: 829761 Change-Id: I1b7b0f849b9d28fa7b46a7fe789459ada7f94fe3 No-Try: true TBR: jsbell@chromium.org, pwnall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/998097Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#548729}
-
Farah Charab authored
normal priority queues. Modify the task queue selection and starvation logic, and add the relevent unit tests. Rename kHighPriority to kHighestPriority, and modify the affected code. The introduced priority is kHighPriority. Change-Id: If6d928180e8848f5492a64ce6a3d504219658376 Reviewed-on: https://chromium-review.googlesource.com/978011 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548728}
-
Yoshifumi Inoue authored
This patch changes "5418891.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "5418891.html" to "break_blockquote_at_end_of_content.html". Bug: 679977 Change-Id: I753287bf7be767e48f3547a2ecc319930a57a9a0 Reviewed-on: https://chromium-review.googlesource.com/999223Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548727}
-
Seth Hampson authored
The WebRTC change has rolled in that these 2 tests were disabled for. One is being re-enabled and updated to pass, while the other is being removed because it is no longer relevant. Bug: webrtc:7932, webrtc:7933 Change-Id: Ia0a9f61997a1640c37fdc8e632f28543169b2161 Reviewed-on: https://chromium-review.googlesource.com/995961Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#548726}
-
Koji Ishii authored
Manual review of IMAGE/IMAGE+TEXT failures after the Time New Roman change in crbug.com/787020, a series started in CL:997255. This time is the result of manual reviews, up to fast/ in the alphabetical order, from bot result #4607. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6b909b760144ffed884a3f984253835ed388a2b9 Reviewed-on: https://chromium-review.googlesource.com/999459 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#548725}
-
https://skia.googlesource.com/skia.git/+log/7768fa17b795..485dc868fff7 $ git log 7768fa17b..485dc868f --date=short --no-merges --format='%ad %ae %s' 2018-04-06 update-docs Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I183d2f42fd03609d6d01bf3e5a40efcb9bd9a445 Reviewed-on: https://chromium-review.googlesource.com/999309Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548724}
-
https://webrtc.googlesource.com/src.git/+log/19aab2ee7c6b..83d676bd1505 $ git log 19aab2ee7..83d676bd1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icb6da3755f6049f859a68bed0a3084d8e5fb6396 Reviewed-on: https://chromium-review.googlesource.com/999104 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548723}
-
Fredrik Söderquist authored
We were previously always using the "left edge" of the fragment bounding box when computing the position within the fragment. This works poorly for vertical text. Use "top edge" for the vertical case instead. Bug: 829214 Change-Id: I52e0aeffa95d05b1c86cd6aeca5dde7a886db486 Reviewed-on: https://chromium-review.googlesource.com/997792 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548722}
-
Henrik Boström authored
The assert_object_equals would fail due to timestamps being different in rare runs where the getStats() cache was invalidated between the two calls. external/wpt/webrtc should make no assumptions about any cache. Tests are updated only to compare stats IDs, not individual metrics. Bug: 829401 Change-Id: I6fcc781a1827af69f47a5c4416dd5e6bae0c98b3 Reviewed-on: https://chromium-review.googlesource.com/999477Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#548721}
-
Takashi Toyoshima authored
This patch adds preflight cache and request implementation in cors::PreflightController. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3681fee55e58636c00218e25eafc446bdd9e30e8 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/992212 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#548720}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I07e9d3d051c0d4b01aeeafd86e06716ed8473af7 Reviewed-on: https://chromium-review.googlesource.com/987594 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548719}
-
Giovanni Ortuño Urquidi authored
Changes tests to use embedded test servers so that URLs can be loaded successfully. This deflakes tests and allows us to test more cases e.g. pages with mixed content, pages with invalid certificates etc. Also adds tests for mixed content and invalid certificates. Based on https://crrev.com/c/923226 by mgiuca. Bug: 825713, 814400 Change-Id: I8603f3e6340eebbbc2faed594825745aed10bb0a Reviewed-on: https://chromium-review.googlesource.com/994553Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#548718}
-
Matthew Cary authored
Removes the ability to set a prerender speculation mode for custom tabs, making the background (hidden) tab the only option. Where appropriate, method names mentioning "prerender" have been changed to generically refer to "speculation". In one case shims for shouldPrerenderOnCellularForSession, etc, have been left in so that downstream code can be changed in a future CL. Bug: 755921,710720, 828968 Change-Id: I7234fad18a9616ae65f20af39da4a0261cf75935 Reviewed-on: https://chromium-review.googlesource.com/979992 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#548717}
-
Luciano Pacheco authored
Bug: 829203 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I605b89d1015fb6a145951871a05bc2db6cf6676e Reviewed-on: https://chromium-review.googlesource.com/999274 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#548716}
-
Gauthier Ambard authored
This CL adds the feature tracker to display the "new" badge for the reading list in the tools menu. Bug: 828382 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifff04e7d6f1ad255759905e88a0a8faceb4d79ff Reviewed-on: https://chromium-review.googlesource.com/997814 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548715}
-
Koji Ishii authored
Manual review of IMAGE/IMAGE+TEXT failures after the Time New Roman change in crbug.com/787020, a series started in CL:997255. This time is the result of manual reviews, up to css3/ in the alphabetical order, from bot result #4607. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0fe34a9bcc6d987018950369e901918bd7f9e928 Reviewed-on: https://chromium-review.googlesource.com/999456 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#548714}
-
Hitoshi Yoshida authored
Those IDL files listed in the file are managed in {core,modules}_idl_files.gni as *_global_constructors_generated_idl_files. Bug: None Change-Id: I7e28508ba3388bc0a02d4537c51790cb85eec7f7 Reviewed-on: https://chromium-review.googlesource.com/999454Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#548713}
-
Daniel Bratell authored
In jumbo build experiments the presence of two different OnCheckIsDefaultBrowserFinished functions meant that Bind didn't know which one to bind and it didn't compile. This patch renames one OnCheckIsDefaultBrowserFinished to OpenURLAfterCheckIsDefaultBrowser which seems like a good name for that function. Bug: 803406 Change-Id: I056e613b7e3d55c0b2dbde68db8d75d3e2c55876 Reviewed-on: https://chromium-review.googlesource.com/998152Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#548712}
-
Daniel Bratell authored
In jumbo build experiments (no jumbo for chromium/browser/ui yet) two GetProfileFromWebContents ended up in the same translation unit. Each of them was only used once. This inlines them both. I dropped the null check from the GetProfileFromWebContents() in account_chooser_dialog_view.cc because if that helper returned null, then the code would already crash inside GetDefaultStoragePartition() (GetStoragePartitionFromConfig() will call browser_context->IsOffTheRecord() without any null check). Bug: 803406 Change-Id: I0200eb42c0a54b674eaec6122e1193c931dd2344 Reviewed-on: https://chromium-review.googlesource.com/997793Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#548711}
-
Darren Shen authored
Test consistently failing on Mac10.11 and flaky on Mac10.10. TBR=nednguyen@chromium.org No-Try: true No-Presubmit: true No-Tree-Checks: true Bug: 829161 Change-Id: I89fc7186a5c3c76853ec666bca57409e76950d73 Reviewed-on: https://chromium-review.googlesource.com/999232 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#548710}
-
Gauthier Ambard authored
This CL change the navigation history menu to be the new navigation menu by default when the UI Refresh flag is enabled. Bug: 804779, 828771 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib0bc001275102400538d989f1e7af744a8e1d18a Reviewed-on: https://chromium-review.googlesource.com/995441 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#548709}
-
Kenichi Ishibashi authored
Before this CL, DeleteSoon() could be called twice when a connection error happens on |url_loader_binding_|. - ServiceWorkerSubresourceLoader sets DeleteSoon() as the connection error handler. - The class also calls DeleteSoon() when the loader is no longer needed. For example, it delete itself when a request falls back to network. After this CL we just call delete directly as needed. Existing DeleteSoon() is renamed to OnConnectionError() as it is only used as the connection error handler. Bug: 828257 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I85737d0d6c33b747a4f70f5156b2b3b4b512f873 Reviewed-on: https://chromium-review.googlesource.com/997256 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#548708}
-
Koji Ishii authored
Following bot results are included. 4591 4592 4593 4595 4597 4599 4602 4606 4607 6 lines were removed and 18 lines were deflaked by consecutive results since 4542. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9f5e4be8dfc280e99d9a78e0808c26488944a093 Reviewed-on: https://chromium-review.googlesource.com/997321 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#548707}
-
https://skia.googlesource.com/skia.git/+log/bf74a460814a..7768fa17b795 $ git log bf74a4608..7768fa17b --date=short --no-merges --format='%ad %ae %s' 2018-04-05 angle-skia-autoroll Roll third_party/externals/angle2/ dd196e0bc..c3755fc56 (5 commits) 2018-04-05 caryclark remove SK_IGNORE_TO_STRING 2018-03-29 bungeman Distinguish between glyphs with empty path and no path. 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ 6959d4597..24c91d143 (1 commit) 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ d75edb2e3..6959d4597 (1 commit) 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ a7974d9f6..d75edb2e3 (1 commit) 2018-04-05 fmalita Clip SlideDir slides to their declared dimensions 2018-04-05 bungeman Mac to better serialize OTTO fonts. 2018-04-05 robertphillips Revert "Remove deprectated GrContext::MakeGL overloads that take raw ptr" 2018-04-05 bsalomon Remove SK_DISABLE_TEXTURE_OP_AA 2018-04-05 fmalita [viewer] Consolidate external slide loading 2018-04-05 liyuqian Flush before snap SkThreadedBMPDevice 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ 3cb9ba6ae..a7974d9f6 (3 commits) 2018-04-04 bryct Update 'Working in a Chromium repo' documentation. 2018-04-05 kjlubick Avoid nonsortable rects in drawRect/drawOval 2018-04-04 bsalomon Remove deprectated GrContext::MakeGL overloads that take raw ptr 2018-04-05 bsalomon Add maxTextureSize()/maxRenderTargetSize() to GrContext 2018-04-05 fmalita Viewer SVG support 2018-04-04 bungeman Via*::draw to finish before checking. 2018-04-05 reed replace size-alignment assert with round-down 2018-04-05 angle-skia-autoroll Roll third_party/externals/angle2/ bc54342bf..dd196e0bc (14 commits) 2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ d26d270c8..3cb9ba6ae (7 commits) 2018-04-02 halcanary SkPDF: implement xheight for type3 fonts 2018-04-05 robertphillips Add GrBackendTexture/RenderTarget accessors to SkSurface 2018-04-05 robertphillips Add SK_API to SkSurfaceCharacterization 2018-04-03 halcanary experimental/tools: minor code cleanup 2018-04-04 brianosman Workaround for lack of ESSL3 external image extension on older Samsung devices 2018-04-05 caryclark tweak SkImage documentation 2018-04-05 robertphillips Fix iOS bot in Chrome CQ 2018-04-05 update-docs Update markdown files 2018-04-04 bsalomon Avoid calling glGetString(GL_EXTENSIONS) on core profiles 2018-04-04 bsalomon Stop using clear-as-draw workaround on newer Intel drivers on macOS 2018-04-04 liyuqian Ensure that pointers/arrays are valid until flush in threaded backend 2018-04-04 benjaminwagner Add loongson3a Build jobs. 2018-04-04 robertphillips Add GrBackendTexture accessor to SkImage (take 2) 2018-04-04 reed move SkIPoint16 to private header 2018-04-04 benjaminwagner Update mips64el_toolchain_linux to GCC 7 2018-04-04 fmalita Fix SkLocalMatrixShader nesting semantics 2018-04-04 egdaniel Make sure we set the origin when initDescForDstCopy fails 2018-04-04 fmalita Banish SkShaderBase::isRasterPipelineOnly() Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I8a5d0c4e84954bcebd8fc4e09327cc0cb009975a Reviewed-on: https://chromium-review.googlesource.com/998395Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548706}
-
Darren Shen authored
We cannot support background-repeat and background-position yet because they are both implemented as shorthands in Blink, but are not shorthands in the spec. We'd need to refactor the existing code to allow shorthands to reify as proper Typed OM objects. There are also some tricky bits to support styleMap.set with shorthands given a proper Typed OM object. Bug: 820299 Change-Id: I064ce37a48bee3d73965b66b323e20abf5a9099f Reviewed-on: https://chromium-review.googlesource.com/994593 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#548705}
-
Xiaohan Wang authored
This CL adds DeferredDestroyStrongBindingSet such that mojom::Foo impl will only be destroyed when: - mojom::Foo connection error happens, AND FooImpl calls the DestroyCallback, or - DeferredDestroyStrongBindingSet is destroyed. This helps solve tricky lifetime issues where we do not want destroy the implementation immediately. For example, currently when connection error on mojom::CdmFactory happens, CdmFactoryImpl will be destroyed, which will also destroy all CDMs owned by CdmFactoryImpl. However, this could happen before MojoCdm is stopped in the render process, causing unexpected behavior. See the bug for more details. This CL also fixes the CdmFactoryImpl lifetime issue by using the DeferredDestroyStrongBindingSet, and let CdmFactoryImpl only call the DestroyCallback when no outstanding CDMs exist. For historical context, mojo::StrongBindingSet was originally added also to solve lifetime issues around media::mojom::InterfaceFactory, the predecessor of media::mojom::CdmFactory. See https://codereview.chromium.org/2530613003/. Bug: 821171 Test: Added new BindingSetTest cases. Change-Id: I24a660e8b62720f7fd772db1bafb9499cb71428c Reviewed-on: https://chromium-review.googlesource.com/969655 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#548704}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 825684 Change-Id: Ie54a02067aa896ec6ff386cfd6283f482217a238 Reviewed-on: https://chromium-review.googlesource.com/997194 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548703}
-
https://chromium.googlesource.com/angle/angle.git/+log/00af463e03ef..c3755fc56611 $ git log 00af463e0..c3755fc56 --date=short --no-merges --format='%ad %ae %s' 2018-04-05 jmadill Vulkan: Move Streaming data to VertexArrayVk. 2018-04-05 jmadill Context: Release surface first in onDestroy. 2018-04-05 jani.hautakangas GLIBC fix: size_t requires include <stddef.h> 2018-04-05 lucferron Vulkan: Bugfix in depth/stencil clearing 2018-04-04 oetuaho Guard traversers used during parsing against stack overflow 2018-04-04 lucferron Vulkan: Implement color mask and depth mask bits 2018-04-04 oetuaho Identify functions by unique id in BuiltInFunctionEmulator 2018-03-31 jmadill Vulkan: Rename StreamingBuffer to DynamicBuffer. Created with: roll-dep src/third_party/angle BUG=chromium:823856 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I6c11e330653afa936d5ffe006c0d30515b0e6219 Reviewed-on: https://chromium-review.googlesource.com/999005Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548702}
-