- 14 Nov, 2019 40 commits
-
-
Mugdha Lakhani authored
Refactor the scheduling and cancellation of one off tasks that wake up the browser to process (Periodic) Background Sync registrations into two methods. This gets rid of the method that calls the appropriate method and removes special casing base::TimeDelta::Max() as the delay that causes cancellation of one-off task. Unit tests have also been updated. Bug: 996166 Change-Id: Ic35f4833c627220d464641db82feee8bbfc12ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906213 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#715284}
-
Armando Miraglia authored
As suggested in http://crbug.com/990381, it should be beneficial to change the child process flag for the video capture service on MacOS. This is due to issues with entitlements. This CL changes the flag of the utility process to CHILD_PLUGIN. Bug: 990381 Change-Id: I31583c2860678d0fadee00f37cb1cfd089ce53a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905848Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#715283}
-
Mugdha Lakhani authored
Before this change, we special case base::TimeDelta::Max() to mean we'd like to cancel delayed processing of Background Sync registrations. This introduces a CancelDelayedProcessing() flow to make code more readable and get rid of this special case. Bug: 996166 Change-Id: Iee5f78a8e8f9e9d2abd8cc1e3e78778807829011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906408 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Peter Kasting authored
Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=1024091#c6 In addition to the color value changes, this eliminates the touch-specific IDs added in https://chromium-review.googlesource.com/c/chromium/src/+/1008841/ . These colors were to follow the spec atop https://bugs.chromium.org/p/chromium/issues/detail?id=826907 , but rather than change non-touch menu colors the same way, the original change added new IDs to allow variance. This change instead unifies the behavior very close to the current touch spec, except using a Google grey directly for the separator instead of the roughly-equivalent alpha blend. (In theory, it also supports dark mode and other menu text styles, e.g. disabled items; in practice I don't believe either of these is used today, and I don't think the original intent was to prevent touch menus from using alternate styles, it was simply not necessary. Bug: 1024091 Change-Id: Ib3addd16ed0915720b64dfda2b629f459b2313e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915659 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715281}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9129fad98516..68ff3171f360 git log 9129fad98516..68ff3171f360 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 tneda@google.com perfetto-ui: Adding different viewing options for heap profile flamegraph 2019-11-14 tneda@google.com perfetto-ui: Integrate merging callsites with expanding Created with: gclient setdep -r src/third_party/perfetto@68ff3171f360 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic7aba1fdc5f8a07b231f8bc7b3647e725cb64c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715280}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: Idaa9423573c506eb9f958998519f71599c8db4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913072 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#715279}
-
ckitagawa authored
Protos that populate the subframe field aren't parsable once serialized as the is_main_frame field isn't populated. This wasn't caught in any tests and iframes aren't captured yet. I caught this when working on some Cluster Telemetry metrics collection. Bug: 1024640 Change-Id: I4632e07b165da3a47534081e6fa024573c5046ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914512Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#715278}
-
Greg Thompson authored
BUG=NONE R=pastarmovj@chromium.org Change-Id: Icb6cd4c90be5ae73c5f63bde94b034bdf62c137b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917200 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#715277}
-
Jesse Schettler authored
When using a PrintRenderer, preview documents are rendered asynchronously, and mulitiple preview document requests may be issued before a preview document is returned. If the returned preview document's cookie does not match the latest document cookie, ignore it and wait for the final preview document. Bug: b:144448724 Test: Print from an ARC app and rapidly change print settings Change-Id: I2b705abd5c86f3b2e54151d07a4c48201560e320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914831Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#715276}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/tracing This CL was uploaded by git cl split. R=eseckler@chromium.org Bug: 1018667 Change-Id: I8b22ba4e94324550545d39beaa65e65df8ee22a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916470 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#715275}
-
Guido Urdaneta authored
Now we consider all windows instead of the visible ones. Restricting to visible ones caused problems when Chrome was maximized and some windows required for the heuristic to work were not visible. Also, this patch removes the check for status windows, since it is common to have one whose title can be read even with permissions disabled. Bug: 1023028 Change-Id: I877bfe518c93961ee3e8e5cc4e768a1ca990eb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917159 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#715274}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/autofill/core/browser This CL was uploaded by git cl split. R=parastoog@google.com Bug: 1018667 Change-Id: I6b3dd0ae0eb6b701e10c1102227cabc7b027742d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916823 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715273}
-
Peter Boström authored
This makes initializer lists easier to follow. Also added some consts where that made sense. Bug: None Change-Id: I86dffdbdfc4eb87df52e2eefbe9aa2a92d0f2fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914607 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715272}
-
Colin Blundell authored
ContentRendererClient::HasErrorPage(http_status_error) determines whether the embedder has an error page for the given http status error. This method is used when a navigation results in an empty document (https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?q=render_frame_impl&sq=package:chromium&g=0&l=4740). When it returns true, RenderFrameImpl will do the following: - Allow the embedder to display an error page if desired (via ContentRendererClient::PrepareErrorPageForHttpStatusError()). - Commit the navigation as a failed navigation. The default implementation returns false, which means that such navigations commit as successful rather than failed navigations. This CL does the following: - Copies //android_webview's implementation of HasErrorPage() into //weblayer to have WebLayer regard such navigations as failed navigations. - Adds a browsertest that navigates to an empty page returning a 404 and waits for the navigation to fail (this test fails without the production change in this CL, since prior to this change the navigation in question would actually complete in WebLayer). - Adds a page whose presence is necessary for navigations made in ssl_browsertest.cc to continue to complete following the production change in this CL (prior to this change the fact that the page was missing was not a problem, due to the very fact that WebLayer completed rather than failed navigations to empty pages with 404's). As detailed in crbug.com/1024212, it's not clear whether //android_webview *not* implementing ContentRendererClient::PrepareErrorPageForHttpStatusError() is intentional. The resolution of that discussion will impact whether/how we implement that method for WebLayer as well, but in the meantime, we are now matching WebView's behavior in this case. Bug: 1024212 Change-Id: I1e8012afd8ddf2f7cd3d1fcb6fcfd65421ddd31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914388Reviewed-by:
-
Justin Donnelly authored
This is in preparation for launch to all channels. Bug: 966462 Change-Id: I876ba5b90a06446e81d8bf36c3b17af9e9c5e289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913971Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#715270}
-
Elly Fong-Jones authored
This change begins breaking dependencies outside //ui/views on DialogClientView. The overarching goal here is to make DialogClientView private to //ui/views, with DialogDelegate presenting the only interface for clients of Views to manage/interact with dialogs. This will also make it easier to move some logic (ie: the AcceptDialog/CancelDialog wrappers this change adds) entirely into DialogDelegate later on. Bug: 1011446 Change-Id: I49c1b435ff57faf41beae7b51c6a5f430f0631cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912805Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715269}
-
Xiyuan Xia authored
Update autotestPrivate.getAppWindowList to carry relevant overview item info under overview mode. It would be used to check whether an item is being dragged, whether a window is closed as expected, and whether a window snapped. Bug: 1007060 Change-Id: If7fdbcb77fa327d268f9edbfec7986cae0c52f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914599Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715268}
-
Elly Fong-Jones authored
These two items are now in the Tab menu, reusing the existing strings and machinery from the context menu. I considered adding separate descriptor strings but it seemed like extra work for no particular gain. This is the design we settled on during our offline discussion :) Bug: 1017344 Change-Id: I5fe6798d4bf0f217e3065373d43d0ec217a4bcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913974Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
Alex Clarke authored
This will help us diagnose any client related performance issues from traces. Change-Id: Iafe9ac796aca317d8eaee9a9bf10890ba719a1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900993 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#715266}
-
Luke Zielinski authored
This roll is mainly triggered by staleness rather than pulling in a key feature. The main changes contained in this version are: - new lint rules (Ahem system font, missing deps) - new commands (./wpt testpaths) - mobile browser support ..and various bug fixes, tweaks etc. Change-Id: I6a8e82ba20cc0462fc63d520e8b9389d0faba182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914964 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#715265}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf04d632. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." 85e02f50 "[Trusted Types] Test that a policy rejection blocks eval." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I2c98983f24d5f414e4fe4806e9571abd2fbe0d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917039Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715264}
-
Ankit Kumar 🌪️ authored
With the introduction of PP_PrivateAccessibilityPageObjects two members link_count and image_count of PP_PrivateAccessibilityPageInfo are unused. This CL removes both the members from the struct. Bug: 1020097 Change-Id: I74d0d8914a98cca12879bf53a59260209f65ab1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892637 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715263}
-
Mugdha Lakhani authored
Before this chance, we were calculating the soonest wakeup_delta across all storage partitions every time there was a change in state of any storage partition, to schedule a wakeup task with this delta. This change builds on the fact that we have running timers representing delays for each of the storage partitions with active registrations in the scheduler. I've changed scheduling the wakeup task to a push system. Each storage partition informs the scheduler of its soonest delay after there's any change in state. If this requested delay is the smallest of all the current delays of the timers the scheduler has, it schedules a wakeup task. Canceling delayed scheduling causes cancellation of the wakeup task if none of the storage partitions need it. The change also removes now unnecessary code. Unit tests are also added, and integration tests updated. Bug: 996166 Change-Id: I1e6216ecc7085535a8e0ca0075ddad05085df763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834086 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
When document.fonts.load() is called with font specification such as '1px ""' (containing two quotes) as the argument, CSS font property parsing parses this successfully as the empty string. FontFaceCache was not prepared to handle that correctly. Fix FontFaceCache to guard against that. Add test to actually ensure that this font specification's load promise resolves successfully. In parallel, raised https://github.com/w3c/csswg-drafts/issues/4510 in CSS WG to discuss whether it would make sense to reject such a font specification at the parsing stage already. Bug: 1023206 Change-Id: If46aef0c7fcd2e06bc657480b9189857438d8cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914392Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#715261}
-
Aaron Leventhal authored
Proposal here: https://github.com/aleventhal/aria-annotations The experimental roles are now: comment, commentsection, mark, revision, suggestion. Also changed the name of the feature flag from kARIAAnnotationRoles to kARIAAnnotations, to make it more general, so that it can be used for any of the upcoming markup changes for ARIA annotations, like aria-description. Bug: 1006767 Change-Id: I3f2580b501050228c4f654e77024f89c9c13dd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907074Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#715260}
-
Lukasz Anforowicz authored
After r694827 and r710554, request_initiator is not set to the extension origin in requests initiated from content scripts. This means that the ExcludeSchemeFromRequestInitiatorSiteLockChecks exclusion (introduced in r691013) will never kick-in and can therefore be removed. For more details please also see https://crbug.com/1023442#c5 and #c6. Bug: 1023442, 940068 Change-Id: I2814ef4f9626f910f9b325a7ad5a3b54a650535b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911221Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#715259}
-
David Jean authored
Bug: 987646 Change-Id: I9e21ec812293136797b80af8c4b189331941a111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903363Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#715258}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4636c1f0..14dea250 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I712992127fd7c5a83a4f22d1bb1471ad8aa39267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916639Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715257}
-
Alex Chau authored
- Add sharing_fcm_token to SharingSpecificFields and rename current fcm_token field to vapid_fcm_token - GetToken with both VAPID authorized_entity and sender ID - Introduced SharingTargetInfo struct for sending messages - Replaced GetSharingInfo in SharingSyncPreference with more efficient methods to only read required information from preferences Bug: 1018145 Change-Id: Iab01f3866124d13fea10d70bec4faa6150ce6377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904167Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#715256}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/chrome_content_browser_client_unittest.cc This CL was uploaded by git cl split. Bug: 1018667 Change-Id: I08e044ff1aac9d05677a3041f5f757dca61124ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916870 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#715255}
-
Marc Treib authored
It didn't actually initialize anything, it was just used to pass in the user agent string. Might as well pass that into the ctor, and remove some plumbing. The original reason for this two-step initialization was apparently to move construction of the Sync user agent string off the UI thread. However, (a) even before this CL, the user agent string was in fact constructed on the UI thread, and (b) nothing in MakeUserAgentForSync looks like it could actually block. Bug: 951350 Change-Id: I691f85468988d27187dbfc9088020e10a875fd79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913258 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Alex Chau authored
- Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1905946 - Was reverted due to a flaky test, test is now disabled: https://crbug.com/1023950 - Disabled ClickToCall/SharedClipboard SyncTurnedOff browser test when UnidoOnSignIn is on as it no longer applies - Disabled Sharing registration when device is in local sync mode if deriving VAPID key as derived key is not available in local sync mode - Add DeviceInfo to allowed type in transport mode in sync_integration_tests when UnidoOnSignIn is on TBR=holte@chromium.org Bug: 1009516 Change-Id: Ia9be25489dd2e874754f3eb4527321f757468e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913403 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
This improves the WebRTC audio processing module adaptation on mono signals even when being played out on more than one speaker. Tested: made appr.tc calls with all combinations of mono/stereo audio, multi-channel feature flag on/off, APM in audio service enabled/disabled: verified that (locally modified) log statement for entering multi-channel is printed, verified that aecdump recordings have the right content, verified that not too much processing happens before stereo is detected Bug: chromium:1016708, chromium:1023337 Change-Id: Ia6827f26e01dba6779ab356687f7920ce9fa8703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906210Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#715252}
-
Gauthier Ambard authored
This CL makes sure that the SectionInfo variable isn't store in the "more" callback on the NTP. This is because the SectionInfo can be recreated for example when disabling/enabling the content suggestions. Bug: 1023793, 1024172 Change-Id: I8edb799baedb3d1dd811a57db77d07298d97533e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913257Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#715251}
-
Sylvain Defresne authored
With https://crrev.com/c/1912239, //third_party/breakpad no longer has any dependency on //third_party/google_toolbox_for_mac (it no longer uses GTMLogger), so remove the deps. Add missing reference to "sqlite3" on //ios/third_party/firebase that was previously pulled transitively via google_toolbox_for_mac. Bug: 1012115, 1024322 Change-Id: I963470cd5a327edb2562a873fcc283eb46b2af6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913414 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#715250}
-
Dominique Fauteux-Chapleau authored
Since testing special DM token values like INVALID_DM_TOKEN may require manually setting the DM token this makes it safer, otherwise the editor might add extra useless whitespace and mess with testing. Change-Id: I50ceafe7fa03d39c0ea8e24f80418805f3d8639a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913871Reviewed-by:
-
Gauthier Ambard authored
Bug: 991608 Change-Id: I7f5c8481309bf2f3be8d98586746d7db1e43f4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914387 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ae55a94ff52c..515f9bebd1f8 git log ae55a94ff52c..515f9bebd1f8 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src ab3cdcaef56e..3da910d55f20 (3 commits) Created with: gclient setdep -r src/third_party/angle@515f9bebd1f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: Ic93e03b0559a1bf5d701b1ffd94e99379e9e8d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916623Reviewed-by:
-
Asanka Herath authored
This CL inches closer to merging the NTLM and Negotiate handlers which basically implement the same logic under different names. Servicification of Negotiate handling will then not have to deal with NTLM and Negotiate authentication schemes separately. R=mmenke@chromium.org Bug: 991265 Change-Id: I167d4fb5856f65319fe7c21636e6e4db61aa46a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907151 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/06d9a50ca1e5..9129fad98516 git log 06d9a50ca1e5..9129fad98516 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 lalitm@google.com trace_processor: add special handling of constraints on sorted cols Created with: gclient setdep -r src/third_party/perfetto@9129fad98516 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I68c7b2bb65dc934da9f4dd40ea0ae5493ebf4aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916625Reviewed-by:
-
