GitLab

This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.

After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.

Bug: 789079
Change-Id: Ibd4de27bb774c8e00a9dc24e720452245b20c8da
Reviewed-on: https://chromium-review.googlesource.com/956325
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544981}

There are many duplicate regexp compiles for joined tags.
This patch improved the time to build chrome/app:generated_resources from 21.562s to 17.672s on Z840 Linux.

Change-Id: I8b703e7ead06c8119cfa7b3e12ed8132c871eb7f
Reviewed-on: https://chromium-review.googlesource.com/967903
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544980}

VDAs can be created without any GL context. In this case,
VaapiPictureFactory fails to return pictures since it cannot rely on the
GL implementation to decide an allocation method. Turn to Ozone in such
a case, since this is the most sensible candidate and we plan to use
this feature in unit tests mainly.

BUG=819542
TEST=Verified that vdatest was still passing on eve, hana and kevin

Change-Id: I08484d1619f32a6bf7613f3cb4663314a1f67c72
Reviewed-on: https://chromium-review.googlesource.com/961779Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544979}

Less dependency is better. Media code should not need to know
third_party plugins (ppapi/). This CL removes ppapi/ dependency from
media/ to enforce this.

Bug: 772160
Change-Id: Ib4e1bf6b6a5a87dde16e5130830e589769a2ca89
Reviewed-on: https://chromium-review.googlesource.com/974574
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544978}

This CL adds a feature pod button for VPN. By clicking on the button,
it will show VPN detailed view of the existing SystemTray.
This behavior is described as Development Stage 1 in the design doc:
go/cros-qs-restyling

Screenshot: http://screen/UGX2VC3yYpo

TEST=manual
BUG=813499

Change-Id: I5159f210279a92e8f17d5898050a7a678901fb86
Reviewed-on: https://chromium-review.googlesource.com/970003Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544977}

This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injector-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.

After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.

Bug: 789079
Change-Id: I786ba9c6425e129770b75e764096284629fb4692
Reviewed-on: https://chromium-review.googlesource.com/955705Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544976}

This CL adds a unit test to make sure that we use the opaque fb
when we schedule an overlay plane with alpha blending disabled.

Bug: 789288, b/74997524
Change-Id: Ib8906e23e439ba936c280e0bf7b1f52d733fb38c
Reviewed-on: https://chromium-review.googlesource.com/973890
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544975}

This CL hooks into the pref added in [1] which controls tab-under
protection. This allows enterprises to turn off tab-under protection.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/970729

Bug: 823700
Change-Id: I49d32aa5f0a270e52bace8f9d509d996589d1ad5
Reviewed-on: https://chromium-review.googlesource.com/970846Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544974}

Change-Id: I855b81d7cef2353eb272ac918187188f1bb93608
Reviewed-on: https://chromium-review.googlesource.com/974792Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544973}

Using wpt-import in Chromium 85a5f770.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14333

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
meade@chromium.org:
  external/wpt/web-animations

TBR=robertma

No-Export: true
Change-Id: I50593598cf0f42b209db44caa5fe4c635395bdcd
Reviewed-on: https://chromium-review.googlesource.com/974753
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544972}

This patch change |Range::intersectsNode()| to follow the spec[1].

[1] https://dom.spec.whatwg.org/#dom-range-intersectsnode

Bug: 822510
Change-Id: Ifd504443355da12482b759701cddd62e2a90d7a6
Reviewed-on: https://chromium-review.googlesource.com/970044Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544971}

This change allows VirtualU2fDevice to create custom attestation
certificates at run-time. It also adds tests for attestation behaviour
that depend on that ability.

Change-Id: I88323de6baaba7883ab0db676c26ccdb4b0dafbb
Reviewed-on: https://chromium-review.googlesource.com/967066Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544970}

Add a part_pseudo_rules vector to RuleSet to hold rules with ::part
selectors and update RuleSet::FindBestRuleSetAndAdd to populate this.


Bug: 805271
Change-Id: If18cabbd8c933f49a252e2f659246cb0e0471e3f
Reviewed-on: https://chromium-review.googlesource.com/972766
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544969}

The entire new wallpaper picker is hidden behind flag. A mock of the
info bar: https://goo.gl/NTLuik

Bug: 824453
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8cb106f76fc01fef361ed3c7ca0f0253484518c5
Reviewed-on: https://chromium-review.googlesource.com/961782Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544968}

BUG=b/74363217

Change-Id: I4aa4a2758772685df3b71f7ad334fa6e6fff745a
Reviewed-on: https://chromium-review.googlesource.com/974602Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Commit-Queue: Junichi Uekawa <uekawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544967}

(Marked as deprecated by crrev/c/583590 on Aug 19, 2017)


Bug: chromium:748842
Change-Id: If77ed2ea38d91719f58abf76e7aedd9173783472
Reviewed-on: https://chromium-review.googlesource.com/970193Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544966}

This patch moves line granularity related tests from "VisibleUnitsTest.cpp" to
"VisibleUnitsLineTest.cpp" for ease of maintenance.

Change-Id: Id1044927113c33c2d9f2fb58e838096b3087189c
Reviewed-on: https://chromium-review.googlesource.com/969804
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544965}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d37d531d536..8bf5a724397c

$ git log 1d37d531d..8bf5a7243 --date=short --no-merges --format='%ad %ae %s'
2018-03-20 manojgupta cbuildbot: Only build virtual/target-fuzzers for fuzzer builders.
2018-03-15 dgarrett archive_lib: Stop appending trybot- for tryjobs.
2018-03-21 dgarrett precq_launcher: Fix swarming PreCQ hack.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:823787,chromium:667393,chromium:823445


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7abe614767178c4d769dd22efaa488e7e6e9083e
Reviewed-on: https://chromium-review.googlesource.com/974743Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544964}

In this CL:
- The browser actions are laid out such that their
  button sizes match those of other toolbar buttons.
- Adds the touchable chrome ink drop style.
- Simplifies the logic by baking the icons' paddings
  inside the views' bounds.

BUG=818034

Change-Id: I1da4347eccaaa8283635ec3c521acd63063ff1f3
Reviewed-on: https://chromium-review.googlesource.com/961722
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544963}

This reverts commit 119455cb.

Reason for revert: Seems to cause flakiness in MediaRouterIntegrationBrowserTest.Dialog_Basic

Original change's description:
> Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink
> 
> There's a race in cc somewhere from commit to draw. I don't know exactly
> how to repro the race yet even though I have a high probably fix. This
> CL is intended to catch the race in the wild and produce a stack trace
> in a crash log. Hopefully from there we can acertain repro steps.
> 
> Once repo steps are produced locally (either via user interaction or
> unit test) then this CL will be reverted.
> 
> Bug: 672962
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: I3bce066591e15d5c3aac7d4c8685dce411e284b7
> Reviewed-on: https://chromium-review.googlesource.com/973987
> Reviewed-by: Saman Sami <samans@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544834}

TBR=fsamuel@chromium.org,samans@chromium.org

Change-Id: I324408ff045908e6d07b1f0e6868e79c10f92db9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/974208Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544962}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Ic1a8d199f85dcfec95303b8307842559f2e00f00
Reviewed-on: https://chromium-review.googlesource.com/974787Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544961}

It seems to have gone missing.

BUG=None

Change-Id: Ica644858d3f03d0dca7f0e2f206cd92c5bce63fb
Reviewed-on: https://chromium-review.googlesource.com/970195Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Junichi Uekawa <uekawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544960}

Bug: 801709
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie059475b03953372cf9fcc9ddafd875ebc849e34
Reviewed-on: https://chromium-review.googlesource.com/973942
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544959}

It hasn't been broadcast as a notification since r369162,
more than two years ago. The code that listens for it is dead.

BUG=268984

Change-Id: Ia8ed45dcf334c5eb96a8ea4c1fe6706f82b299b3
Reviewed-on: https://chromium-review.googlesource.com/974324Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544958}

Make HostViewController call EnableVideoChannel(false) when the app is
inactive. This can save some battery for the device.

Bug: 824554
Change-Id: Ic468344509bcb9458a592cf4eea8e5b28a939f90
Reviewed-on: https://chromium-review.googlesource.com/974506Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544957}

The weak_ptr_ in ChromotingSession seems to be unused. This CL removes
it.

Bug: 817566
Change-Id: I4f07be8e8047b76ce36f5fe658b17bf6cf45ec72
Reviewed-on: https://chromium-review.googlesource.com/974563Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544956}

This CL:
* Delays setting Proxy.Type to PAC unless a PAC value is set.
* Sets proxyModified_ = true otherwise so that the type is not
  overridden on an update.
* Focus the appropriate input field when the proxy type changes.

Bug: 822670
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e9a68fc8982d2286e144e57dfe14dc61fa84b1b
Reviewed-on: https://chromium-review.googlesource.com/974119
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544955}

Currently setting automatic_  may trigger automaticChanged_ before
ipConfig_ is set, causing unexpected behavior. We should only trigger
the automaticChanged_ function on user action.

Bug: 823525
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id653bb88bb20b22abd9c85d8c1417b2b8355f5ca
Reviewed-on: https://chromium-review.googlesource.com/974510Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544954}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8943d0bd..b8eac287

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ic25d7661df6652d9a42e8aeac192fde7e07bf18d
Reviewed-on: https://chromium-review.googlesource.com/974451Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544953}

This patch moves sentence granularity related tests from "VisibleUnitsTest.cpp"
to "VisibleUnitsSentenceTest.cpp" for ease of maintenance.

Change-Id: I637f054dcb700aee6969113a0287d82656d98508
Reviewed-on: https://chromium-review.googlesource.com/970128Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544952}

- Activate and focus notification content view with text selection
  changed event in Android. If text selection changed is dispatched from
  Android, it means that user is trying to type something in Android
  notification.

Bug: 822140
Test: unit_tests:ArcAccessibilityHelperBridgeTest
Change-Id: I9e7613d2121cbd43e2cfd9ecc602a8834f18bfdf
Reviewed-on: https://chromium-review.googlesource.com/963960
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544951}

This CL contains the following changes:
- Combined consistency checks for temporary/persistent pages, along with
  clearing legacy archives directory into the StartupMaintenanceTask.
  Also removed old files.
- Combined related tests.
- Adding a step to report storage usage for ClearStoragePreRunUsage2 at
  startup.
- Adding an ArchiveManager instance and a method AddPageWithoutDBEntry()
  to ModelTaskTestBase.

Bug: 778813
Change-Id: I9af446da29dbbf912ae0a4f2d73531c224e81f80
Reviewed-on: https://chromium-review.googlesource.com/965634
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544950}

Bug: 822144
Change-Id: I810ee10d0f428f8893d90281079341101d7d8c04
Reviewed-on: https://chromium-review.googlesource.com/963956
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544949}

... and do the same in ShellDevtoolsBindings (sigh).
Also, add a browser test to cover the implementation in DevToolsUIBindings.

Bug: 721408
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I83bd0c8160feb6a0de764bb4f6615ef421516f4b
Reviewed-on: https://chromium-review.googlesource.com/973811
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544948}

This CL fixes focus getting trapped by the cr-action-menu which has
tabindex set on it. Since this is moved to the internal dialog, it
can be removed from the host.

Bug: 823195
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I88f012f9d94c31557917a64ae64c34ef0472a836
Reviewed-on: https://chromium-review.googlesource.com/968044Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544947}

While adding the |dcheck_is_configurable| build argument, the new
dependency of base/logging.h on a buildflags_header() caused missing GN
dependencies to break the build.

Add the (known) missing dependencies, and enable GN checks for those
targets.

Bug: 812058
Change-Id: I5aed4d5a62619e026cdb86e5d6a5c33858875bd4
Reviewed-on: https://chromium-review.googlesource.com/970165
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544946}

If an image fails to decode on a shader, abort early instead of trying
to decode the flags further. Since Flags() returns nullptr based on
whether the decode failed, it was causing crashes.

R=enne@chromium.org

Bug: 824068,824058
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1040598df19c94a10a71a5b494f196abfffee2ab
Reviewed-on: https://chromium-review.googlesource.com/974480Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544945}

Change-Id: Ifa009db981608d2fa0efbcb4d43652010e60e17c
Reviewed-on: https://chromium-review.googlesource.com/974077
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544944}

BUG=411569

Change-Id: I711882b31f106ea55de23fedf7e32077be430696
Reviewed-on: https://chromium-review.googlesource.com/974642Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544943}

See screenshot in bug.

Bug: 821686
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iddc5c0bc3e2eddc5d1e7d06f30f996191560fba6
Reviewed-on: https://chromium-review.googlesource.com/972548Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544942}