- 19 Feb, 2015 40 commits
-
-
jlklein authored
Pull web-animations-js into third-party via the third_party/polymer/reproduce.sh script. Add necessary third_party bits. R=cpu, dzhioev BUG=424574 Review URL: https://codereview.chromium.org/917523002 Cr-Commit-Position: refs/heads/master@{#317119}
-
sergeyu authored
policy_component doesn't need to depend on autofill_core_browser. Also added dependency on gfx_geometry in favicon_base. policy_component was failing to compile without it. BUG=458581 Review URL: https://codereview.chromium.org/926093002 Cr-Commit-Position: refs/heads/master@{#317118}
-
wfh authored
The component updater now only uses bsdiff so courgete diffs no longer have to forwards and backwards compatible, since Chrome always ships the correct version of the courgette patcher with the courgette diff. However, bsdiff generated diffs still have to be version compatible. This CL adds a test for the forwards compatible case. BUG=459505 Review URL: https://codereview.chromium.org/918403003 Cr-Commit-Position: refs/heads/master@{#317117}
-
tedchoc authored
BUG=459773 Review URL: https://codereview.chromium.org/932703006 Cr-Commit-Position: refs/heads/master@{#317116}
-
enne authored
This is redundant with the UpdateDrawProperties that happens during CommitComplete. One pixel test was amusingly changing draw properties after the commit and update, so modify it to do the update earlier. Review URL: https://codereview.chromium.org/935143002 Cr-Commit-Position: refs/heads/master@{#317115}
-
JF Bastien authored
This recently came up on our mailing list, and isn't quite obvious. R=sbc@chromium.org BUG= none Review URL: https://codereview.chromium.org/940503003 Cr-Commit-Position: refs/heads/master@{#317114}
-
paulmeyer authored
The issue involved a discrepancy between sizes specified in logical versus physical pixels. See https://codereview.chromium.org/939443002/ for an explanation on a very similar bugfix, which this CL utilizes. BUG=459266 Review URL: https://codereview.chromium.org/934303003 Cr-Commit-Position: refs/heads/master@{#317113}
-
erikchen authored
This CL creates two subclasses of FastNavigationProfileExtender: CookieProfileExtender and HistoryProfilerExtender. The former performs up to 500 navigations, with the goal of filling up the Cookie Database but not overfilling it (which is possible, unfortunately). The latter performs a large number ~20,000 navigations to URIs pointing at the local file system to fill up the History Database. The run these profile extenders, this CL adds the class LargeProfileCreator. This new class intentionally contains minimal logic, since the existing profile_creator.py file is pretty hacky, and the goal is to eventually move away from it entirely. BUG=442546 Review URL: https://codereview.chromium.org/914253005 Cr-Commit-Position: refs/heads/master@{#317112}
-
Adam Langley authored
net: a batch of manual HSTS updates. Cr-Commit-Position: refs/heads/master@{#317111}
-
mikecase authored
BUG=448030 Review URL: https://codereview.chromium.org/831173005 Cr-Commit-Position: refs/heads/master@{#317110}
-
tbansal authored
Also, fixed variable names to comply with style guide. BUG=459426 Review URL: https://codereview.chromium.org/939083003 Cr-Commit-Position: refs/heads/master@{#317109}
-
johnme authored
BUG=401439 Review URL: https://codereview.chromium.org/933423002 Cr-Commit-Position: refs/heads/master@{#317108}
-
enne authored
The main thread calculates needed render surfaces, but doesn't have all of the information that it needs. In particular, it may not know that one of its twin layers on the pending or active tree still has an unserviced copy output request that will live through the commit and activation, and thus that twin will still need a render surface. As render surface calculations will probably move to the compositor thread, rather than adding in complicated tracking and counting of outstanding copy requests to Layer and request callbacks, instead just add some logic to check if there are remaining copy output requests during commit and activation and take that into consideration when setting the output surface. This also reverts commit 1e447ad6, which was clearly legit as it caught this mistake. BUG=457217 Review URL: https://codereview.chromium.org/935193002 Cr-Commit-Position: refs/heads/master@{#317107}
-
eakuefner authored
Previously, creating a TraceValue would store the associated trace_data in memory and defer serialization until needed. In this CL, the trace_data is serialized right away into a temporary file to prevent it from being stored in memory. BUG=457385 Review URL: https://codereview.chromium.org/920523002 Cr-Commit-Position: refs/heads/master@{#317106}
-
chrome://chrome-signinnoms authored
Revert of Add Autofill to the <webview> chrome://chrome-signin page (patchset #12 id:340001 of https://codereview.chromium.org/866523002/) Reason for revert: Introduced crashes in ManagePasswordsUIController::OnPasswordSubmitted:( https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2742.0.2309.0%27%20AND%20custom_data.ChromeCrashProto.channel%3D%27canary%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27ManagePasswordsUIController%3A%3AOnPasswordSubmitted%27 Original issue's description: > Add Autofill to the <webview> chrome://chrome-signin page > > The change in the chrome_autofill_client.cc is needed to enable the autofill popup on > Mac. > > BUG=447938 > TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username > with an incorrect password. After the password error appears, you should be able > to autofill that username. > > Committed: https://crrev.com/4a1e13b16b5ef2cb6f7c800ad3c08f1f44bef285 > Cr-Commit-Position: refs/heads/master@{#314889} > > Committed: https://crrev.com/e6d3ca36ec225b0e13e385318c6c4f35fad4ca47 > Cr-Commit-Position: refs/heads/master@{#316899} TBR=estade@chromium.org,fsamuel@chromium.org,lazyboy@chromium.org,vabr@chromium.org,engedy@chromium.org,jww@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=447938 Review URL: https://codereview.chromium.org/944513002 Cr-Commit-Position: refs/heads/master@{#317105}
-
sandersd authored
Summary of changes available at: https://chromium.googlesource.com/chromium/third_party/ffmpeg/+log/2e38ab8..d4b1674 BUG=459114 Review URL: https://codereview.chromium.org/919663003 Cr-Commit-Position: refs/heads/master@{#317104}
-
aurimas authored
two_button_menu_item was added in https://codereview.chromium.org/608283004 but it is not used anymore due to menu button removal from the menu popup. four_button_menu_item was also added to support menu button inside the menu popup. BUG=None Review URL: https://codereview.chromium.org/934353003 Cr-Commit-Position: refs/heads/master@{#317103}
-
kkimlabs authored
In enhanced bookmark UI, we still showed the partner bookmark node in the side drawer even if it's deleted. BUG=460122 Review URL: https://codereview.chromium.org/941733002 Cr-Commit-Position: refs/heads/master@{#317102}
-
rdevlin.cronin authored
BUG=460137 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/936603005 Cr-Commit-Position: refs/heads/master@{#317101}
-
ttuttle authored
Just a small update to the baked-in config for mail.google.com. BUG= Review URL: https://codereview.chromium.org/945443002 Cr-Commit-Position: refs/heads/master@{#317100}
-
bungeman authored
Revert of Fix Presentation API mocks: do not eagerly drop clients. (patchset #2 id:20001 of https://codereview.chromium.org/938033002/) Reason for revert: This change appears to be causing failures in running layout tests ('webkit_tests' step) of Windows 7 and Linux debug builds. See http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/1363 or http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9658 . Original issue's description: > Fix Presentation API mocks: do not drop eagerly drop clients. > > BUG=412331 > > Committed: https://crrev.com/4ff204b8d2637af0abd8a05485e5941af8ef4271 > Cr-Commit-Position: refs/heads/master@{#317057} TBR=mkwst@chromium.org,avayvod@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=412331 Review URL: https://codereview.chromium.org/940783003 Cr-Commit-Position: refs/heads/master@{#317099}
-
jbroman authored
This causes Chrome to show a scary infobar when either of these flags is used, in order to discourage their use in production. They are intended for Chromium development only. BUG=454504 Review URL: https://codereview.chromium.org/928593004 Cr-Commit-Position: refs/heads/master@{#317098}
-
jrummell authored
Key IDs and keys used in JSON data should be encoded base64url, not just base64 with trailing = removed. BUG=459834 TEST=new tests pass Review URL: https://codereview.chromium.org/934423002 Cr-Commit-Position: refs/heads/master@{#317097}
-
jiangj authored
bookmark_index.cc, bookmark_model.cc and bookmark_utils.cc all uses functions from base_i18n. Review URL: https://codereview.chromium.org/938003002 Cr-Commit-Position: refs/heads/master@{#317096}
-
skare authored
Disable now notifications extension in component loader if launcher field trial is running (ChromeOS only) BUG=460164 Review URL: https://codereview.chromium.org/936203002 Cr-Commit-Position: refs/heads/master@{#317095}
-
rsleevi authored
This updates to the following revision: bad2a08db205 (2015-02-17 17:53 +0000) It includes changes from revision 97c40a737bda (2014-11-21 04:28 +0100) to revision bad2a08db205 (2015-02-17 17:53 +0000), listed at http://hg.mozilla.org/mozilla-central/log/bad2a08db205/netwerk/dns/effective_tld_names.dat R=pkasting@chromium.org BUG=37436 Review URL: https://codereview.chromium.org/923713005 Cr-Commit-Position: refs/heads/master@{#317094}
-
dfalcantara authored
Icon and rating view were missing accessibility strings. BUG=453170 Review URL: https://codereview.chromium.org/926593006 Cr-Commit-Position: refs/heads/master@{#317093}
-
epenner authored
Revert of Clean up perftesthelper.js style (patchset #2 id:20001 of https://codereview.chromium.org/927583005/) Reason for revert: Tough animation cases are failing due to a few missed files in the refactor. Original issue's description: > Clean up perftesthelper.js style > > This change makes tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js > consistent with the Chromium Javascript style guide: > - Fixed indentation > - Added missing semicolon > - Renamed file to be underscore separated > > Committed: https://crrev.com/30a1e4bc96550502e8607ac0f0a246eb42a61852 > Cr-Commit-Position: refs/heads/master@{#316965} TBR=qyearsley@chromium.org,alancutter@google.com,alancutter@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/941773002 Cr-Commit-Position: refs/heads/master@{#317092}
-
robert.bradford authored
This change adds a new constructor for ui::MouseEvent that takes an accurate event time for use by the ozone evdev backend. For ui::MouseWheelEvent the existing constructor was extended to include the timestamp and the existing users updated. For mouse moves in the generic handler the time of the EV_SYN message is used as the time for the event. In events from the gesture library the end time of the gesture is used. For purely synthetic events EventTimeForNow() is used which uses the same time source (CLOCK_MONOTONIC) as evdev. BUG=450341 TEST=Interactive testing on link_freon. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_chromeos_ozone_rel_ng Review URL: https://codereview.chromium.org/889673004 Cr-Commit-Position: refs/heads/master@{#317091}
-
bratell authored
The chromium base policy is to not inline code but since automatically generated code and templates easily become inlined it can happen anyway. This explicitly outlines destructors, copy constructors and assignment operators in the IndexedDB code for a win of 11 KB of x64 machine code. Most of it (maybe 8 KB) from IndexedDBKey. clang x64 numbers: Total change: -11795 bytes ========================== 42 added, totalling +3270 bytes across 13 sources 25 removed, totalling -5883 bytes across 14 sources 9 grown, for a net change of +1556 bytes (7936 bytes before, 9492 bytes after) across 6 sources 60 shrunk, for a net change of -10738 bytes (54277 bytes before, 43539 bytes after) across 17 sources BUG= Review URL: https://codereview.chromium.org/933823002 Cr-Commit-Position: refs/heads/master@{#317090}
-
yfriedman authored
We shouldn't be asking for native pointers from java. All that was needed was a WebContents, so use that directly. getNativePtr isn't called anymore but can't be removed until the downstream override is gone which needs this patch to roll down. Review URL: https://codereview.chromium.org/941633003 Cr-Commit-Position: refs/heads/master@{#317089}
-
rsorokin authored
Gaia takes full window Show guest button on gaia screen Show more settings button for creation supervised users Hide enterprise container BUG=451959 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/930953002 Cr-Commit-Position: refs/heads/master@{#317088}
-
yfriedman authored
It's possible that this could move to BookmarksBridge but it would require some more refactoring so start with just upstreaming. BUG=443773 Review URL: https://codereview.chromium.org/943643002 Cr-Commit-Position: refs/heads/master@{#317087}
-
newt authored
This upstreams the privacy screen in settings, which includes navigation error suggestions, omnibox suggestions, prefetching, crash report uploading, do not track, and clearing data. BUG=428869 Review URL: https://codereview.chromium.org/935903002 Cr-Commit-Position: refs/heads/master@{#317086}
-
davidben authored
BUG=none Review URL: https://codereview.chromium.org/940033004 Cr-Commit-Position: refs/heads/master@{#317085}
-
creis authored
This behavior was updated in https://crrev.com/299939, but the comment didn't explain why the method might return null. BUG=none TEST=No behavior change. Review URL: https://codereview.chromium.org/938073002 Cr-Commit-Position: refs/heads/master@{#317084}
-
carlosk authored
Now the navigation cancellation logic should conform to what has been described in the "PlzNavigate: Navigation cancellation" design document [1]. Added some new tests to exercise the cancellation cases described in the document. Note: This is being developed on top of http://crrev.com/912833002. [1] https://docs.google.com/a/chromium.org/document/d/1lO7_fgppFTDd8PSQfIb888z7vODcw2Sc8r7h5Rbiwcg/edit# BUG=376014 Review URL: https://codereview.chromium.org/914223002 Cr-Commit-Position: refs/heads/master@{#317083}
-
smckay authored
Review URL: https://codereview.chromium.org/944453002 Cr-Commit-Position: refs/heads/master@{#317082}
-
oshima authored
This is prep for tooltip improvement: https://codereview.chromium.org/924433002/ (WIP) * Consolidated GetMaxWidth * Eliminate screen type argument. This can be obtained from tooltip window. * Move tooltip truncate code from TooltipManager to TooltipController BUG=None TEST=no functional change. all test should pass. Review URL: https://codereview.chromium.org/916423002 Cr-Commit-Position: refs/heads/master@{#317081}
-
mdempsky authored
The BMM PNaCl toolchain doesn't currently support waitid. Arguably it should because it's in POSIX, but the userland/Linux signal ABI mismatch makes it non-trivial because of the siginfo_t. Since we don't need the siginfo_t anyway, we can just use waitpid instead. While here, use WIFEXITED and WEXITSTATUS for interpreting status instead of directly comparing it to the expected exit code. Review URL: https://codereview.chromium.org/928963003 Cr-Commit-Position: refs/heads/master@{#317080}
-