- 26 Aug, 2020 40 commits
-
-
David Black authored
c/b/u/ash/holding_space has similar requirements as applist to show icons for specific file types in its UI. To facilitate reuse, moving the existing file_icon_util to ash/public/cpp to avoid directly relying on c/b/u/app_list from c/b/u/ash. Bug: 1113775 Change-Id: Iafafecf19df4ffa195f9459610a53e768243a34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377319 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802032}
-
Jia Li authored
Previously it observes any services not just the ML Service. Bug: 1122160 Change-Id: I8a22d6bd770af25cf48851eab81f1272513663fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378692Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Jia Li <jiakl@google.com> Cr-Commit-Position: refs/heads/master@{#802031}
-
David Black authored
HoldingSpaceClient is the browser client for the TemporaryHoldingSpace feature. This CL adds an API to open holding space items, though the use of this API will not be added until UI classes merged. Bug: 1112469 Change-Id: I93f9fb190e90af19e8b29b6e683bc3e8d6b9db0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375601 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802030}
-
Xiaoling Bao authored
Change-Id: Ic2dbcb1870116daf85028aadba6d15da53402082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378716Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/master@{#802029}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64f3530dc37e..398ecf1876f1 2020-08-26 egdaniel@google.com Remove unused factories that take characterizations. 2020-08-26 bsalomon@google.com Enable glesfakev2 config on Android perf bots 2020-08-26 bungeman@google.com Format and comment SkScalarInterpFunc 2020-08-26 bsalomon@google.com Add config "glesfakev2". It runs GLES with the version faked as 2. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ie693311df982ae034bb444c2fc94c1fcd68dc11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378656Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802028}
-
Solomon Kinard authored
Bug: None Change-Id: I4a926b2326c10759ac01b92c27f99f9d9ddc342e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369333Reviewed-by:
Alex Mineer <amineer@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#802027}
-
Orin Jaworski authored
This CL prevents duplicate Pedal attachments from appearing in omnibox suggestions as a result of match upgrades. It was previously expected that duplicate matches, once buried, would not be used or shown again, but that is not the case when entity suggestions are involved. Bug: 1122183 Change-Id: I4539d51304cf3a1acad87ecbf80c7c51749a2398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376722Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802026}
-
Lei Zhang authored
Now that https://crbug.com/755826 has been fixed, tests that read from the clipboard can use ClipboardMonitor to get notifications for when the clipboard changes, instead of polling the clipboard. This is more straight-forward, and hopefully more reliable. Bug: 1121446 Change-Id: I53291e0957ee2bad8a565bb0d80ef0628be40e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376765Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802025}
-
Nnamdi Theodore Johnson-Kanu authored
Fixed: 1111477 Change-Id: I1d26d3063ad38d70dc38177d13a276905c7bd79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378000 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802024}
-
Dave Tapuska authored
Remove unused definitions and includes. Remove AfterUpdateVisualProperties virtual since it can be solely handled inside RenderWidgetFullscreenPepper and its WebExternalWidgetClient itself. BUG=1097816 Change-Id: I30f83f37ed770b1b7fa6a1c48c5042ef9e6b959a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363837 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802023}
-
dpapad authored
Bug: 1032634 Change-Id: I4ba1647811413751f7ef6414e995ebf2bcd04b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377994 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#802022}
-
Etienne Bergeron authored
This CL is boosting the thread priority to avoid loading the DLL at background priority. The following stackframe is the cause of the priority inversion: base::win::RoGetActivationFactory device::BluetoothAdapterWinrt::PerformSlowInitTasks() [...] base::internal::WorkerThread::RunWorker() base::internal::WorkerThread::RunBackgroundPooledWorker see: https://bugs.chromium.org/p/chromium/issues/detail?id=973868#c42 Noticed in crash/bc6506f76abf6a60 R=joenotcharles@chromium.org,robliao@chromium.org Bug: 973868 Change-Id: Ifbe2b87aed7364ad24a59ad300512ef82c03491a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377891Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802021}
-
Zhaoliang Ma authored
memcpy is used to copy a linear buffer to the dst linear buffer, this CL replaces it with libyuv::CopyPlane. Bug: None Test: viz_perftests --gtest_filter=GLRendererCopierPerfTest.* Change-Id: I4892329e243e2fd577a7571f65b7c33a150ff90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373947 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#802020}
-
Etienne Bergeron authored
PerformSlowInitTasks should be scheduled (BEST_EFFORT) but once it starts executing it needs to be on a foreground thread to avoid priority inversion. From this crash/312ca3b6fb0c2131 Thread 28 ThreadPoolBackgroundWorker LoadLibraryExW [...] RoGetActivationFactory device::BluetoothAdapterWinrt::PerformSlowInitTasks() [...] base::internal::WorkerThread::RunBackgroundPooledWorker() This is blocking other threads. R=joenotcharles@google.com Bug: 973868 Change-Id: Ic7512ad567bc4e3a5fc549dd9c408db0047a45fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377904Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802019}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1111477 Change-Id: I15c70e99c644e5a74b06868673fe091679daa8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376575 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Martin Kreichgauer authored
This feature gates a new implementation of GATT session handling on Windows that uses a supposedly more reliable set of Windows Bluetooth APIs, but ended up breaking GATT connection establishment with unpaired devices. Disable the feature and fall back to the old implementation. Bug: 1120338 Change-Id: I4241747791d3875cfbdecd71fd2e0d41f0e82fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378143Reviewed-by:
-
Peter Kasting authored
This reverts commit 76c5ef2b. Reason for revert: Broke compile on linux-chromeos-chrome: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8010 Original change's description: > [Switch Access] Move code out from behind flag > > AX-Relnotes: Launch Switch Access on Chrome OS. > Bug: 1016200,1121357 > Change-Id: I464abbeaeb50c8c40adbac4ce51d7d9f038430fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373368 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801947} TBR=jamescook@chromium.org,dtseng@chromium.org,anastasi@google.com Change-Id: Ib1919aa6d682bed530d51194522c8cba56a76055 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016200 Bug: 1121357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378758Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#802016}
-
Nathan Zabriskie authored
Right now converting CPU backed YUV images to RGB textures forces creation/deletion of shared images for each YUV plane. This CL allows callers of media::ConvertFromVideoFrameYUV to the created shared images if desired to prevent thrashing. Bug: 1090255 Change-Id: I8eef131e7256b2d2dc61f14c2f98922ecd9a9bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363021Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802015}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I641a66c2015d0d2d77b190125cfe805ee27bb34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378619Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802014}
-
Anupam Snigdha authored
If the TSFBridgeImpl initialization fails due to an error HRESULT, then reset the delegate object inside TSFBridgeTLS that would return NULL when |TSFBridge::GetInstance| is called. Thus the tests wouldn't crash due to invalid window(headless mode) and such when trying to use TSFBridge's instance to set or reset focused client. Bug: 1115355 Change-Id: Iffe60fdb0f78ba076829090416361d1bd565524f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373424 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#802013}
-
Hazem Ashmawy authored
Replace withTitle and withSubtitle custom View Matchers with espresso supported API for AdapterView using onData(...).atPosition(..). This way is better since it makes sure info is shown in the expected order in the ListView. It also removes the burden of maintaining the custom written Matchers. Bug: 1106300 Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*" Change-Id: I638c9686f9c64ec8c7c58aaa58cb9a545735449d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376845Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#802012}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/54d60a59..1f2195b4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2709eb81831b3f5aa21684e320c474994f4a639e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378690Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802011}
-
chrome://internals/web-appJun Kokatsu authored
This fixes a TT violation on chrome://internals/web-app by disabling Trusted Types. This is necessary because the page uses Polymer 3 which is yet to support Trusted Types. This change also added few tests that were missing. Bug: 41905 Change-Id: I800ea96c2d487988da4a85f8df69a5a2691722ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376989Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1111477 Change-Id: Iec69b45225066affea3f95baa2248bc3f50505d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376573 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Tibor Goldschwendt authored
This is more consistent with the GN targets of other WebUIs. + Move module_wrapper.* to modules/. Change-Id: I23be97df455e8cb0a9ed35b15b184902b3fa1a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376529 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#802008}
-
Kalvin Lee authored
This change modifies some of the server_contents() of the PpdProviderTest fixture. This change does not fix any unit tests for PpdProvider v3; it merely concentrates a body of clerical work (rewriting served metadata into the v3 format) in a pre-emptive CL. Bug: chromium:888189 Test: autoninja ... chrome{,os_unittests} Change-Id: I6344b9ccfe0c08d834994cf8e8cdc5a9356cd2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351712 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#802007}
-
Will Cassella authored
This flag allows the TurnOffStreamingMediaCaching feature to be enabled regardless of whether the device is on battery power, which is useful for testing purposes. Bug: 984851 Change-Id: If6cb4c6878c15fec61cd0691af8aaa63c20a6058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376320 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#802006}
-
Sean Topping authored
AllowJavascript() can have a CHECK failure when the RPH changes as a result of page navigation. Setting the bindings in CastWebUI also guarantees proper setup when switching RPH. Bug: internal b/158783984 Test: Force launch of settings UI, verify no crashes. Change-Id: I6cceb910833a3139794dbe0cb09d912467f09872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367798Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#802005}
-
Tom Anderson authored
This corrects a bad refactor from this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2253223 R=sky BUG=1114385 Change-Id: I0abd00304b3ed220756ea2d27a91697638f7a02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376879 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#802004}
-
Garrett Beaty authored
Removing the master-only directory and moving the trunk only builder definitions into the same file as the branched builders means that the values aren't appropriate for the entire module. As it is, some things which are not mirrors of CQ builders were already appearing in the CQ mirrors console. Bug: 1119446 Change-Id: Ic888d6b0a070ec20d73d0b1ff20b3da1d75e1667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378771Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#802003}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14a9bffb3e9e..ced41e1f394d 2020-08-26 treehugger-gerrit@google.com Merge "Remove tasks blocking the End LatencyInfo slice from queuing." 2020-08-26 treehugger-gerrit@google.com Merge "Update trace processor" 2020-08-26 treehugger-gerrit@google.com Merge "Add a new AVG of no jank dur_overlapping_ns." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2f723e310f1ebca1ae512ad2955ac297aa9570ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377364Reviewed-by:
-
Nate Fischer authored
This reverts commit 9d53cbf3. Reason for revert: https://crbug.com/1122225 (build errors for downstream checkouts) Original change's description: > Remove unused androidx-legacy libraries > > As far as I can tell these were never used... > > Bug: 1121713 > Change-Id: Ie81d7bfa72e40b48a775442684aae025a55259f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376125 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: benjamin joyce <bjoyce@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: benjamin joyce <bjoyce@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801973} TBR=agrieve@chromium.org,bjoyce@chromium.org Change-Id: I745e025f674b51f012fa138d5abd760444ded1c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121713 Fixed: 1122225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378736Reviewed-by:
-
Ankit Kumar 🌪️ authored
Update DocumentLayout to use gfx::Rect instead of pp::Rect. Update callers to expect gfx::Rect as return value instead of pp::Rect. Bug: 1101101 Change-Id: I6835b99e1355b14b1d27511ba9e8a8bb3910d46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371083 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#802000}
-
Daniel Classon authored
Adds deep links to the Personalization Page, including the change picture and ambient mode subpages. Also fixes a bug where the ambient mode page tests were not run. Bug: 1084154 Change-Id: Ife0a6602e9fecdef57db116ce6dd7e74c9ce3cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375730 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#801999}
-
David Tseng authored
See go/chromevox-touch-gestures R=dmazzoni@chromium.org AX-Relnotes: n/a Change-Id: Ia69121b5889e50ba04c466ca811dfd186eb44290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377897Reviewed-by:
-
David Bienvenu authored
Bug: 1010217 Change-Id: I93e5284aeaa6aef40265ecfae71e4b8b48d7d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378105 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801997}
-
Nicholas Verne authored
Previously, shutting down a VM then restarting it would fail to share the previously shared devices, even though Settings app was indicating their shared status. This is now fixed - the devices are shared again. Fixed: 1117354 Change-Id: I6c4d6ab1c1f21692a150a6dc2e072d48a689fb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376939 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#801996}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee3d26b3cdc2..53daab94768a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC estade@google.com,sahel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1004848,chromium:1102196,chromium:1121776,chromium:912681 Tbr: estade@google.com,sahel@google.com Change-Id: Ia8114a5c2e268314aa55afe961a2325d5a8cc687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377622Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801995}
-
My Nguyen authored
Add blank dialog for now. Both Action and Cancel buttons currently close the dialog. Current view: http://screen/3NCtVAFiCFdFYcx Strings are being finalised by UX writing so keeping them as translateable=false and no screenshots required. Bug: 1113439 Change-Id: I0128a8bf1c3989c691f0ca5a1a3701c1faea171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367254 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Garrett Beaty authored
A generator ensures that all builders for bucket ci that have an associated scheduler job actually have a scheduler job both with and without the ci prefix, so it's unnecessary for it to be set for builders in the ci bucket. Not setting it means that we won't unnecessarily add the property to builders when we move builders from master-only/ci.star. Bug: 1119446 Change-Id: I2575cb34f3f9ac97dce30545dafbe40e5ff96cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378717Reviewed-by:
-
