- 26 Jul, 2018 40 commits
-
-
Jan Krcal authored
This CL implements the functions to load the data of the model type. In particular, the function GetAllDataForDebugging() unblocks writing unit-tests for further changes. Bug: 853688 Change-Id: I6705ed3fd76b83fc59538c2d9e5b4f4a12b57436 Reviewed-on: https://chromium-review.googlesource.com/1151298 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578333}
-
sebsg authored
This code changes no behavior. It's simply in preparation for changing the autofill dropdown in the next CLs. Change-Id: I682c245d728c8bf3e8d5c57139b02e28a326111a Reviewed-on: https://chromium-review.googlesource.com/1147428 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#578332}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3ac64df1741..b5093bc9ede3 git log f3ac64df1741..b5093bc9ede3 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 benjaminwagner@google.com [infra] Add Metal to no_upload. 2018-07-26 robertphillips@google.com Maybe fix numStencilBits TSAN crash 2018-07-26 caryclark@skia.org avoid uninitialized under fuzzer Created with: gclient setdep -r src/third_party/skia@b5093bc9ede3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867314 TBR=benjaminwagner@chromium.org Change-Id: I8b846218bf68424526b235de8dc3e9c415b76257 Reviewed-on: https://chromium-review.googlesource.com/1151212Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578331}
-
Mark Pearson authored
to point to the histogram with the higher maximum Bug: 856467 Change-Id: Ie16d5190e008c7188ef4c9e4c60ef56a1c62d21f Reviewed-on: https://chromium-review.googlesource.com/1148885 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#578330}
-
Andrew Moylan authored
The is just testing that ServiceConnection::BindModelProvider returns successfully. The Mojo invitation won't go anywhere beyond the no-op FakeMachineLearningClient D-Bus client. To make this test compile, I had to fix an #include from an overlooked file rename in an earlier CL ... Bug: 863794 Change-Id: Ifd31fea950145561cd5954ae16e930b801bfe49b Reviewed-on: https://chromium-review.googlesource.com/1139942 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#578329}
-
Aleksei Loshkarev authored
If SetFirstSetupComplete was called before engine initialization, we'd record wrong UMA histograms and called DataTypeManager::Configure with wrong configure reason. The Yandex Browser wants to able to do this because in some signin scripts, for example corporate browser, user do not need to change sync channels. In this scenario RequestStart and SetFirstSetupComplete calls happpens simultaneously. Bug: 867451 Change-Id: Iec326c542476adf42c291cf2e002fc52e0a7b99d Reviewed-on: https://chromium-review.googlesource.com/1150175 Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#578328}
-
tzik authored
TimeZoneMonitorLinuxImpl is a ref counted type, and its first reference used to be made by base::Bind implicitly. The reference was passed to |file_task_runner_| and released on the task destruction. However, if the PostTask failed or the posted task ran soon before the ctor of TimeZoneMonitorLinuxImpl has finished, the instance is destroyed immediately, and `new TimeZoneMonitorLinuxImpl` returns a stale pointer. This CL adds a static constructor to move the problematic ref count manipulation out of the constructor. Bug: 866456 Change-Id: I5000cfa493cabe8858f20517328fe1d6e27795ff Reviewed-on: https://chromium-review.googlesource.com/1150959Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578327}
-
tzik authored
//chrome/browser/profiling_host/chrome_browser_main_extra_parts_profiling.cc includes chrome/common/chrome_switches.h, which needs an generated //chrome/common/buildflags.h, but corresponding BUILD.gn entry doesn't have the deps to the //chrome/common target that generates buildflags.h. As the result, chrome_browser_main_extra_parts_profiling.cc may be compiled before buildflags.h is generated, and that causes a flaky build failure. This CL adds a necessary target to chrome/browser/profiling_host deps to deflake the build. Change-Id: Ia1938e682a1f4dd5a52d4d00993d0877000532ce Reviewed-on: https://chromium-review.googlesource.com/1151044Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578326}
-
Achuith Bhandarkar authored
Don't need OS_CHROMEOS since this is only built on chromeos. Bug: 777356 Test: this is the test. Change-Id: I3088890e2ff8e5d11da1a487517c68c8e1eec720 Reviewed-on: https://chromium-review.googlesource.com/1144438Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#578325}
-
gogerald authored
Change-Id: Ib70d478a65996cadb1abe1c23b19197010215fec Reviewed-on: https://chromium-review.googlesource.com/1150733Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#578324}
-
Scott Violet authored
I had created TestEventInjector in hopes of being able to get rid of EventInjector, but that isn't possible. We rely on event injector for two real world cases: autoclick (an a11y feature that can generate mouse clicks) and for telemetry. Both of these need event injection enabled in production code. The telemetry and autoclick cases don't care about being notified when processing is completed, so I introduced a special function for this case. I am doing this because the code needed to verify an event has been processed is non-trivial, and I would like to avoid running it when possible. BUG=852439 TEST=none Change-Id: I2691151ffaa9b6519f7462582d0f1aadd2010850 Reviewed-on: https://chromium-review.googlesource.com/1150503 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#578323}
-
Urvang Joshi authored
https://aomedia.googlesource.com/aom.git/+log/0415f2e501a2..ef95278f79fa $ git log 0415f2e50..ef95278f7 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 yunqingwang Add config flag to only enable normal tile mode 2018-07-25 debargha Add config flag to limit decoding profile 2018-07-24 wtc Add oss-fuzz test cases for invalid_file_test.cc. 2018-07-24 wtc Document how to make a new test data file public. 2018-07-24 ravi.chaudhary SSE2 optimization of aom_highbd_comp_mask_pred 2018-07-24 yuec Turn on wavelet energy modulated deltaq 2018-07-06 jimbankoski new aq variance 2018-07-24 ddvfinite Fix Visual Studio 12 build Error 2018-07-23 ddvfinite Refactor: remove useless include file 2018-07-13 niva213 lbd loopfilter 6,8,14 performance improvement 2018-07-20 ravi.chaudhary Enable tile-row based multi-threading in Encoder 2018-07-23 ravi.chaudhary Fix encoder multi-threading mismatch for superres 2018-07-20 ranjit.tulabandu Optimize interpolation filter selection 2018-07-18 ddvfinite Opt blend_a64_mask 2018-07-23 binpengsmail Speedup find_tx_size_rd_info 2018-07-20 weitinglin Fix the quality boost ratio between ALT2 and ALT in AOM_Q mode 2018-07-16 weitinglin Apply pyramid structures on GF length >= 4 2018-07-15 debargha DNN RD Model simplification and improvement Created with: roll-dep src/third_party/libaom/source/libaom R=johannkoenig@google.com cmake flags Bug: 867619,867620 Change-Id: I9802b6b9beb8a827cb94b78083d6da94bf93e085 Reviewed-on: https://chromium-review.googlesource.com/1150903Reviewed-by:
Urvang Joshi <urvang@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578322}
-
Han Leon authored
Currently service_worker.mojom defines a [Native] mojom struct content.mojom.PlatformNotificationData using the legacy IPC struct traits for the native struct content::PlatformNotificationData. However, there is already existing a mojom struct blink.mojom.NotificationData which is typemapped with content::PlatformNotificationData, it's exactly fit to our needs, so, this CL starts to use blink.mojom.NotificationData then removes the [Native] content.mojom.PlatformNotificationData and the corresponding legacy IPC struct traits. BUG=789854 Change-Id: I20549a8feb3575341661b92a5993bf758e6174e1 Reviewed-on: https://chromium-review.googlesource.com/1149714Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#578321}
-
Justin Novosad authored
This CL discards the pre-existing CanvasResourceProvider instance if it is not of the right size when pushing a WebGL animation frame. BUG=866855 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibfa8924102dfcd2815a6010b0b9ada6c37fdd5ab Reviewed-on: https://chromium-review.googlesource.com/1148685Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578320}
-
jonross authored
Both of these PerfBenchmarkTests have hard coded expectations of the number of enabled features. This however causes these tests to fail whenever the telemetry_perf_unittests suite is ran for any feature that is also controlled by --enable-features. This prevents properly running the suite while bringing up new features. This change disables the tests on linux where we've been trying to run the suite for VizDisplayCompositor. However these tests can fail on any platform and should be revisited to verify the flags that the test cares about. TEST=PerfBenchmarkTest.testVariationArgs, PerfBenchmarkTest.testVariationArgsReference Bug: 844863 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I3cdd534fc63475c75f94e6e6a16e644efaa21779 Reviewed-on: https://chromium-review.googlesource.com/1151103Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#578319}
-
Gemene Narcis authored
Blacklisted credentials are special PasswordForm instances saved in PasswordStore, which record the user's choice never to store credentials for a given site. When PasswordFormManager asks for all stored forms for a given PasswordStore::FormDigest(scheme, realm and origin), it suppresses all saving functions as long as there is at least one entry marked as blacklisted. In particular, saving more than one blacklisted entry for a given scheme/realm/origin combination has no additional effect compared to just one. Nevertheless, duplicates could have been created by older versions of Chrome, and their frequency is measured by the PasswordManager.BlacklistedDuplicates histogram. To avoid potentially confusing the user by copies of the blacklisted entries and also to avoid potential bugs when deleting just one blacklisted entry would keep the site blacklisted, this CL makes the PasswordStore prune duplicated blacklist entries on start-up. Bug: 862930 Change-Id: I48d8919139c50c267053244573b70b246e9e99b2 Reviewed-on: https://chromium-review.googlesource.com/1140158 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578318}
-
Aaron Leventhal authored
Expose as IA2_ROLE_INTERNAL_FRAME, and do not used STATE_SYSTEM_READONLY or FOCUSABLE. Bug: 867015 Change-Id: I310c3dc3fa1cede34b54d66a35c23ca4345b1ebd Reviewed-on: https://chromium-review.googlesource.com/1148785 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#578317}
-
Justin Novosad authored
This is a follow-up to CL: https://chromium.googlesource.com/chromium/src/+/1fff44ec70ab202add6f06e6f8603637d265ccc4 BUG=789232 Change-Id: I703333249b0c06642647842b2c735424b795447f Reviewed-on: https://chromium-review.googlesource.com/1150721Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578316}
-
Amy Qiu authored
Create new recordings for pages in pathological mobile sites to ensure current sites are used for the rendering benchmark. Update URL for espn and add login for linkedin. Bug: 852530 Change-Id: I3f30d1b4daf7c4a850f8f759129f27be01a1751a Reviewed-on: https://chromium-review.googlesource.com/1148949Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#578315}
-
Amy Qiu authored
Now that it's been a week since pages in top_real_world_desktop were refreshed, remove the old pages. Also delete expectations for replaced pages. Bug: 852530 Change-Id: I3a702e877a56fe94a47add8b2254774d9c93fa28 Reviewed-on: https://chromium-review.googlesource.com/1150680Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#578314}
-
Elodie Banel authored
Displaying favicons with clear background, shrinking down to 16pt, and changing default icon. Bug: 860245 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I75e75d0bb21784441561e79a623002fdc2c95ae8 Reviewed-on: https://chromium-review.googlesource.com/1151111 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#578313}
-
Marc Treib authored
This replaces most remaining ThreadTaskRunnerHandle/SingleThreadTaskRunner by SequencedTaskRunnerHandler/SequencedTaskRunner. There are some places that actually need thread-affinity (e.g. network stuff), or where it makes sense (UIModelWorker which is specifically for running on the UI thread). One remaining place I'm not sure about is WeakHandle. Bug: 846238 Change-Id: I704406fbf2c462537971eda0102c40626503b793 Reviewed-on: https://chromium-review.googlesource.com/1151296Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#578312}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=sky@chromium.org Bug: 589840 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie374511b52899d367e12c89f8f78e7717b4d6b6f Reviewed-on: https://chromium-review.googlesource.com/1150219Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#578311}
-
Francois Doray authored
It is no longer to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define a global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable. This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 589840 Change-Id: I7c899d2cfdb3a5c38f6d9a136b474c19f6370c71 Reviewed-on: https://chromium-review.googlesource.com/1150287Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#578310}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6031e69d34ff..17aff35e1dea git log 6031e69d34ff..17aff35e1dea --date=short --no-merges --format='%ad %ae %s' 2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for sdk/ (part 1). 2018-07-26 nisse@webrtc.org Add missing include of stdint.h in MIPS code. 2018-07-26 hta@webrtc.org Add API to report "interesting" usage patterns to PC client Created with: gclient setdep -r src/third_party/webrtc@17aff35e1dea The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:866792 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea50bc810d2af73a791ecb4ce508258083db91a4 Reviewed-on: https://chromium-review.googlesource.com/1151249Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578309}
-
Mounir Lamouri authored
This reverts commit dab9cc04. Reason for revert: <INSERT REASONING HERE> Original change's description: > Picture-in-Picture: show buttons when the mouse is hovering. > > This is fixing a Windows specific bug where the ENTER event isn't fired. > > Bug: 867646 > Change-Id: I79daf4679bdfaff00aadcf087bc89c27995fe0d9 > Reviewed-on: https://chromium-review.googlesource.com/1150892 > Reviewed-by: apacible <apacible@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578212} TBR=mlamouri@chromium.org,apacible@chromium.org Change-Id: Ied59d027a5fb261ac3c436dacf2ba074e05dc773 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867646 Reviewed-on: https://chromium-review.googlesource.com/1150703Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#578308}
-
Fady Samuel authored
Prior to this CL, SurfaceDependencyTracker read activation_dependencies from the pending CompositorFrame's CompositorFrameMetadata. This meant that it had to look up already resolved dependencies. It's more efficient to use the remaining dependencies set tracked in Surface directly. The code is also more compact and easier to read. In the first attempt to land, the CL iterated over activation_dependencies as they were changing. This resulted in a crash. The solution is to copy over the set before iteration. Bug: 672962 Change-Id: I3264f75b3fc71d7cd0368a63fcd38f7afcaf1cb0 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1148226Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1150675 Cr-Commit-Position: refs/heads/master@{#578307}
-
Ramya Nagarajan authored
Bug: 867719 Change-Id: I8f1368e86194c1732a7b7abb232cb137ea4ccf96 Reviewed-on: https://chromium-review.googlesource.com/1150978Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578306}
-
Oscar Johansson authored
Building //media takes around 23 CPU minutes. A experimental branch showed that this could be reduced, by using jumbo, to around 9 CPU minutes. media/base is the second largest part of media and takes around 3.1 CPU minutes to compile without jumbo. This commit enables jumbo for media/base. Bug: 867350 Change-Id: Ie2dae0a65bfc596b30339712a39cab321e293f48 Reviewed-on: https://chromium-review.googlesource.com/1150037Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#578305}
-
Olivier Robin authored
Change-Id: Icb90e3167166a33d4c4214c306bc1faea86f31ae Reviewed-on: https://chromium-review.googlesource.com/1151201 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578304}
-
Robert Kroeger authored
Ozone/drm/mojo assumes when running in single-process mode on one thread that the UI portion will be initialized before the GPU portion. CHECK this only in the single thread case instead of (wrongly) checking it in the single-process case as well. BUG=866263 TEST=by-hand with wait insertion with and without check change. Change-Id: I0029ac81f23c11153d8e2e027f7003f7f616af11 Reviewed-on: https://chromium-review.googlesource.com/1150845 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578303}
-
sebsg authored
This CL implements GetStorageKey() and GetClientTag() functions of the autofill wallet USS bridge. The implementation is compatible with the previous syncable service code. Bug: 853688 Change-Id: If86916ef6486b104685e615c68010ac9da281b61 Reviewed-on: https://chromium-review.googlesource.com/1148962 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#578302}
-
Xida Chen authored
In this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1149456 When projecting a touch-action rect to a graphics layer's space, the offset with regards to the layout object is accounted for. What we really need is the offset with regards to its transform node. The correctness can be proved by passing an existing test. Bug: 853912 Change-Id: I534bd2aa52552bc2ac12a0eec259d47c9cb73574 Reviewed-on: https://chromium-review.googlesource.com/1150928Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578301}
-
Moe Ahmadi authored
Bug: 866922 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I37c634cc378214a10861b0a1fc3f8b3f8b97a2a3 Reviewed-on: https://chromium-review.googlesource.com/1149119Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578300}
-
Stephen McGruer authored
Test is flaking consistently on the CQ: https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxCcm93c2VyVGVzdC5XaW5kb3dPcGVuQ2xvc2UyDA TBR=fsamuel@chromium.org Bug: 823043 Change-Id: I6103eb9fcb95e9e3afc77ab9da1740391fe5d211 Reviewed-on: https://chromium-review.googlesource.com/1151387Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#578299}
-
Joshua Peraza authored
93b1271e1b8d package.h: Update PACKAGE_COPYRIGHT_YEAR to 2018 20294e79cc09 android: Rename crashpad_handler_module target Change-Id: I1bfb07c0478ff050fab8e54ab2073e9c79a159f0 Reviewed-on: https://chromium-review.googlesource.com/1150975Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#578298}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 589840 Change-Id: I26d9d7478b46c88bde21ec9ee095cebb26c0e520 Reviewed-on: https://chromium-review.googlesource.com/1150288 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#578297}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 589840 Change-Id: I8e7bbadce2f45929143f65aa54957a703432ed76 Reviewed-on: https://chromium-review.googlesource.com/1150286 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578296}
-
Noel Gordon authored
Add tests cases for zipping a file: test Downloads, Drive, and USB, to get the "create-a-zip-file" integration test ball rolling. Test: browser_tests --gtest_filter="ZipFiles/FilesApp*zipCreate*" Bug: 864256,865197,867738 Change-Id: I28c2da7bd5662ef944659c11529d963cf81d48ed Reviewed-on: https://chromium-review.googlesource.com/1151068 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578295}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=torne@chromium.org Bug: 589840 Change-Id: I4fbd69c788fc06549d32b4d12199309bbd1bbe1f Reviewed-on: https://chromium-review.googlesource.com/1150283 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578294}
-