GitLab

Renamed EUnicodeBidi to just UnicodeBidi to match the name of the file,
UnicodeBidi.h. This is pre-work to allow UnicodeBidi to be used by
generated fields in ComputedStyleBase, and also better matches the
style guidelines (class names should have the same name as the file).

BUG=628043

Review-Url: https://codereview.chromium.org/2620873002
Cr-Commit-Position: refs/heads/master@{#443041}

Previously, an oscillator would start at the nearest sample frame
boundary.  This can produce noticeable effects.

Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.

BUG=631576
TEST=Oscillator/start-sampling.html

Review-Url: https://codereview.chromium.org/2186813003
Cr-Original-Commit-Position: refs/heads/master@{#442669}
Committed: https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d04cfa521e38c
Review-Url: https://codereview.chromium.org/2186813003
Cr-Commit-Position: refs/heads/master@{#443040}

Revert of Enable creation of offscreen contexts which own their backing surface. (patchset #12 id:220001 of https://codereview.chromium.org/2586803003/ )

Reason for revert:
Causes out-of-order frames and tearing in WebVR.

Original issue's description:
> Enable creation of offscreen contexts which own their backing surface.
>
> This is adapted from bajones's patch from issue 2461803002 at patchset 1
> (http://crrev.com/2461803002#ps1)
>
> Uses the own_offscreen_surface flag with WebGL contexts when WebVR is enabled,
> to allow the surface to be swapped out with a compatible one if used for VR
> presentation.
>
> Includes support for canvas attributes such as "antialias", and adds a "low
> priority" GL context option so that postprocessing such as in WebVR frame
> submit at normal priority won't get blocked on the next frame being drawn.
>
> BUG=655722
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2586803003
> Cr-Commit-Position: refs/heads/master@{#442448}
> Committed: https://chromium.googlesource.com/chromium/src/+/46b9f6aaaf5851014c2474365734e71ffe9367a0

TBR=aelias@chromium.org,bajones@chromium.org,dcheng@chromium.org,jbauman@chromium.org,klausw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=655722

Review-Url: https://codereview.chromium.org/2628963002
Cr-Commit-Position: refs/heads/master@{#443039}

The testBrowsingPostEntryWithKeyboard test is flaky on device, with the
failure that the Go button on the keyboard is not interactable when tap
is performed. This implies that the tap is reached before the keyboard
is fully interactable, so this CL adds a requirement that the button is
interactable to the wait criteria.

BUG=670380

Review-Url: https://codereview.chromium.org/2626143002
Cr-Commit-Position: refs/heads/master@{#443038}

We need to add touchscreen support to mustash where display and
input-device management happens in a different process from ash.
Decouple ash::TouchTransformerController from the rest of ash and move
to src/ui/display/ so it can be used with mus. This also decouples and
moves the accompanying tests.

The dependency on WindowTreeHostManager can't be broken so add
AshTouchTransformController which extends TouchTransformController and
listens for ash display configuration changes.

BUG=679747

Review-Url: https://codereview.chromium.org/2617043003
Cr-Commit-Position: refs/heads/master@{#443037}

The separator is actually a dot.

BUG=661741

Review-Url: https://codereview.chromium.org/2620353002
Cr-Commit-Position: refs/heads/master@{#443036}

The last of these files was removed from cc/base/ over a year ago:
  https://chromium.googlesource.com/chromium/src/+/a370ef52788ea0f6c410b05ec40a74ee9bf3a647

Review-Url: https://codereview.chromium.org/2625913004
Cr-Commit-Position: refs/heads/master@{#443035}

- Add support to ContentRectangle.
- Inherit opacity from parent elements.
- Update tests.
- Drive omnibox opacity animations natively rather than via CSS.

BUG=679761
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624243002
Cr-Commit-Position: refs/heads/master@{#443034}

This flag is used in the renderer to override the memory limit for
tiles. The code to actually override the memory is already there, but
the flag isn't currently being propagated to the renderer. This patch
fixes this.

R=enne@chromium.org

Review-Url: https://codereview.chromium.org/2616773002
Cr-Commit-Position: refs/heads/master@{#443033}

Also update callers to use better way to construct the path using
StringPiece-s, avoiding string copy (GURL::path()) and substring
copy (std::string::substr(1)).

Move ExtensionIconSet's unittest to extensions/

BUG=None

Review-Url: https://codereview.chromium.org/2626923002
Cr-Commit-Position: refs/heads/master@{#443032}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7863f77ca84e..64cff499aefc

$ git log 7863f77ca..64cff499a --date=short --no-merges --format='%ad %ae %s'
2017-01-11 simonhatch Dashboard - Fix incorrect default metric on group_report.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2628073002
Cr-Commit-Position: refs/heads/master@{#443031}

A dummy CTVerifier and CTPolicyEnforcer is used to turn off parsing,
validation, and evaluation of results.

BUG= internal b/34104027

Review-Url: https://codereview.chromium.org/2621083004
Cr-Commit-Position: refs/heads/master@{#443030}

Replace the SetSubclassProperties method with CheckSubclassProperties,
which checks the properties that were set, and checks that all others
are the default values.

The next step is to delete all of the sub-classes (including the
just-added CheckSubclassProperties functions).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2628713002
Cr-Commit-Position: refs/heads/master@{#443029}

Copying the summary from dcheng@ on the referenced bug:

The current implementation looks like this:
void WebTaskRunner::postTask(const WebTraceLocation& location,
                             std::unique_ptr<CrossThreadClosure> task) {
  toSingleThreadTaskRunner()->PostTask(location,

     convertToBaseCallback(std::move(task)));
}

However, base::TaskRunner::PostTask() takes a const base::Closure&.
When we convert the CrossThreadClosure to a base::Callback, we just
extract the internal callback object. However, this callback object is
never supposed to be copied, only moved.

Since the base APIs haven't been updated to use base::OnceCallback, now
 we have two copies of the callback referencing the same
base::BindState (which is holding the bound variables): one on the
posting thread (call it thread 1), and one on the posted thread (call
it thread 2).

If the copy on thread 2 is destroyed before the copy on thread 1,
base::BindState will be destroyed on thread 1. If base::BindState
contained WTF::String or other thread-unsafe objects, and thread 2
copied it, this means that the thread-unsafe objects will be ref'ed
and deref'ed on multiple threads, which is not good.

BUG=679915, 680042

Review-Url: https://codereview.chromium.org/2626883003
Cr-Commit-Position: refs/heads/master@{#443028}

Follow-up from discussion on http://crrev.com/2612093002.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2616353003
Cr-Commit-Position: refs/heads/master@{#443027}

This caused a crash bug in FRE code on some versions of
Android where setUserVisibleHint() gets called before
onViewCreated().

This was broken by my CL from this morning:
https://codereview.chromium.org/2561433002

BUG=632199
NOTRY=true

Review-Url: https://codereview.chromium.org/2628943002
Cr-Commit-Position: refs/heads/master@{#443026}

Enable writing to the prefs by default in the network quality estimator
(NQE). The reading from the prefs is still disable by default, and
controlled via field trial.

Also enable correlation logging by default which records UMA on
correlation between a higher layer metric, and a lower layer metric.

Also, use UMA_HISTPGRAM_EXACT_LINEAR for 2 histograms since those
histograms only need 2 buckets for storing data.

BUG=490870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2622663002
Cr-Commit-Position: refs/heads/master@{#443025}

This CL is a pre-requisite for
https://codereview.chromium.org/2592143003/

TBR=bauerb@chromium.org,bauerb@chromium.org,hubbe@chromium.org,jri@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2627903002
Cr-Commit-Position: refs/heads/master@{#443024}

This CL implements HID detection screen for material design ChromeOS OOBE.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2600983003
Cr-Commit-Position: refs/heads/master@{#443023}

BUG=

Review-Url: https://codereview.chromium.org/2625893002
Cr-Commit-Position: refs/heads/master@{#443022}

BUG=464835

Review-Url: https://codereview.chromium.org/2625093003
Cr-Commit-Position: refs/heads/master@{#443021}

The previous code didn't validate incoming messages at all.

BUG=579646

Review-Url: https://codereview.chromium.org/2613813002
Cr-Commit-Position: refs/heads/master@{#443020}

Methods of GeolocationHeader typically take a context, but the
context is merely used to get the package name and start an Activity.
We can instead use ContextUtils.getApplicationContext().

Review-Url: https://codereview.chromium.org/2619093002
Cr-Commit-Position: refs/heads/master@{#443019}

The gtk3 port of chrome would segfault under the following circumstances:
* The version of Gtk is at least 3.20
* Using a non-component build
* Using the bundled harfbuzz library

This CL adds the same hack used in libgtk2ui to force harfbuzz symbol loading.

BUG=462689
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2624073002
Cr-Commit-Position: refs/heads/master@{#443018}

In some cases, it tried to generate favicon URL using the referrer URL of a
navigation, but referrer URL could be empty which triggered a DCHECK in
TemplateURL::GenerateFaviconURL.

BUG=678502

Review-Url: https://codereview.chromium.org/2624263002
Cr-Commit-Position: refs/heads/master@{#443017}

CompositorViewHolder should add views with their original layout params,
rather than creating a new one every time.

BUG=679998

Review-Url: https://codereview.chromium.org/2628033002
Cr-Commit-Position: refs/heads/master@{#443016}

Currently the message "Turn on Bluetooth to allow pairing" is aligned
left on the chooser. This CL moves it to the center of the chooser.

I uploaded some screenshots on the issue page.

BUG=664240

Review-Url: https://codereview.chromium.org/2627483003
Cr-Commit-Position: refs/heads/master@{#443015}

Chrome sign-in URLS are only supposed to be open in regular profiles and
loading them in incognito or guest profiles leads to crashes.

This CL avoids loading these URLs on incognito profiles.

Screenshots after this change in a guest session:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbeHUxR0lZbGs4OFU/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbV2I4TnJ4enpuazg/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbLWdVOUZkc0JfeEU/view?usp=sharing

BUG=679265

Review-Url: https://codereview.chromium.org/2621083002
Cr-Commit-Position: refs/heads/master@{#443014}

Previously we log even the stacktrace of NotBootstrappedError. It turned
out that it really pollutes log by spamming the log with
stacktraces.

In this cl, we changed the logging of error to just one line.

BUG=675666

Review-Url: https://codereview.chromium.org/2622693003
Cr-Commit-Position: refs/heads/master@{#443013}

white animation speed

Changes:
(1) shutdown_timer_ in TabletPowerButtonController changes from 1000ms to 500ms.
(2) animation_speed_shutdown is set to 2500ms for touch view enabled device case.

This change follows the new timing guideline in go/touchview-power.

BUG=633304
TEST=tested on device

Review-Url: https://codereview.chromium.org/2622103003
Cr-Commit-Position: refs/heads/master@{#443012}

I unintentionally added this to an unrelated CL, didn't mean to commit.

R=vmpstr,reveman
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2625033003
Cr-Commit-Position: refs/heads/master@{#443011}

BUG=577816
R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2622293002
Cr-Commit-Position: refs/heads/master@{#443010}

Revert of Use TaskScheduler instead of WorkerPool in cache_util.cc. (patchset #3 id:40001 of https://codereview.chromium.org/2610503002/ )

Reason for revert:
It looks like this CL may be related to a unit test failure on this build:
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/7492
- Sheriff

Original issue's description:
> Use TaskScheduler instead of WorkerPool in cache_util.cc.
>
> The following traits are used:
>
> Priority: BACKGROUND
>   User won't notice if this task takes an arbitrarily long time
>   to complete.
>
> Shutdown behavior: CONTINUE_ON_SHUTDOWN
>   Tasks posted with this mode which have not started executing before
>   shutdown is initiated will never run. Tasks with this mode running at
>   shutdown will be ignored (the worker will not be joined).
>
>   Note: Tasks that were previously posted to base::WorkerPool should
>   use this shutdown behavior because this is how base::WorkerPool
>   handles all its tasks.
>
> May Block:
>   Tasks posted with MayBlock() may block. This includes but is not
>   limited to tasks that wait on synchronous file I/O operations:
>   read or write a file from disk, interact with a pipe or a socket,
>   rename or delete a file, enumerate files in a directory, etc. This
>   trait isn't required for the mere use of locks.
>
> BUG=659191
>
> Review-Url: https://codereview.chromium.org/2610503002
> Cr-Commit-Position: refs/heads/master@{#442985}
> Committed: https://chromium.googlesource.com/chromium/src/+/8d1a5a1e352ee6b2aee40b42d9fdc4b6e0c97fed

TBR=gavinp@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659191

Review-Url: https://codereview.chromium.org/2626163002
Cr-Commit-Position: refs/heads/master@{#443009}

Part of removing the dependency of the browser DLL on Windows on V8.

BUG=581766

Review-Url: https://codereview.chromium.org/2625853002
Cr-Commit-Position: refs/heads/master@{#443008}

Removes all the Android-code related to blimp from //chrome, and
removes all the dependencies of the //blimp directory.

This includes all hooks for the UI code, command line flags,
resources, and the BrowserContextKeyedService.

BUG=677556

Review-Url: https://codereview.chromium.org/2623023002
Cr-Commit-Position: refs/heads/master@{#443007}

If a quick action was shown, contextual cards data for a thumbnail/caption
were not shown, so the histograms for whether contextual cards data
was shown should log "false".

BUG=680229

Review-Url: https://codereview.chromium.org/2621413003
Cr-Commit-Position: refs/heads/master@{#443006}

Texture must be bound before it has a valid mailbox.
https://crrev.com/d40f03 accidentally broke this by
accessing the mailbox before calling BindTexImage.

BUG=679200

Review-Url: https://codereview.chromium.org/2627753003
Cr-Commit-Position: refs/heads/master@{#443005}

methodname.

Example:
  --test_filter=Hello.W*
  Matches classname='Hello' and methodname='W*'

BUG=669956

Review-Url: https://codereview.chromium.org/2624133003
Cr-Commit-Position: refs/heads/master@{#443004}

This is (mostly) the bare minimum to merge the two. Future patches
will cleanup WmWindow usage.

BUG=671246
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2620153003
Cr-Commit-Position: refs/heads/master@{#443003}

Rename and renumber enum entries to exactly match wire values
defined in the HTTP/2 specification.  In particular:
* s/GOAWAY_OK/GOAWAY_NO_ERROR/
* s/RST_STREAM_INVALID_STREAM/RST_STREAM_STREAM_CLOSED/
* s/RST_STREAM_FRAME_TOO_LARGE/RST_STREAM_FRAME_SIZE_ERROR/
* Remove RST_STREAM_UNSUPPERTED_VERSION, RST_STREAM_IN_USE,
  RST_STREAM_ALREADY_CLOSED.

Change string serialization values only used for log messages.

RST_STREAM_INVALID_STREAM and RST_STREAM_STREAM_CLOSED were used
interchangeably.  Now RST_STREAM_INVALID_STREAM is removed in favor of
RST_STREAM_STREAM_CLOSED.  This CL also renames STATUS_CODE_INVALID_STREAM to
STATUS_CODE_STREAM_CLOSED, and changes description in histograms.xml.

Also add STATUS_CODE_COMPRESSION_ERROR to SpdyProtocolErrorDetails,
to correctly log incoming RST_STREAMs with RST_STREAM_COMPRESSION_ERROR.

This CL lands server change 143555862 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2612293004
Cr-Commit-Position: refs/heads/master@{#443002}