GitLab

https://chromium.googlesource.com/catapult.git/+log/ba76717a8d18..bbb04a38bbdb


git log ba76717a8d18..bbb04a38bbdb --date=short --no-merges --format='%ad %ae %s'
2018-08-22 wangge@google.com Fix Bug When No APK is present and Add Relevant Test Cases.
2018-08-22 anthonyalridge@google.com Initial application of mann whitney testing.
2018-08-22 benjhayden@chromium.org [chromeperf v2] Simple redux helpers.
2018-08-22 benjhayden@chromium.org Add icons for V2SPA.
2018-08-21 mseaborn@google.com [dashboard] Update docs to mention old issues filed in the Github tracker
2018-08-21 benjhayden@chromium.org Fix minify script for v2spa.
2018-08-21 benjhayden@chromium.org Add some utility functions to V2SPA.
2018-08-21 eakuefner@chromium.org [Tracing] Fix Pylint errors
2018-08-21 amyqiu@google.com Fix search bug in metrics visualization tool
2018-08-21 benjhayden@chromium.org Add ElementBase for V2SPA.
2018-08-21 benjhayden@chromium.org Plumb test case tag maps via test suite descriptors.
2018-08-21 vovoy@chromium.org Add story property: wpr_mode
2018-08-21 wangge@google.com Restructure Long Term Health Tool Output File Structure.
2018-08-20 benjhayden@chromium.org Add Material textarea for V2SPA.
2018-08-20 benjhayden@chromium.org Add checkbox to V2SPA.
2018-08-20 benjhayden@chromium.org Add cp-loading for V2SPA.
2018-08-20 benjhayden@chromium.org Add raised-button to V2SPA.
2018-08-20 chiniforooshan@chromium.org Telemetry: pixel metrics in TBMv2
2018-08-20 simonhatch@chromium.org Dashboard - Add a path for inserting out-of-order diagnostics.
2018-08-20 simonhatch@chromium.org Dashboard - Fix gcs read.
2018-08-20 chiniforooshan@chromium.org Telemetry: rename metrics as per crbug.com/627461
2018-08-20 simonhatch@chromium.org Dashboard - Cleanup unused masters and bots
2018-08-20 chiniforooshan@chromium.org Telemetry: break rendering_metric.html


Created with:
  gclient setdep -r src/third_party/catapult@bbb04a38bbdb

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:863390,chromium:866423,chromium:862077,chromium:863390,chromium:760553,chromium:874856,chromium:627461,chromium:760553
TBR=sullivan@chromium.org

Change-Id: I6f9a52e2e301d0e04b4800a9c57a33000ec51f26
Reviewed-on: https://chromium-review.googlesource.com/1185141Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585147}

This separates the WebContentsObserver and WebContentsDelegate code
from ChromeKeyboardUI.

Note: ChromeKeyboardWebContents has a dependency on ui::keyboard that
will need to be replaced with a mojo API call for multi process mash,
but the separation should at least help with the single process mash
split, and calls out / documents where the multi process mash change
needs to happen.

Bug: 843332
Change-Id: I09a8ea3ac0536737d395fda372b98919221c1a3a
Reviewed-on: https://chromium-review.googlesource.com/1182679Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585146}

This CL adds a method to validate a value against a given schema to the
python schema validator. This method is also used in a new presubmit
test to ensure all example values are valid in policy_templates.json.

Bug: 873641, 858980, 856901
Change-Id: I2ad477785e8ee37a9e07ee7231c3d12d8501a43f
Reviewed-on: https://chromium-review.googlesource.com/1174443
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585145}

In order to prevent the pointer leakage when we create local_card_migration_manager from the settings page, we add two accessor methods in AutofillManager and FormDataImporter.

Notice that form_data_importer is a unique_ptr owned by autofill_manager (created when autofill_manager is created). Form_data_importer owns a unqiue_ptr of the local_card_migration_manager and create that when itself is created.

We can add form_data_importer() accessor function in autofill_manager to get the raw pointer of the form_data_importer and add local_card_migration_manager() function to form_data_importer to get the raw pointer of local_card_migration_manager.

Bug: 852904
Change-Id: Ied951b50aaa0181cfeb97c1f6be9f2517db5e5a5
Reviewed-on: https://chromium-review.googlesource.com/1180595Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Cr-Commit-Position: refs/heads/master@{#585144}

Remove the feature flag that controls whether Modern is enabled,
effectively enabling the feature at 100%. Fix up tests that were
previously running with Modern disabled. Removes some "Chrome classic"
render tests.

This CL effectively enables Modern and "contextual suggestions" (EoC),
which relies on Modern being enabled, for all tests.

BUG=876051

Change-Id: I9938dabbba238f86d42356325d42ace581512d25
Reviewed-on: https://chromium-review.googlesource.com/1183684
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585143}

This reverts commit c7196c14.

Reason for revert: WebKit Win Builder failing, 
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder/158247
speculatively reverting

Original change's description:
> [Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature).
> 
> This CL adds a feature to use THREAD_MODE_BACKGROUND_BEGIN instead of
> THREAD_PRIORITY_LOWEST for ThreadPriority::BACKGROUND threads. This
> lowers the disk and network I/O priority of the thread in addition to
> the CPU scheduling priority. MSDN recommends using this setting for
> threads that perform background work.
> https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-setthreadpriority
> 
> Bug: 872820
> Change-Id: Ia731fcf39c991ae30ca74055595a84385f27635f
> Reviewed-on: https://chromium-review.googlesource.com/1171482
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585104}

TBR=gab@chromium.org,fdoray@chromium.org

Change-Id: Ia6a20e3a59b68ee0c845f26f343bb10582d03d72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 872820
Reviewed-on: https://chromium-review.googlesource.com/1185342Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585142}

Since the visual rects are now relative to the transform ancestor,
we don't need to clear the visual rects if the paint invalidation
container changes.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie23d14c9bd90882f0cbabf28347848bd2a019de3
Reviewed-on: https://chromium-review.googlesource.com/1166204
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585141}

Change-Id: I5a483b0100ab76e52dcb88d379f46721b0b86bbc
Reviewed-on: https://chromium-review.googlesource.com/1184717
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585140}

GetLatestInFlightSurface should not return nullptr if fallback doesn't exist.
Instead it should try to search for active surfaces in primary's FrameSinkId.

Bug: 875381
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I8940c374b7f52f728e4d88c88358aeb177dc8520
Reviewed-on: https://chromium-review.googlesource.com/1179989Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#585139}

The two entry types seem to be completely unused.

Change-Id: I0fe32a2b7502d5aa4af0a4f2c3457536810a4a03
Reviewed-on: https://chromium-review.googlesource.com/1183637Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585138}

https://chromium.googlesource.com/angle/angle.git/+log/de8d4cb0d496..9259fd0d4f4c


git log de8d4cb0d496..9259fd0d4f4c --date=short --no-merges --format='%ad %ae %s'
2018-08-22 oetuaho@nvidia.com Clean and enable NoLeakingFragments multiview test
2018-08-22 oetuaho@nvidia.com Add helpers for multiview framebuffer init
2018-08-22 jmadill@chromium.org Add state change test for uniform buffer validation.
2018-08-22 oetuaho@nvidia.com Ignore D3D11 debug layer messages in multiview tests
2018-08-22 chrome-bot@chromium.org Remove cq_name from cq.cfg at tandrii@chromium's request.
2018-08-22 chrome-bot@chromium.org Temporarily suppress multiview test failure due to debug layers
2018-08-22 oetuaho@nvidia.com Fix resource init/teardown in multiview tests
2018-08-22 jie.a.chen@intel.com Make some Program methods inlined
2018-08-22 jmadill@chromium.org Use Observer pattern for Buffers in front-end.
2018-08-21 jmadill@chromium.org Add gl::Program::syncState and dirty bits.
2018-08-21 jmadill@chromium.org Optimize element array binding.
2018-08-21 tobine@google.com Revert "Expect pass on pointcoord test on Pixel 2"
2018-08-21 jmadill@chromium.org Add more test param documentation to perf tests.


Created with:
  gclient setdep -r src/third_party/angle@9259fd0d4f4c

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ieaaaf429abd70072ec213526eabdc5166460c919
Reviewed-on: https://chromium-review.googlesource.com/1184865Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585137}

Change-Id: Ic8cccbf6287471f6750dd273b7b4b0c69cc0a64c
Reviewed-on: https://chromium-review.googlesource.com/1184719
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585136}

R=drubery

Change-Id: Ic7501d359fce58eafccdb2cede709fb6f83503a9
Reviewed-on: https://chromium-review.googlesource.com/1184117Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585135}

Fix the navigation of the "Google Assistant settings" link in Chrome OS settings.

Test: local compile and manually test.
Bug: b:112606371
Change-Id: I9bedaa639a0a0e7a3ceb33c999d0528af5c0bd47
Reviewed-on: https://chromium-review.googlesource.com/1183886Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585134}

Includes srcjars and classes.jar files.

Bug: 874852
Change-Id: I71d3904dd0d27ed14e9f88f78f17a95140080955
Reviewed-on: https://chromium-review.googlesource.com/1181773Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585133}

The SimpleJavascriptTests were flaky due to loading/destroying of the
MV iframe. Disabling all iframes for these tests will prevent the
flakiness and the iframes aren't needed by the tests anyway.

Also update some of the tests, as things have changed in the time
they've been disabled.

Bug: 857256, 845498
Change-Id: I98d6f337ab2a5172f5e07648f2df0ce272f25597
Reviewed-on: https://chromium-review.googlesource.com/1183958
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585132}

The bookmark bar has historically been disabled when the Omnibox popup
was open. This was because the Omnibox popup was a full-width dropdown
that would cover any attached bookmark bar.

In that case, we don't want the top couple of pixels of the bookmark
bar to spuriously trigger any navigations if the user clicked on it.

For MD Refresh, where the dropdown covers the bookmark bar entirely
within the popup width, the above logic doesn't make sense.

We now let the bookmark bar be clickable even when the popup is open
if Material Refresh is on.

Bug: 875610
Change-Id: I3b79461ea4a4fcc21e79e22dbcf22c779abc3f99
Reviewed-on: https://chromium-review.googlesource.com/1184262Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585131}

In order to prevent system UI dialogs for BLE/Touch ID from appearing
prior to WebAuthN UI, we hold off on dispatching request to
authenticators until user consents on using the specified transport
type. However, in current implementation, we send GetInfo command to
external BLE authenticators as soon as we discover the device. This
would trigger OS UI dialog on Mac for unpaired devices and potentially
cause BLE connection failures on other platforms. As so, move call to
GetInfo command after FidoRequestHandlerBase::AuthenticatorAdded().

Bug: 847985
Change-Id: I37b7cd8118c3edb799fa29c36700febbb2b3d08e
Reviewed-on: https://chromium-review.googlesource.com/1182946Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585130}

In order to get the list of Android apps from Play, we need to retrieve
and send the device config (such as touchscreen type, screen density,
etc.). This info is required by the Play server to filter apps. This
operation is usually done by the Play Store client. But since ARC is not
provisioned at the recommend-apps screen, Chrome must send this info.

device_configuration.proto is used to encode the device config info. The
message content is identical to the one on Play side.

This CL also moves the network request into a separate class.

Bug: 835029
Change-Id: I2796fe9411bc92aea49bfdde58f674e0e5539980
Reviewed-on: https://chromium-review.googlesource.com/1107100
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585129}

An earlier patch (http://crrev.com/582337) regressed this.

Bug: 873883

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie5fe1149ac1da2df7c1a59864339f5b5982527ff
Reviewed-on: https://chromium-review.googlesource.com/1183596
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585128}

Bug: 871478
Change-Id: I781bc9c7a13f6b90812d986f6cb56d2eefa20abd
Reviewed-on: https://chromium-review.googlesource.com/1183626Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585127}

There is some places that temporary string constants are used when
server side strings are not ready. Replace these places with server
strings now.

Bug: b/78190629
Test: Manual Test
Change-Id: I94c7816f1039c7f2dec994317029f69a2acd2866
Reviewed-on: https://chromium-review.googlesource.com/1184309Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585126}

The interfaces for committing were not kept in sync. The work-in-progress
interface NavigationClient was lacking the added callbacks.
This is corrected in this patch.

Bug: 789577
Change-Id: Ic803d8265e9b8544f1f1027df5d4f5b5991838cf
Reviewed-on: https://chromium-review.googlesource.com/1181051
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585125}

Overview
========

Flash has its own CORS-like mechanism (crossdomain.xml-based) and
therefore CORB (Cross-Origin Read Blocking) cannot be enforced for
requests initiated by Flash.

This CL avoids making an exception for plugins, unless the given
renderer process is actually hosting a Flash plugin (and is therefore
capable of proxying network requests on behalf of Flash).  This
means that the exception won't take place unless the user has
approved running Flash (via click-to-play / content settings /
enterprise policy - see the bug for more details).


Details
=======

This CL introduces a global set that stores process IDs of renderers
that host Flash.  This set lives either in the NetworkService process or
(if NetworkService feature is disabled) in the IO thread of the browser
process.  In both cases the global set is implemented and exposed by new
static methods of network::CrossOriginReadBlocking class.

The CL populates the global set from
PluginServiceImpl::FindOrStartPpapiPluginProcess after all the security
checks have been done and the plugin process is ready to be used or
launched.

The CL consults the global set before deciding to make a CORB exception
for a plugin request.  This is done from network::URLLoader (used if
NetworkService feature is enabled) and from
CrossSiteDocumentResourceHandler (used otherwise).

The CL removes items from the global set when RenderProcessHostImpl is
destroyed.


Bug: 874515
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I50484807c921a4daea08be8a00c67a3cf9c82cf0
Reviewed-on: https://chromium-review.googlesource.com/1178885
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585124}

Buffering state changes should only be dropped when two
seek operations are queued, as we dont want the state change
from the first to be misinterpreted as the second one finishing.

This manifested itself as a severe issue with HLS playback
(especially on android phones) where track switches were causing
the buffering updates used to signal startup to be dropped.

Bug: 873837
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3930bb446f69a2c166419aedd0b5a97d3200ce49
Reviewed-on: https://chromium-review.googlesource.com/1183893Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585123}

As following spec[1], the [SecureContext] extended attribute appears on an interface,
partial interface, interface mixin and so on but not dictionary.
So, it should be deleted.

[1] : https://heycam.github.io/webidl/#SecureContext

Bug: None
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I752e0c53ad1848b58278d4def47b034e450a88eb
Reviewed-on: https://chromium-review.googlesource.com/1180630Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585122}

Bug: 757605
Change-Id: I0fa269386a04ca91e58dfdfb47c7a047de8b0754
Reviewed-on: https://chromium-review.googlesource.com/1184331Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585121}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ie73f2b6256c39cc5b9df211af257f4537d985da6
Reviewed-on: https://chromium-review.googlesource.com/1126201Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585120}

It is being added by
https://skia-review.googlesource.com/c/skia/+/136062

Bug: skia:6839
Bug: skia:8052
Change-Id: I552a0e94f04cc29b27450792494e9f0160fb5b3a
Reviewed-on: https://chromium-review.googlesource.com/1183382Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585119}

The Runnable and BiFunction overrides are either only used in
tests or can easily replace the "() ->" syntax with "x ->".
This simplifies the Observers class considerably while not
adding much inconvenience anywhere else, modulo the need to use
Both.adapt(), which is now documented in reactive_java.md.

Also fixed the generics of the remaining methods and made sure
the tests would actually catch type errors correctly.

Bug: None
Test: cast_base_junit_tests, cast_shell_junit_tests
Change-Id: I99095c07615e57cb7265e57a3ca0c196c1424d6b
Reviewed-on: https://chromium-review.googlesource.com/1182795Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585118}

To reland 1164647 which was reverted in 1179701 where one test
fails on MacOS 10.13. After manual testing on MacOS 10.13, it
consistently logs |kDialogClosed| rather than the expected
|kCancelDialogsCalled|. It never appears as flaky since for
all builds between 4738 and 4746
(https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29?limit=200),
where the reverted change was in place, the test
"browser_tests on (none) GPU" never succeeded.

Thus, we need to relax the check in this test for MacOS to cover
the behavior difference for different versions.


Bug: 872795
Change-Id: Ie2c5ccd4881f5c8bbbf37bd7aae4be4fc5591c59
Reviewed-on: https://chromium-review.googlesource.com/1181245
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585117}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Iaeae7928bc4d14d92db53526373d8e9931ac106a
Reviewed-on: https://chromium-review.googlesource.com/1126177
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585116}

Change-Id: Idc9d5300360eb9b7061ff1bc68532d7083cf6b2b
Reviewed-on: https://chromium-review.googlesource.com/1184905Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585115}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/171ca366..0c05bf73

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I824cb6250377a854a9467df6d27b5daf632a85c2
Reviewed-on: https://chromium-review.googlesource.com/1184964Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585114}

Android Location and Search Geolocation preferences are removed from the
persistent storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ia23460d35650fd7631dfcad2b42b54fcd3305856
Reviewed-on: https://chromium-review.googlesource.com/1176809Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585113}

Bug: 740715
Change-Id: I96168d9078151e0bd64cda1b987ad3b546ce4570
Reviewed-on: https://chromium-review.googlesource.com/1181161Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585112}

R=bauerb@chromium.org, proberge@chromium.org

Bug: gab's memory is dwindling and proberge is better suited for this :)
Change-Id: Iade9b7416f0e0c20bfcf826255c9ea034af86b2b
Reviewed-on: https://chromium-review.googlesource.com/1184978Reviewed-by: proberge <proberge@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585111}

This reverts commit 1501aabf.

Reason for revert: Various compiles are failing on targets not being changed in those ranges

Each with a similar compiler error: No matching compiler(clang++ 4.2.1[clang version 7.0.0 (trunk 338452)]

Example failure: https://www.google.com/url?sa=j&url=https%3A%2F%2Fci.chromium.org%2Fp%2Fchromium%2Fbuilders%2Fluci.chromium.ci%2FLinux%2520Builder%2520%2528dbg%2529%252832%2529%2F86901&uct=1516637227&usg=pKzrEj68lML-ZPjHPTSWUKP4wTA.

Original change's description:
> Clang: stop building with GCC/libstdc++ from Ubuntu Precise (roll 338452-1:338452-2)
> 
> Previously we used a GCC/libstdc++ package from Ubuntu Precise to build a Clang
> that would work on Precise or later. These days, all bots and developers are on
> Trusty or later, so this should no longer be necessary.
> 
> Bug: none
> Change-Id: I518ee55d07c04dc89163fe262c81d935e05fed78
> Reviewed-on: https://chromium-review.googlesource.com/1183915
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585067}

TBR=thakis@chromium.org,hans@chromium.org,thomasanderson@chromium.org

Change-Id: I9a21a41db52458d77b949842e11b13dbec02368c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1185104Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585110}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539

Change-Id: I6915b08846dd50f587dded3544b990334615d4bc
Reviewed-on: https://chromium-review.googlesource.com/1111597Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585109}

Timezone preferences are removed from the persistent storage list for
incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ia6839002befb019f46617fc373c77b9600c069f1
Reviewed-on: https://chromium-review.googlesource.com/1180219Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585108}