- 29 Oct, 2019 40 commits
-
-
Tommy Steimel authored
This reverts commit 75651994. Reason for revert: Suspected cause of ios compile failures: https://ci.chromium.org/p/chromium/builders/ci/ios-device/139770 Original change's description: > Introduce DataDecoder API > > This provides a new DataDecoder API in the data_decoder client library, > allowing for clients to use the service for isolated and batched > operations without any dependency on the Service Manager or the > cumbersome usage of batch IDs. > > Only JSON parsing facilities are added to DataDecoder in this CL. > > The JsonSanitizer API is cleaned up a bit too, as is some test code. > > Bug: 977637 > Change-Id: I5798982a500a403ddb345ab40db35d466dc6b7fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879792 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710438} TBR=avi@chromium.org,rockot@google.com,blundell@chromium.org,sorin@chromium.org,rsesek@chromium.org Change-Id: I6c7d890c5ce7abea1d80b26a85c867e72bab32d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888739Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#710451}
-
Austin Eng authored
This reverts commit 32cfad60. Reason for revert: Suspect causing deqp/functional/gles3/framebufferblit/conversion_29.html and deqp/functional/gles3/framebufferblit/conversion_33.html to fail webgl2_conformance_gl_passthrough_tests Original change's description: > Merge WEBGL_multi_draw_instanced into WEBGL_multi_draw > > The WebGL working group decided there is enough WebGL 1 support for > instancing that it would be simpler to only expose the instanced > version of the extension. > > This also rolls WebGL 2701c13..69e333c which includes the spec and > conformance test changes. > > Bug: chromium:890539 > Change-Id: Ib4dccf56f488cedf8161268ac3467d27c9b371c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881712 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710310} TBR=dcheng@chromium.org,kbr@chromium.org,enga@chromium.org Change-Id: If3d20cc176ecc1404ba4acbdfff481a4ae9adbb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:890539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888184Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#710450}
-
Michael Lippautz authored
- Allow TraceWrapperV8Reference in HeapVector (previously, the test would not compile) - Fix usage of TraceWrapperV8Reference in ephemerons Change-Id: I1430307a5c8692a7fa38fd4857be391c2a243a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886857 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#710449}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d50a9c98..c165bf48 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iea14f847bad5df0d1ef21300da287398fe3107ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887371Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710448}
-
Megan Jablonski authored
Additionally, fix the width of the language dropdown. https://drive.google.com/file/d/1xaTNVnz2RvUnleI4w_06tgMTdC2AY52v/view?usp=sharing https://drive.google.com/file/d/1wCPdx1dWUsiU5LVz8M4tLssGgBxSdQX9/view?usp=sharing Bug: 1017490 Change-Id: I780ccbcdbeae91edd8ba5e3643ffcec6107c4262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877658Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#710447}
-
evliu authored
Bug: 997813 Change-Id: Iaaa4aa2527d9a0f8e76cef84e17b0f1273f045ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884365 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710446}
-
David Grogan authored
Bug: 845235 Change-Id: I12097a71dbebd03effe45883cf354597d380dd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881982Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710445}
-
Henrique Nakashima authored
This call happens rarely (1/60000), but it causes a crash when it does. Change-Id: I0d584f0cd4017252ab80fc23fe0a41124bd13c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880705Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710444}
-
Yi Gu authored
Some tests relied on time equality which could be flaky because internally the time value is converted to base::TimeTicks. Bug: 1014810 Change-Id: I9530f087c1273907af653f0d81f75569572d2e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886293Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710443}
-
Ken MacKay authored
Change-Id: I72e4845177d9c7c41b3c2ebd04c00ef34807976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887832Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#710442}
-
Christian Dullweber authored
To simplify the UI, we remove the omnibox icon when third-party cookie blocking is on but no cookies have been blocked. This is similar to how the old cookies blocked icon worked. Bug: 1019131 Change-Id: Id755ddcd10976d22cbcc67de18725382ab9eee78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886862 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710441}
-
Nasko Oskov authored
Unfortunately, the WebUIReuseInSubframe test is running into issues with the memory allocator returning separate instances of WebUI objects at the exact same memory address. This means that even though we have different instances of the object, which is what the test aims to assert it isn't possible to use pointer inequality as the assertion. I've modified the test to use the RenderFrameHost global routing id since one cannot have the same WebUI instance be owned by more than one RenderFrameHost instance. Bug: 713313, 1002276 Change-Id: Iea036b5cd10962c75f86a5b25d9f655012caf686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886292Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#710440}
-
dpapad authored
CL produced with ESLint --fix and clang-format. This is in preparation for turning on no-var and prefer-const ESLint checks for that folder. Bug: 720034 Change-Id: I6467d1308118f67f076708612247852568fba2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885652 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710439}
-
Ken Rockot authored
This provides a new DataDecoder API in the data_decoder client library, allowing for clients to use the service for isolated and batched operations without any dependency on the Service Manager or the cumbersome usage of batch IDs. Only JSON parsing facilities are added to DataDecoder in this CL. The JsonSanitizer API is cleaned up a bit too, as is some test code. Bug: 977637 Change-Id: I5798982a500a403ddb345ab40db35d466dc6b7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879792Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710438}
-
Alex Gough authored
This copies policy rule opcodes when snapshotting policies, and serializes them for display in chrome://sandbox's raw view. Example rule: "NtQueryAttributesFile": [ "!(p[1] & 1) && !(prefix(p[0], '\\??\\')) -> askBroker", "!(p[1] & 1) && scan(p[0], '~') -> askBroker", "prefix_i(p[0], '\\??\\pipe\\chrome.') -> askBroker", "prefix_i(p[0], '\\??\\C:\\src\\chromium\\src\\out\\release-x86\\') && ends_i(p[0], '.pdb') -> askBroker" ], Bug: 997273 Change-Id: I54f82b0a9523fa1ed94cecf982f2b25203ae7351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872304 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710437}
-
Clark DuVall authored
the backing string was getting destroyed too early. base: :FeatureList::SplitFeatureListString takes in a StringPiece, and Change-Id: Id054a40451031bc41cbae3d4caa95f25568d0011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887830Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710436}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/918853e6112f..0e87f1419824 git log 918853e6112f..0e87f1419824 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 bsheedy@chromium.org Revert "Deduplicate desktop/CrOS minidump code" 2019-10-29 khokhlov@google.com [Telemetry] Update intermediate file format Created with: gclient setdep -r src/third_party/catapult@0e87f1419824 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:994274,chromium:1018248 Change-Id: I5381b039fd4c3cbfe35c44ae135eff41752f4b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710435}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 79-3904.41-1571046112-benchmark-79.0.3940.0-r1 to 80-3931.2-1572259441-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I64047232b0703769b3335b1d3fabe6a473a58f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887682Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 79-3928.0-1571049528-benchmark-79.0.3940.0-r1 to 80-3940.0-1572255699-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ie14ea4e9aab90f13b61794582e02eff9c6fd90fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887680Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 79-3931.2-1571054549-benchmark-79.0.3940.0-r1 to 80-3940.0-1572260209-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I2dee2448a6264d052e677b11c0b0730b9068903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887681Reviewed-by:
-
David Van Cleve authored
This change extends the DNS host cache to store responses to ESNI queries: - adds a new member of type EsniContent and corresponding accessor - adds serialization and deserialization routines R=ericorth Test: expands HostCache's merging and serialization tests Bug: 1003494 Change-Id: I4977d4f12b2253e5895c36e0a86429f6074d9cbd Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865611Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#710431}
-
Asanka Herath authored
There already existed http_auth_handler_ntlm_{portable,win}.cc. And yet there was platform specific code in http_auth_handler_ntlm.cc along with lots of preprocessor directives. This CL cleans out the rest of http_auth_handler_ntlm.cc so that that file only contains cross platform code. No changes in behavior. This CL just moves code around. R: mmenke@chromium.org Bug: 927182 Change-Id: I25e20a658ad4fa46e1e9929f992bad2dcbb6dd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881323 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710430}
-
Juan Antonio Navarro Perez authored
Tweak URLs to match their latest form as used by LUCI builders. Also rename "buildbot_url" to the more generic "builder_url", as buildbot is not related to these any more. Bug: 958739 Change-Id: Ie8a8889b78b36962c19698d776fafb6f5c1b18db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886673 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#710429}
-
Daniel Rubery authored
Add a few metrics to the BinaryFCMService just to detect that it behaves generally as expected when launched. Bug: 1018226 Change-Id: I8ff23455fadbe1808d1bb1dbf3cb8c97c39dd9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880704 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#710428}
-
Xiaohan Wang authored
This reverts commit c1176485 and relands commit 15cb261d with fix. Original change's description: > media: Add ENABLE_CDM_PROXY BUILDFLAG > > CdmProxy is still under development and will not be enabled on all > platforms. Hence, this CL adds a new buildflag so it's not enabled by > default. > Tbr: nasko@chromium.org > Bug: 785563 Tbr: xhwang@chromium.org,nasko@chromium.org,jrummell@chromium.org Bug: 785563 Change-Id: I940da6c83f987cd5027708b7d9ce7b1edc0c6970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885512 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710427}
-
Reilly Grant authored
These Javascript resources have Closure type annotations but they have never been checked. This change enables the type checking step and fixes the errors that it found. Bug: 1001198 Change-Id: Icf6d8cef1fb5e7b11a4a80e77ad664f4cbc1dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879469 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#710426}
-
Yura Yaroshevich authored
The comment above assert did not match behavior of assert. This comment has been fixed and an explanatory assertion message was added. Bug: None Change-Id: If9ac26c578ac45fb9e6dd50b1605ecff13bf1323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881161Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/master@{#710425}
-
Chris Mumford authored
Switching from testing::CreateFunctor to a C++ lambda is slightly easier to understand, but allows the deletion of an upcoming CL to delete gmock_mutant.h. Bug: 1007833, 806952 Change-Id: Ib210a0c92090ca330f99b695a3256c981f7f14e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887661Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#710424}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 1018887 Change-Id: I2b2693e82a1aaf15022a680dda56122b7b09a6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885013 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#710423}
-
Piotr Bialecki authored
This switches uint32 to uint64 for IDs generated for AR-related entities (plane, anchor, hit test subscription) and changes methods that generate said IDs in ArCoreImpl to CHECK prior to potential overflow & no longer return an optional type. Bug: 1013643 Change-Id: Ic87b60a56b35e74b4b3b9d000741b27bad7dd90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879671Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#710422}
-
Johannes Henkel authored
New revision: d2fc9b958e1eeb1e956f3e2208afa9923bdc9b67 To roll this I need to update some call sites; this is because the Serializable interface is changing. Upstream change / review was here: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1879870 Change-Id: I42340da97177ce635d7e2c6c245247dd32f178f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877662Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#710421}
-
Caroline Rising authored
When an animation is triggered while another is already in progress the animation was being stopped then restarted. This led to a 1 frame delay in the animation that was very noticeable when quickly scrubbing the tab strip. This change makes it so that the animation is never stopped and continues from where the interrupted animation left off. A linear animation also seems more fitting for this case since we are never reversing the animation. Bug: 1017134, 1017029 Change-Id: I945f5c180c8758cc5e14d7d45ed792bc7c11ac89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881949Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#710420}
-
Quinten Yearsley authored
Depends on first adding Metrics analyzer definition in service cfg. The Metrics analyzer recipe has been temporarily changed to only run for changes by ltina@, https://crrev.com/c/1881935, so enabling this analyzer is not expected to create comments on regular CLs. TBR=tandrii@chromium.org Bug: 1004564 Change-Id: I008e855b759f97a0e70c400ee7891c7b9fcd2926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885015 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Cr-Commit-Position: refs/heads/master@{#710419}
-
Ryan Sturm authored
- Adds support to put n high scoring links in a predicted set - Adds support to fetch predicted set in order serially - Removes rate limit of prerenders for NavigationPredictor - Finches the "n" value Bug: 1016213 Change-Id: Ieb343446ff18dd5da248022c65f58eb46a76610d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877196Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#710418}
-
chrome://signin-email-confirmationdpapad authored
Bug: 1012533 Change-Id: I9088a9885806832629b9d0b6bea887ea81309784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885223 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#710417}
-
Etienne Bergeron authored
This CL applying multiple change to fix the way ItemizeTextToRuns split a sequence of codepoints into runs with same/compatible scripts. *) Increase kMaxScripts to support codepoints with large amount of scripts. Some codepoint has much more than the previous maximum 5 scripts (see indic_fraction test u+A830, dev_danda u+0964). *) Only rely on Script extensions to find longest script interval see: http://www.unicode.org/reports/tr24/tr24-29.html (more specifically Table 7. Script_Extensions Examples) Cases where script was 'Common' and Script Extensions has a set of explicit script was not handled properly. Script Script Extensions Results Previously: Common {Hira Kana} -> {Hira Kana Common} Currently: Common {Hira Kana} -> {Hira Kana} This mistake has the consequene to put lot of codepoints from different scripts into the same bucket ('common') and there won't be a font that can renders (too) different scripts. Which is causing expensive fallback fonts lookups. "" U+30FC Scx = {Hira Kana} Script = Common Example 1. Mixed script detection for spoofing. Using the Script property alone, for example, will not detect that the U+30FC KATAKANA-HIRAGANA PROLONGED SOUND MARK (Script=Common) should not be mixed with Latin. "" *) Inherited script should only be applied to the previous codepoint. It was incorrectly intersected with the previous or the next one. [ RUN ] ItemizeTextToRunsScripts/RenderTextTestWithRunListCase.ItemizeTextToRuns/diac_lat ../../ui/gfx/render_text_unittest.cc(930): error: Expected equality of these values: param.expected Which is: "[0][1->2]" GetRunListStructureString() Which is: "[0->2]" That was causing more codepoints to be appended to long sequence of script when type was 'Common'. Bug: 1017194 Change-Id: Ia1339697a44d0d7bbac389997e9fa2878e6eac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876489Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710416}
-
Mike Wittman authored
This CL extracts the core stack copying parts of tracing::StackUnwinderAndroid into the dedicated base::StackCopierSignal class, and adapts it for direct use by the sampling profiler stack unwinding implementation. This drops some unneeded code; updates the code to run on 32-bit Android, 64-bit Android, and 64-bit Linux platforms; and converts the code to use C++ atomics. The StackUnwinderAndroid implementation will eventually be replaced wholesale by the sampling profiler implementation for Android. This CL does not attempt to reuse the extracted stack copying implementation on its own, in order to avoid introducing bugs in StackUnwinderAndroid due to the differing implementations. The reland enables the StackCopierSignalTest.CopyStackFromOtherThread test on 32-bit Android only. TBR=gab@chromium.org Bug: 988579, 1018615 Change-Id: I96704fe4843994721a0eb37896e11bea99be3fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884376 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#710415}
-
Tommy Steimel authored
This CL fixes a race where the toolbar icon could be stuck in a disabled state. The issue was that we didn't "unbind" the MediaNotificationItem if we were already frozen and bound, causing the MediaNotificationItem to get out of sync with the MediaToolbarButtonController. Bug: 1015903 Change-Id: I67df3365ecedf019f8edb621b660c9cc97a3bf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886294Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#710414}
-
Benoît Lizé authored
This adds an error message to ProcessInitException, and in the process converts the error class to @IntDef. Bug: 979638 Change-Id: I1b1c531b0fdb212b70a977e7c84bde3043a00aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876329 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710413}
-
Nico Weber authored
This is a late follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1287850 -- since GetChannelName() now depends on GetChannel() being called previously, call it instead of relying on something else having called it. Probably a no-op in practice, but it makes the code more reliable and look less surprising. Bug: none Change-Id: Ie4e2c791db52f590d44d906fb5b0a42f521d427e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887270 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#710412}
-
