GitLab

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77397c4f2930..9a49d4b5de90

2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com
Change-Id: I2b48099041c2e08aa8c72383d9acd09ed0fcfe6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435149Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811380}

Cache.addAll() must wait for the all requests to succeed before starting
to store the results in CacheStorage.  Previously this was done by
waiting for all the Response objects to become available and only then
would it begin loading the bodies into blobs.  This does not work with
throttling since throttling requires bodies to be loaded in order to
make progress.

The main change in this CL is to refactor things so we now immediately
load the body to a blob when a Response becomes available.  We then wait
for all Responses and their bodies before proceeding to store the
result.  This should not use too much memory since loading a Response to
a blob streams data to the BlobRegistry, which may then subsequently
stream to disk if necessary.

One notable change here is that code cache generation now requires
loading the body into an ArrayBuffer from a blob.  Previously we loaded
the response to the ArrayBuffer and then converted that into a blob.
This will be slightly slower for putting scripts in CacheStorage, but
that should be fine since generally we do not optimize for write
performance.

Other changes in this CL:

* Adds a cache.addAll() test for the throttled service worker case.
* Adds `cache:no-store` to the existing throttled service worker test
  since that more easily triggers true throttling behavior.  This in
  turn also required draining the response bodies in the test.
* Refactored cache add(), addAll(), and put() to all go through the
  same set of objects where appropriate.
* FetchHandler is used in add/addAll to wait for each individual fetch()
  to complete.
* ResponseBodyLoader is used in add/addAll/put to take a Response and
  load its body as a blob.
* BarrierCallbackForPutResponse waits for a list of Response and blob
  objects to become available before calling PutImpl().
* BarrierCallbackForPutComplete waits for any code cache generation and
  the final cache operation to complete.

Bug: 1035448
Change-Id: I8c9b6b5831cfd21bd266e526a138de4cbf03171f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404267
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811379}

Roll Chrome Mac PGO profile from chrome-mac-master-1601294375-805284c073a4c807365387c8b737f70c270f4966.profdata to chrome-mac-master-1601315959-5577f3dbf01608bf6e215c63714e131a2bd389f7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I5f5f34b19437a9c69086fb651f916fc77d1f5ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436231
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811378}

EndTest() only really exit tests when there are no pending main
frames. This might be cause of flaky timeout failure. This CL
changes to redraw only the needed frames so that EndTest() would
not be blocked.

Bug: 1127563
Change-Id: I28943ddf1bd247b1ec2cdebc98fb28d77b2f2543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426971
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811377}

Bug: angleproject:2634
Change-Id: I1a9adc2cb13e3377dbdd2eaca9d5bd877358b063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435328Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811376}

This CL ensures that buffers that require a horizontal flip transform
are not promoted to overlays. The reason why this is needed is that
support for this transform is dependent on the buffer layout (e.g., on
some devices, linear buffers with a horizontal flip transform cannot be
scanned out). Unfortunately, page flip testing does not currently use
real buffers, so we could end up promoting a buffer to an overlay plane
incorrectly.

Horizontally flipped linear buffers are used in the camera capture app.
They can also be used by web pages that use getUserMedia() plus CSS.

Bug: b:161758029, b:168899960
Test: launch the camera capture app on JSL
Change-Id: I24df6c8e0820ce391e5699de3cb906f348df9ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434911
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811375}

TBR: sky@chromium.org
Bug: none
Change-Id: Iea3da6ecd4ee4c982ec9ffd11e8433d2c8a706dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436910Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811374}

This patch ships the following @font-face descriptors with M87:
- ascent-override
- descent-override
- line-gap-override

Bug: 1098355
Change-Id: I5ecb8761ccdd4a6c35eef3b8326266bc756dadc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432949Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811373}

Bug: 1130650
Change-Id: Icb7c11466a7b7fced2831584572c3433c50d7ccc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435108
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811372}

Using wpt-import in Chromium 07fb2be4.
With Chromium commits locally applied on WPT:
74e4b2fc "[COOP] access reporting: Use infinite timeout for receive."
6bdcd688 "[COOP] access reporting: split property.https.html test."
f4c4d71a "Only reset trailing_collapsible_space_ structure if it has value"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: Iff06af3aab658d5df2cfdd94b330e1285ef0bc1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435583Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811371}

Bug: 1126920
Change-Id: Ia8357864f15f29266432423c87351c1899725451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429518Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#811370}

BUG=1066670
R=sky

Change-Id: I5ae49205600b870897481f8fadd99f8143c45bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430328
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811369}

Also make ChromeTranslateClient return const& instead of &.

Non-const refs are forbidden by the style guide.

Bug: none
Change-Id: I8e49bc7bb3dacb83b124ff0a12e302805c2387ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404360
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811368}

Currently with the InteractiveWindowCycleList flag enabled, if a user
taps on an item it will activate that window and exit the window cycle
list. It's unclear to users that this selection is being made.

To address this, this CL makes it so taps move the focus ring to the
tapped item rather than activating the tapped item.

Test: manual + modified existing test
Bug: 1067327
Change-Id: Ic35972a931d2ddf5c2afa6bb02743a25e0e9ecf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432725Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811367}

OS settings are being migrated from Polymer 2 to Polymer 3, so load time
performance metrics are still valuable. Extend both load time metrics
to June 2021.

Bug: 1121211
Change-Id: I9b7b59f52edd8bb580f662a33470475e605349bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436294
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811366}

static_cast is better suited for downcasting since it can check that the
types are related.

/content/browser/renderer_host/render_widget_host_view_aura_browsertest.cc
This CL was uploaded by git cl split.

R=sadrul@chromium.org

Change-Id: If9ab935e6aa1dbd305c21edc4826e734c3084b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435883
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811365}

Change the name of the icon list from `icons` to `sources`. This makes
gn format alphabetize the list.

Bug: 1132894
Change-Id: I8dfe07d74fa2ddfd32ef8bec8729923e999a640e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427135
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811364}

This reverts commit 8a7b843c.

Reason for revert: might be causing webview test failures, see https://crbug.com/1132987

Original change's description:
> android: create cache dir if needed.
>
> When using a subdirectory of the Android cache dir (e.g. in WebView),
> explicitly create the directory in PathUtils instead of relying on any
> user of the directory creating it implicitly.
>
> Set the directory mode to 02700 which is what it currently gets set to
> when created implicitly.
>
> Fixed: 963640
> Change-Id: I8e1c140241d6a2decfcd27186b767ef05e7a4320
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432447
> Reviewed-by: Anna Malova <amalova@chromium.org>
> Commit-Queue: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811257}

TBR=torne@chromium.org,amalova@chromium.org

Change-Id: I29edd006d25c1189449c9368b50324d7be33f71a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436889Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811363}

This reverts commit f4423821.

Reason for revert: Blocking the revert of a CL that blocks chrome-uprev. See issue 1132766.

BUG=1132766

Original change's description:
> exo: Send keysym on zwp_test_input_v1_send_keysym.
>
> According to the document, the zwp_test_input_v1_send_keysym's argument
> named |code| should be XKB keysym.
> Currently, XKB keycode is sent, so fixed to the collect one.
>
> BUG=1123705
> TEST=Ran locally. Made sure expected keysym is sent to client.
>
> Change-Id: I9db31cf84b21a7c9a400d75bcbec2fbfe69a2ad4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432165
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810912}

TBR=mukai@chromium.org,hidehiko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1123705
Change-Id: I7852ff3d577044e82cd2f8fb5c859f1947b1b3fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436509Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811362}

After we finish the scroll unification, the scrolls happens mainly on
the compositor thread, and the scroll code in the main thread will be
removed. eventSender sends the scroll events to main thread, so it
would not work after the scroll unification. We rewrite below tests
fast/scroll-behavior/main-frame-interrupted-scroll.html,
fast/scroll-behavior/overflow-interrupted-scroll.html and
fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests
because we cannot guarantee that the scroll arrives before the animation
completes.

Bug: 1047176
Change-Id: I79275eb7f2a78fd52e0c1ac93c4ee7d95d27b22f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250663
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811361}

Nothing's using it, and it never really worked, since cloning file
handles open for async reading on Windows and passing them between
processes doesn't really work.

Bug: None
Change-Id: Ied440e696ddad1fb78ea9e2a06c59f9121c83aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434625Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811360}

Fragments that are there just to contain overflowing children, must have
no size, and also paint no border.

Bug: 829028
Change-Id: I0942679e8278128b6c6c485e5ca449bef65e3e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421463Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811359}

static_cast is better suited for downcasting since it can check that the
types are related.

/content/renderer/render_widget_fullscreen_pepper.cc
This CL was uploaded by git cl split.

R=jonross@chromium.org

Change-Id: I74f67a038605cf52ea40fa8eaec6047a8b1e4b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434631
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811358}

static_cast is better suited for downcasting since it can check that the
types are related.

/content/browser/renderer_host
This CL was uploaded by git cl split.

R=sadrul@chromium.org

Change-Id: I69d9a771d2470aeab73853b6f2468a9c5c507645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435882
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811357}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I08cb627cece4a78e4cabbb170acafcc5343bfb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436087Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811356}

This CL fixes a bug in
ExtensionPlatformKeysService::SignTask::OnCanUseKeyForSigningKnown where
a return statement is missing. That led to calling
ExtensionPlatformKeysService::SignTask::OnCanUseKeyForSigningKnown::DoStep
after the task is finished and deleted.

Bug: 1132926
Change-Id: I0e5be5b4a90e54e045c33e0bfa3568c0737f9272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435197Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Omar Morsi <omorsi@google.com>
Commit-Queue: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#811355}

This reverts commit eb59216d.

Reason for revert: After evaluation, staying with green is decided.
BUG=b:167556640

Original change's description:
> [Bluetooth] Change Bluetooth subtext to gray
>
> As per recommendation in Comment #30 of crbug.com/1114876.
>
> BUG=b:167556640
>
> Change-Id: I57bc4ff360d05d1d6a0b03f58d4f24e23492b858
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410746
> Reviewed-by: Tim Song <tengs@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#808073}

TBR=xiyuan@chromium.org,tengs@chromium.org,sonnysasaka@chromium.org,hansberry@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:167556640
Change-Id: I6dd86bf9e10c8c06bb2fec96561da7715d14ccee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430105Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811354}

Instead of manually setting each scan setting in the StartScanRequest of
LorgnetteManagerClient::StartScan(), set them all at once using the
given ScanSettings proto. This will eliminate the need to manually set
additional settings that get added to the proto in the future.

Bug: None
Change-Id: I05f734c630beed8e9cfb9a7a5359c9441d5f0502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432310Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811353}

The IronA11Announcer approach does not work when a modal dialog is
showing. A large number of cr-input instances reside within modal
dialogs, and errors do not get announced to screen reader users.

By using role="alert" the error gets announced, even when the
cr-input resides in a modal dialog.

Moreover, VoiceOver seems to not announce the same error
text, even if the cr-input transitions from invalid->valid->invalid.
A workaround has been employed to always removing role="alert" when
the error is fixed and re-adding it when the error re-occurs which
forces VoiceOver to always announce it.

Bug: 1130778
Change-Id: I646e25814f4719fb1a39d206e0c970a8bb75aae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429943
Commit-Queue: dpapad <dpapad@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811352}

Roll Chrome Linux PGO profile from chrome-linux-master-1601294375-f18d3a3ac9a6313011d7149de4bf7e7984859ae2.profdata to chrome-linux-master-1601315959-4ec2d6a153e04750c200a2fe71bb63fd4f2d802c.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: I44d803cae53206a60d7f475480c12d79001b5c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436094Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811351}

static_cast is better suited for downcasting since it can check that the
types are related.

/content/browser/media
This CL was uploaded by git cl split.

R=sandersd@chromium.org

Change-Id: I324ae893245bbd253e68e9e2d7b31fe0c62ccb87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434909
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811350}

This CL is the first part of an effort to port the existing Desktop
feature to Android. This feature enables a user to send an image to
Google to process to generate a descriptive alt text if a website
does not provide one.

Design Doc: go/2020-q1-android-image-descriptions
Slide Deck: go/clank-imageDescriptions
Launch Bug: 1057168

Original Desktop Design Doc for reference:
go/chrome-a11y-annotations-design

This is a conservative approach, we use a separate set of profile
Prefs for this feature rather than syncing with the Desktop Prefs.
This can be updated in time as needed. We have also hidden the
entire feature behind a feature flag, so this CL is not visible
to an average user.

----------

This CL adds the following:

- Prefs, ContentFeatureFlag, and ChromePreferenceKeys
- More Options menu item
- User facing dialog
- Associated strings etc for above

----------

AX-Relnotes: N/A
Bug: 1057169
Change-Id: I61b0d21bfc665b194e5d181df3df8b7cbb9bbac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278304
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811349}

Limit the size of the pinned files container to make sure
it's always 8px below the top of the screen.

Bug: 1131268
Change-Id: I0533873d0039f1d1952e396724cebae10fc50200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427542
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#811348}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: If031db85723d9f2301446cfc3a351f1119dcf3bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431488
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#811347}

MouseWheelEventQueueTest uses a non-existent #define for ChromeOS,
defined(CHROME_OS), we should replace it with defined(OS_CHROMEOS).

Bug: 1121653
Change-Id: Ia6ee5adf638aad3d25d03f36d0903c509d793ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433304Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811346}

In 6f15f17c the audio focus
was inadvertently being adjusted the Activity, Fragment, and
Service, but we just want the Activity.

Bug: internal b/169078948
Test: verify audio works for Cast and Bluetooth content

Change-Id: Ia0e8991f82d2b44618307b67b9541f953d53f659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431409Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Mike Dodd <mdodd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811345}

Error:
  File "build/lacros/test_runner.py", line 129, in _remove_unused_ash_chrome_versions
    age = time.time() - os.path.getatime(os.path.join(p, 'chrome'))
  File "/usr/local/google/home/svenzheng/.vpython-root/000cad/lib/python2.7/genericpath.py", line 67, in getatime
    return os.stat(filename).st_atime
OSError: [Errno 2] No such file or directory: 'build/lacros/prebuilt_ash_chrome/for_bots/chrome'

Bug: 1131739
Change-Id: I78dbaa624956a4e9019598eae3c07270907792bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429590Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811344}

The AudioDecoder tests are no longer broken on Android, and can be
re-enabled.

See:

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868055132639161312/+/steps/cast_unittests_on_Android_device_Nexus_5__with_patch_/0/stdout

Bug: 831999
Change-Id: I1d7cbd3adbd1734adc04bd5f0fb6c713815986e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433664Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811343}

This is phase 4 on the design document [1].

[1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/

BUG=787252
R=guidou@chromium.org, haraken@chromium.org

Change-Id: If7d88ea6be23d46dd78a9c9bbdc564762ae86a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435922Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#811342}

Add this metric to help us understand usage and plan
improvements.

Add ClipboardHistory.ContextMenu.NumberOfItemsShown.
This metric will help UX see if we should increase the
size of multipaste, or whether 5 is enough. It will also
function as a heartbeat metric for the feature.

Add UserJourneyTime to understand usage.

Bug: 1099338
Change-Id: If3253db5da7ba22554a806d8903929de3e81f17a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425005
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811341}