GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223315 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a bug wherein a non-fatal crash report would prevent subsequent (fatal or non-fatal) crash reports in the same browser process from being counted in the histograms.

It has been further expanded to define separate histograms for crashing, non-crashing and total-number-of attenoted crash reports.

R= cpu, jar, rvargas, grt
BUG= 290196

Review URL: https://chromiumcodereview.appspot.com/23453032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223314 0039d316-1c4b-4281-b951-d872f2087c98

The previous approach did not work, not sure why. Here we take the more
standard approach.

It fails with Aura enabled, but it is the only one to do so and only on XP.

BUG=292299
TBR=mpcomplete

Review URL: https://codereview.chromium.org/23503054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223313 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223312 0039d316-1c4b-4281-b951-d872f2087c98

1731: ninja: Add .a files in a deterministic order to link lines.

BUG=280718
TBR=scottmg

Review URL: https://codereview.chromium.org/23965005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223311 0039d316-1c4b-4281-b951-d872f2087c98

We switched to Aura on Windows and its bigger, the chrome.dll size. By about 1.6 megs.

Not sure what I am doing, the command was

python update_perf_expectations.py -f xp-release/sizes/chrome.dll/chrome.dll --reva 223293 --revb 223296

Where 223293 was the revision were it got larger.


BUG=none
TEST=none
TBR=maurel

Review URL: https://codereview.chromium.org/23547014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/23498031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223309 0039d316-1c4b-4281-b951-d872f2087c98

This makes the keyboard button actually hide the keyboard. Note that we achieve this by exposing the hide keyboard functionality as an extension API. This is stubbed in for WebUI but is not yet implemented.

Note that this leaves a known issue where tapping a text field, hiding a keyboard, and retapping that already-focused text field does not deploy the keyboard a second time (you'd have to unfocus the text field first).


BUG=236925

Review URL: https://chromiumcodereview.appspot.com/20526005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223308 0039d316-1c4b-4281-b951-d872f2087c98

Merge Allocate+Start, Stop+DeAllocate. 

Move the non-IO thread parts of VideoCaptureController, which were 
precisely the VideoCaptureDevice::EventHandler implementation, into a 
new class VCC::VideoCaptureDeviceClient, which retains only a WeakPtr 
to the VCC. 

Change the contract between VideoCaptureDevice and its client so that 
(1) The Start+Allocate, and Stop+DeAllocate phases of VCD are merged, 
and (2) the VCD owns its EventHandler*; which is to say, the VCD owns 
the VideoCaptureDeviceClient. 

The merging of the phases is justified because it will eliminate 
intermediate states from the 6+ implementations of the 
VideoCaptureDevices. 

The new VCD::EH ownership model is justified because it will enable 
some of the impls (MFWin, desktop capture, and tab capture, at least) 
to eliminate locks protecting the EventHandler* from being 
synchronously removed at the DeAllocate() step. 

Rather than make deep changes to each VCD implementation with this 
change, the interface changes to VideoCaptureDevice are effected 
through a new shim class, VideoCaptureDevice1, which bridges the old 
and new interfaces. Follow-on changes will eliminate this shim class, 
one VideoCaptureDevice implementation at a time. 

BUG=285562, 285569
TEST=unittests,basic webcam interaction

Review URL: https://chromiumcodereview.appspot.com/24133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223307 0039d316-1c4b-4281-b951-d872f2087c98

For Android renderer processes, base::i18n::SetICUDefaultLocale was not
called. So base::i18n::IsRTL() returned incorrect value which made
offline error html page's text direction incorrect. Therefore, call
base::i18n::SetICUDefaultLocale on renderer process initialization.

BUG=288371

Review URL: https://chromiumcodereview.appspot.com/24127003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223306 0039d316-1c4b-4281-b951-d872f2087c98

This CL plumbs pointers from the inner/outer-viewport layers and page scale
layer into CC from Blink. At present this has no effect on CC unless
--enable-pinch-virtual-viewport is specified on the command line.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23922006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223305 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23629032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=290041

Review URL: https://chromiumcodereview.appspot.com/23625013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223303 0039d316-1c4b-4281-b951-d872f2087c98

It fails with Aura enabled, but it is the only one to do so.

BUG=292299
TBR=mpcomplete

Review URL: https://codereview.chromium.org/24165002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223302 0039d316-1c4b-4281-b951-d872f2087c98

Becomes flaky in Aura windows

browser\ui\views\find_bar_host_interactive_uitest.cc(222): error: Value of: GetFindBarText()
  Actual: L""
Expected: ASCIIToUTF16("a")
Which is: L"a"


BUG=292299
TEST=none
TBR=sky

Review URL: https://codereview.chromium.org/24129007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223301 0039d316-1c4b-4281-b951-d872f2087c98

Check that the renderer can't launch a denial of service attack on the browser

Check that the content settings apply to the main frame URL

BUG=289528,289525
R=bauerb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23600041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223300 0039d316-1c4b-4281-b951-d872f2087c98

As earlier refactorings made possible, this moves the remaining functions
from BookmarkModelTestUtils class into bookmark_test_helpers.h file.

BUG=None
TEST=unit_tests
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23570009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223299 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the semantic of the |url| field of the
requestFocusNodeHref method for compatility reasons, keeping consistent
with the behavior of the old WebView.

BUG=290905

Review URL: https://chromiumcodereview.appspot.com/23454036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223298 0039d316-1c4b-4281-b951-d872f2087c98

The timeouts should be fixed now the number of window.open calls have been reduced (https://chromiumcodereview.appspot.com/19014003/).  Leaving win and mac disabled as they have extra issues which will be fixed separately.

BUG=245594

Review URL: https://chromiumcodereview.appspot.com/23449037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223297 0039d316-1c4b-4281-b951-d872f2087c98

Because r223293 flaked on Win X64

BUG=none
TEST=none
TBR=scottmg

Review URL: https://codereview.chromium.org/23494051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223296 0039d316-1c4b-4281-b951-d872f2087c98

Because we've been shipping Aura to canary for a while. And because force compositor landed 40 hours ago and things seem ok. See https://codereview.chromium.org/23874016/

This also allows to see perf numbers for Aura. 

This has happened before see for example r204698, r211007 and 214056 as an experiment but this time it might stick.

BUG=259185
TEST=none
TBR=scottmg

Review URL: https://codereview.chromium.org/24164002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223293 0039d316-1c4b-4281-b951-d872f2087c98

Udated the manifest files for the Quickoffice component extension
to set the version number to 31.89.1319.0

BUG=286230

Change-Id: If84e3c6c4fbd4165ae513cc9f79a32b1f437e50c

Review URL: https://chromiumcodereview.appspot.com/23702041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223290 0039d316-1c4b-4281-b951-d872f2087c98

I also made GFX_EXPORT real, which is ok since it's the same as
UI_EXPORT. It'll only matter when we separate out at gyp level.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/23531053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223289 0039d316-1c4b-4281-b951-d872f2087c98

Media.RTCVideoDecoderInitDecodeStatus: the results of InitDecode
Media.RTCVideoDecoderError: errors reported from VDA

BUG=170345
TEST=Run apprtc.appspot.com on Chromebook Daisy.

Review URL: https://chromiumcodereview.appspot.com/23967010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223288 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to worry about not visible since process mode still
works.

There is no need to worry about processing calling invoke on the next
ViewRenderer because OnDetachFromWindow also processes pending GL
commands by necessity.

Losing global context will be handled in src/content since that's where
the global offscreen contexts live.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223287 0039d316-1c4b-4281-b951-d872f2087c98

TCPClientSocket becomes a wrapper around TCPSocket to expose a client-only interface.

The corresponding change for POSIX will be in a separate CL.

BUG=262601
TEST=new tests in tcp_socket_unittest.cc

Review URL: https://chromiumcodereview.appspot.com/23881002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=146940

Review URL: https://chromiumcodereview.appspot.com/23876021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223285 0039d316-1c4b-4281-b951-d872f2087c98

This changeset removes the chromium side of notifying when an accelerated layer is created
due to an element having mix-blend-mode set from CSS. This change is required before actually
remove this in Blink.


BUG=285153

Review URL: https://chromiumcodereview.appspot.com/23530026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223284 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure that when a tap becomes a long press, we keep
SHOW_PRESSED_STATE until either it becomes a LONG_TAP (finger is lifted),
or SCROLL, or window focus is lost (a context menu has been opened). At
which point we will send SHOW_PRESS_CANCEL.

BUG=285712

Review URL: https://chromiumcodereview.appspot.com/23444068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223283 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24672,76112
TEST=None, no functional change.
R=finnur@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23531044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223279 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223275 0039d316-1c4b-4281-b951-d872f2087c98

TBR=noamsml

Review URL: https://chromiumcodereview.appspot.com/23707040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223273 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None, no functional change.
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23658056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223272 0039d316-1c4b-4281-b951-d872f2087c98

Code is duplicated from //chrome.

BUG=291745
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23609051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223271 0039d316-1c4b-4281-b951-d872f2087c98

TBR=justinlin

Review URL: https://codereview.chromium.org/23460044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243150

Review URL: https://chromiumcodereview.appspot.com/17298002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223269 0039d316-1c4b-4281-b951-d872f2087c98

This fixes win-aura build after r223265.

BUG=291141
TBR=erg@chromium.org

Review URL: https://codereview.chromium.org/23513058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223268 0039d316-1c4b-4281-b951-d872f2087c98

Need to use it outside the package

BUG=
R=joth@chromium.org

Review URL: https://codereview.chromium.org/23724029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223267 0039d316-1c4b-4281-b951-d872f2087c98

This is a pre-requisite for crbug.com/291747 / crrev.com/23526048 as
with that get request will have query param appended even when the
target is data:
Also the test states it is doing a POST so this actually makes it so.

Landing as its own patch as trybots don't like my attempts to send CRLF
edits in patches.

NOTRY=true
BUG=291747
R=kristianm@chromium.org

Review URL: https://codereview.chromium.org/23513057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223266 0039d316-1c4b-4281-b951-d872f2087c98