- 21 Mar, 2018 40 commits
-
-
Guido Urdaneta authored
This fixes the issue for audio devices which always report the same echoCancellation capabilities without permission checks. Bug: 823826 Change-Id: I2ac336760a843d1ff11f25a1a40fe22a57f356a2 Reviewed-on: https://chromium-review.googlesource.com/971482 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#544667}
-
Thomas Tangl authored
This CL changes the activation of HoverButton to on mouse released instead of on mouse pressed, which was inherited from MenuButton. Also, unlike MenuButton, HoverButton should not be pressed on key up or down. This CL fixes this. Bug: 822147 Change-Id: Ia336a3f0e6b6f4f618c9cb2e6f4009d2fa0a826b Reviewed-on: https://chromium-review.googlesource.com/966286 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#544666}
-
Colin Blundell authored
The chrome.identity.onSigninChanged extension API event is defined as follows: "Fired when signin state changes for an account on the user's profile." (https://developer.chrome.com/apps/identity#event-onSignInChanged) The current browser-side implementation uses gaia::AccountTracker, which ignores events for secondary accounts if there is no primary account (i.e., syncing account) present. Thus, this browser-side implementation also fires events for secondary accounts only if there is a primary account present. However: (1) This behavior is not defined in the documented semantics above (2) In practice, this case has historically never been encountered by end users, as it has been impossible in desktop Chrome to have a secondary account without a primary account present. In this CL, we are removing browsertests that enforce this undocumented behavior (note that we ourselves added these browsertests merely to document the existing implementation's behavior before refactoring it). By removing the requirement that the implementation behave in a specific way in this case, we will ease the upcoming refactoring significantly. Note that post-project DICE, it will be possible for this case to be encountered by end users. In that world, it will actually be more sensible for events to fire for secondary accounts regardless of whether or not the user has designated a syncing account. This behavior is what will occur post the refactoring that will follow this CL. Bug: 729542 Change-Id: I02c1ffbcbfd732ba17056e939eb6f86ab3b26576 Reviewed-on: https://chromium-review.googlesource.com/966035Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#544665}
-
Alexander Potapenko authored
This reverts commit 8ce1863f. Reason for revert: speculative revert to fix CrOS MSan build, see crbug.com/824097. Original change's description: > Turn on native notifications by default for Chrome OS. > > They're already on by default for Mash. This makes Chrome use the mojo > ("native") interface for notifications even in non-Mash. > > Bug: 578868 > Change-Id: If1ee85e2136dc0480ccee9a57835b0ffb9b47b8b > Reviewed-on: https://chromium-review.googlesource.com/963518 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544395} TBR=stevenjb@chromium.org,estade@chromium.org Change-Id: I044bbe505034ccb6da615163f6cbe74e7b164f6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 578868 Reviewed-on: https://chromium-review.googlesource.com/973006Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#544664}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 13dc6be4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14289 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: Iea8f46da2b76d93b7e80c620609b52cd4b786242 Reviewed-on: https://chromium-review.googlesource.com/972863 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544663}
-
Hans Wennborg authored
modetest is a new target added in #544442, but it was missing the dependency on //build/config:exe_and_shlib_deps, causing link failures in e.g. ASan builds. TBR=dnicoara,spang Bug: none Change-Id: I6f66333f89a0d5d828c417d7d4b9dc9c1b5e364a Reviewed-on: https://chromium-review.googlesource.com/972046Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544662}
-
jdoerrie authored
This change clarifies the wording around the password saving and autofill toggles. Bug: 822465 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I91b31fe61cd0754239f7908e8c04c7e69b72f670 Reviewed-on: https://chromium-review.googlesource.com/970541 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544661}
-
Olivier Robin authored
The previous implementation uses a temporary folder to fetch favicon then move it to the current icon folder. Should any favicon arrive out of a normal fetch operation, an empty temporary folder replace the normal one. As |favicon_provider fetchFaviconAttributesForURL:completion:| can call completion multiple times (once for the cached icon, once for the newly fetched one) , this implementation is not reliable. Change logic removing temporary folder. All icons are saved in the icon folder. When a new list is received, icons that correspond to no URL in the list are deleted. Whenever a new icon is received, it replaces the previous one. Bug: 818204 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaf51c4336e55cbc9d1d0093faa6a70d470b66a4d Reviewed-on: https://chromium-review.googlesource.com/970472 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#544660}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ddc6a12..09e7152e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2a63269af21221d14c6fc5444ff2e4ebde105d7c Reviewed-on: https://chromium-review.googlesource.com/972861Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544659}
-
Zhuoyu Qian authored
This patch makes HistogramCategories, ContentSuggestionsService::State, RemoteSuggestion::ContentType, ReceivedMessageAction and TestType to enum class instead of plain C++ enum for better type safety. Bug: 710254 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I40ff10809aa5e135b3ac9380ba54e97170eed02d Reviewed-on: https://chromium-review.googlesource.com/970049Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#544658}
-
stkhapugin@chromium.org authored
Fixes the layout of the omnibox when the input is short. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib5fa70364d805b62d10b9e5e4a4a4b519c341759 Tested: iPhone, iPad, editing and not, rotating, in multitasking. Reviewed-on: https://chromium-review.googlesource.com/971421Reviewed-by:
-
Henrik Grunell authored
Bug: 819406 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9ec4028146c3a561f847a649848c5c16dde6e2a8 Reviewed-on: https://chromium-review.googlesource.com/951684Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#544656}
-
Gauthier Ambard authored
This CL creates the items to be used by the tools menu. It also creates the actions associated with the items. Bug: 804773 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id34c8fb33daceaa34276aa4c42cf39ce0d3a5eb1 Reviewed-on: https://chromium-review.googlesource.com/970583Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#544655}
-
edchin authored
Bug: 804557 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I78bd8b762afa23c27101afba9d37da85958dd582 Reviewed-on: https://chromium-review.googlesource.com/972189Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544654}
-
Gauthier Ambard authored
This CL changes the popup menu presenter such as the popup is correctly presented relatively to its layout guide. Bug: 821856 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I426d8b5dfee8bf6fe81644cfa5d03bb7e0f58dcf Reviewed-on: https://chromium-review.googlesource.com/966028Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#544653}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f64a0522bb8..ba51bb3c1274 $ git log 6f64a0522..ba51bb3c1 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 cwallez presubmit_unittest.py: use LUCI for the optional GPU tests on Mac Created with: roll-dep src/third_party/depot_tools BUG=chromium:815092 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3ee8f121b0c000cf31929a9d09dcce47f77d7659 Reviewed-on: https://chromium-review.googlesource.com/972675 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544652}
-
https://pdfium.googlesource.com/pdfium.git/+log/da89ac4c4901..765d1ebe41de $ git log da89ac4c4..765d1ebe4 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 thestig Rename one ArgbEncode() variant to AlphaAndColorRefToArgb(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1b2639f609db817c9048c23658f27c5873266097 Reviewed-on: https://chromium-review.googlesource.com/972673 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544651}
-
Mitsuru Oshima authored
BUG=None TEST=None Change-Id: I2dbd949adb7a558fc4a854344685e4df42d2e31d Reviewed-on: https://chromium-review.googlesource.com/967060Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#544650}
-
Fergal Daly authored
Refactor to combine NeedsImplicitShadowCombinatorForMatching and the selection of which new relation type. This is done to centralize these 2 related things and also because ::part will add another case to what was previously a ternary expression. Bug: 805271 Change-Id: I2df655c57b952307f64b021b547319849e5356d2 Reviewed-on: https://chromium-review.googlesource.com/970626 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#544649}
-
Christopher Cameron authored
We will be moving RWHVCocoa into a separate process from RWHVMac. The two classes are currently very tightly coupled. Add RenderWidgetHostNSViewBridge as the RHWVMac->RWHVCocoa interface. The implementation RenderWidgetHostViewNSViewBridgeLocal is to be instantiated in the same process as the NSView (this will be the browser for now and later also the AppShim). Add RenderWidgetHostNSViewClient as the RHWVCocoa->RWHVMac interface. Put both of these classes in render_widget_host_view_mac.h for the moment, to avoid churn. The end-state is that RHWVCocoa will be an private interface, only accessed via RenderWidgetHostNSViewBridge. Remote the .get() from renderWidgetHostView_.get() in RWHVCocoa, and change cocoa_view_ to cocoa_view() in RWHVMac. R=tapted TBR=avi (content/ OWNERship) Bug: 821651 Change-Id: I5563bfb99ea2c9582798c9353fd3c5395b993ba2 Reviewed-on: https://chromium-review.googlesource.com/969975 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6792b856916a..6ea47f17c992 $ git log 6792b8569..6ea47f17c --date=short --no-merges --format='%ad %ae %s' 2018-03-20 dgarrett cros tryjob: Use correct buildbucket name in logging. 2018-03-20 gmeinke cbuildbot: change firmware key-id to firmware-key-id 2018-03-16 achuith chrome_chromeos_lkgm: Use git.py 2018-03-20 adityakali cbuildbot: stop generating update paylods for some lakitu boards Created with: roll-dep src/third_party/chromite BUG=chromium:None,chromium:814910 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I292494f54eb93125d97e10594fbcc0e1bf8302e7 Reviewed-on: https://chromium-review.googlesource.com/972670Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544647}
-
https://pdfium.googlesource.com/pdfium.git/+log/40d37b1a8077..da89ac4c4901 $ git log 40d37b1a8..da89ac4c4 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 thomasanderson Remove thin_archive config from complete static libraries Created with: roll-dep src/third_party/pdfium BUG=chromium:801925 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib4c12f7135e08e2391edfffb2a4b729265ade551 Reviewed-on: https://chromium-review.googlesource.com/972663Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c006457e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14276 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=kereliuk No-Export: true Change-Id: Ia35a76824435fcbd2a1d258ed58a0320c0d02310 Reviewed-on: https://chromium-review.googlesource.com/972662 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Alexander Alekseev authored
Bug: 787966 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0b49e527726554c1a1542dc19a6bce3b5b865ad0 Reviewed-on: https://chromium-review.googlesource.com/972642Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#544644}
-
Aleks Totic authored
I had to update bad expectations for several files. New expectations match Legacy. Bug: 728378 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I64c10c269dd38f55a707cb7a0135f9f3a1207b97 Reviewed-on: https://chromium-review.googlesource.com/971465Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#544643}
-
Andre Goddard Rosa authored
There were unused typedefs and they also don't improve legibility of the code. While at it, in the Ozone case, rename |cursors_| for |image_cursors_| that states what the map holds, similarly to how it's implemented in X11. Change-Id: Id5a58cf106a2c7dcf24e1c66e3603626bac897b7 Reviewed-on: https://chromium-review.googlesource.com/967376Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Andre Goddard Rosa <andre.rosa@lge.com> Cr-Commit-Position: refs/heads/master@{#544642}
-
Koji Ishii authored
This patch fixes lines after ::first-line to use correct styles and line metrics. NGInlineLayoutAlgorithm keeps track of the style and text metrics of the current tag in NGInlineBoxStateStack. This stack is kept alive in NGInlineBreakToken and cloned for the next line. When the previous line had ::first-line style, styles and text metrics in the stack may be different. This patch rebuilds the stack in such case. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I185bba37fc9844e131ec7a65f43347b6ee2ac7b1 Reviewed-on: https://chromium-review.googlesource.com/972221 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#544641}
-
Yuly Novikov authored
Also in roll scripts TBR=kbr@chromium.org TBR=sky@chromium.org BUG=731979 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic160cb4fab54d32647da0df364891aa670cdaa65 Reviewed-on: https://chromium-review.googlesource.com/972634Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#544640}
-
Zhongyi Shi authored
Change-Id: I08f31c0bf1414720ce72302411d1d57fd0aa512e Reviewed-on: https://chromium-review.googlesource.com/972357Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544639}
-
Chirantan Ekbote authored
Add labels for the VM events that are reported via the CrOSEvent histogram. BUG=none Signed-off-by:
Chirantan Ekbote <chirantan@chromium.org> Change-Id: I94fa2f83e0c2d7829f458340f8eb3998493fe410 Reviewed-on: https://chromium-review.googlesource.com/972549Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#544638}
-
Chris Harrelson authored
Currently, the overflow clip of these layers is not applied. This can lead to an overly large interest rect, in case when the overflow clip is significantly smaller than the clip of the root frame. This CL also makes regular box scrollers have the same behavior as composited LayoutViews. The latter receive the clip due to special logic in LayoutView::MapToVisualRectInAncestorSpaceInternal that intersects with the ViewRect. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1a585d0a69e2dbd82ecc515ea0782fea6f651d4b Reviewed-on: https://chromium-review.googlesource.com/967870 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544637}
-
Christopher Lam authored
Bug: 707014 Change-Id: I5905904fe6b752129881a45453643fef9a8ed3b4 Reviewed-on: https://chromium-review.googlesource.com/954623Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#544636}
-
Pavel Feldman authored
Change-Id: I7478de0cf171d84b7cc6f335e772650ac62799bd Reviewed-on: https://chromium-review.googlesource.com/972200Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544635}
-
Devlin Cronin authored
Manifest v1 extensions did not have any forced CSP, whereas manifest v2 extensions do. Remove the special handling for manifest v1 extensions, so that all loaded extensions are given a CSP. Update a number of tests that needed to be changed because of inline JS (pulling the script out the a separate JS file). In the case of chrome/test/data/extensions/autoupdate and chrome/test/data/extensions/install, also remove the .crx versions where they were simply packed versions of the others, and instead pack th extension in the test to make future changes easier. Leave autoupdate/v3.crx, which is (deliberately) packaged incorrectly (to test error handling). Also remove unneeded "toolstrip.html" file references from these tests. Bug: 816677 Change-Id: I3ee9930007d6674b0cdf31999fd7a1612ef3cfee Reviewed-on: https://chromium-review.googlesource.com/953175Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544634}
-
https://chromium.googlesource.com/angle/angle.git/+log/427071ea307a..b2c60b1a1950 $ git log 427071ea3..b2c60b1a1 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 ynovikov cq.cfg: equivalent_to to 100% for Android tryservers. 2018-03-01 ynovikov Rename vulkan_loader to libvulkan Created with: roll-dep src/third_party/angle BUG=chromium:731958,chromium:759301 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I0a951e66d97503d0726099273d6251dee4366bff Reviewed-on: https://chromium-review.googlesource.com/972637 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544633}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d77b019f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14275 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor TBR=kereliuk No-Export: true Change-Id: Iea0ce05ee67ac6888be51fddef68474b5f0d2656 Reviewed-on: https://chromium-review.googlesource.com/972614 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c88bd16..0ddc6a12 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I84cc80e7b62912bd423e850c1d2ccc1928cf0b8c Reviewed-on: https://chromium-review.googlesource.com/972564Reviewed-by:
-
Emil A Eklund authored
Refactor the NGInlineItemsBuilder class to make it easier to understand, maintain, and use. Removes the is_svg_text_ field which changes behavior of the append method and wasn't tested. Instead that logic is now in the append method itself. Also renames methods for consistency. No CamelCase for whitespace and newline to match other uses and the style enum value. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I40ca62c7b726720dda01bf61cc4191fba4c552a0 Reviewed-on: https://chromium-review.googlesource.com/972589 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iac4ca741dea1e3682e16696b4f3eefad4c11494f Reviewed-on: https://chromium-review.googlesource.com/972639Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#544629}
-
https://skia.googlesource.com/skia.git/+log/5c4b33bce10b..ba7b7abda177 $ git log 5c4b33bce..ba7b7abda --date=short --no-merges --format='%ad %ae %s' 2018-03-20 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b391ec408..427071ea3 (3 commits) 2018-03-20 benjaminwagner Switch to new NVIDIA drivers on Win2k8 Golo bots. Created with: roll-dep src/third_party/skia BUG=chromium:823867 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Iea377f0adbab2a8b69d060e0753e1970245572bd Reviewed-on: https://chromium-review.googlesource.com/972569 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544628}
-
