- 26 Aug, 2019 27 commits
-
-
Gyuyoung Kim authored
This CL converts implementations of media_device.mojom and related classes. Major changes are as below, - Change MediaDevicesListenerPtr with PendingRemote or Remote - Change BindingSet with ReceiverSet - Change Binding with Receiver Bug: 955171 Change-Id: I7b441d04659ace82ba10ab8b51e0d8039c467670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760835Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#690273}
-
Kenichi Ishibashi authored
This method was used legacy on-the-main-thread script fetch which was removed a while ago. Remove this leftover. Bug: 967272 Change-Id: Ia57e7ec143bf08a245bc9ae83ac5522604344081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771101Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690272}
-
Alan Cutter authored
Because AppIds are derived from start_urls we can just do an ID check instead of scanning all installed apps for the start_url. This is a refactor with no changes in behaviour. Bug: 891172 Change-Id: I9d84a8ef1edffa91a2d2ab3740db483755544e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761876 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#690271}
-
Kentaro Hara authored
This reverts commit 78d78792. Reason for revert: This broke unit_tests (CrostiniManagerRestartTest.OsReleaseSetCorrectly ) on multiple bots. https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/14819 Original change's description: > CrostiniManager stores OsRelease protos reported from containers. > > The information can change dynamically during a container session since the > user could upgrade manually. > > Bug: 930901 > Change-Id: I93fd4b227a2f93b26924c0eae0e8f005aea4e562 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765088 > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689746} TBR=timloh@chromium.org,joelhockey@chromium.org,nverne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 930901 Change-Id: Ib55e556ff909ee3c39232c86c6303c9324be375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768493Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#690270}
-
Takashi Sakamoto authored
This reverts commit 02536c57. Reason for revert: suspect Step('generate .isolate files') failure on Deterministic Linux(dbg) bot Sample build: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/10441 (The 10441 contains only #690259) Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904094727741717040/+/steps/generate_.isolate_files/0/stdout?format=raw --- /b/s/w/ir/cache/builder/src/buildtools/linux64/gn gen //out/Debug --runtime-deps-list-file=/b/s/w/ir/cache/builder/src/out/Debug/runtime_deps Done. Made 11992 targets from 2025 files in 6457ms error: gn `data` items may not list generated directories; list files in directory instead for: //out/Debug/../apprtc/out/app_engine/ //out/Debug/../apprtc/temp/google-cloud-sdk/ //out/Debug/../collider/ --- Original change's description: > mb: Make check for generated `data` directories work on Win and enable there. > > The line `os.path.normpath(self.PathJoin(build_dir, f))` had two problems > on Windows: > > 1. Since `build_dir` was something like `//out/Release`, on Windows normpath > wouldn't resolve '..' against it, so `//out/Release/../../net/data` > would become `\\out\Release\net\data` > > 2. The slash flipping for `path` made the `path.startswith(build_dir)` always > fail. > > Just remove `path` completely and check if `f` starts with '../../' to find > directories that are not in the build dir instead. > > Also mixing stderr and stdout on Windows produced strange output, so print > the error message to stdout instead. > > The Windows build doesn't have any additional violations, so no new > whitelist entries are needed. > > Bug: 912946 > Change-Id: I4db9850103751b4736e5990caddddc9dd223786d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769205 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690259} TBR=thakis@chromium.org,tikuta@chromium.org Change-Id: I4379320c19d3ce29b0a24ecd247a3a59b0a5c562 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771103Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#690269}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cee7bf091f42..edb35190808c Created with: gclient setdep -r src-internal@edb35190808c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib7366ec65617bd9b4e843b4722d6fde259456fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690268}
-
Miyoung Shin authored
This CL converts ServiceWorkerRegistrationObjectAssociated{Ptr, PtrInfo, Request} and ServiceWorkerRegistrationObjectHostAssociated{Ptr, PtrInfo} in content and blink to the new Mojo types, and uses pending_associated_remote<ServiceWorkerRegistrationObjectHost> and pending_associated_receiver<ServiceWorkerRegistrationObject> in service_worker_registration.mojom. Bug: 955171, 978694 Change-Id: Ia1c88fe08c16a722b46bf9aaa012f874d0eeb5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767287 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Fergal Daly authored
Tweak space-before-function-paren rules to be comatible with clang-format. Change-Id: I686766972996f652a8ffe15f724227279117bbb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767284 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#690266}
-
Julie Jeongeun Kim authored
This CL converts RestrictedCookieManagerRequest to new Mojo types. It also updates GetRestrictedCookieManager from network_context.mojom and methods and members which implements it. Bug: 955171, 978694 Change-Id: I8dbe736773f5446863b8b3d3d092204d66ada749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767464 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690265}
-
Julie Jeongeun Kim authored
This CL converts BlobRequest to new Mojo types. It updates Clone from blob.mojom and Register and GetBlobFromUUID from blob_registry.mojom and methods and members to implement them. It cleans up unnecessary BlobRequest declarations, as well. Bug: 955171, 978694 Change-Id: I4d2599341445a50af92e7c09245981b6939003ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757605 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690264}
-
Adam Rice authored
WebSocketStream is a new API for the WebSocket protocol that uses streams to support backpressure. See the explainer for more justification: https://github.com/ricea/websocketstream-explainer/blob/master/README.md This CL implements WebSocketStream behind the experimental-web-platform-features flag. See the design doc at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit#heading=h.7nki9mck5t64 Bug: 983030 Change-Id: I3002fd52ab151acb579e96a24985988e3fd35053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735156Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#690263}
-
Steven Bennetts authored
This also removes setNetworkProperties_ (no longer needed) from internet_detail_dialog.js, and some no longer used code from cr_onc_types.js. Bug: 853953 Change-Id: I6638351e520cf76e253b93482d985f5b97aee540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762633 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690262}
-
Wei-Yin Chen (陳威尹) authored
Bug: 987043 Change-Id: I695cc5d1b8a83b06481c6b487b43e22ad8d24109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770089 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#690261}
-
Anand Mistry authored
This reverts commit 753f8707. Reason for revert: Test failing on multiple bots. https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/46160 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/81082 Original change's description: > PDF a11y: kTextDirection attribute support > > The text direction attribute is now properly set for text runs in PDF. > It is inferred by the position of the first and the last characters of > a text run. > > This change includes a pdf-template file (text-direction.in) with RTL > text representation used to generate our unit test PDF file. > > Bug: 985604 > Change-Id: If5d82296463331e95c4ded4e5244d65be3fbadfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737019 > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#690163} TBR=thestig@chromium.org,kbabbitt@microsoft.com,benjamin.beaudry@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 985604 Change-Id: Ic276193fbc4d1d60ae234a653b1decf2094036b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768606Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#690260}
-
Nico Weber authored
The line `os.path.normpath(self.PathJoin(build_dir, f))` had two problems on Windows: 1. Since `build_dir` was something like `//out/Release`, on Windows normpath wouldn't resolve '..' against it, so `//out/Release/../../net/data` would become `\\out\Release\net\data` 2. The slash flipping for `path` made the `path.startswith(build_dir)` always fail. Just remove `path` completely and check if `f` starts with '../../' to find directories that are not in the build dir instead. Also mixing stderr and stdout on Windows produced strange output, so print the error message to stdout instead. The Windows build doesn't have any additional violations, so no new whitelist entries are needed. Bug: 912946 Change-Id: I4db9850103751b4736e5990caddddc9dd223786d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769205Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690259}
-
Leon Han authored
The java object NfcHost is for tracking the Activity for a given WebContents on behalf of NFCImpl (Impl of the NFC interface), previously it's created per-WebContentsImpl, due to navigations happening on the given WebContentsImpl it may end up in a state serving multiple NFCImpls because NFCImpl exists per-Document, which breaks the assumption that one NfcHost can only serve one client otherwise it can not work well with WindowEventObserverManager of the WebContentsImpl. This CL starts to create multiple NfcHosts for navigations on the same WebContentsImpl rather than reusing just one instance of it. BUG=520391 Change-Id: Ice15b70d5df705be0165620579586f1ff597af99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747859 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#690258}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d48c288c0553..d5163953610a git log d48c288c0553..d5163953610a --date=short --no-merges --format='%ad %ae %s' 2019-08-26 vapier@chromium.org boolparse_lib: drop unused lib 2019-08-26 vapier@chromium.org replace basestring/unicode with six string/text types 2019-08-26 vapier@chromium.org lint: fix protected-access warnings Created with: gclient setdep -r src/third_party/chromite@d5163953610a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie341081f9006456626b128d0c04d2257e0965838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770942Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690257}
-
Julie Jeongeun Kim authored
This CL converts CustomProxyConfigClientPtr and CustomProxyConfigClientRequest to new Mojo types. Bug: 955171, 978694 Change-Id: Id536279553dd930ee68ef5d1642c06d39712cf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767291Reviewed-by:
-
Miyoung Shin authored
This CL converts WebLaunchServiceAssociatedPtr in chrome and WebLaunchServiceAssociatedRequest in blink to the new Mojo types. Bug: 955171, 978694 Change-Id: Ic73752fe3f3525c631d9665cbc7cb967ce8c39ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767446Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#690255}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed485e199407..31f187e5c0d7 git log ed485e199407..31f187e5c0d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org pylint: add myself as an owner Created with: gclient setdep -r src/third_party/depot_tools@31f187e5c0d7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: Ibe685b665bc81c611c885f41f3077898e67e3262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771036Reviewed-by:
-
Sam Maier authored
Change-Id: I1aea40512deb6d258332b998f2c89cec11f779ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768937 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#690253}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92b33354ddac..27afcf5d12c0 git log 92b33354ddac..27afcf5d12c0 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@27afcf5d12c0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ie6d562732de72c3ab6ab67920293f6df06bca6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770735Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/93e8ffa4bf05..d48c288c0553 git log 93e8ffa4bf05..d48c288c0553 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org stop using exceptions module Created with: gclient setdep -r src/third_party/chromite@d48c288c0553 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1787753709ba4a5cf767cb99a95711369474f12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768359Reviewed-by:
-
Steven Bennetts authored
Bug: 853953 Change-Id: I67129d3d0c68f750b4d907f8d37c8ef052dd9324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758591 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15a8c5705ef5..cee7bf091f42 Created with: gclient setdep -r src-internal@cee7bf091f42 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I278df5cb6e38d4686bcb53ea939456c6ba32b96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770734Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b4699f36. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" d7f933bd "Revert "Started implementing the STAPIT algorithm"" d3b97055 "Update simulateUserActivation to match webxr-test-api spec" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I48ebe6703421bb0ce015e3580c0eab2f1e3a5e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770482Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690248}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4016d1b393a1..ed485e199407 git log 4016d1b393a1..ed485e199407 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org pylintrc: disable score reports Created with: gclient setdep -r src/third_party/depot_tools@ed485e199407 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:866772 Change-Id: I50f2dde35f31a1a6182d82a4eb97420636ab2d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770733Reviewed-by:
-
- 25 Aug, 2019 13 commits
-
-
Sanket Joshi authored
This reverts commit 27e98258. Reason for revert: One of the added tests is failing MSAN validation (https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN) Original change's description: > Add keyboard based navigation for visual color picker > > This change adds functionality to move the color selection ring > through the color well and hue slider via keyboard input. The user > can press the up/down/right/left arrows to move the ring in the > corresponding direction. The user can also press ctrl+[arrow key] > to perform an accelerated movement. The accelerated movement is > particularly useful for the color well as it takes time to navigate > from one end of the color well to the other with just the standard > keyboard movement. > > Bug: 994437 > Change-Id: Idfef70adf443f8576f83dc9e6c9347a0d320b768 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757159 > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690076} TBR=chrishtr@chromium.org,tkent@chromium.org,masonfreed@chromium.org,sajos@microsoft.com Change-Id: Ic44c8b15bd96270baa86b53a4750083788d1d4b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 994437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770000Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/75f7b8d20d80..93e8ffa4bf05 git log 75f7b8d20d80..93e8ffa4bf05 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org rework division handling Created with: gclient setdep -r src/third_party/chromite@93e8ffa4bf05 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I37dfaf87e650e0866ceda31b71a5afdd07c69e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770730Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf05e0b2d3f4..15a8c5705ef5 Created with: gclient setdep -r src-internal@15a8c5705ef5 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0cae8d2a704029682ed4898763553c81386f0658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770727Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4f3d482ab708f1ca29677a3c8f22f2105861bdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770729Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/765375356dc5..75f7b8d20d80 git log 765375356dc5..75f7b8d20d80 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org use six.reraise Created with: gclient setdep -r src/third_party/chromite@75f7b8d20d80 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I00f69d94b4d97742d740e397a4fe971ee781dbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770726Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/216afbb2995c..cf05e0b2d3f4 Created with: gclient setdep -r src-internal@cf05e0b2d3f4 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iabea5a1b01b0bc6a35562facd6433e1978fdfdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770886Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/3367690414ae..8e49d0a2b160 git log 3367690414ae..8e49d0a2b160 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 dneto@google.com Remove extra semi-colons (#790) Created with: gclient setdep -r src/third_party/shaderc/src@8e49d0a2b160 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I93b894c799f3ff57d259b9554d6ccb1a6175126c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770724Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62d93b5f3261..216afbb2995c Created with: gclient setdep -r src-internal@216afbb2995c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I77927980fbc02e277bac06b8b75df94e5d95a583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770723Reviewed-by:
-
Steven Bennetts authored
This CL: * Introduces <network-property-list-mojo> * Uses the mojo element and mojo properties in <network-apnlist> Follow-up CLs will use <network-property-list-mojo> more broadly. Bug: 853953 Change-Id: I25ed760ecb8bfaa88936cbf88271c6c74525f41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758490 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4cd502d0b1c9523a82f394e8a538db3c947316c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770721Reviewed-by:
-
Dominik Röttsches authored
Speculative fix for issue 980094. Ensure that the read protobuf memory has a size and is not a nullptr before trying to have the ProtoBuf library parse it. Bug: 980094 Change-Id: Idaf47884e82eff8c0850a6ec27fc8d452c10e622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768762 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690236}
-
Nico Weber authored
`data` entries that are directories are fine for directories in the source tree, but in the build tree they cause incorrect incremental builds: Consider a build step that copies a bunch of files into the build out dir. At a later revision, it copies fewer files. Incremental bots will still have the now-removed file sitting around, and due to the listed directory, the stale file will be zipped up and sent to swarming. For now, enable this check only on non-cros non-msan linux, on fuchsia, and on iOS. Add temporary whitelist entries for existing violations. (See patch set 17 for how some of them can be removed, but I'd like to land those in separate CLs.) Bug: 912946 Change-Id: Ia01d8e43f0256e3fcae39cb3e1529084d587bb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764392 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a02f9aa1faa2..62d93b5f3261 Created with: gclient setdep -r src-internal@62d93b5f3261 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If7db091fc34ba2e9dfad3f3b0d23ec520c4f83f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770784Reviewed-by:
-
