- 22 Aug, 2019 40 commits
-
-
Ali Juma authored
When a load fails while offline, and an offline version of the page is available, two loads are currently performed: a blank error page is loaded (driven by ErrorRetryStateMachine) and an offline readling list page is loaded (driven by OfflinePageTabHelper::PresentOfflinePageForOnlineUrl). These two loads race with each other. When the second load happens to while the first load is in between didStartProvisionalNavigation and didCommitNavigation, then a didFailProvisionalNavigation is triggered for the first load, and WKWebView's URL is reset to the value it had before that load (which happens to be a placeholder URL). This URL change is incorrectly interpreted as a location.replace call in webViewURLDidChange, which ultimately leads to a placeholder URL being displayed in the omnibox instead of the URL of the offlne page. This CL prevents this race by eliminating the load of the blank error page in this situation. Change-Id: I3e951ed4356b7b1e1efa2b96077f22ad74af60ce Bug: 980912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754511 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#689594}
-
Christopher Cameron authored
This most notably includes tearing out AppsPageShimHandler, which then allows us to remove much of the complexity from AppShimHostManager. This will allow cleaning up much of the complexity of the AppShimHost and ExtensionAppShimHostHandler classes (which will then allow sharing a single shim process between multiple profiles). Bug: 982024 Change-Id: If8be5323a29502cc447cd3cf4134fac6b53ec834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757370Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#689593}
-
Bettina authored
For non-syncing users, we use the SecurityEventRecorder to record an event when users use to Protect Account on receiving a Password Protection warning. https://screenshot.googleplex.com/Jc9TGRxqCkf Doesn't have any events in the screenshot because the Recorder is WIP still. Bug: 914410 Change-Id: I5a451ca9f2518362a72a858ab78d561c0c0b82df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764790Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#689592}
-
Justin Cohen authored
Bots rolled with the following script: git grep -l '11m382q' | xargs sed -i '' -e 's/11m382q/11m392q/g' This CIPD package only includes iOS 12.2 and iOS 13 to conserve disk space, so cronet (which still tests on iOS 9, 10 and 11) was not rolled to beta 6. CIPD packages: infra_internal/ios/xcode/mac 11m392q infra_internal/ios/xcode/ios 11m392q Bug: 995797 Change-Id: Ie375b0bb61989d87c3ba6cf883bf7bf32f5b6b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760286 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689591}
-
Jun Mukai authored
Currently the wayland code sends the new bounds immediately when the bounds changes, but this might happen during the display change and the display change can be delayed since multiple method calls happen in a single change. This CL also delays sending the bounds change if it happens during the display change -- the remote shell now stores the pending requests and flushes all pending ones right after the display changes are sent. Bug: b/130897153, b/134776218 Test: todo Change-Id: Id7eb2b7c1a3c16d2f105bfe6adc37fc7bb2e3ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760281 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#689590}
-
Xiaocheng Hu authored
Bug: 978682 Change-Id: I428f84d516cf5ab4df8aa754f406008c034b6e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764793Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#689589}
-
Hans Wennborg authored
Extra changes in this update: - Update the released clang version to 10.0.0. - Move -momit-leaf-frame-pointer next to -fno-omit-frame-pointer since that's where it logically belongs. clang started warning on momit without fno-omit after r365860, but it stopped doing this again in r368728 so this change is no longer needed for the roll. But it's still a nice cleanup. - A file in the profile runtime with static init was renamed, do that in the check - Disable new -Wno-implicit-float-conversion warning - Remove ifdefs for plugins using new ErrorOr API in clang - Remove -Wno-error=return-stack-address flag for ToT builds. - Replace llvm::make_unique with std::make_unique in clang plugins for LLVM r369130, remove LLVM_FORCE_HEAD_REVISION ifdefs TBR=dprake Binary-Size: crbug.com/992372, compiler update adds 32KB, seems reasonabe Bug: 983371 Change-Id: Icdcbd70adec2548a2bf8222df15560e70ce32d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763261 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#689588}
-
Malay Keshav authored
This patch adds method to WebUIDataSource class to allow overriding of worker-src. This is needed by webui that implement lottie on a web worker and initialize them using a blob url. Bug: 976057 Test: Manually tests this and dependent changes by navigating to OOBE Change-Id: I504cf603baeb4f804a60dd5916a552d63f44602e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764629Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#689587}
-
Pavel Yatsuk authored
The feature was approved for stable rollout in crbug.com/955951 R=jwd@chromium.org Change-Id: I78bb35573a5078c8126af8a37e52314d27520df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765988Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#689586}
-
Peter Kasting authored
This removes four entries from the tab context menu; changes the text on several others to stop saying "tab(s)" explicitly; adds one entry to the frame context menu; and changes the bookmark-related menu entry strings from "page" to "tab" for consistency. Most of the file changes here are due to renaming enums/APIs to match the string changes. Bug: 515930 Change-Id: I22415f21936c6162494cfbe84fea24cf29282d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761666Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#689585}
-
Nico Weber authored
Bug: 961769 Change-Id: I866e83728d107203edfeea0ce6bdebebaa128eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765869Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#689584}
-
Regan Hsu authored
Modifies update_engine_client to process an additional optional integer parameter representing the number (if it exists) of milestones until end of life. (See https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/1759285) Bug: 994999 Change-Id: I0ae17d9f8022a9897b16b8529da89eb6f3938924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758979 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#689583}
-
David Black authored
The ProactiveSuggestionsLoader is tasked with downloading proactive suggestions on behalf of Assistant's ProactiveSuggestionsClient in the browser. Note that this CL removes ProactiveSuggestionsClientObserver in favor of ProactiveSuggestionsClient::Delegate, as there is only a single entity in ash (AssistantSuggestionsController) that will need to bind to the ProactiveSuggestionsClient to respond to its events. This makes it easier to pass ownership of objects through the delegate pipeline. Bug: b:139199715 Change-Id: Ic67fda79ea15c9e822244be8aa43ccd7ada83904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758738Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#689582}
-
Tetsui Ohkubo authored
Based on the discussion in https://crrev.com/c/1743869, we decided to add autotestPrivate.swapWindowsInSplitView() instead of using automation API in Tast. Tast side CL: https://crrev.com/c/1716679 TEST=arc.SplitView BUG=135150701 Change-Id: I9e96b01daf0c8c84dc77363727dd4e38244562c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758037Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#689581}
-
Andy Paicu authored
Many users find the fact that the warning message is displayed on every startup annoying (https://support.google.com/chrome/thread/11549634?hl=en) This CL adds a 14 day cooldown period for the warning after it is dismissed. Bug: 918428 Change-Id: I358b1646c797d48e12c1b2718d3f8631483736d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761592Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689580}
-
Mohamed Amir Yosef authored
With the recent introduction of FakeServerInvalidationSender which excerises FCM-based invalidation production code, the FakeServerInvalidationService isn't needed anymore. Change-Id: I18b8eba337c27d9d3f7a5d12dd101ed5aea0c38f Bug: 985287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758242 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689579}
-
David Black authored
Previously we used the OnConversationTurnStarted API to notify us of when an interaction was starting in LibAssistant. This API did not give us any metadata about the interaction, so we couldn't match it with confidence to one of our requests. The new API exposes an ID through the |metadata| param. We can use that ID to match an interaction request with a conversation turn. Once fully wired up, this will allow us to stop pending a query before a conversation turn starts and instead only do so within our interaction lifecycle. Once lifecycle has been fixed, a number of downstream bugs will be resolved. The CL to fix lifecycle will be a follow up. This CL only exposes the interaction metadata that we will need in order to do so. Bug: 941259, 973680 Change-Id: I32edf71251272aa21dc571df40f15b8de12cefba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757425 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
Bug: 976975 Change-Id: Ia14d5475b94f4fb2579dfddfa54a544157f8e3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761235 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#689577}
-
Nikita Podguzov authored
Change-Id: I9f4ebef4d6c6038b1a305e6756e9ceb9a1c45419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764134Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#689576}
-
Jon Mann authored
Bug: 966270 Change-Id: I162d6d1d60e2c1b5f1341f41bbc89bcf09b0348f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764186Reviewed-by:
-
Brian Sheedy authored
Updates the driver version targeted by Win10 FYI x64 Exp Release (Intel HD 630) from 24.20.100.6286 (stable) to 26.20.100.6912. TBR=kbr@chromium.org Bug: 916832 Change-Id: I048e84b5aacbb0283cb84a487e75fcd5321d88f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764759Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#689574}
-
Ioana Pandele authored
This reverts commit 8ffd6f64. Reason for revert: crrev.con/c/1763677 landed right before and is using a string ID which this CL removed, so the build will fail. Original change's description: > Update strings in leak dialog > > Bug: 986317 > Change-Id: Id07d47c2f8c8db1f7d5278752cff13d0aac642f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765748 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Rafał Godlewski <rgod@google.com> > Cr-Commit-Position: refs/heads/master@{#689554} TBR=vasilii@chromium.org,rgod@google.com Change-Id: I506696251be58277fcce043f97796c9469de59d0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766128Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#689573}
-
Lei Zhang authored
Consolidate the calls to base::SysInfo::IsRunningOnChromeOS(), which is only available when OS_CHROMEOS is defined, to PDFiumTestBase. Then all tests that are derived from PDFiumTestBase can just call PDFiumTestBase::IsRunningOnChromeOS() and avoid having #ifs. Change-Id: Id6da1b6b3db648ebb0dab121e48f525fd18266ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764557Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#689572}
-
Mohamed Amir Yosef authored
Change-Id: I43de31210a0e52a39f2b0017e08994ccf1207714 Bug: 985287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745997 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Bug: b/139810037 Test: covered by unittest. also tested manually. Change-Id: I18a1f7e3d368d51823a3cd1b21e5d905fcc3d00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757686Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima (slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#689570}
-
Michael Crouse authored
This change records for each HTTPS navigation if the host has had hints fetched for it recently. The change also removes expired entries from the pref on update and limits the maximum number of hosts allowed to be added to the pref controlled by a finch parameter. Bug: 994931 Change-Id: Ia40f345a1d57994469823b5e757a4900c633ec2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762791Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#689569}
-
Daniel Rubery authored
This CL adds the implementation and tests for the BinaryUploadService, a class that encapsulates the process of uploading a file to Safe Browsing and asynchronously receiving a verdict through FCM. Bug: 980784 Change-Id: I8d527a81661c0d209f3beba9636805f27357b913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735840 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689568}
-
Wei Li authored
Changed the bubble title to the final string in spec. BUG=979530,996547 Change-Id: I79ebf03486b8d50f1e7bbb5475490b058eb0cd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765651Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689567}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/23742c0958dd..02d4c0d38ea1 git log 23742c0958dd..02d4c0d38ea1 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 chrisforbes@google.com Add support for multiview rendering Created with: gclient setdep -r src/third_party/swiftshader@02d4c0d38ea1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139862810 Change-Id: Iad975762f49fcdbffb31ffb101752befd4a13600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765652Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689566}
-
Ryan Hamilton authored
HTTP/3 SETTINGS and PRIORITY frames. Change-Id: I04f93729bdb7c82af37072e55cd4e40d567be408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764272Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#689565}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f463a2029142..9d9d76c590e9 git log f463a2029142..9d9d76c590e9 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 jiawei.shao@intel.com OpenGL: Support B2T and T2T copies with BC formats 2019-08-21 cwallez@chromium.org Update .gitignore 2019-08-21 cwallez@chromium.org OpenGL: Use non-filtering samplers for int/uint texture. Created with: gclient setdep -r src/third_party/dawn@9d9d76c590e9 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I2b4d589a2df4dd3d9b3e0707fd177c680399fa91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765650Reviewed-by:
-
Stephen Nusko authored
This mode will allow us to set up a background scenario and deliver triggers to the system when something interesting is happening. Which will allow us to only upload traces that are of interest. Bug: 979583 Change-Id: Ic48ea08e3f9fafccaf045847cc0ddfa76d11611c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760736 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#689563}
-
Lukasz Anforowicz authored
Before this CL, AddAdditionalRequestHeaders would set the Origin header to either the destination origin (for main frame navigations) or to the main frame's origin (for subframe navigations). Both of these are wrong and don't match Blink behavior (which correctly uses the initiator of the navigation to calculate the Origin header's value). Bug: 915538 Change-Id: Ied0262462f7665d0004da3b298bf0618ae312aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761051 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#689562}
-
Aaron Colwell authored
This changes SiteInstanceImpl::DoesSiteURLRequireDedicatedProcess() to return true for all WebUI schemes instead of just singling out the chrome: scheme. This ensures that these URLs get placed in dedicated processes even if site isolation is disabled. Bug: 991153,991888 Change-Id: I1af3b87ac39d93f6e45587a5b3845a176f98b7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763643 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
-
Lei Zhang authored
Otherwise, if FPDFText_CountChars() returns -1, that will get misinterpreted as a very large value. As a consequence, other unsigned integers used in the method have to be changed to match. Also change the out parameter to a signed int for consistency, and because most code in pdf/ prefer the char count to be signed. Change-Id: I080997ed0b5654348ff8d40eda9327093a65cb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764655Reviewed-by:
-
Jeffrey Kardatzke authored
One of these already expired and the other is going to soon. These are currently unused by anybody so they are being marked obsolete and will be removed from client side code in a Chrome OS CL. CL which removes them from ChromeOS: crrev.com/c/1763923 Bug: 975639 Test: None Change-Id: Id7da189f57b26ba9140a899f304f4dfb360c49f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763632 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#689559}
-
Dave Tapuska authored
Add code to support handling of frozen clients. Frozen clients do not run their event loop, so postMessage to them just causes problems. To allow service workers to continue working with frozen windows we expose includeFrozen in the matchAll and the frozen attribute on the Client. If a service worker calls focus on a client it will unfreeze the window when it is moved to have focus. This feature is currently marked as experimental and an intent to ship will be sent. This is specified in https://wicg.github.io/page-lifecycle/ and https://github.com/w3c/ServiceWorker/pull/1442 BUG=957597 Change-Id: I6abe1882e88c65dac99250db5bb7fa8d3a4b2b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677065 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#689558}
-
Nina Satragno authored
Add the `RemoveCredential` WebAuthn command to ChromeDriver. This is one in a series of patches intended to create a Testing API for WebAuthn, for use in Web Platform Tests and by external webauthn tests. For an overview of overall design, please see https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing Bug: 922572 Change-Id: I3a547e5cc63af1099327606ccf22e8f916ea34d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764634 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689557}
-
Robbie McElrath authored
Bug: 934152 Test: gn check out/Default //android_webview/gpu Change-Id: I083a3fd762b7b0c8a819db8e0dc09261cd6662fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764339Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#689556}
-
Caleb Rouleau authored
Also increase hard timeout for the same reason. TBR=jbudorick@chromium.org Bug: 996464 Change-Id: I194c1cb73fef3422a4b976419d59035943d34b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764673Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
