- 20 Nov, 2018 40 commits
-
-
Egor Pasko authored
Just a tiny utility, because writing code (to invoke the upload) is easier than to read the code (to extract the right command). Bug: 893981 Change-Id: Iff50406f554c207384ab0c4119d22d4510e59fd9 Reviewed-on: https://chromium-review.googlesource.com/c/1340267Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#609668}
-
Rob Buis authored
Be strict on request's Content-Type by only allowing whitespace before type and after subtype. Behavior matches Firefox. Bug: 902681 Change-Id: Id08c0c56076c5b4aa6e335893f663b7d91229da1 Reviewed-on: https://chromium-review.googlesource.com/c/1341508 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#609667}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I76c99d90e1c957619676a135a1c9ad736f0f1995 Reviewed-on: https://chromium-review.googlesource.com/c/1342787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609666}
-
Maxim Kolosovskiy authored
This reverts commit a8f4b170. Reason for revert: Suspect this CL caused a failure of org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testCloseButtonBehaviourWithDynamicModule https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3725 org.junit.ComparisonFailure: expected:<http[s://www.google.com/search?q=cat]> but was:<http[://127.0.0.1:37221/chrome/test/data/android/test.html]> at org.junit.Assert.assertEquals(Assert.java:115) at org.junit.Assert.assertEquals(Assert.java:144) at org.chromium.chrome.browser.customtabs.CustomTabActivityTest.testCloseButtonBehaviourWithDynamicModule(CustomTabActivityTest.java:1195) Original change's description: > Cleanup XR usage of EmbeddedTestServer > > Cleans up manual usage of EmbeddedTestServer in XR tests, which was both > adding a lot of duplicate code and had the potential to fail to clean up > the server if the test failed, which could then affect other tests. > > This is achieved by making EmbeddedTestServerRule lazy and applying it > to all ChromeActivityTestRules, not just WebappActivityTestRule. > > Bug: 901923 > Change-Id: I431dac3ce2488a1a5762a1ab1f5ec68aea16c9f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1320024 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609556} TBR=nyquist@chromium.org,pauljensen@chromium.org,bsheedy@chromium.org Change-Id: I676439292a0f90ee353dadef415437415d82bba4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901923 Reviewed-on: https://chromium-review.googlesource.com/c/1343265Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609665}
-
Peter E Conn authored
Previously Digital Asset Link verification contacted a Google Server. This had the disadvantage that verification would only work with servers that were publicly accessible. By doing the verification locally it will work with non-publicly accessible servers (such as company internal sites). Bug: 905698 Change-Id: Iaf00ae3b0d6193349310359183f3154c7f1d84f6 Reviewed-on: https://chromium-review.googlesource.com/c/1338180 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609664}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/50b8426648f3..5f0099596439 git log 50b8426648f3..5f0099596439 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 srte@webrtc.org Using unit classes in AimdRateControl. Created with: gclient setdep -r src/third_party/webrtc@5f0099596439 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I91c4ab664b89a1cb1cbd3e1fefe922fff31ec7dd Reviewed-on: https://chromium-review.googlesource.com/c/1342689Reviewed-by:
-
Yuki Shiino authored
Make IDL callback function not hold a ScriptState of its creation context when it's cross origin from the incumbent realm. Not holding a cross origin ScriptState, there is much less risk to access a cross origin context. IDL callback interface will follow the same approach in a separate patch. Bug: 892755, 886588, 904218 Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6 Reviewed-on: https://chromium-review.googlesource.com/c/1314023Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609662}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 57d5d1dc. With Chromium commits locally applied on WPT: 5ee777f6 "Fix test exclusion logic of wpt/referrer-policy test generator warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1920 and retry the command." ec589a5c "Add referrer-policy module worker tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ib3f0583c6acb94da677257449d0f94079d46668b Reviewed-on: https://chromium-review.googlesource.com/c/1343570 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609661}
-
Peter E Conn authored
Chances are the user of a TWA already has an app installed for the site they are viewing. In this case we should not show the app install banner. Bug: 906673 Change-Id: Ic09242e902cb4a76cc3deb879a1dd62b71614bf7 Reviewed-on: https://chromium-review.googlesource.com/c/1342618Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#609660}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b0c143c8eb23..101c113f649b git log b0c143c8eb23..101c113f649b --date=short --no-merges --format='%ad %ae %s' 2018-11-20 stevenperron@google.com Remove long running cfg limit test. 2018-11-20 dj2@everburning.com Add missing override to ProcessLinesPass Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@101c113f649b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8e306b6bdff9ef1f9cd05c0ef364728e3500125a Reviewed-on: https://chromium-review.googlesource.com/c/1343189Reviewed-by:
-
Mikel Astiz authored
This component contains sync-specific logic and plumbing so let's follow the setup in other components/sync_* components and list the core sync team as owners. Bug: None Change-Id: I509a41e3b4738967188680771ae8c535c02ca7ef Reviewed-on: https://chromium-review.googlesource.com/c/1343261Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609658}
-
Eric Seckler authored
Adds preferences for configuring the tracing mode and enabled tracing categories to the mobile tracing preferences. Bug: 898512 Change-Id: I23583dd24868918ce29eebce68568344b7c3c2f0 Binary-Size: feature implementation, strings will not be translated. Reviewed-on: https://chromium-review.googlesource.com/c/1340300 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#609657}
-
jdoerrie authored
This change introduces the PasswordManager.HttpCrendentials histogram superseding the currently existing PasswordManager.HttpCredentialsWith* histograms. As discussed in https://crbug.com/899949#c3, the Password Manager team has an interest in monitoring the number of HTTP credentials in the long term, which due to https://crbug.com/899949#c5 is now done in one histogram. Bug: 899949 Change-Id: I9f9a492fbc1fc55028b00f4521c5aba69cd984bd Reviewed-on: https://chromium-review.googlesource.com/c/1333309 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609656}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/21f7091b9a09..c6195df99b92 git log 21f7091b9a09..c6195df99b92 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 cjmcdonald@chromium.org cbuildbot: Add option to build config to skip BuildPackages stage 2018-11-20 zamorzaev@chromium.org Revert "Remove waterfall parameter from InsertBuild method" 2018-11-20 dburger@chromium.org Fix assertRaises call in cidb_integration_test 2018-11-20 dhanyaganesh@chromium.org gob_util.FetchUrl: Add an exponential backoff retry 2018-11-20 dburger@chromium.org Remove unused some_alerts_dispatcher 2018-11-20 saklein@chromium.org SetupBoardStage: remove update_chroot call 2018-11-20 saklein@chromium.org UpdateSDKStage: Add UpdateSDK stage to execute main update Created with: gclient setdep -r src/third_party/chromite@c6195df99b92 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3065643b4946acc8375ece55037e6113993193c0 Reviewed-on: https://chromium-review.googlesource.com/c/1342785Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit a1b9cd32. Reason for revert: Suspect this CL caused WebViewTest.InterstitialPageFocusedWidget failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/16877 [ RUN ] WebViewTest.InterstitialPageFocusedWidget [20977:51975:1119/183258.737359:WARNING:notification_platform_bridge_mac.mm(512)] AlertNotificationService: XPC connection invalidated. [20977:775:1119/183258.919345:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [20977:775:1119/183300.396209:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [20977:775:1119/183300.901427:ERROR:delegated_frame_host.cc(165)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [20977:775:1119/183301.011438:INFO:CONSOLE(15)] "embedder.loadGuest: 49781", source: chrome-extension://cdeknlbiapideljomhnngchhffjgbmfc/embedder.js (15) [20977:775:1119/183301.011622:INFO:CONSOLE(21)] "guestSrcHTTPS: https://localhost:49781/extensions/platform_apps/web_view/interstitial_teardown/https_page.html", source: chrome-extension://cdeknlbiapideljomhnngchhffjgbmfc/embedder.js (21) ../../chrome/browser/apps/guest_view/web_view_browsertest.cc:1953: Failure Expected: (interstitial_widget) != (content::GetFocusedRenderWidgetHost(guest_web_contents)), actual: 0x7fe90b092600 vs 0x7fe90b092600 Stack trace: 0 browser_tests 0x0000000103d7875b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 browser_tests 0x0000000103d78119 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 browser_tests 0x00000001026c1a62 WebViewTest_InterstitialPageFocusedWidget_Test::RunTestOnMainThread() + 466 3 browser_tests 0x00000001071d7f6b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491 4 browser_tests 0x0000000106c255c4 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4372 5 browser_tests 0x0000000106c243ed ChromeBrowserMainParts::PreMainMessageLoopRun() + 45 6 browser_tests 0x0000000104d913d2 content::BrowserMainLoop::PreMainMessageLoopRun() + 50 7 browser_tests 0x00000001051f8f07 content::StartupTaskRunner::RunAllTasksNow() + 39 8 browser_tests 0x0000000104d9000b content::BrowserMainLoop::CreateStartupTasks() + 683 9 browser_tests 0x0000000104d93615 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85 10 browser_tests 0x0000000104d8e402 content::BrowserMain(content::MainFunctionParams const&) + 178 11 browser_tests 0x00000001066ae490 content::ContentMainRunnerImpl::Run(bool) + 752 12 browser_tests 0x00000001099f5a4b service_manager::Main(service_manager::MainParams const&) + 3051 13 browser_tests 0x00000001066ad514 content::ContentMain(content::ContentMainParams const&) + 68 14 browser_tests 0x00000001071d7bbd content::BrowserTestBase::SetUp() + 2829 15 browser_tests 0x0000000106b96431 InProcessBrowserTest::SetUp() + 529 Original change's description: > Added committed ssl interstitials to testing_config > > Bug: 755632 > Change-Id: I7e156e2df3a3124a13a5b576b7d691d77dd9c08b > Reviewed-on: https://chromium-review.googlesource.com/c/1289687 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Doug Turner <dougt@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609543} TBR=nasko@chromium.org,mgiuca@chromium.org,alexmos@chromium.org,holte@chromium.org,emaxx@chromium.org,vakh@chromium.org,cthomp@chromium.org,dougt@chromium.org,carlosil@chromium.org Change-Id: I4832ced67d6d115ed43fdd155424469d1136d695 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755632 Reviewed-on: https://chromium-review.googlesource.com/c/1343084Reviewed-by:
-
Luciano Pacheco authored
Change quick view for audios and videos to allow to use tab to focus the audio and video HTML5 tag's controls, e.g.: play, slider and volume. Add a blue outline for focused elements inside audio and video HTML5 tags, as part of the accessibility to make visually clear what control is focused. Change audio to not show the download button since it's already in the file system and downloading doesn't make sense in that context. Change video to not show picture-in-picture since it doesn't work for quick-view. Bug: 627701, 801522, 848216 Change-Id: Ie46159bc90d2948bbac98d69acaf8b53e62d5e58 Reviewed-on: https://chromium-review.googlesource.com/c/1341777 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609653}
-
Yoshifumi Inoue authored
This patch implements LayoutNG version of |LayoutText:: {First,Last}CharacterAfterWhitespaceCollapsing()| with making a unit test, |CharacterAfterWhitespaceCollapsing| to run on both legacy and ng layout tree. This patch also changes legacy layout tree path of |LastCharacterAfterWhitespaceCollapsing()| to use |StringView::CodepointAt()| instead of |String::CharacterStartingAt()| to return last code point in string instead of trail part of surrogate pair. Bug: 906915 Change-Id: I364195c5b9366cf7ca890ba2738a4be37779a6bd Reviewed-on: https://chromium-review.googlesource.com/c/1341776 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609652}
-
Sergio Villar Senin authored
This is a follow up of crrev.com/c/1335567. The only missing bit pending to be migrated was some SigninManager API that is now replaced by the PrimaryAccountMutator API. Bug: 890817, 890818, 890819, 890820, 890820 Change-Id: I9c746457987038bc810163dbb69dafdba75a74f0 Reviewed-on: https://chromium-review.googlesource.com/c/1341537Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#609651}
-
Boris Sazonov authored
This CL replaces 'new Handler().post(...)' statements with 'ThreadUtils.postOnUiThread(...)'. This is safe, as all SigninManager methods are invoked on the UI thread. Bug: 906193 Change-Id: I9638a96074762b5db6e3cfb9d80ea48685b499f3 Reviewed-on: https://chromium-review.googlesource.com/c/1343257Reviewed-by:
-
Mikel Astiz authored
Recent changes (linked to the bug) are believed to have deflaked the test, so let's reenable it on all platforms. Bug: 873902 Change-Id: I9804fa4d83c3b1afb9b71356d134736b63b11298 Reviewed-on: https://chromium-review.googlesource.com/c/1343083Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609649}
-
Maxim Kolosovskiy authored
This reverts commit 8f34427c. Reason for revert: BoundedLabelTest.GetWrappedTextTest failures. Builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests First failed build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/30863 Original change's description: > Fixes to get Views versions of message_center_unittests passing on Mac. > > This enables the views version of the message_center, in preparation > for removing the Cocoa implementation. > > Fixes: > - Use an EventGenerator in tests, rather than manually synthesizing > events. > - NotificationInputContainerMD::HandleKeyEvent() now explicitly clears > the text input field when handling VKEY_RETURN, as the test expects > this. > - Disabling notifications is no longer handled in > NotificationViewMD::ButtonPressed(), since it wasn't the button > Listener for the block_all_button_ (the > NotificationControlButtonsView is). Disabling is now handled in > ToggleInlineSettings() instead. > - The SlideOut tests are disabled on Mac because the test framework > doesn't support synthesizing gesture scroll events. > > Bug: 739386 > Change-Id: Id841779233662111f52d491ba78e5315422003b4 > Reviewed-on: https://chromium-review.googlesource.com/c/1341091 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609514} TBR=stevenjb@chromium.org,estade@chromium.org,rsesek@chromium.org Change-Id: I16b0173147f81502bd0a1fa83ffb895db6420f13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 739386 Reviewed-on: https://chromium-review.googlesource.com/c/1343262Reviewed-by:
-
Alex Clarke authored
This means embedders don't need to subclass TaskQueue. To avoid confusion we rename the existing API method to CreateTaskQueueWithType. Bug: 863341 Change-Id: I962c9229acc1e14ab098d9d779d8dca4e1583fb0 Reviewed-on: https://chromium-review.googlesource.com/c/1342537 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Marc Treib authored
PersonalDataManager now supports storing addresses in the account (aka ephemeral) DB, so we don't need to just drop them anymore. We do need to make sure not to merge the Wallet addresses into the local (persisted) ones in this case. PersonalDataManager now takes care of that. Bug: 864519 Change-Id: I114d7554ba0773986ae308f5e7e7f34f4feb19b9 Reviewed-on: https://chromium-review.googlesource.com/c/1329661Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609646}
-
Maxim Kolosovskiy authored
This reverts commit 04942507. Reason for revert: FindIt pointed to this CL with 100% confidence https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/3727 Original change's description: > Update X button behaviour if dynamic module exists. > > Bug: 889916 > Change-Id: I552a8c4e7da4e3916a0e8bb5378d4f60252c4cd6 > Reviewed-on: https://chromium-review.googlesource.com/c/1329797 > Commit-Queue: Anna Malova <amalova@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609318} TBR=mvanouwerkerk@chromium.org,yusufo@chromium.org,peconn@chromium.org,amalova@chromium.org,pshmakov@chromium.org Change-Id: I8a3f1d467bbb32e03efd669e02da6bd542b7b62d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889916 Reviewed-on: https://chromium-review.googlesource.com/c/1343260Reviewed-by:
-
Hayato Ito authored
The 1st wave is here: https://crrev.com/c/1337225. This CL makes flat tree traversal faster, again, by utilizing FlatTreeNodeData::assigned_slot_ field. This field is now set at the timing of reclc slot assignement. This filed is set to nullptr if host's child is not assigned to any slot there. In FlatTreeTraversal::TraverseSiblingsForV1HostChild, we check this field to avoid hashmap lookup there. BUG=906494 Change-Id: I4d5133821de1de2e58d08c7a31a7853017fd67ba Reviewed-on: https://chromium-review.googlesource.com/c/1341744 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609644}
-
phweiss authored
If a VPN connection is set to be Always-on (via Android setting or policy), we want an off-switch in Chrome Settings in case the Android container is compromised. If the VpnConfigAllowed preference is set to false, this new switch will be disabled, and potentially the policy indicator is displayed to its right. This should line up with the same indicator next to the "(Dis)Connect" button above, and the "open subpage" indicators in the lines below. For this, the controlled-button needs to remove its right margin for the (Dis)Connect buttons. Fortunately, these two buttons are the only controlled-buttons in the codebase that do not have the end-justified attribute set, as there is only one other instance of controlled-button (in downloads_page.html, with end-justified set). BUG=b:72861260 BUG=873123 TEST=browser_tests --gtest_filter=*CrSettingsInternetDetailPageTest* Change-Id: Ifa76dc905fb0b06ddd13d1e1e2d2ab6d4c2cd018 Reviewed-on: https://chromium-review.googlesource.com/c/1340333Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Philipp Weiß <phweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#609643}
-
Benoît Lizé authored
Bug: 906042 Change-Id: Ic65a91052397be9a2b0facbb9924114edd7904a2 Reviewed-on: https://chromium-review.googlesource.com/c/1341839Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#609642}
-
Sam McNally authored
Bug: 849618 Change-Id: I768ea72228e4fb2c322eeb0e04d00075c677a826 Reviewed-on: https://chromium-review.googlesource.com/c/1343874Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609641}
-
Sergio Villar Senin authored
It can observe IdentityManager::Observer instead. This is a step forward in the migration to IdentityManager API. Most usages of SigninManager were also replaced by their equivalent IdentityManager API. It's also observing IdentityManager::DiagnosticsObserver from now on. BUG: 809539 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9e7319a522f298298ab6a1a512bad73675050e70 Reviewed-on: https://chromium-review.googlesource.com/c/1276606Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#609640}
-
Hitoshi Yoshida authored
Update IDLExtendedAttributes.md to be more consistent with current implementations. Specifically, this CL does - Make targets of applicable-to-types ext. attr. clear. - Update C++ implmentations to meet current coding style - Remove trailing commas in WebIDL. It's now disallowed. - Update few descriptions. Bug: None Change-Id: I39fb50699cd8f6bf3ed7fb74e8304c8ed476e0d3 Reviewed-on: https://chromium-review.googlesource.com/c/1343873Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Jan Lamecki authored
View suffix doesn't make sense as it is not an Android view. I'm planning to introduce view showing CastWebContents, so freeing the name before makes sense. Also added @ColorInt to document what is expected encoding of argument. Bug: None. Change-Id: Ie8079383180801a37453ed8784085472d48345ad Reviewed-on: https://chromium-review.googlesource.com/c/1333468Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Jan Lamecki <jachor@google.com> Cr-Commit-Position: refs/heads/master@{#609638}
-
Sergio Villar Senin authored
It was using both SigninManager and ProfileOAuth2TokenService fake objects injected in the profile to signin the user with a refresh token. The IdentityTestEnvironmentProfileAdaptor could be used to create the testing profile followed by IdentityTestEnvironment::MakePrimaryAccountAvailable() to perform the signin. Bug: 882864 Change-Id: I6d546a722a0eda4f3d14d6234d819a3964c7d92e Reviewed-on: https://chromium-review.googlesource.com/c/1338107Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#609637}
-
Sam McNally authored
The paper-ripple elements use up and down events to decide whether to render a ripple. Allowing these events to propagate through the eject button causes both the button and the directory tree item to ripple, instead of just the eject button. Bug: 671987 Change-Id: I3fb9f6c1c1f1694810a497f967ec73378ba0e223 Reviewed-on: https://chromium-review.googlesource.com/c/1343871Reviewed-by:
-
Corentin Wallez authored
BUG=chromium:901830 Change-Id: I8cea07cc08ca559014cf68d75f4eef65a838efb0 Reviewed-on: https://chromium-review.googlesource.com/c/1341844Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#609635}
-
Sam McNally authored
Querying the board from the files app is only used for deciding which Drive promo to display: specifically, whether the board is link, which is now AUE. This is now unnecessary so remove it. Bug: 906983 Change-Id: Ia98c9e96b81609fdacd46a4d464da18a6cbd1fdc Reviewed-on: https://chromium-review.googlesource.com/c/1343591Reviewed-by:
-
Kai Ninomiya authored
Change-Id: I96a41c6b41f9094f704bc25193b53e6582669a68 Reviewed-on: https://chromium-review.googlesource.com/c/1343188Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#609633}
-
Yuta Kitamura authored
This CL tries to fix the test flakiness in gcm_unit_tests by using the mock NetworkChangeNotifier in tests, which avoids receiving real network status changes. Bug: 906769 Change-Id: I08227a6f303328fe2f44cecc84c0ea64bd145415 Tbr: rmcelrath@chromium.org Tbr: dimich@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1343592Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#609632}
-
Ben Wells authored
This should make debugging failing default and policy installs simpler. Bug: 906911 Change-Id: Ia8e893925d6d4d6b75acb1c1e23aef816f198d8a Reviewed-on: https://chromium-review.googlesource.com/c/1343579 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609631}
-
Joel Hockey authored
Currently we only enter check select mode if 2 or more files are selected as part of select-all. This is now changed so that we always enter check select mode even if only a single file is selected. Bug: 903253 Change-Id: I15d05ea19570d7c83cfd77f20afa1370301b8b2a Reviewed-on: https://chromium-review.googlesource.com/c/1343586 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609630}
-
Christian Dullweber authored
The SiteDataDeleteHelper in WebsiteSettingsPreferences is only used to delete cookies but creates a CookiesTreeModel for various data types. Instead, we can use CookieManager directly to fetch and delete cookies. Bug: 883701 Change-Id: I08efb5d1e4d96902c9f018ca673a019f1334d2a8 Reviewed-on: https://chromium-review.googlesource.com/c/1337617Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
