- 03 Jan, 2019 40 commits
-
-
Daniel Murphy authored
This reverts commit 97ba6ddb. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable WebViewTest.Shim_testFindInMultipleWebViews on Windows > > Due to flakiness. > > TBR=ekaramad@chromium.org > > Bug: 892085 > Change-Id: I96d8a3b14583c340abba18a725941b8ae0c1cf06 > Reviewed-on: https://chromium-review.googlesource.com/c/1261700 > Commit-Queue: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596682} TBR=msramek@chromium.org,ekaramad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892085 Change-Id: I8b417d49cef605a3dd734886332ac70b1f53d8d7 Reviewed-on: https://chromium-review.googlesource.com/c/1394869Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#619763}
-
Ramya Nagarajan authored
The emoji context menu has been enabled by default on Win, Mac and CrOS since M70. This cleans up existing feature flags and test that rely on them. Bug: 827404 Change-Id: I40321c4e2ea91affeed017d875df6a870de4d494 Reviewed-on: https://chromium-review.googlesource.com/c/1393823Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#619762}
-
Kenneth Russell authored
The Vulkan driver doesn't seem properly installed on these machines. Will re-enable once it is. Bug: 918942 Change-Id: I0f3ceeead53d10ce0ffbbb1ed017dcc521172cba No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1394917Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619761}
-
John Delaney authored
This is a reland of 7c6d18ba Original change's description: > Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource > > This CL is strictly a refactor that switches the Ads PLMO to count frame > data using ResourceDataUseUpdate instead of OnLoadedResource. This will > allow us to include incomplete resources and header bytes in future > per-frame metrics. This will not change behavior of existing histograms > at all. > > Bug: 878393 > Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251 > Reviewed-on: https://chromium-review.googlesource.com/c/1372428 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619436} TBR=rsesek@chromium.org Bug: 878393 Change-Id: I9c8760497d2a5110f4bae31d633d82a405ed812a Reviewed-on: https://chromium-review.googlesource.com/c/1393530 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619760}
-
Andrew R. Whalley authored
Change-Id: Id6fed6762afce61a9860eb930fb2dc4a4349b001 Reviewed-on: https://chromium-review.googlesource.com/c/1394787Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Andrew Whalley <awhalley@google.com> Cr-Commit-Position: refs/heads/master@{#619759}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/241644a5a398..a900bacb58c3 git log 241644a5a398..a900bacb58c3 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 33432579+alan-baker@users.noreply.github.com Broader check for ids that require a type (#2259) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a900bacb58c3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7100e6bb7e09f4fed3254512eaca7c15a982309b Reviewed-on: https://chromium-review.googlesource.com/c/1394866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619758}
-
Adithya Srinivasan authored
Adds IDL files for PortalHost and window.portalHost, and has a simple layout test for window.portalHost. Bug: 914117 Change-Id: Iccaae8992e7cf2794a26e171cebffc94deca8e1d Reviewed-on: https://chromium-review.googlesource.com/c/1393438Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#619757}
-
Bailey Berro authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/44b6331b895d..825055dd8383 $ git log 44b6331b8..825055dd8 --date=short --no-merges --format='%ad %ae %s' 2018-12-26 cmtm system_api: remove support for creating arcbridge socket in session_manager 2018-12-14 jimmyxgong smbprovider: Add UpdateMountCredentialsOptionsProto 2018-12-27 itspeter system_api: add more fields for generic_storage in runtime_probe Created with: roll-dep src/third_party/cros_system_api Change-Id: I6ef9f2e47665adf5c69329d3807a8345b0fe71a6 Reviewed-on: https://chromium-review.googlesource.com/c/1394785 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#619756}
-
Max Moroz authored
Bug: 790747 Change-Id: I4bbae28a27174ce1d2e53ad356aba7726d16c228 Reviewed-on: https://chromium-review.googlesource.com/c/1394597Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#619755}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/35caab8b839f..2667a52a4bde git log 35caab8b839f..2667a52a4bde --date=short --no-merges --format='%ad %ae %s' 2019-01-03 dtu@chromium.org [dashboard] Remove deprecated bots from bot list. Created with: gclient setdep -r src/third_party/catapult@2667a52a4bde The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865016 TBR=sullivan@chromium.org Change-Id: I6f0bb6113242fe3f1351244a805f056a12469518 Reviewed-on: https://chromium-review.googlesource.com/c/1394872Reviewed-by:
-
edchin authored
A previous CL changed the snapshot API contract to return nil instead of a default white image. Due to the change, all snapshot containers should have an opaque default white background color. The previous CL missed this one snapshot container. Change-Id: I659a6511dd0b83a0e0d20e1e49e0bb752522c289 Reviewed-on: https://chromium-review.googlesource.com/c/1394708Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#619753}
-
Rohit Rao authored
BUG=911350 Change-Id: Iec791dc2bf41b10705686bf01bbadc39ccee9e9d Reviewed-on: https://chromium-review.googlesource.com/c/1394013Reviewed-by:
-
Peter Kotwicz authored
This CL removes the useless intent parameter in ExternalNavigationDelegateImpl#matchResolveInfoExceptWildCardHost(). The parameter became useless as a result of https://chromium-review.googlesource.com/c/chromium/src/+/1096554/ BUG=None Change-Id: Iaf493fa288a16a22a52d30ead5884ab2e8164f73 Reviewed-on: https://chromium-review.googlesource.com/c/1390321 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619751}
-
Jamie Madill authored
This should help prevent flaky tests from landing in the tree. Also includes a minor cleanup where the test suite keys in the entries for ANGLE tests are sorted alphabetically. Bug: angleproject:3029 Change-Id: I19420d3f716d44ded44db39b185aa947c06110f4 Reviewed-on: https://chromium-review.googlesource.com/c/1394795Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#619750}
-
Philip Rogers authored
When deciding whether an overflow clip paint property node is needed, we previously checked if the visual overflow extended beyond the overflow clip rect. This would miss cases when the visual overflow was empty (e.g., descendants with width: 0) but the content was still scrollable. This patch adds a check for layout overflow. While in the area, the condition for visual overflow has been refactored to make the self-painting PaintLayer case a little clearer. The early-out for PaintLayer descendants is required for correctness. Bug: 918675 Change-Id: I41fe5fd71a957f196b5b8095965d4e361e535196 Reviewed-on: https://chromium-review.googlesource.com/c/1393885Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619749}
-
Leonard Grey authored
One might ask: why do even have this lever? I agree, so I filed https://crbug.com/918911 Bug: 918194 Change-Id: I0ea816a50d840e71bc6f8c5684877c8353cb0c11 Reviewed-on: https://chromium-review.googlesource.com/c/1394734Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619748}
-
Becca Hughes authored
This is a reland of 858e896d Original change's description: > [Audio Focus] Restrict browser group to CrOS > > Restrict browser audio focus grouping to Chrome OS. > > BUG=915501 > > Change-Id: I702952cca7a388e78c201531866307797d25b277 > Reviewed-on: https://chromium-review.googlesource.com/c/1379918 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617800} Bug: 915501 Change-Id: Ideb9814a6d4ff7e9faedc66efa6d2073adec818d Reviewed-on: https://chromium-review.googlesource.com/c/1386107Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#619747}
-
Tommy Steimel authored
The test is also failing on Retina builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20(retina)/8631 Bug: 917970 Change-Id: I3de376948ec19cfc4a83c58dd28b5bde04fd3f95 Reviewed-on: https://chromium-review.googlesource.com/c/1394868 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#619746}
-
Brandon Jones authored
Updated to the newer types described by the latest WebXR Device API spec updates. Bug: 915050 Change-Id: I14f07f922ff2eee046664bd9a6ecf1cf4e954312 Reviewed-on: https://chromium-review.googlesource.com/c/1377711 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619745}
-
Mathieu Perreault authored
Bug: None Change-Id: I2770684d47147b0a267214b1c5e55eea1438907f Reviewed-on: https://chromium-review.googlesource.com/c/1394391Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#619744}
-
Piotr Bialecki authored
This flag will be set appropriately depending on the context for which the manifest is generated (bundle vs APK). This CL maintains current behavior. Change-Id: I543e09d07e2bea4769e2d4a71663b10b140c01c6 Reviewed-on: https://chromium-review.googlesource.com/c/1394864 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#619743}
-
Chromium WPT Sync authored
Using wpt-import in Chromium eaf82f71. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ide9e164909bb1a695b32f8650351d574591478c8 Reviewed-on: https://chromium-review.googlesource.com/c/1394399Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619742}
-
Doug Turner authored
Bug: 897312 Change-Id: I3f156092b1d5687fce06ef05b2f6cf4db1d9ba32 Reviewed-on: https://chromium-review.googlesource.com/c/1388809 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619741}
-
Sergey Ulanov authored
Previously PlatformExit() was called before WebContents is destroyed. On Fuchsia PlatformExit destroys the Screen sigleton, but WebContents was trying to use it while destroying the window. With this change WebContents is destroyed before the Screen. Bug: 778467 Change-Id: I3200e9339771b001c9b8b4fe0e311b1ef42d8d01 Reviewed-on: https://chromium-review.googlesource.com/c/1389026Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#619740}
-
Marcin Wiacek authored
This is part of changes which put as goal removing redundant ChromeAnimation API by moving everything into CompositorAnimator. Public doc with proposal: https://docs.google.com/document/d/1VL5ntE7vn267IFjE4Zke0GkhVVTHz1bEP672Apj_E2k/edit This concrete patch is migrating StackLayoutBase. BUG=890643 Change-Id: I66668b9373c54fc9573de8d797990b6e291f2b54 Reviewed-on: https://chromium-review.googlesource.com/c/1376851Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#619739}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c63ddb2a3f9a..3f2b9aad4a05 git log c63ddb2a3f9a..3f2b9aad4a05 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 srte@webrtc.org Moves logged event structs to separate header. 2019-01-03 yinwa@webrtc.org Bugfix: Activate pushback on every sent packet. 2019-01-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 86bff8b8..adf0af4d (619523:619625) 2019-01-03 hta@webrtc.org Add an observer API for DTLSTransport events. 2019-01-03 minyue@webrtc.org Use ordered data structure for supported frame lengths in ANA. 2019-01-03 nisse@webrtc.org Convert peerconnection_client to use VcmCapturer 2019-01-03 nisse@webrtc.org Update unityplugin to use VcmCapturer. 2019-01-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d189a954..86bff8b8 (619409:619523) Created with: gclient setdep -r src/third_party/webrtc@3f2b9aad4a05 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:907849,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9eb6c6869d7c551064e241d794ecd60715e660b0 Reviewed-on: https://chromium-review.googlesource.com/c/1394686Reviewed-by:
-
Becca Hughes authored
Notifies the mojo observer from content::MediaSessionImpl when the supported actions change. BUG=892771 Change-Id: Iea1edf130b415d44ab9f32f7b6506d53f4558280 Reviewed-on: https://chromium-review.googlesource.com/c/1379917Reviewed-by:
-
Peter Kasting authored
Bug: 331924, 603562, 626761, 837219 Change-Id: If2695993d98dc00168c367c3c171b99a96eb7bc5 Reviewed-on: https://chromium-review.googlesource.com/c/1351809 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#619736}
-
Danyao Wang authored
Change-Id: I8f2cfb66099a3bf8bd03f3407ed763067a465f01 Reviewed-on: https://chromium-review.googlesource.com/c/1394883 Commit-Queue: Danyao Wang <danyao@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619735}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idb57ebf1ea2981b717cb9712ad86dda8c7ed0c3b Reviewed-on: https://chromium-review.googlesource.com/c/1394797Reviewed-by:
-
Xianzhu Wang authored
This is a reland of crrev.com/618316 which was reverted in crrev.com/619326 because of performance regression. This patch changed the condition in PrePaintTreeWalk::WalkTree() from if (root_frame_view.GetLayoutView()->Layer()->NeedsRepaint()) to if (needs_invalidate_chrome_client_). needs_invalidate_chrome_client_ is set by PaintInvalidator. The problem of previous code was that NeedsRepaint() is always true if the document doesn't update lifecycle to paint which is the case for the subdocument of SVGImage, causing infinite invalidation of the chrome client. Original change's description: > Revert "[CompositeAfterPaint] Invalidate chrome client when needed" > > This reverts commit 29021ede. > > Reason for revert: Suspect performance regression > > Bug: 918276 > > Original change's description: > > [CompositeAfterPaint] Invalidate chrome client when needed > > > > For pre-CompositeAfterPaint, we call InvalidateChromeClient() > > when an object is invalidated in a view referenced from a plugin or > > an svg-image. > > > > Now let the path also work for CompositeAfterPaint. > > > > This fixes several web plugin tests for CompositeAfterPaint. > > > > Bug: 524134 > > Change-Id: Ia4c3ccba4632ddcdfdfdfec299fb7a68440a1419 > > Reviewed-on: https://chromium-review.googlesource.com/c/1385112 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#618316} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 524134 > Change-Id: I9b4f67a74732919ba23acc00fd501d45baa498e6 > Reviewed-on: https://chromium-review.googlesource.com/c/1392439 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619326} Bug: 918276, 524134 Change-Id: Ifad1c2eb8bdddcceea26a286c3309665f6d94c1a Reviewed-on: https://chromium-review.googlesource.com/c/1393558Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#619733}
-
Lindsay Pasricha authored
Creating 2 prototype tests using EG2 with the smoke_egtest suite. The plan for migrating to EG2 is outlined at go/chrome-eg2-migration. - Added the earl_grey2:all_tests as a build target - Added the ios/chrome/test/earl_grey2 directory with BUILD and gni files - Added the prototype smoke_test suite with 2 test cases - Added the chrome_earl_grey_edo .h/mm files for the EDO helpers - Tweaked and reorganized ios/third_party/earl_grey2/ BUILD and gni files. Bug: 906201 Change-Id: I6521af6403ac9e4b320cba25f390be88522a0678 Reviewed-on: https://chromium-review.googlesource.com/c/1352532 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Raul Tambre authored
Bug: 766891 Change-Id: Ib8cf38fb63d9494f21462ab55ce361775b107322 Reviewed-on: https://chromium-review.googlesource.com/c/1390003Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eb333167..b4e2270d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I218b75e19cb3322712e550ee9a9f13d96b545637 Reviewed-on: https://chromium-review.googlesource.com/c/1394789Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619730}
-
liberato@chromium.org authored
This CL adds SupportedVideoDecoderConfig to match the mojom struct. It also adds a struct traits for them, and converts the existing mojo code to use the media:: rather than the mojom:: version. This will make it easier for {D3D11, MediaCodec}VideoDecoder to return their media::SupportedVideoDecoderConfigs, since they cannot use mojo directly. Bug: 918029 Change-Id: Id0403ccadaa1b3fbbb310f01fd9b3a7bebc92ba7 Reviewed-on: https://chromium-review.googlesource.com/c/1392350 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#619729}
-
Tim Zheng authored
To set a Crostini app scaled is to set the property in the Crostini app registry so that when the app launches it'll use low display density. BUG=chromium:839242 TEST=unit test included in this CL Change-Id: I1428a49cce918930f8b5d4083fbc9ba208e8b101 Reviewed-on: https://chromium-review.googlesource.com/c/1393547 Commit-Queue: Tim Zheng <timzheng@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#619728}
-
Manu Cornet authored
Shelf items used to be aligned directly after the launcher button, so it made sense to include everything within bounds where tooltips should not hide to avoid hiccups. However, now that we show centered shelf items, this means that a tooltip can be shown all over a possibly quite large amount of white space between the launcher button and the first shelf item. 1) It is very strange to show a tooltip over such a potentially large piece of shelf. 2) On the other hand, when it does happen that the first shelf item is close to the launcher button, not showing a tooltip in the space between them does mean a slight stutter when hovering from one to the next. The drawbacks of 1) clearly outweigh the ones of 2), so this change hides tooltips between the launcher button and the first shelf item. Bug: 896524 Change-Id: I06e666ba0296881f87c2cf3ce5972b38d638c3f7 Reviewed-on: https://chromium-review.googlesource.com/c/1393889 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#619727}
-
Tomasz Wiszkowski authored
Overlooked in crrev/c/1393888 Bug: 918877, 918335 Change-Id: I4c4f0274eefd0b23d449390699f673e061653b48 Reviewed-on: https://chromium-review.googlesource.com/c/1394784 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619726}
-
Tommy Steimel authored
Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7897 Bug: 918905 Change-Id: I3ab6874fb5380d8f369e03f3d0837edff8eacbeb Reviewed-on: https://chromium-review.googlesource.com/c/1394799Reviewed-by:
-
Elly Fong-Jones authored
The existing code used FocusedBorderColor, which happened to be equal to ProminentButtonColor on non-Mac and close enough on Mac that nobody noticed the disparity. Mojave changed the color that underlies FocusedBorderColor, which made checkboxes start drawing very faintly. Bug: 918673 Change-Id: If73a4607bb5857e4b61d67cfd7e9f58ebd341021 Reviewed-on: https://chromium-review.googlesource.com/c/1394434Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#619724}
-
