- 09 Sep, 2019 40 commits
-
-
Ben Pastene authored
This reverts commit bd916257. Reason for revert: mac_chromium_compile_dbg_ng is purple: https://ci.chromium.org/p/chromium/builders/try/mac_chromium_compile_dbg_ng?limit=200 Original change's description: > Switch mac_chromium_compile_db_ng to builderless > > Bug: 999206 > Change-Id: I91c01200552c4170ac6d18badd5bdd113396526d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792461 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Auto-Submit: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694874} TBR=martiniss@chromium.org,jbudorick@chromium.org Change-Id: I4a3f86fdb97b98adc7752082e3330f0c2870d6e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793263Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#694898}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac68e9c3dd09..afc6ed3cdbc7 git log ac68e9c3dd09..afc6ed3cdbc7 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 treehugger-gerrit@google.com Merge "Refactor record controllers and fix extension" Created with: gclient setdep -r src/third_party/perfetto@afc6ed3cdbc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6e1f8c53c4bfca415fd1bd8c6dfb49710047b724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694897}
-
Daniel Clark authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1772228. The initial commit was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1789295. It was reverted because the tests it changed were failing in Win7; it turns out that there is a UIA platform difference where the Win7 platform doesn't query for the LocalizedLandmarkType, causing the tests to fail as they now expect that value to be dumped. This reland is is identical to the initial change with the addition of separate test expectation files for Win7 where the LocalizedLandmarkType is omitted. Original change description follows: Change the LocalizedLandmarkType and LocalizedControlType for the contentinfo aria role from "content info" to "content information" per https://www.w3.org/TR/core-aam-1.1/#role-map-contentinfo. Also update the LocalizedLandmarkType for <footer> when scoped to the body element to "content information", since it inherits this from the contentinfo role per https://w3c.github.io/html-aam/#el-footer. Note that this doesn't affect <footer>'s LocalizedControlType, which should be "footer" (but is currently still "content info"). That is handled in the separate change at https://chromium-review.googlesource.com/c/chromium/src/+/1763243. TBRing reviewers: aleventhal@: Please review content/browser/accessibility/browser_accessibility.cc rockot@: Please review changes to content/app/strings/content_strings.grd TBR=aleventhal@chromium.org,rockot@google.com Bug: 997897 Change-Id: I30af47d7a3cc2f41653177b365cde003cb56caaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793283Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#694896}
-
Joshua Pawlicki authored
Bug: 1001973 Change-Id: Ib123d0f68d0557a07de10eb57a29604db8c8d38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793405Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#694895}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ec283489193a..884c81e1703f git log ec283489193a..884c81e1703f --date=short --no-merges --format='%ad %ae %s' 2019-09-09 perezju@chromium.org [Telemetry] Remove support for ShouldAddValue Created with: gclient setdep -r src/third_party/catapult@884c81e1703f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:921000 Change-Id: Id888836ed76d5dac6e9a673bc769c13c79b34f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793403Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/3f05f651ae36..3a4503986247 git log 3f05f651ae36..3a4503986247 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 absl-team@google.com Googletest export 2019-09-09 absl-team@google.com Googletest export 2019-09-09 absl-team@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@3a4503986247 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: Iecc2c85bc541dfee25b0ca837dece5e37ae6339f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792141Reviewed-by:
-
Brian Sheedy authored
Switches media_perftests to use PerfResultReporter instead of PrintResult and whitelists the tests for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: Id007f0f777f47cf676b32feb7b9b0455ec5df628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790413 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#694892}
-
Tina Wang authored
Previously: when sharing by right clicking a non-avtive tab, the active tab will be sent. After fixing: send the tab that the user right clicked on. Bug: 995614 Change-Id: If9a52d36eed400c3f096b2cbf58069aa85169446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790375 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694891}
-
Miyoung Shin authored
This CL converts AdapterPtr, AdapterClientPtr DiscoverySessionPtr in chrome and device to the new Mojo type, and uses pending_remote<AdapterClient> and pending_remote<DiscoverySession> in adapter.mojom and pending_remote<bluetooth.mojom.Adapter> in bluetooth_internals.mojom Bug: 955171 Change-Id: I013e11c6b5b1ce16275f22e99678f22564ebd13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787669 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694890}
-
Khushal authored
Since we do uniform scaling horizontally and vertically when rastering content and choose the higher scale between the 2, this can lead to excessive memory use if the ratio between the 2 scales and layer bounds is extremely high. Cap this ratio to some limit (arbitrarily chosen). Change-Id: If90b101d5a096c03dfb22fb633f3b33e2600eb74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790958Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#694889}
-
Koji Ishii authored
This patch changes line breaking behavior after out-of-flow objects to match to ICU, assuming the out-of-flow object is an object replacement character. The behavior is not well-defined, and not all cases are interoperable across existing implementations. Legacy/WebKit resets the prior context so that text after out-of-flow objects behave as if it is at the top of the line. Gecko and Edge seem to allow break in most cases, even when NBSP follows, but not when the line overflows. The behavior implemented in this patch is interoperable for all tests that pass on existing 4 implementations, but not exactly same as legacy when implementations do not agree. Bug: 1001438 Change-Id: I4c7077d2c287a6e897175b29a73ce1c308f29f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792467Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694888}
-
Brian Osman authored
The cache size is now configurable by the client. This CL re-implements the change made here: https://skia.googlesource.com/skia/+/450ba0a2b25de433470d5bfa2f21a0db833786fc Bug: chromium:974219 Bug: chromium:988964 Change-Id: Ibef0f842c30154d7295909284c5dc6922c3fa40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790501 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#694887}
-
Bo Liu authored
Use the ContentView as the WebContents container view Also emulate focus changes like content shell. Change-Id: I6edf3e7be920bcc2a385d0698b1bf949a496c91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790150 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#694886}
-
Samuel Huang authored
This CL sets the default value for |dfmify_dev_ui_dfm| to true, to put the DevUI DFM on track for launch: Canary -> Dev -> Beta -> Stable. Depending on approval status, we can easily disable this. For Canary, Play Store is also expected to gracefully handle disappearance / reappearance of the DevUI DFM, if we ever need to disable / re-enable it. Currently only chrome://bluetooth-internals is in the DevUI DFM, but more will be moved in the upcoming weeks. Also, only native resources split is supported (native code split is future work). Bug: 927131 Change-Id: Ie5c8b821ca067a19f4c69dbd7af863816a89c460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793233 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694885}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/views. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Restore full TaskEnvironment in ViewsTestBase. R=weili@chromium.org Bug: 891670 Change-Id: Id7d806ac0dcacb9bdeeb3e7117c659ffbb46c217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786953Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694884}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/browsing_data. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=dullweber@chromium.org Bug: 891670 Change-Id: I31e0a16f1dc0e605fad78e6252ec7d7a833efb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786839 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694883}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/eb590e0e22e9..1d3ff52a37c7 git log eb590e0e22e9..1d3ff52a37c7 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 thestig@chromium.org Fix out of bound read in PDF_DecodeText(). 2019-09-09 bebeaudr@microsoft.com PDF a11y: new API for font-weight 2019-09-07 thestig@chromium.org Simplify CPDF_CMap ctor. Created with: gclient setdep -r src/third_party/pdfium@1d3ff52a37c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1001159,chromium:985604 Change-Id: Ib6fc0b8abd36d50385d4509937a90eb1c28f455f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793234Reviewed-by:
-
David Tseng authored
Issue: Whenever a node does not have focus, the textSelStart and textSelEnd attributes are not populated properly. For example, Node role=textField textSelStart=2 textSelEnd=3 value="asdf" regardless of where the actual selection is in the text field. Change-Id: I542e58384268b069d6d015e981a2ad3fc7c20ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790268Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#694881}
-
Stephen Chenney authored
TBR=eae@chromium.org Bug: None Change-Id: I39bb28ca7e94aea076f0df2973c5ddc156a876bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793382Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#694880}
-
Sergey Ulanov authored
ExternalVkImageBacking was calling Initialize() for the command buffer returned from VulkanCommandPool::CreatePrimaryCommandBuffer(), but CreatePrimaryCommandBuffer() already calls Initialize(), i.e. Initialize() was called twice, which means VkCommandBuffer was created twice, while only second handle was freed in VulkanCommandBuffer::Destroy(), the other one was leaked. This change fixes the issue in ExternalVkImageBacking to avoid the second Initialize() call. Also added a DCHECK() to avoid this problem in the future. Bug: 1001296 Change-Id: I043ddd53952a0650db5cd44835f8d4c244a6e722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792853 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694879}
-
Ramya Nagarajan authored
The SyncSendTabToSelf feature has been enabled by default across all platforms since M75. This cleans up any dependencies on the feature. Bug: 949612 Change-Id: I4a59c151d2cf6349d277e52a81fe88399f2ab665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790642 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#694878}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /gpu/command_buffer. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=vmiura@chromium.org Bug: 891670 Change-Id: Idb77d543a4954904ed6f6fd8e8f9d753ef170964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786782 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Before allowlist is available from GmsCore, we plan to have it hardcoded in our code. This call is synchronous for now, since it gets result directly instead of a IPC call. I will have a follow up CL for Async implementation. Bug: 999344 Change-Id: Ide3b7de83f0e32c5be8ac657369ce9f95a848f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776601 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#694876}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9cb02b618069..4baa46a5d104 git log 9cb02b618069..4baa46a5d104 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 zoddicus@users.noreply.github.com Rolling 4 dependencies and update known_failures (#803) Created with: gclient setdep -r src/third_party/shaderc/src@4baa46a5d104 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I44fa20fadc6711b626c96443af523b89f63afa89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793231Reviewed-by:
-
Stephen Martinis authored
Bug: 999206 Change-Id: I91c01200552c4170ac6d18badd5bdd113396526d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792461 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#694874}
-
https://crbug.com/996337Lucas Furukawa Gadani authored
Bug: 996337 Change-Id: I18d8fee2f27842abd3ab48cb5bde90815afba5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785078 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#694873}
-
Haiyang Pan authored
It looks like this target does not apply to x86. See https://cs.chromium.org/chromium/src/chrome/android/BUILD.gn?rcl=833be61e91e914e4e84dd2f2a86d35433746b8c8&l=2160 and https://cs.chromium.org/chromium/src/chrome/android/static_initializers.gni?rcl=909cd47e9565dc8cca8b1ca5e7647203b325c851&l=15 Bug: 997376 Change-Id: Id2f6c5dc9112a058bb6ef3d85569faeeafcd04ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790431Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=sandersd@chromium.org Bug: 891670 Change-Id: I6a3dfc2fa21be93d5ebb050de7df8db034dd8cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787198 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
James Darpinian authored
Clusterfuzz found a null dereference crash here. In the case where the context is lost, uniforms_es3_ can be invalid. Bug: 1001285 Change-Id: I8c9984ccf13e4c26252017efbd0ec39a486a73a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792139 Auto-Submit: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ddef8d1b6b07..9e380fd484db git log ddef8d1b6b07..9e380fd484db --date=short --no-merges --format='%ad %ae %s' 2019-09-09 sprang@webrtc.org Improve performance of RtpPacketHistory 2019-09-09 ilnik@webrtc.org Reland "Refactor FEC code to use COW buffers" 2019-09-09 sprang@webrtc.org Remove usage of RtpRtcp::SetSSRC() in RtpRtcpImplTest 2019-09-09 andreidumitru@google.com Add option to enable retransmission for all temporal layers in the constructor for rtp_sender_video. 2019-09-09 eshr@google.com Add qualityLimitationResolutionChanges stat 2019-09-09 orphis@webrtc.org Connect the stable target rate to the video encoders Created with: gclient setdep -r src/third_party/webrtc@9e380fd484db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I9af999abb9d9d2f1b7314fc027cc03e591ad786a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793227Reviewed-by:
-
Gayane Petrosyan authored
This is a reland of f5a9a694 Original change's description: > [Cleanup] Move complex color calc out of searchbox_extension.. > > In this CL the logo and shortcut color calculation is split into 2 parts. > The color calculation based on the theme is moved to themes, and > defaults are moved to ThemeProperties. > The logo and shortcut colors can be overridden when custom background is > set. This logic is moved to instant_service. > > NTP text and logo_alternate logic is also moved out of > searchbox_extension. > > Bug: 983717 > Change-Id: I12b938ba8a833bd920cf224171163781889989a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759150 > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691869} TBR=ochang@chromium.org Bug: 983717 Change-Id: I1a72f7e4d7c48289ed9cb8b0341b448c03b025f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778856 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#694868}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I99c2917452ef0f16f391fb0d0592be07480ccafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791269Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694867}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efce0d1b7657..6a860326887f git log efce0d1b7657..6a860326887f --date=short --no-merges --format='%ad %ae %s' 2019-09-09 brucedawson@chromium.org Handle GOMA_DISABLED more precisely Created with: gclient setdep -r src/third_party/depot_tools@6a860326887f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:b/140312943 Change-Id: I0d8d28c96997af61759196d10f65dd814435e9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793223Reviewed-by:
-
Rahul Singh authored
This CL changes how we overload caption styling on Windows. Going forward, we will overload a caption styling property only when a user explicitly sets it in Settings (set to something other than Default). Previously we always overloaded styling with OS preferences, even when a property was set to Default. This change aligns with changes to macOS behavior that went in recently https://crrev.com/c/1764966 Bug: 1000515 Change-Id: Ibdaaa8a40653543367eb655bd6b0945d78dd516c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786870Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#694865}
-
Gary Kacmarcik authored
This cl also removes some support for the ICE protocol to simplify the display handling code. Change-Id: I64523c0fc766cd80acdaae832c8f0fa08bb59757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790274 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#694864}
-
Sidney San Martín authored
Sometimes, a browser window isn't considered "on the current space" during the fullscreen transition at the moment the exclusive access bubble is displayed. Fix by checking again at the end of the transition. Bug: 1000882 Change-Id: Ia2ef081098ca84f975dd26dfa6bf2615a3094af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790378 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Kristi Park authored
This reverts commit d4a3f593. Reason for revert: Encountering issues such as http://crbug/1002013 Original change's description: > [NTP] Fix bottom border of focus ring in richer picker > > Before: http://screen/VS5BsT3hGH1.png > After: http://screen/9x05VZFtAkS.png > > Bug: 997665 > Change-Id: If76461a2b26ebad7ad48d9bd157af4d7a76d8070 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772124 > Commit-Queue: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Auto-Submit: Kristi Park <kristipark@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690525} TBR=kristipark@chromium.org,kmilka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997665,1002013d Change-Id: I4500159c78eca3429528a4aa55071ff3a43d9b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790146Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694862}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types. - Apply pending_receiver to CreateGpuMemoryBufferFactory Bug: 955171 Change-Id: I84cb8e73efcfa2d499bc8f568d5586744e8be7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792023 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#694861}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28d40b2e7ade..3fdfe2823866 git log 28d40b2e7ade..3fdfe2823866 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 brianosman@google.com Simplify GPUSink constructors by just passing the config object Created with: gclient setdep -r src/third_party/skia@3fdfe2823866 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I6a7eacecb9c1ad1cb2cbb0ea95cf1054b34c7fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793226Reviewed-by:
-
Saman Sami authored
The tests were disabled due to timeout when native Vulkan is used, so use swiftshader instead. Bug: 940723 Change-Id: Ida3745c7d6d480aebf1a56498b3242a1b77353d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790198 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#694859}
-
