GitLab

1) Fix padding.
2) Fix editing in landscape mode


Screenshots - https://screenshot.googleplex.com/xFHjg8t9rxu.png
https://screenshot.googleplex.com/sS7NWffEpOf.png

Landscape mode screenshots -
https://screenshot.googleplex.com/xM2HVR5SXH6
https://screenshot.googleplex.com/zDeW1YOtQqB


Bug: 848955
Change-Id: I2b8d3f70291de088f29007377cae0c03e3c5f18d
Reviewed-on: https://chromium-review.googlesource.com/c/1391350Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Commit-Position: refs/heads/master@{#619472}

We are in the process of migrating to R8 to replace Proguard. This is
the first step - move all usages of Proguard in public targets to R8.

Some refactorings were natural with the few forced changes this caused.

TBR=smaier

Bug: 908988, 913554
Change-Id: I2139919598fba1643d7560dc5557d5efb9a5887c
Reviewed-on: https://chromium-review.googlesource.com/c/1357306Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619471}

This is purely a mechanical change; there is no intended behavior change.

BUG=837308
R=enne@chromium.org

Change-Id: I2a28091c571d44f8c828c3698d3dd4a7e6fac220
Reviewed-on: https://chromium-review.googlesource.com/c/1392747
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619470}

Bug: 167187
Change-Id: Iec89a8e1928a6ba0eda22dc7ec1d55b5f7265312
Reviewed-on: https://chromium-review.googlesource.com/c/1393369Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619469}

This CL fixes the overlay element info tooltip in 2 cases:
- Elements located offscreen to the left had no visible tooltip
- Elements whose width is too narrow had offset tooltip arrows

Screenshot: https://imgur.com/a/WIVozJC

Bug: 908637
Change-Id: I9b22dda4fb15761c86d58e529cd1340d6711ba85
Reviewed-on: https://chromium-review.googlesource.com/c/1385185Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619468}

https://webrtc.googlesource.com/src.git/+log/bde71044cd4a..5f7c835487e0


git log bde71044cd4a..5f7c835487e0 --date=short --no-merges --format='%ad %ae %s'
2019-01-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c5391e48..d189a954 (619309:619409)


Created with:
  gclient setdep -r src/third_party/webrtc@5f7c835487e0

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I80d792bfa7d4f2955e7a64f524cc4cec523a7ac3
Reviewed-on: https://chromium-review.googlesource.com/c/1393349Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619467}

Blink can OOM crash when trying to display text that is too long.
This CL disables the 'Show more' button, and shows memory size
instead of remaining character count.

Screenshot: https://imgur.com/a/1ET0ui3

Bug: 873498
Change-Id: I0f2a9a06c5f7710260f1795d0f9446b68b7f4498
Reviewed-on: https://chromium-review.googlesource.com/c/1377710
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619466}

Change-Id: If88c1840b18b8abf4b8ca34baca4d29ad492f3e4
Reviewed-on: https://chromium-review.googlesource.com/c/1393007Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#619465}

Specifics:
       +66,376 bytes main lib size
      +488,684 bytes main dex size
      +786,246 bytes normalized apk size
InstallSize:
      +300,364 bytes APK size
      +872,125 bytes Estimated installed size (Android Go)
    +2,274,647 bytes Estimated installed size
InstallBreakdown (+2,274,662 bytes):
        +2,802 bytes unwind_cfi (dev and canary only) size
        +2,708 bytes Non-compiled Android resources size
       +66,376 bytes Native code size
          +552 bytes Package metadata size
    +2,185,868 bytes Java code size
       +16,356 bytes Compiled Android resources size
Dex:
        +2,495 entries fields
        +3,526 entries methods
          +802 entries types
        +1,766 entries strings

Bug: 913874
Change-Id: Icda58273a358ec07b86f6ac2cbd2350a43870ffb
Reviewed-on: https://chromium-review.googlesource.com/c/1393261Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619464}

Bug: 167187
Change-Id: Ie7b6c5714567d8486fcc6ce16f17cc418ca6ac30
Reviewed-on: https://chromium-review.googlesource.com/c/1393332Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619463}

Add a mojo method to query the sheet's vertical offset. In practice
this offset is off of the widget's NSWindow's contentView, so perform
the computations to make that adjustment in the app shim process.

Bug: 912815
Change-Id: I7c224a87769705cab94606c0bb24ab5f7b5e7d6d
Reviewed-on: https://chromium-review.googlesource.com/c/1389962Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619462}

Bug: none
Change-Id: I65e12280b8e9763fb9bead3ae66d9c9767dd8342
Reviewed-on: https://chromium-review.googlesource.com/c/1391418Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619461}

BUG=916749

Change-Id: Ideb4f53009923138676063e2186332c0b4d147a2
Reviewed-on: https://chromium-review.googlesource.com/c/1393021Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619460}

If the active window is snapped when the user switches from laptop mode
to tablet mode, then split view shall be activated with the active
window on the side to which it was snapped. On the other side shall be
the previous window if it was snapped to that side, and overview
otherwise.

Bug: 819798
Change-Id: I22830563e0fea71977cd5b6c0b78f9d4f3a66e71
Reviewed-on: https://chromium-review.googlesource.com/c/1391470
Commit-Queue: Avery Musbach <amusbach@google.com>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619459}

Instead define an explicit Show() method to start the UI. See bug for
details.

TBR=sky@chromium.org

Bug: 904148
Test: Run chrome --show-taps, see touch point circles
Change-Id: I9d718097be9bb685e1e218780489fffce386a622
Reviewed-on: https://chromium-review.googlesource.com/c/1385013Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619458}

If the tab count has changed since the last toolbar texture capture,
force a texture capture the next time #setForceTextureCapture is called.

Prior to splitting the tab switcher and browsing mode toolbar views this
wasn't necessary because changing the tab count caused an invalidation
to propogate to the ViewResourceFrameLayout. After the split, however,
the invalidation doesn't get propogated becaused the browsing mode view
is invisible while in the tab switcher.

BUG=917805

Change-Id: I451767a6d24bf570a60eac22ef1c2d76decf9740
Reviewed-on: https://chromium-review.googlesource.com/c/1391677Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619457}

This study doesn't do anything except exercise permanent-consistency.
Query it once to "activate" it, so it shows up in the logs when
WebViewLogVerbosifier.apk is installed, so QA can verify
permanent-consistency.

BUG=866722

Change-Id: I2b2c6812b735a7bd0cee8c116161d2e18c5a27f3
Reviewed-on: https://chromium-review.googlesource.com/c/1389437Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619456}

TEST=Manually
BUG=896221

Change-Id: I4be49faac0574372b52a009f912dabeb85ec7283
Reviewed-on: https://chromium-review.googlesource.com/c/1392110Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619455}

https://skia.googlesource.com/skia.git/+log/9356393f5b48..279b65ddb5a3


git log 9356393f5b48..279b65ddb5a3 --date=short --no-merges --format='%ad %ae %s'
2019-01-02 halcanary@google.com SkPDF: clean up public header
2019-01-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0c6672158c77..04ea03e4e1e1 (2 commits)
2019-01-02 kjlubick@google.com Add docker caches in more places


Created with:
  gclient setdep -r src/third_party/skia@279b65ddb5a3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I37dd481b921970bfa138568370013fb54719e86a
Reviewed-on: https://chromium-review.googlesource.com/c/1393345Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619454}

This patch adds a yielding budget which tries to do as much work as
possible within the budget. If the budget expires, it yields between
lifecycles.

This patch also makes this the default budget, since it's the best
behavior currently implemented.

See YieldingDisplayLockBudget::GetCurrentBudgetMs() for the time budgets.
These were picked arbitrarily, but I think they seem reasonable.

R=chrishtr@chromium.org

Bug: 907619, 882663
Change-Id: If8b3680df6b52690c238f23a319591dd8e181add
Reviewed-on: https://chromium-review.googlesource.com/c/1388159Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619453}

This inconsistency appears to have been introduced in error during an
update. This constant is not present in the upstream code and is unused.

Bug: crashpad:271
Change-Id: Ic1d72fe353da9076b4adf111e855347b04df3f94
Reviewed-on: https://chromium-review.googlesource.com/c/1389161Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619452}

This allows test-only APIs to be added without SECURITY_OWNERS review.

TBR=bartfab@chromium.org

Bug: 915912
Test: compiles
Change-Id: I9f8fb2e30b15f71aeddc778da571560b0a60d2a9
Reviewed-on: https://chromium-review.googlesource.com/c/1384926Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619451}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d2bcf3c2f33..dae815456c77


Created with:
  gclient setdep -r src-internal@dae815456c77

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I3b7473ef942fd522d8ebd18e1ae6b0337614a635
Reviewed-on: https://chromium-review.googlesource.com/c/1393348Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619450}

This updates the media notification to only show
action buttons for actions that are supported by
the media session.

BUG=897836

Change-Id: I0809167fb108e803a44f9e4f5220259555550fe9
Reviewed-on: https://chromium-review.googlesource.com/c/1386646Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619449}

These pass on Windows.

Bug: 11761, 40948, 43070, 43072, 367701, 369169, 733286, 825341
Change-Id: Ic6ebbddbdd306ff09867a1ea2c97cbf701ee526e
Reviewed-on: https://chromium-review.googlesource.com/c/1351785Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619448}

This reverts commit 8a5a16af.

Reason for revert: Suspected cause of breakage on android-rel:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/6359

Original change's description:
> Android: Replace desugar with d8 and r8 for debug
> 
> For release builds, desugar.jar still runs first, before d8 or r8, so
> nothing is changing for them as by the time d8 or r8 runs, the code has
> already been desugared.
> 
> When r8 is enabled, it can desugar all targets that enable proguard, and
> d8 can desugar all targets that do not enable proguard.
> 
> This can only be turned on once r8 replaces proguard since proguard does
> not understand java 8 code that has not been desugared already.
> 
> Bug: 906803, 913679, 916733
> Change-Id: I3fcc5a20b38e7fdc78cdeed1533583675d58346b
> Reviewed-on: https://chromium-review.googlesource.com/c/1384945
> Reviewed-by: Sam Maier <smaier@chromium.org>
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#619434}

TBR=wnwen@chromium.org,smaier@chromium.org

Change-Id: I5591321bd6369f4fb9de3f1519b2c823775c048b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 906803, 913679, 916733
Reviewed-on: https://chromium-review.googlesource.com/c/1393425Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619447}

BUG=524215

Change-Id: If163f88332e28bf769c4f4c80e6a2a00efc16f39
Reviewed-on: https://chromium-review.googlesource.com/c/1392249Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619446}

Since the WeakPtrFactory is used on |task_runner_|, we need to also
destroy it on |task_runner_| as well. This change wraps the
WeakPtrFactory in a unique_ptr and calls DeleteSoon on |task_runner_|
with the factory in the destructor.

Bug: 918532
Change-Id: I5a5eed43966b81f0cbb28c978c0f50f133b16169
Reviewed-on: https://chromium-review.googlesource.com/c/1392595Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619445}

The PreviewsLitePageDecider implements a 4th type of blacklist just
for LitePageRedirect Previews that is populated from a server bypass
response. This CL renames a couple methods and a member variable to
aid in clarity about the nature of this blacklist to avoid confusion
with other blacklists. This CL has no functional changes.

Change-Id: I20d721b8926492c984efba82e228a3571f03d8ce
Reviewed-on: https://chromium-review.googlesource.com/c/1392591Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619444}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/abd39667..46d76765

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib3eb7dad37e014bf4fdc8e3b6f4bb6f1a4afbdc2
Reviewed-on: https://chromium-review.googlesource.com/c/1393269Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619443}

Performance improvements, one small step at a time :-)

The current tooltip logic has at least two issues that this CL
addresses:

* When computing the contiguous area over which to show a tooltip
  continuously, all children of the ShelfView were considered
  (including overflow items for a non-overflow shelf for instance).
* Said contiguous area was recomputed on *every single mouse event*
  over the shelf, thus performing a O(n) (n = # of shelf items)
  operation every mouse move. These are cheap but completely gratuitous
  operations.

Note that this CL will not yet by itself fix the linked bug.

Bug: 896524
Change-Id: I801bf727232bd588b25dd797fdd20a6a5f675ac3
Reviewed-on: https://chromium-review.googlesource.com/c/1391360Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619442}

TBR=oshima, dbeam

Bug: none
Change-Id: Idf7858096414e43b9d067b55627bb6af97839ab1
Reviewed-on: https://chromium-review.googlesource.com/c/1351796Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619441}

Request an update to the toolbar texture after exiting the tab switcher
to ensure a new texture is captured before the user re-enters the tab
switcher. This used to be handled in
ToolbarPhone#updateVisualsForLocationBarState due to the visual state
for the toolbar changing from TAB_SWITCHER_* to one of the other states.

Also update the location bar bounds logic and shadow drawing logic to
ensure that the location bar is properly clipped and the shadow has the
proper visibility when capturing textures.


BUG=916561

Change-Id: I8ab5116d087866c7aa6e56865dc160c7a5f729c3
Reviewed-on: https://chromium-review.googlesource.com/c/1384374Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619440}

Bug: 879208
Change-Id: If2934a611d583d6725b7a9cd170e3c0fcd63bf34
Reviewed-on: https://chromium-review.googlesource.com/c/1374158
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619439}

Bug: 918350
Change-Id: Ieac9c9e1590c4cfe8f39d9f9bdfd510b41be616e
Reviewed-on: https://chromium-review.googlesource.com/c/1392719Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619438}

Existing pause time application in cc::KeyframeModel is incorrect.

To convert the client pause time to monotonic time, we used to add the
|time_offset_| (1) but not add |total_pause_duration_| (2). The new logic now
excludes (1) and adds (2). This ensures pause time and monotonic time
have the same base clock.

The original conversion was incorrect because:
a. Pause time should have the same base clock as monotonic time since we compute
   total_paused_duration_ as difference between the two.
b. Blink provides its animation's current time as pause offset which maps to
   the concept of local time in cc. So to convert it to monotonic time we don't
   need to include time_offset_.


Without this correction animations with start-delay or multiple pause/unpause
cycles would lead to incorrect pause time calculation. I suspect these issues
flew under the radar mainly because pausing is only ever used for simple test
cases not involving either of these conditions.

Bug: 840364
TEST: cc/animation/keyframe_model_unittest.cc

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id52ca7a3f3d63899864b7153470c7ef64c582d29
Reviewed-on: https://chromium-review.googlesource.com/c/1045126
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619437}

This CL is strictly a refactor that switches the Ads PLMO to count frame
data using ResourceDataUseUpdate instead of OnLoadedResource. This will
allow us to include incomplete resources and header bytes in future
per-frame metrics. This will not change behavior of existing histograms
at all.

Bug: 878393
Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251
Reviewed-on: https://chromium-review.googlesource.com/c/1372428
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619436}

Navigation icon is changed only in tablet mode.

Bug: 871798

Change-Id: Iab19f02b93566f35a0a65362e035bf82851cad73
Reviewed-on: https://chromium-review.googlesource.com/c/1391995
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619435}

For release builds, desugar.jar still runs first, before d8 or r8, so
nothing is changing for them as by the time d8 or r8 runs, the code has
already been desugared.

When r8 is enabled, it can desugar all targets that enable proguard, and
d8 can desugar all targets that do not enable proguard.

This can only be turned on once r8 replaces proguard since proguard does
not understand java 8 code that has not been desugared already.

Bug: 906803, 913679, 916733
Change-Id: I3fcc5a20b38e7fdc78cdeed1533583675d58346b
Reviewed-on: https://chromium-review.googlesource.com/c/1384945Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619434}

Change-Id: I8d452ba40f6224b3d33e651e2ad3bd5319d65ea2
Reviewed-on: https://chromium-review.googlesource.com/c/1391670Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619433}