- 20 Nov, 2019 40 commits
-
-
Ryan Hansberry authored
Bump up expiry dates as necessary, and update contact details: bluetooth-aggressive-appearance-filter, show-bluetooth-device-battery, and updated_cellular_activation_ui are all features still under development, and their expiry dates have been bumped to M85. instant-tethering has been marked as 'never-expire' because our team needs to be able to change it to enabled during development. This is because though it is a stable, launched feature, it is only marked enabled on select, approved boards (e.g., Pixelbook) which have passed Bluetooth verification and received Finch config seeds marking it as enabled. This means it is disabled-by-default and needs to be flipped to enabled on test machines. Bug: 1026291 Change-Id: Iffe0d2f72d5c380e6c01f244c6dcc4bcf332c1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917993Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#717239}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=diannahu@chromium.org Bug: 1023677 Change-Id: Ifd1adafef8dfad750aa9b319d524426bf6496642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926791 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Dianna Hu <diannahu@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#717238}
-
Dana Fried authored
This uses a method suggested by aleventhal@ in that it provides a hidden view on each widget that can be used to send accessibility notifications via the existing (at least on Mac) ViewAccessibility::AnnounceText() method. This CL expands AnnounceText() to be available on all platforms, with the non-Mac implementation using an invisible view parented to the widget's RootView. Currently uses alerts since they are compatible with all screen readers. Followup work will be to change to a live region update, which is a less obtrusive alert (see crbug.com/1024898). Bug: 1024026 Change-Id: I9dbe0d7e38fb69d3ada8b8e1574aee211bfe6291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913281Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#717237}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9233e0c593b1..b5a4004a3e8c git log 9233e0c593b1..b5a4004a3e8c --date=short --no-merges --format='%ad %ae %s' 2019-11-20 scroggo@google.com Add arm64 Wuffs perf bots 2019-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 8d45badce994..2914b63d6886 (1 commits) Created with: gclient setdep -r src/third_party/skia@b5a4004a3e8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: chromium:1023191,chromium:None Change-Id: Id77b504dd4dc4e94d801f070ef5a20035914dde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926656Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717236}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=emircan@chromium.org Bug: 1023677 Change-Id: I79e54ce00deeb5aa40c055633b6ace0813427643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927050 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#717235}
-
Kevin Marshall authored
ScrollLatencyScrollbarBrowserTest.ScrollbarThumbDragLatency is disabled because it breaks browser_tests on Mac. TBR=dtapuska@chromium.org Bug: 1026720 Change-Id: Idbfdd91221c94bea5e1b52d6026a9c4d7682e2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924280Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#717234}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=karandeepb@chromium.org Bug: 1023677 Change-Id: I6d4fe6a3d14d511be84b317559900be2491bbe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927028 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#717233}
-
Kevin Marshall authored
Test breaks the bot "Linux Tests (dbg)(1)". TBR=dcheng@chromium.org Bug: 1026725 Change-Id: I2c606cfcbc9c8867387f609727d453cb4cd7c510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927033 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=manucornet@chromium.org Bug: 1023677 Change-Id: I6865ac3416a8606c0dd616755704b535d331fba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927027 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#717231}
-
Anupam Snigdha authored
When |ContextDestroyed| was called in the InputMethodController, the active EditContext stored in the InputMethodController wasn't getting destroyed so explicitly setting it to null in |ContextDestroyed|. Bug: 1024161 Change-Id: I49489f90b13aa105c2ae6dffdaae19546e31f290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925891Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#717230}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=chcunningham@chromium.org Bug: 1023677 Change-Id: I4c33a117b6b3333aecb95ca09db752ecada7942e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926935 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#717229}
-
Huanzhong Huang authored
Please refer to the bug for details. Bug: 1022343 Change-Id: Ic0fa9ee3600d4892e874516d847314fc64dd0e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922689 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#717228}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=emaxx@chromium.org Bug: 1023677 Change-Id: I488d8812cab252e91415e53b311c4cbae8858ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926996 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#717227}
-
James Forshaw authored
Disable the Renderer AppContainer feature as it seems to be increasing crash rates due to DLL delay loading failures. Bug: 1024027 Change-Id: Ib4be829f63ba871fd43fc28f0ab7a1a1cdf04f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925195Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#717226}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=guidou@chromium.org Bug: 1023677 Change-Id: Iaa74f84ea442bebf4ff838c9d7371099d0544c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926941 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717225}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/90a11ba0668e..b872b4d58042 git log 90a11ba0668e..b872b4d58042 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 thestig@chromium.org Simplify image_diff_png::DecodePNG(). 2019-11-20 thestig@chromium.org Add --reverse-byte-order flag to test_runner.py. Created with: gclient setdep -r src/third_party/pdfium@b872b4d58042 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I748283a7a4aafd0f774e2748cfe2c9739f9f8986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926510Reviewed-by:
-
Hazem Ashmawy authored
Show a persistent error message if the user hasn't opted into crash collection: - If "--enable-crash-reporter-for-testing" flag isn't enabled. - AND GMS "Usage & Metrics" collection is not enabled. The UI has to be relaunched in order to update the error status. Bug: 1014825 Test: Check the error after with --enable-crash-reporter-for-testing flag on/off on upstream and downstream SystemWebView Test: Check the error after switching GMS "usage & diagnostics" settings on/off on downstream webview Change-Id: Idc1a74579cef267612bb5c5804f5b988c8c44c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914394 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#717223}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 1023677 Change-Id: I33792710ba7f52706e8e3eaaf3997dcc43482f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926815 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#717222}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=parastoog@google.com Bug: 1023677 Change-Id: I73531181fb5fd0f23b5620f11f67c89f21d01748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925185 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717221}
-
Maggie Chen authored
InitializeStaticGLBindings function is mainly for loading dlls which don't call the GPU drivers or use the GPU hardware. This code separation is the pre-work for the GPU watchdog to guard the functions that use the GPU drivers or/and hardware only. Bug:949839 Change-Id: I3f0a2f7eab6b17689dd088208e4298d2d410a52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854211Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717220}
-
Wenbin Zhang authored
This CL added the test version check for PRESUBMIT by calling the load_tests() in system_health_smoke_test.py: https://chromium-review.googlesource.com/c/chromium/src/+/1850353 The load_tests() has logic of downloading non-local stories, thus it will fail the PRESUBMIT when the CL author does not have access to the stories. This CL separates the logic of version check and test downloading. Now in PRESUBMIT we only do version check. Bug: chromium:1024912 Change-Id: I40775ec91aebc2179640565f2c1836aee44d176e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918363 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#717219}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=asanka@chromium.org Bug: 1023677 Change-Id: Ifa0d71e864ccb33c4a51f945ead6a9f5ff4312f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925733 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717218}
-
Olivier Li authored
The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: I3793de26ba54c7818ef3f710dd88c389e5d01297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924624Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#717217}
-
Michael Spang authored
Create new source_sets in each directory with the unit tests for the component that directory implements. This avoids having to add all tests directly ui/events/BUILD.gn. Bug: 1026406 Change-Id: Id3b462f655da31219c08131601e0bab8927bb1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925674 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#717216}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=xdai@chromium.org Bug: 1023677 Change-Id: I2a37dba9dcad0551d09a8d3df6d35403785a3c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927054 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#717215}
-
Gabriel Charette authored
We had landed the previously agreed upon API but recent design discussions have invalidated previous decisions. To stop the bleeding let's at least revert the documentation until we have a fully approved plan. R=altimin@chromium.org, darin@chromium.org Bug: 1026641 Change-Id: Idf0c2deafbd7fcd85541272f04fcd93cc745ce73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926533 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717214}
-
Kevin Marshall authored
Disables time-multiple-fields-stepup-stepdown-from-renderer-hour.html because it is flaking on the testbot Mac10.13 Tests (dbg). TBR=dpranke@chromium.org Bug: 1026712 Change-Id: I13272a5c6306e66bb3eef26b9ff1572b5c6bc2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926995Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jdoerrie@chromium.org Bug: 1023677 Change-Id: Icb6700d62c0f13d14e1d2b6c1217f4821026dca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926812 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#717212}
-
pwarren authored
This CL extends the expiration milestone of the enable-vaapi-{jpeg,webp}-image-decode-acceleration browser flags until M83. Bug: 1025756 Test: Open chrome://flags and verify the flags are still there. Change-Id: Ice9843b266db49e5b72c86bbbcdb84cd297a2b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924696 Commit-Queue: Paulo Warren <pwarren@google.com> Reviewed-by:Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#717211}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=afakhry@chromium.org Bug: 1023677 Change-Id: I9a73d43c7318398caa8e13e238788e4319f6dedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926999 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#717210}
-
Josh Nohle authored
In the fake v1 device manager, pass ExternalDeviceInfo vector by const ref. In the fake v2 device manager, expose the Instance-ID-to-device map member variable and the NotifyDeviceSync{Started,Finished} methods. Bug: 951969 Change-Id: I4856da01d885d25c1e48cc166a60d786f54ca713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925213Reviewed-by: -
Jeffrey Cohen authored
For all sharing features in the case where the device name is not useful we should fall back to using a common naming scheme. This CL adopts that common naming scheme and moves it and the required helper functions into components for cross platform access. Bug: 1025362 Change-Id: Ibb20dc9db3a99b24f9688fd51838febab0419694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919738 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#717208}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=maxlg@chromium.org Bug: 1023677 Change-Id: I2eeca96350c31893f82ffa31c98777c2bcd42b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926800 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717207}
-
Amy Huang authored
Bug: 1026283 Change-Id: I7c310bd09cba995ed648d8743aa62f5878698416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924872 Commit-Queue: Amy Huang <akhuang@google.com> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#717206}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=afakhry@chromium.org Bug: 1023677 Change-Id: I257bc3f2ffad224fbb7ab2542d748004a6871a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926924 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/639872c8ef6e..50696684f7a8 git log 639872c8ef6e..50696684f7a8 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 ukai@google.com roll out new goma client binary Created with: gclient setdep -r src/third_party/depot_tools@50696684f7a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1026184 Change-Id: I57864306e1cb8c2b24055363894580abb7ad678c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926385Reviewed-by:
-
Kevin Ellis authored
Bug: 960944 Change-Id: I09c84d7e5b08e1f3d12498d785acf50610b57a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926668Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#717203}
-
Shivani Sharma authored
This CL fixes the Network isolation key unittests so that they work even if append frame origin is enabled by default. Note that there is already tests that explicitly enable the feature, NetworkIsolationKeyWithFrameOriginTest. Also removes a test NetworkIsolationKeyTest.WithFrameOrigin which is redundant with NonEmptyKey, Operators and NetworkIsolationKeyWithFrameOriginTest.WithFrameOrigin Bug: 1026388 Change-Id: I0d395767daab00f074c8284f654a2d5875820bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924965Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#717202}
-
Gavin Williams authored
In order to make settings sliders more functional for users of screen readers we are adding more descriptive ARIA labels. -Update aria-roledescription to describe to users the context of the min and max values of a slider. For reference: Current slider ARIA output: "Slider. 120 percent. Min 60, Max 820" Video: https://bugs.chromium.org/p/chromium/issues/detail?id=1015839#c5 Expected slider ARIA output: "Slider: Slowest to Fastest. 120 percent. Min 60 Max 820" Video: https://bugs.chromium.org/p/chromium/issues/detail?id=1015839#c9 Bug: 1015839 Change-Id: Iff2ea48b9badde05c93534ed1f2d283abef87bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906941 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#717201}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=andrescj@chromium.org Bug: 1023677 Change-Id: I509e52204e61e7c1a65c809e9e512f4255c16f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925294 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
