- 29 Oct, 2018 40 commits
-
-
Daniel Bratell authored
openh264 sources lists referred to two non-existing headers which prevented gn check from successfully working on that code. This patch removes those headers from the sources list. One of them (utils.h) does exist but with another path, and it's already included with that path, Change-Id: Ie0a1e7e0b48295a28e9a89651e07800a70a36154 Reviewed-on: https://chromium-review.googlesource.com/c/1298956Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603483}
-
Rijubrata Bhaumik authored
Tested using a brio-stream-4k-hd-webcam, where we could change the exposure time in manual mode. command line: v4l2-ctl -d 1 --set-ctrl exposure_auto=1 v4l2-ctl -d 1 --set-ctrl exposure_absolute=100 GUI: guvcview --device=/dev/video1 TEST= run the demo in https://codepen.io/rijuB/pen/gjapBo use slider to change exposureTime. BUG=823316 Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ls3wQSoHOUY Change-Id: I2c4faaf8bd475fedefd267aaf83e6c06f55e5afd Reviewed-on: https://chromium-review.googlesource.com/c/1243288 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#603482}
-
Peter Wen authored
- Adding myself and isherman@ to: chrome/android/java/src/org/chromium/chrome/browser/crash/OWNERS Bug: None Change-Id: I955dbded0924f5a8fdea1ffeaf6d97f2d31bea0e Reviewed-on: https://chromium-review.googlesource.com/c/1294474Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603481}
-
Raphael Kubo da Costa authored
IWYU. std::unique_ptr needs <memory>, which was being included indirectly and breaking the libstdc++ build after commit e806ef73 ("Snap after pressing arrow key"): In file included from ../../cc/input/snap_selection_strategy.cc:5:0: ../../cc/input/snap_selection_strategy.h:20:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForEndPosition( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.h:24:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForDirection( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.h:27:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<SnapSelectionStrategy> CreateForEndAndDirection( ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:9:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:18:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ ../../cc/input/snap_selection_strategy.cc:24:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<SnapSelectionStrategy> ^~~~~~~~~~ Bug: 819294 Change-Id: I83c594b1ae71a34f21e77c7c9d866e47629c7a61 Reviewed-on: https://chromium-review.googlesource.com/c/1304418Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#603480}
-
Michael Lippautz authored
These metrics are high level and do not include subscopes. Examples: - v8-gc-mark-compactor-total - v8-gc-mark-compactor-mmu - v8-gc-mark-compactor-marking-total No-try: true Tbr: nednguyen@chromium.org Change-Id: I6feafb6971f0904d1d9bd31201d1be2e63258049 Reviewed-on: https://chromium-review.googlesource.com/c/1304479Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603479}
-
David 'Digit' Turner authored
The header was renamed in a previous CL, this one adjust all includes under //cc/ to use the new header instead. BUG=898787 R=skyostil@chromium.org, enne@chromium.org, danakj@chromium.org Change-Id: I98fafefc6c463c4d5765ef9703fcfdea909ffc2f Reviewed-on: https://chromium-review.googlesource.com/c/1301464 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#603478}
-
Keishi Hattori authored
Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. Bug: 864425 Change-Id: I1fb04d7c501a8519e106237946f86f52eb7ce8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1297782Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a64198c..d289e7e7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I36257232267b8953921f037f007c947ae4aa1593 Reviewed-on: https://chromium-review.googlesource.com/c/1304402Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603476}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d474432ff15..abe2229c3928 Created with: gclient setdep -r src-internal@abe2229c3928 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I42fc24a74ce35eada3791bd4bb7f3ea8c986238a Reviewed-on: https://chromium-review.googlesource.com/c/1304376Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603475}
-
Olga Sharonova authored
This reverts commit ca965d9a. Reason for revert: Failing on Win7 https://ci.chromium.org/buildbot/chromium.webrtc/Win7%20Tester/46658 Original change's description: > Re-enable WebRTC webcam tests. > > Webcams should be fixed on all chromium.webrtc bots now. > > Bug: 896654 > Change-Id: I6e3694e88c24ad754ec5f852d1cc6165a5482ccd > Reviewed-on: https://chromium-review.googlesource.com/c/1295811 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603459} TBR=phoglund@chromium.org,martiniss@chromium.org,mbonadei@chromium.org Change-Id: I5b5d743fb41075ebfae9e27d733b83767a3ebca4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896654 Reviewed-on: https://chromium-review.googlesource.com/c/1304513Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#603474}
-
Jun Choi authored
Currently, WebAuthN BLE device selection view only handles the case when a Bluetooth authenticator changes from non-pairable mode to pairable mode. Add logic to remove devices in non-pairable mode from the list view ui. Bug: 877344 Change-Id: If093940cf63533520d6377e4a4fc971122ab0a8d Reviewed-on: https://chromium-review.googlesource.com/c/1292869 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#603473}
-
Clemens Arbesser authored
Previously, the controller would request the scripts only after GetLastCommittedURL() was available, which takes quite a bit of time (> 1 second on the emulator). Now, the URL is passed directly to the constructor of the controller, which allows it to request the scripts immediately. This results in a moderate performance improvement at the cost of an additional string parameter. Bug: 806868 Change-Id: Ib11024ce8eb4228b1703abfd58a2e52fbad8e1e8 Reviewed-on: https://chromium-review.googlesource.com/c/1297969Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#603472}
-
Yuta Kitamura authored
The directory structure for Blink scheduler is changing. The new convention deprecates util/ and the files in util/ should go to common/ now. Headers used by non-scheduler code are moved to public/. Bug: 826203 Change-Id: I617deec92f3d34fc0bc82e3211bdd223e90339be Reviewed-on: https://chromium-review.googlesource.com/c/1301578 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Adds MakeGarbageCollected<T> which can be used to allocate Oilpan objects in place of new. Bug: 757708 Change-Id: I11d715736896a04cfc1a15d7676717444eb6ed5f Reviewed-on: https://chromium-review.googlesource.com/c/1255085 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Henrik Grunell authored
TBR=sahel@chromium.org Bug: 899715 Change-Id: Ic6b90ce68432b2f1254740e237d32f674fa3e628 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1303366Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603469}
-
Mario Sanchez Prada authored
Move all public methods from IdentityManager to using identity::ScopeSet instead of the equivalent type definition OAuth2TokenService::ScopeSet. This will make it clearer when migrating from SigninManager[Base] and [Profile]OAuth2TokenService to the IdentityManager, as code will be explicitly using a type definition from the identity service. As a side effect, this patch changes the signature of the constructors for AccessTokenFetcher and PrimaryAccountAccessTokenFetcher, and update clients of these APIs wherever needed. TBR=sky@chromium.org,dvadym@chromium.org,jkrcal@chromium.org,fgorski@chromium.org,peter@chromium.org,sdefresne@chromium.org,dcheng@chromium.org,fgorski@chromium.org,jdonnelly@chromium.org,mathp@chromium.org,hashimoto@chromium.org Bug: 899175 Change-Id: I4bda23f4e928cf94654d7c4ce2eb7961ff91dd9e Reviewed-on: https://chromium-review.googlesource.com/c/1301520Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#603468}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df73a8e5ffdb..4a22f4b04619 git log df73a8e5ffdb..4a22f4b04619 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 brandon1.jones@intel.com ES31: Add atomic_uint support to HLSL translator Created with: gclient setdep -r src/third_party/angle@4a22f4b04619 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ia458231909704d35514bea360de295ba5c7fdedb Reviewed-on: https://chromium-review.googlesource.com/c/1303741Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603467}
-
Morten Stenshorne authored
We cannot just use the innermost inline, without checking if it's a valid containing block for absolutely positioned descendants. Find the right ancestor. The idea of using the *next* inline in the continuation chain may not be ideal, but it's not obvious that using the previous one would be much better (it's more work to find that one anyway), so leaving it as it is. The spec says that if the relatively positioned inline occurs on multiple lines, CSS 2 doesn't define exact behavior. Therefore, in the test, put the same amount of stuff on the line preceding the interrupting block-level element as on the line following it, to be sure that the abspos descendant is sized the way we want it to be. Bug: 897535 Change-Id: Ie9bc4e83400bc283b9c95aafef821000f2303d12 Reviewed-on: https://chromium-review.googlesource.com/c/1301457 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#603466}
-
Clemens Arbesser authored
More specifically, the `prompt` field of the `CollectDataSpecification` message was previously unused, but is now passed along to AutofillAssistantPaymentRequest, which will show the prompt in the title of the UI. If not set, the UI defaults to the title of the web-contents (as before). Bug: 806868 Change-Id: I37b8d9570b5833095eca6070871c211a7a775c24 Reviewed-on: https://chromium-review.googlesource.com/c/1301441 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#603465}
-
Henrik Grunell authored
Disable flaky virtual/threaded/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations.js on Linux. TBR=alph@chromium.org Bug: 899710 Change-Id: I96112fd672703ce2d6fb6c30b6167fcea3a256ff No-Try: true Change-Id: I96112fd672703ce2d6fb6c30b6167fcea3a256ff Reviewed-on: https://chromium-review.googlesource.com/c/1304415Reviewed-by:
-
Eric Seckler authored
Folks have started to replace PostAfterStartupTask with posting BEST_EFFORT tasks instead, e.g.: https://crrev.com/c/1255343. This preserves the behavior of AfterStartupTasks for tasks posted to a BrowserThread via base::PostTask with BEST_EFFORT priority, while we wait for the BrowserUIThreadScheduler. Bug: 887407 Change-Id: Id98e4714435c801342002c710657b0f0784e55e0 Reviewed-on: https://chromium-review.googlesource.com/c/1283093Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#603463}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/22a8f98dd55b..f3ff14c00b43 git log 22a8f98dd55b..f3ff14c00b43 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 yvesg@webrtc.org Properly setup MockPeerConnectionObserver in tests. Created with: gclient setdep -r src/third_party/webrtc@f3ff14c00b43 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I219ac6e6a9782303ffb4e2a6a0614252eb3f0ec4 Reviewed-on: https://chromium-review.googlesource.com/c/1303742Reviewed-by:
-
Sami Kyostila authored
We recently increased[1] the minimum resolution of web-exposed timers. This patch relaxes the WPT tests accordingly to allow for a higher resolution (with a small delta to account for floating point errors). Bug: 897775 [1] https://chromium-review.googlesource.com/c/1290916 Change-Id: I6f8a8d8ac2b827ae54718db6f8940cafb1cad665 Reviewed-on: https://chromium-review.googlesource.com/c/1298017Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#603461}
-
Pavol Marko authored
Make ClientCertResolver understand ClientCertRef in addition to ClientCertPattern. The resolution of the ClientCertRef uses the fact that CertificateImporterImpl sets the nickname of the imported private key to the certificate's GUID. Bug: 898603, 697441 Test: chromeos_unittests --gtest_filter=*ClientCertResolver* Change-Id: If52f7e324e14b41d018942adaa3c3aefa9eccf58 Reviewed-on: https://chromium-review.googlesource.com/c/1299008 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603460}
-
Patrik Höglund authored
Webcams should be fixed on all chromium.webrtc bots now. Bug: 896654 Change-Id: I6e3694e88c24ad754ec5f852d1cc6165a5482ccd Reviewed-on: https://chromium-review.googlesource.com/c/1295811Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#603459}
-
Thomas Tangl authored
Bug: 896515 Change-Id: Idd45447bd092e934286f0b574782b92caa61a051 Reviewed-on: https://chromium-review.googlesource.com/c/1301517Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/797197a772b8..618decb9c4f5 git log 797197a772b8..618decb9c4f5 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 herb@google.com Remove unneeded sk_bzero Created with: gclient setdep -r src/third_party/skia@618decb9c4f5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I13a966d27ea325a4202cc3890ac8430ea719ee93 Reviewed-on: https://chromium-review.googlesource.com/c/1304374Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79b07e22fa04..1d474432ff15 Created with: gclient setdep -r src-internal@1d474432ff15 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I92e66648efb75f8255b2e7680d2f785a75a635dc Reviewed-on: https://chromium-review.googlesource.com/c/1303743Reviewed-by:
-
Henrik Grunell authored
Disable flaky virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-nested-divs-forbidden.html. TBR=masonfreed@chromium.org Bug: 891427, 899548 Change-Id: I044b5f63c84ec3a0761302f4dfc8d96f694ccbdf No-Try: true Change-Id: I044b5f63c84ec3a0761302f4dfc8d96f694ccbdf Reviewed-on: https://chromium-review.googlesource.com/c/1304414 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Add the kSVGGeometryPropertyHasNonZeroUnitlessValue use counter for non-zero unitless (<number> / "user units") values in the 'x', 'y', 'r', 'rx', 'ry', 'cx' and 'cy' properties. Bug: 899074 Change-Id: I1a7e6cdce018a75ed46745ec245dabcaed5ea954 Reviewed-on: https://chromium-review.googlesource.com/c/1301597Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#603454}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3a55ee4b..4a64198c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id49aceb52db60646f7e19112b922872101650ab7 Reviewed-on: https://chromium-review.googlesource.com/c/1304394Reviewed-by:
-
Daniel Bratell authored
There is both a top level namespace ::switches and a sub namespace ::extensions::switches so inside extensions, if both namespaces are known to the compiler, you need to clarify which one you want. This is the reason the code style guide prohibits sub namespaces with the same name as common top level namespaces. This is a quick fix to make some jumbo builds happy. I am not sure exactly what commit triggered this, but it can easily happen just by adding an include somewhere. TBR=hubbe@chromium.org Change-Id: I22d742aa1645aa1b37317524e9b1aa18e91d2fd3 Reviewed-on: https://chromium-review.googlesource.com/c/1303362Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603452}
-
Hitoshi Yoshida authored
GetTypeExtension() function takes a string object from a union object |string_or_options|. In case the union object is a Dictionary (= V8 object), we converted it to a Blink object ElementCreationOptions, but we do not have to do it. This CL makes the function skip to conversion and take the property from V8 object directly. Bug: None Change-Id: I360c4e8d732b699835b108e8410a1e1376f35752 Reviewed-on: https://chromium-review.googlesource.com/c/1303325Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d4c9c094a31..79b07e22fa04 Created with: gclient setdep -r src-internal@79b07e22fa04 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If5fed8b0863a23113587c4753d329c3d61eec1a2 Reviewed-on: https://chromium-review.googlesource.com/c/1304373Reviewed-by:
-
Marc Treib authored
The version_79.sql "golden" file actually contained a version 78 database. Not sure why all the tests were passing anyway. Bug: none Change-Id: I89cc90655b81c2090e724104e48a645eb1d5081e Reviewed-on: https://chromium-review.googlesource.com/c/1299160Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#603449}
-
Hirokazu Honda authored
Decoded pictures (i.e. yuv format) on h264, vp8 and vp9 must be identical on any platforms, except its pixel format and device alignment. VideoFrameValidator checks soundness of each decoded picture comparing its md5sum value with golden md5sum. VideoFrameMapper used by VideoFrameValidator map decoded pictures and converts them, by libyuv, to I420 picture to resolve pixel format and device alignment differences. This change is the second step for it. VideoFrameValidator would support VA-API based VDA after this change. One pager: go/CrOSVFValidator BUG=chromium:856562 TEST=VDA unittest on h264, vp8 and vp9 with --frame_validator at eve $ ./video_decode_accelerator_unittest --test_video_data=test-25fps.vp8:320:240:250:250:35:150:11 --ozone-platform=gbm --gtest_filter=Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 --test_import --frame_validator Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I63b57cb35553edea0a85ea4aab5017f031653d82 Reviewed-on: https://chromium-review.googlesource.com/c/1189511 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#603448}
-
Mohamed Amir Yosef authored
This adds the functionality of storing laziness information back. It has been removed to avoid circular dependency due to a bug in the build system TBR=peter@chromium.org Bug: 882887 Change-Id: Ic9a26956909c3dbbdfae71e0d5f0c94a73896e18 Reviewed-on: https://chromium-review.googlesource.com/c/1301526Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#603447}
-
Henrik Grunell authored
This reverts commit cc54574d. Reason for revert: Seems to be the reason for Chromium OS failures. BUG: 899664 Original change's description: > [Reland] Refactor DirectoryTree > > Fix flakiness by adding call to this.expanded=true in EntryListItem. > > Change updateSubDirectories: > - use arrow function and const; > - change error callback calling style to match the same style used by > success callback (without if). > - change check from isFakeEntry to check for presence of the method > that's used "createReader". > > Change the sorting to be an method, so it can be customized per > sub-class, later it will be used to sort My files to show Linux and Play > files at the bottom. > > Fix unittest that started failing because it metadataModel was null. > > No changes in behaviour for users, the small change in behaviour is > EntryListItem.updateSubDirectories now reads its children using FS API > which isn't synchronous. > > Change-Id: I1019247e776e266cdd980a4c8a8338bf2b516b87 > Reviewed-on: https://chromium-review.googlesource.com/c/1300993 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603403} TBR=joelhockey@chromium.org,lucmult@chromium.org Change-Id: I9826f601fe469eb079b33e1415c3fddb324e0bb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1303731Reviewed-by:
-
Henrik Grunell authored
TBR=masonfreed@chromium.org Bug: 891427, 899609 Change-Id: Idb7a9501c40d008df9b02b7a1626579466fa2889 No-Try: true Change-Id: Idb7a9501c40d008df9b02b7a1626579466fa2889 Reviewed-on: https://chromium-review.googlesource.com/c/1303361Reviewed-by:
-
Sergei Datsenko authored
BUG=chromium:892524 Change-Id: Ic23bda48801b4874f1d31d6c151b24329bb836ae Reviewed-on: https://chromium-review.googlesource.com/c/1303315Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#603444}
-
