GitLab

The specification defines that PushEvents can be initialized with a
data member that is of type PushMessageDataInit, rather than an actual
PushMessageData object. This allows us to remove the constructor from
the PushMessageData object entirely, aligning with the specification.

https://w3c.github.io/push-api/#pushmessagedata-interface

This CL also implements the following pull requests, which defines the
PushMessageDataInit type to also encapsulate ArrayBuffer(View)?.

https://github.com/w3c/push-api/pull/160

Note that the PushMessageData object has not shipped to the world yet.

R=mvanouwerkerk
BUG=

Review URL: https://codereview.chromium.org/1311853002

git-svn-id: svn://svn.chromium.org/blink/trunk@201129 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Stabilized after https://codereview.chromium.org/1286093008

TBR=pdr@chromium.org
BUG=521856

Review URL: https://codereview.chromium.org/1317543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make EditorCommand to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |EditorCOmmand| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range and avoid registering temporary |Range|
object into |Document|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=388681, 513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1315813003

git-svn-id: svn://svn.chromium.org/blink/trunk@201127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

reset() is called from a number of places with the expectation of
putting the controls into the state they would be if created anew.

One such place is via HTMLMediaElement::preDispatchEventHandler, where
the controls are reset when entering or exiting fullscreen. This has a
very strange side-effect, namely that dispatching a synthetic
webkitfullscreenchange event on a video will cause the media controls to
become visible.

It would be rather messy to write a layout test for this, and it would
be slow to run, so instead add unit tests to test this more directly.

R=fs@opera.com

Review URL: https://codereview.chromium.org/1319433003

git-svn-id: svn://svn.chromium.org/blink/trunk@201126 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A simple follow-up of https://codereview.chromium.org/1306793003/.

BUG=509911
R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1314703003

git-svn-id: svn://svn.chromium.org/blink/trunk@201125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |localCaretRectOfPosition()|
by templatizing function to share algorithm.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=webkit_unit_tests --gtest_filter=VisibleUnitsTest.localCaretRectOfPosition

Review URL: https://codereview.chromium.org/1317503002

git-svn-id: svn://svn.chromium.org/blink/trunk@201124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make WebLocalFrameImpl to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |WebLocalFrameImpl| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1313013002

git-svn-id: svn://svn.chromium.org/blink/trunk@201123 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |firstRangeOf()| function as replacement of |firstRange()|
member function of |VisibleSelection| to prepare templatizing |VisibleSelection|
to exclude DOM tree position specific function out from |VisibleSelection|
for ease of templatizing.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1313883002

git-svn-id: svn://svn.chromium.org/blink/trunk@201122 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make EventHandler to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |EventHandler| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311623004

git-svn-id: svn://svn.chromium.org/blink/trunk@201121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |WebSubstringUtil| class to use |EphemeralRange| instead
of |Range| object to avoid registering temporary |Range| object into |Document|
for Oilpan friendly.

This patch is also a preparation of making selection to handle granularity for
web component, http://crrev.com/1277863002 to reduce DOM position dependency
from |VisibleSelection| for ease of templatization of |VisibleSelection|.

BUG=388681, 513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311373002

git-svn-id: svn://svn.chromium.org/blink/trunk@201120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method only serves to break the cue layout computed by
SnapToLinesLayouter. If we want to factor in margin+border for cues (and
padding for the cue container), then factor that into the cue layout
algorithm instead.

BUG=301580

Review URL: https://codereview.chromium.org/1314613002

git-svn-id: svn://svn.chromium.org/blink/trunk@201119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink used to set focused flag on focused element after
dispatching focus events.

This caused mismatch with other
browsers, during event handler 
  document.querySelector(":focus")
doesn't match anything.

BUG=523126
TEST=fast/events/focus-querySelector-in-focus-event-handler.html

Review URL: https://codereview.chromium.org/1312093002

git-svn-id: svn://svn.chromium.org/blink/trunk@201118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |markAllMisspellingsAndBadGrammarInRanges()| member function
of |SpellChecker| class to take |EphemeralRange| instead of |Range| to avoid
registering temporary |Range| object into |Document|.

This patch is also a preparation of making selection to handle granularity for
web component, http://crrev.com/1277863002 to reduce DOM position dependency
from |VisibleSelection| for ease of templatization of |VisibleSelection|.

BUG=388681, 513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1313863002

git-svn-id: svn://svn.chromium.org/blink/trunk@201117 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No client so far. Follow-up CLs will add actual clients.

Design doc:
https://docs.google.com/document/d/1TbtkhXpjw_8lftLwELuEPEgcyWfXuVLuqW2KYJZeaBA/edit?pli=1

Non trivial changes from the design doc:
- MemoryPurgeController owns its clients.
- Page owns MemoryPurgeController (because core/ and modules/ will want
  to access MemoryPurgeController to register clients)

I chose Page as the owner of the controller because it has the same
lifetime of WebView.

BUG=520496

Review URL: https://codereview.chromium.org/1303203002

git-svn-id: svn://svn.chromium.org/blink/trunk@201116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make DragController to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |DragController| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1316603002

git-svn-id: svn://svn.chromium.org/blink/trunk@201115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the default case from the CSSValue::equals method, to enable the
compiler to check that every enum value is in the switch statement.

Review URL: https://codereview.chromium.org/1311843003

git-svn-id: svn://svn.chromium.org/blink/trunk@201114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL re-enables tests and updates their expectations.

(1) Blink: https://codereview.chromium.org/1311113002/
(2) Chromium: https://codereview.chromium.org/1307133003/
(3) Blink: THIS PATCH

BUG=523904

Review URL: https://codereview.chromium.org/1311103002

git-svn-id: svn://svn.chromium.org/blink/trunk@201113 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make EditingStyle to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |EditingStyle| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range and avoid registering temporary |Range|
object into |Document|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=388681, 513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1314713004

git-svn-id: svn://svn.chromium.org/blink/trunk@201112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520742
NOTRY=true

Review URL: https://codereview.chromium.org/1312033002

git-svn-id: svn://svn.chromium.org/blink/trunk@201111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |positionForPoint()| in |LocalFrame| class as replacement
of |visiblePositionForPoint()| to reduce doing visible position
canonicalization for increasing chance to delay canonicalization with changing
|setPosition()| in |DragCaretController| and |VisibleSelection| constructor to
take |PositionWithAffinity|.

Note: Both of |VisbilePosition| constructor and |VisibleSelection| constructor
do visible position canaonicalization.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1310323004

git-svn-id: svn://svn.chromium.org/blink/trunk@201110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To reduce a mess of Heap.h, this CL splits Heap.h into Heap.h and HeapPage.h.

This CL just moves code around without any behavioral change.

BUG=437144

Review URL: https://codereview.chromium.org/1314793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
R=fs@opera.com

Review URL: https://codereview.chromium.org/1318443002

git-svn-id: svn://svn.chromium.org/blink/trunk@201108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This connects USBDevice interface methods to the embedder.

BUG=492204
R=reillyg@chromium.org

Review URL: https://codereview.chromium.org/1315683002

git-svn-id: svn://svn.chromium.org/blink/trunk@201107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With recent changes, it's dangerous to inject /deep/ selectors
to the page, as they get high priority. This patch stops injecting
backwards compatilibity code to the all-new frontned.

BUG=none

Review URL: https://codereview.chromium.org/1310653003

git-svn-id: svn://svn.chromium.org/blink/trunk@201106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes the raw pointer instances below:

    * StubFrameLoaderClientWithParent::m_parent
    * FrameLoaderClientImpl::m_webFrame
    * RemoteFrameClientImpl::m_webFrame

BUG=509911
R=haraken@chromium.org, oilpan-reviews@chromium.org, peria@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1306793003

git-svn-id: svn://svn.chromium.org/blink/trunk@201105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch reduces interfaces of WI.CSSProperty and WI.CSSStyleDeclaration
classes.

The patch removes:
  - remove style.getLiveProperty() method and the whole notion of "live"
    properties
  - removes tripple state defined via property.active()/property.inactive()
    flags. (The state was tripple as !property.active() !== property.inactive()).
  - style.shorthandValue/style.shorthandIsImportant public methods
  - removes property.styleBased() property

The patch adds:
  - property.activeInStyle() method which defines if the current property
    has any effect in style.
  - style.leadingProperties() method which computes those properties
    which should be displayed in StylesSidebarPane.

BUG=496263
R=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1308663002

git-svn-id: svn://svn.chromium.org/blink/trunk@201104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL temporary disables tests to be broken by (2).

(1) Blink: THIS PATCH
(2) Chromium: https://codereview.chromium.org/1307133003/
(3) Blink: https://codereview.chromium.org/1311103002/

BUG=523904
NOTRY=true

Review URL: https://codereview.chromium.org/1311113002

git-svn-id: svn://svn.chromium.org/blink/trunk@201103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of Take care of a FIXME in SecurityOrigin.cpp to check the validity (patchset #1 id:1 of https://codereview.chromium.org/1315793002/ )

Reason for revert:
Failure still present.

Original issue's description:
> Revert of Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during constructio… (patchset #4 id:60001 of https://codereview.chromium.org/1294933004/ )
> 
> Reason for revert:
> Speculative revert for "Too many opened files in the system".
> 
> Original issue's description:
> > Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during construction and to handle invalidity as a 'unique' origin.
> > 
> > TBR=mkwst
> > BUG=514076
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201022
> 
> TBR=jsbell@chromium.org,palmer@chromium.org,mkwst@chromium.org,brettw@chromium.org,michaeln@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=514076,524248
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201100

TBR=brettw@chromium.org,jsbell@chromium.org,michaeln@chromium.org,mkwst@chromium.org,palmer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=514076,524248

Review URL: https://codereview.chromium.org/1309333004

git-svn-id: svn://svn.chromium.org/blink/trunk@201102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of |VisibleSelection| constructor with |Range| parameter
to templatize |VisibleSelection| easier.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1307763003

git-svn-id: svn://svn.chromium.org/blink/trunk@201101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during constructio… (patchset #4 id:60001 of https://codereview.chromium.org/1294933004/ )

Reason for revert:
Speculative revert for "Too many opened files in the system".

Original issue's description:
> Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during construction and to handle invalidity as a 'unique' origin.
> 
> TBR=mkwst
> BUG=514076
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201022

TBR=jsbell@chromium.org,palmer@chromium.org,mkwst@chromium.org,brettw@chromium.org,michaeln@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=514076,524248

Review URL: https://codereview.chromium.org/1315793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that SkImage sports a lazy-decoding querying API (isLazyGenerated), we no longer
need the external mechanism introduced in http://crrev.com/1253483004.


BUG=523922
R=noel@chromium.org

Review URL: https://codereview.chromium.org/1308233002

git-svn-id: svn://svn.chromium.org/blink/trunk@201099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After landing https://codereview.chromium.org/1298113003/, we have four types
of GC callbacks:

- A callback for a minor GC
- A callback for incremental marking of a major GC
- A callback for atomic pause of a major GC
- A callback for weak processing

This CL distinguishes the four types of GC callbacks in V8GCController::gcPrologue/gcEpilogue.

This CL basically just moves code around. No substantial changes in behavior.

BUG=521946

Review URL: https://codereview.chromium.org/1288683005

git-svn-id: svn://svn.chromium.org/blink/trunk@201098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current flex-grow and flex-shrink interpolation code will not smoothly
interpolate values with 0.
This patch removes this special behaviour as there is no specification text
justifying this behaviour.
Without this behaviour we can simplify the Constraint enum out of AnimatableDouble.

BUG=522817

Review URL: https://codereview.chromium.org/1300323003

git-svn-id: svn://svn.chromium.org/blink/trunk@201097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=475370

Review URL: https://codereview.chromium.org/1313733007

git-svn-id: svn://svn.chromium.org/blink/trunk@201096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change Counter to CSSValueCounter, and remove counters from
CSSPrimitiveValue.

BUG=523893

Review URL: https://codereview.chromium.org/1303153003

git-svn-id: svn://svn.chromium.org/blink/trunk@201095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebDatabase used an extern "C" section to declare the monkey-patching
symbols it uses from our patched SQLite VFS code.  Switch to the items
exported from sqlite3.h.

Additionally, various modules were satisfying an implicit dependency on
icu via SQLite's static library (SQLite needs it for the REGEXP override
in sqlite/src/ext/icu/icu.c).  Change the modules depending on the
sqlite library to also depend on icu, so that sqlite can work with
component build.

BUG=489444

Review URL: https://codereview.chromium.org/1311913002

git-svn-id: svn://svn.chromium.org/blink/trunk@201093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of moved unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1306693007/ )

Reason for revert:
I don't think this contributes any of "too many opened files".
(as is commented bay jianli
https://code.google.com/p/chromium/issues/detail?id=524248#c7 )

Will revert and reland the original patch.



Original issue's description:
> Revert of Removed unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1291873005/ )
> 
> Reason for revert:
> Speculative revert for causing "Too many opened files in the system".
> 
> https://code.google.com/p/chromium/issues/detail?id=523598
> 
> 
> Original issue's description:
> > Removed unused CascadeOrder.
> > 
> > CascadeOrder is always ignoreCascadeOrder after [1] and can be removed.
> > 
> > [1] https://codereview.chromium.org/1298173004
> > 
> > BUG=487125
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201019
> 
> TBR=kochi@chromium.org,rune@opera.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=487125
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201082

TBR=rune@opera.com,jianli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487125

Review URL: https://codereview.chromium.org/1313713005

git-svn-id: svn://svn.chromium.org/blink/trunk@201092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

" ".repeat(10) will produce string with one space in console output.
This CL changed this behavior by replacing white-space:nowrap rule to white-space:pre.

BUG=516989
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1304033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is helpful to let Oilpan report its memory usage at each safe point.

BUG=

Review URL: https://codereview.chromium.org/1315603004

git-svn-id: svn://svn.chromium.org/blink/trunk@201090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200993

BUG=523403
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1309383002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201089 bbb929c8-8fbe-4397-9dbb-9b2b20218538