GitLab

Inline the tiny code left there into LayerTreeHostImpl, delete the
|renderer_| member and change references to the |output_surface_|
instead.

R=enne
BUG=641613
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2323583002
Cr-Commit-Position: refs/heads/master@{#417150}

BUG=

Review-Url: https://codereview.chromium.org/2315923003
Cr-Commit-Position: refs/heads/master@{#417149}

This seems to sometimes be causing videos to initially display black.

BUG=635319
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2314773003
Cr-Commit-Position: refs/heads/master@{#417148}

Revert of Video capture Android: enable unittests for Camera2 API (patchset #5 id:220001 of https://codereview.chromium.org/2286303003/ )

Reason for revert:
Caused WebViewLayoutTest#testMediaStreamApi and MediaAccessPermissionRequestTest#testGrantAccess to consistently fail.

Confirmed locally by reverting patch, commenting out @DisableIf and running:

ninja -C out/Release android_webview_test_apk android_webview_apk && out/Release/bin/run_android_webview_test_apk -f MediaAccessPermissionRequestTest.*

BUG=644910

Original issue's description:
> Video capture Android: enable unittests for Camera2 API
>
> This CL reenables a bunch of VideoCaptureDeviceTest
> test cases for Android and for the "new" APIs
>
> For this:
> - adds a |mTestMode| to VideoCapture.java, interface
>  of all camera java classes. VCCamera2.java tests this
>  flag and adds a capture thread if it's set.
> - the C++ correspondent classes get a method to configure
>  the java side for testing, and a method to test if the
>  underlying platform is using the new or the old APIs.
>
> Also:
> - Removes DeAllocateCameraWhileRunning because it was
>  equivalent to CaptureWithSize test case.
> - Cleans up/refactors some parts of the unit tests, adds
>  a few more comments etc
>
> BUG=626857
>
> Committed: https://crrev.com/7c32b70068c65b7bb372bb52a33d70b8e6653129
> Cr-Commit-Position: refs/heads/master@{#417015}

TBR=jbudorick@chromium.org,emircan@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626857

Review-Url: https://codereview.chromium.org/2320873002
Cr-Commit-Position: refs/heads/master@{#417147}

BUG=644953

Review-Url: https://codereview.chromium.org/2319963002
Cr-Commit-Position: refs/heads/master@{#417146}

On tablets it's possible to end up with a "dummy" tab selected if the
EmptyBackgroundView is showing when a merge is triggered and the currently
"selected" model has no tabs in it. In this case, do not reset
the tab model selection to the model that was selected before the merge.

BUG=644707

Review-Url: https://codereview.chromium.org/2317363002
Cr-Commit-Position: refs/heads/master@{#417145}

BUG=640116

Review-Url: https://codereview.chromium.org/2308973002
Cr-Commit-Position: refs/heads/master@{#417144}

::shadow and /deep/ combinator are deprecated.
We need to use CSS variables instead.

BUG=498405
TEST=manually confirmed that color/opacity doesn't change.

Review-Url: https://codereview.chromium.org/2317113002
Cr-Commit-Position: refs/heads/master@{#417143}

Reland of Mojo C++ Bindings: Additional support for associated binding sets (patchset #1 id:1 of https://codereview.chromium.org/2324623003/ )

Reason for revert:
It seems like linker just occasionally ran out of memory on the buildbot. The CL seems to be innocent.

Original issue's description:
> Revert of Mojo C++ Bindings: Additional support for associated binding sets (patchset #2 id:20001 of https://codereview.chromium.org/2309513002/ )
>
> Reason for revert:
> This broke compilation on Win x64 builder:
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/94511
>
> Original issue's description:
> > Mojo C++ Bindings: Additional support for associated binding sets
> >
> > Implements three orthogonal changes to the public bindings API:
> >
> >  1. Adds the ability to remove bindings from a binding set. Uses
> >     a new mojo::BindingId integer alias to identify added bindings.
> >
> >  2. Adds the ability to set a pre-dispatch hook on binding sets.
> >     In some cases simply making the dispatch_context() available
> >     is insufficient, for example when a consumer owns multiple
> >     binding sets and wants a common path for establishing context
> >     among any of them.
> >
> >  3. Adds mojo::GetDummyProxy, a helper that can bind an
> >     AssociatedInterfacePtr<T> so that it has some valid internal
> >     state and silently drops all outgoing messages. Unlike
> >     regular message pipe interfaces, without this feature
> >     associated interfaces are difficult to stub out in test
> >     environments.
> >
> > Part a series of CLs to enable and demonstrate WebContents associated
> > interfaces:
> >
> >   1. https://codereview.chromium.org/2301123004
> >   2. This CL
> >   3. https://codereview.chromium.org/2310563002
> >   4. https://codereview.chromium.org/2310583002
> >
> > BUG=612500
> > R=yzshen@chromium.org
> >
> > Committed: https://crrev.com/4b8bca190cdc55bae81974aa09cc10f422f022fb
> > Cr-Commit-Position: refs/heads/master@{#417126}
>
> TBR=yzshen@chromium.org,rockot@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=612500
>
> Committed: https://crrev.com/c08a3abcbc9d79e2a7031b116d0af9ee92d17459
> Cr-Commit-Position: refs/heads/master@{#417135}

TBR=yzshen@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612500

Review-Url: https://codereview.chromium.org/2320723003
Cr-Commit-Position: refs/heads/master@{#417142}

BUG=644122

Review-Url: https://codereview.chromium.org/2318033003
Cr-Commit-Position: refs/heads/master@{#417141}

Revert of DevTools: Allow clicks to register in SSP when swatch popover is open (patchset #2 id:20001 of https://codereview.chromium.org/2307463004/ )

Reason for revert:
This breaks editing color swatches within shadow swatches. If you edit the color, and then edit the shadow, it reverts to the original color.

We should further examine the effects of majorChange=true in applyStyleText.

Original issue's description:
> DevTools: Allow clicks to register in SSP when swatch popover is open
>
> Applying the style text to the tree element when the popover is hidden
> causes the section to update, not allowing clicks to register.
>
> It is unnecessary to apply the style text when the popover is hidden
> (unless reverting back to original property text) because the change
> has already been applied.
>
> BUG=644779
>
> Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
> Cr-Commit-Position: refs/heads/master@{#417109}

TBR=lushnikov@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644779

Review-Url: https://codereview.chromium.org/2320533005
Cr-Commit-Position: refs/heads/master@{#417140}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8e6fcd316b9f3551ec6618e39adb516accd0b0f9 Re-add perf-id and results-url. (dtu@chromium.org)

R=dtu@chromium.org
BUG=644370

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320843002
Cr-Commit-Position: refs/heads/master@{#417139}

https://pdfium.googlesource.com/pdfium.git/+log/f56d93f8ea1c..7b68f616e492

$ git log f56d93f8e..7b68f616e --date=short --no-merges --format='%ad %ae %s'
2016-09-07 tsepez Make Observers into a templated class

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2321493003
Cr-Commit-Position: refs/heads/master@{#417138}

Currently in these two functions, we are not using CheckedNumeric. This
CL uses CheckedNumeric to ensure that integer-overflow will not happen

BUG=644271
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2310243002
Cr-Commit-Position: refs/heads/master@{#417137}

The WebRTC related files under chrome/browser/media are
isolated from "the rest" of the folder, i.e. do not include
other files and "the rest" don't include webrtc-related
files; there's 130 files in media/ folder, of which 85
are webrtc-specific, so this CL extracts these WebRTC files
(i.e. having to do with Media Stream, WebRTC, Desktop/Tab
capture and capture permissions) into its own folder.

No new code whatsoever. Splitted OWNERS and DEPS.

TBR= stevenjb@chromium.org for
for chrome/browser/ui/webui/options/media_devices_selection_handler.h
that has a noparent in the OWNERS file, and
anyway says : "# This UI is deprecated."

Review-Url: https://codereview.chromium.org/2307083002
Cr-Commit-Position: refs/heads/master@{#417136}

Revert of Mojo C++ Bindings: Additional support for associated binding sets (patchset #2 id:20001 of https://codereview.chromium.org/2309513002/ )

Reason for revert:
This broke compilation on Win x64 builder:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/94511

Original issue's description:
> Mojo C++ Bindings: Additional support for associated binding sets
>
> Implements three orthogonal changes to the public bindings API:
>
>  1. Adds the ability to remove bindings from a binding set. Uses
>     a new mojo::BindingId integer alias to identify added bindings.
>
>  2. Adds the ability to set a pre-dispatch hook on binding sets.
>     In some cases simply making the dispatch_context() available
>     is insufficient, for example when a consumer owns multiple
>     binding sets and wants a common path for establishing context
>     among any of them.
>
>  3. Adds mojo::GetDummyProxy, a helper that can bind an
>     AssociatedInterfacePtr<T> so that it has some valid internal
>     state and silently drops all outgoing messages. Unlike
>     regular message pipe interfaces, without this feature
>     associated interfaces are difficult to stub out in test
>     environments.
>
> Part a series of CLs to enable and demonstrate WebContents associated
> interfaces:
>
>   1. https://codereview.chromium.org/2301123004
>   2. This CL
>   3. https://codereview.chromium.org/2310563002
>   4. https://codereview.chromium.org/2310583002
>
> BUG=612500
> R=yzshen@chromium.org
>
> Committed: https://crrev.com/4b8bca190cdc55bae81974aa09cc10f422f022fb
> Cr-Commit-Position: refs/heads/master@{#417126}

TBR=yzshen@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612500

Review-Url: https://codereview.chromium.org/2324623003
Cr-Commit-Position: refs/heads/master@{#417135}

This change allows for positionally matched keywords in background-size CSS
Animations. This brings it in line with CSS Transitions behaviour.

Previously CSSSizeListInterpolationType inherited from CSSLengthListInterpolationType,
due to the handling of keywords this is no longer suitable.

BUG=640450

Review-Url: https://codereview.chromium.org/2280553002
Cr-Commit-Position: refs/heads/master@{#417134}

This change decouples the GetECT() API exposed by NQE, and the
logic that dictates when NQE recomputes the ECT. It also makes
GetECT() API light-weight so it can be called more frequently
by consumers (e.g., once per request) without worrying about
the computation overhead.

BUG=639869

Review-Url: https://codereview.chromium.org/2266663002
Cr-Commit-Position: refs/heads/master@{#417133}

The idea is that we invalidate needs_push_properties flag
from bottom-to-top in the hierarchy of ownership.

It helps us to isolate untouched groups of objects.

BUG=604280
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1ec9dd4962683e1fe12734a6756e825df2db10ca
Review-Url: https://codereview.chromium.org/2261113002
Cr-Original-Commit-Position: refs/heads/master@{#414981}
Cr-Commit-Position: refs/heads/master@{#417132}

The browser updates the overlay video mode flag before the renderer can
send a new frame. This means that when switching from fullscreen to
non-fullscreen the browser was expecting the renderer the fill the frame
completely and wasn't drawing the background, but it was accidentally
leaving part of the frame corrupted and uncleared.

BUG=631866
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2302023003
Cr-Commit-Position: refs/heads/master@{#417131}

* Provide a single jumping off point that avoids memory leaks when using
  the OfflinePageDownloadBridge from the menus.

* Provide a single function for determining whether the offline pages button
  should be clickable.

BUG=616324

Review-Url: https://codereview.chromium.org/2322773002
Cr-Commit-Position: refs/heads/master@{#417130}

We're going to start with just NVIDIA Maxwell and Pascal GPUs enabled,
then gradually expand to earlier GPUs once we're sure everything's stabilized.

BUG=643850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2316873002
Cr-Commit-Position: refs/heads/master@{#417129}

BUG=chromedriver:1497
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2315363003
Cr-Commit-Position: refs/heads/master@{#417128}

Revert of Allow canvases to be GPU-accelerated in Workers (patchset #5 id:80001 of https://codereview.chromium.org/2300633004/ )

Reason for revert:
This makes the following tests fail on Linux MSAN bot:

virtual/gpu/fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.html
virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.html

Build link:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12091

Original issue's description:
> Allow canvases to be GPU-accelerated in Workers
>
> This change sets up a per-thread shared GPU context that is managed by
> a thread-specific singleton SharedGpuContext.  This means that all 2D
> contexts on a given worker will use the same context, which avoids
> having to rely on mailboxes all the time.  Also this CL makes deep changes
> to AcceleratedStaticBitmapImage in order to support the use of
> the current thread's shared context, and it handles transfers
> between threads in order to support the transferrable behavior of
> ImageBitmap objects.
>
> BUG=593514
>
> Committed: https://crrev.com/83ac5ff37da4ea1c6d052649ccea46dd4bd453d6
> Cr-Commit-Position: refs/heads/master@{#416929}

TBR=kbr@chromium.org,haraken@chromium.org,junov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593514

Review-Url: https://codereview.chromium.org/2323573002
Cr-Commit-Position: refs/heads/master@{#417127}

Implements three orthogonal changes to the public bindings API:

 1. Adds the ability to remove bindings from a binding set. Uses
    a new mojo::BindingId integer alias to identify added bindings.

 2. Adds the ability to set a pre-dispatch hook on binding sets.
    In some cases simply making the dispatch_context() available
    is insufficient, for example when a consumer owns multiple
    binding sets and wants a common path for establishing context
    among any of them.

 3. Adds mojo::GetDummyProxy, a helper that can bind an
    AssociatedInterfacePtr<T> so that it has some valid internal
    state and silently drops all outgoing messages. Unlike
    regular message pipe interfaces, without this feature
    associated interfaces are difficult to stub out in test
    environments.

Part a series of CLs to enable and demonstrate WebContents associated
interfaces:

  1. https://codereview.chromium.org/2301123004
  2. This CL
  3. https://codereview.chromium.org/2310563002
  4. https://codereview.chromium.org/2310583002

BUG=612500
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2309513002
Cr-Commit-Position: refs/heads/master@{#417126}

Found these eslint errors on the new devtools buildbot I setup!

Right now, the buildbot is configured to be non-blocking (i.e. the errors
don't prevent commits from landing), but eventually it will be.

Eslint errors from buildbot:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_DevTools_Linux%2F475%2F%2B%2Frecipes%2Fsteps%2Frun_eslint%2F0%2Fstdout

BUG=none

Review-Url: https://codereview.chromium.org/2319823002
Cr-Commit-Position: refs/heads/master@{#417125}

This allows the user to disable the magnifier and use the palette while the magnifier is active.

TEST=ash_unittests
BUG=642535

Review-Url: https://codereview.chromium.org/2303963002
Cr-Commit-Position: refs/heads/master@{#417124}

R=nasko@chromium.org
BUG=510836

Review-Url: https://codereview.chromium.org/2312003006
Cr-Commit-Position: refs/heads/master@{#417123}

BUG=635611,635151

Review-Url: https://codereview.chromium.org/2322653002
Cr-Commit-Position: refs/heads/master@{#417122}

BUG=644664
R=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2321683003
Cr-Commit-Position: refs/heads/master@{#417121}

BUG=640375

Review-Url: https://codereview.chromium.org/2314503005
Cr-Commit-Position: refs/heads/master@{#417120}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/391b9e37..5cc438d6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2319313002
Cr-Commit-Position: refs/heads/master@{#417119}

By returning a signed simple challenge that can actually be parsed as SignedData, we allow callers of the FakeCryptohomeClient to extract the original data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass

Review-Url: https://codereview.chromium.org/2297193006
Cr-Commit-Position: refs/heads/master@{#417118}

Ensure that |Thread::id_| is only accessed when an happens-after relationship has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

Also don't AssertWaitAllowed() in WaitableEvent::TimedWait(0) on Windows to allow
WaitableEvent::IsSignaled() to be called on threads which aren't allowed to wait.
From MSDN:
  The time-out interval, in milliseconds. If a nonzero value is specified, the function
  waits until the object is signaled or the interval elapses. If dwMilliseconds is zero,
  the function does not enter a wait state if the object is not signaled; it always returns
  immediately. If dwMilliseconds is INFINITE, the function will return only when the object
  is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng

Review-Url: https://codereview.chromium.org/2303943003
Cr-Commit-Position: refs/heads/master@{#417117}

fraction of the crashes is due to bad font files. This
change adds more last resort fallback fonts in the vague
hope that at least one can be loaded successfully.

BUG=561873

Review-Url: https://codereview.chromium.org/2302663002
Cr-Commit-Position: refs/heads/master@{#417116}

https://chromium.googlesource.com/skia.git/+log/ef6a9b7f9393..14fe8cc16d2a

$ git log ef6a9b7f9..14fe8cc16 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 ethannicholas refactored SkSL VarDeclaration handling GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2312233002

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2320623004
Cr-Commit-Position: refs/heads/master@{#417115}

Add a LayerTreeHostInterface which is implemented by the LayerTreeHost.
This change moves the public methods on the LayerTreeHost used by the
embedder to an interface, in preparation for restricting the use of the
current LayerTreeHost implementation to the case where the compositor
thread componenets run in the same process (a.k.a single threaded and
threaded compositor), and a different implementation can be used where
these are seperated by a network boundary.

Currently only the use of the threaded compositor has been hidden
behind the interface. Subsequent changes will move the single threaded
compositor and the cc_unittests to use the interface as well.

BUG=625283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2317753002
Cr-Commit-Position: refs/heads/master@{#417114}

Sometimes the normal UI font is larger (eg. Hindi text). This code will ensure the Bookmark bar takes this into account and makes the height accommodate it. This eliminates painting artifacts when the Omnibox suggestions dropdown is displayed.

BUG=622678

Review-Url: https://codereview.chromium.org/2208973003
Cr-Commit-Position: refs/heads/master@{#417113}

Official build doesn't output strings on CHECK failures.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2319283002
Cr-Commit-Position: refs/heads/master@{#417112}

Made date input field read "mm", "dd", "yyyy", or equivalents in other languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org, keishi@chromium.org, tkent@chromium.org, avi@chromium.org
TESTED=manually with Jaws

Review-Url: https://codereview.chromium.org/2306383005
Cr-Commit-Position: refs/heads/master@{#417111}