GitLab

Useful in SPDY 4 development.

This lands server change 42070418.


Review URL: https://chromiumcodereview.appspot.com/12259003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182408 0039d316-1c4b-4281-b951-d872f2087c98

Inspection of stack prepared by caller shows it is indeed copying dword, not qword, for 32-bit arguments on Win64, and the background stack is not zeroed.

Incorrect function result, access violations or worse (not-immediately caught side effect of corrupted memory within process address space) could easily result from current win64 usage of these routines.

One solution, implemented here, is to change the function prototypes for the yasm routines to take ptrdiff_t arguments instead of int args.  The C version of the equivalent code needs matching prototype (due to the choose proc routines), so they are updated too.

Another, probably slightly less performant, solution would be to change the asm routines to conditionally sign-extend when loading int (32-bit) parameters on x64.  None of these routines currently use int passed in directly as register; I  don't know if zero-extension of registers would be required if they did.

Yet another solution would be to switch to VS2012 and redo the yasm routines using compiler intrinsics completely (not supported in VS2010).

Note, some other media_unittests, namely those involving ffmpeg, currently give access violation on Win64.  There is a separate ffmpeg fix in progress https://gerrit.chromium.org/gerrit/#/c/43063/.  With PS1 or PS2 applied along with the ffmpeg fix, Win64 media_unittests pass.

Detail:
The following are sign-extended in prototype:
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertARGBToYUVRow_SSSE3
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertRGBToYUVRow_SSSE3
simd/convert_yuv_to_rgb_mmx.asm:%define SYMBOL ConvertYUVToRGB32Row_MMX
simd/convert_yuv_to_rgb_sse.asm:%define SYMBOL ConvertYUVToRGB32Row_SSE
simd/scale_yuv_to_rgb_mmx.asm:%define SYMBOL ScaleYUVToRGB32Row_MMX
simd/scale_yuv_to_rgb_sse.asm:%define SYMBOL ScaleYUVToRGB32Row_SSE
simd/scale_yuv_to_rgb_sse2_x64.asm:%define SYMBOL ScaleYUVToRGB32Row_SSE2_X64
simd/linear_scale_yuv_to_rgb_mmx.asm:%define SYMBOL LinearScaleYUVToRGB32Row_MMX
simd/linear_scale_yuv_to_rgb_sse.asm:%define SYMBOL LinearScaleYUVToRGB32Row_SSE
simd/linear_scale_yuv_to_rgb_mmx_x64.asm:%define SYMBOL LinearScaleYUVToRGB32Row_MMX_X64

The following C versions and the corresponding typedefs also needed updating to match:
ConvertYUVToRGB32Row_C
ScaleYUVToRGB32Row_C
LinearScaleYUVToRGB32Row_C

The following yasm routines have no C prototype, nor do they appear to be used anywhere.  I updated their comments though to match the same prototype change that would be necessary.
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertARGBToYUVEven_SSSE3
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertARGBToYUVOdd_SSSE3
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertRGBToYUVEven_SSSE3
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertRGBToYUVOdd_SSSE3

BUG=174160
TEST=with https://gerrit.chromium.org/gerrit/#/c/43063/ also applied, all win64 media_unittests non-disabled test cases pass
R=hclam@chromium.org
R=dalecurtis@chromium.org
R=rbultje@chromium.org
CC=jschuh@chromium.org
CC=scherkus@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12211067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182407 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12207167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182406 0039d316-1c4b-4281-b951-d872f2087c98

> [Cleanup] Files.app: Fill 'TODO' comments to missing descriptions in @param annotation.
> 
> This suppresses 'E:0210: Missing docs for parameter' errors from closure linter.
> 
> All changes are in comment, hence I believe this patch doesn't change any behavior.
> 
> BUG=175657
> TEST=none
> TBR=mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/12261008

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/12255028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182405 0039d316-1c4b-4281-b951-d872f2087c98

This significantly reduces the context switching overhead for
impl-side painting.

Instead of posting reply task to the impl thread after completing
each raster job, post a reply only when worker pool becomes idle
and poll for completed tasks at a 6ms interval.

This doesn't just make rasterization more efficient but also
reduces the number of shallow flushes, which makes async uploads
more efficient.

BUG=173802

Review URL: https://codereview.chromium.org/12217105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182404 0039d316-1c4b-4281-b951-d872f2087c98

When the surface is created from GpuCommandBufferStub, it is
made current for the very first time while
helper_->stub()->decoder()->GetGLContext() returns NULL (see order
in GpuCommandBufferStub::OnInitialize()).

If we then handle drawing and swapping of a frame while
a) the context is still current and we avoid calling
Surface::OnMakeCurrent() again
b) the surface is destroyed right after with the ack pending,
it is possible for context_ to be NULL in BufferPresentedImpl.

With virtual contexts, this patch causes us to hold a reference
to the real GL context instead now, which is fine because we only
need the context to delete the backbuffer texture during destruction.

BUG=169429

Review URL: https://codereview.chromium.org/12252028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182403 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses 'E:0210: Missing docs for parameter' errors from closure linter.

All changes are in comment, hence I believe this patch doesn't change any behavior.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12261008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182402 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=sky,bauerb

Review URL: https://chromiumcodereview.appspot.com/12260035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182401 0039d316-1c4b-4281-b951-d872f2087c98

We can't reference-count shared memory regions in the GPU
process, so we dup/map the memory block for each upload.
This doesn't scale for small uploads, both because we can
use too many file descriptors, and use too much address
space when the small upload transfer buffers are contained
in larger shared memory blocks.

This limits the total number of uploads to prevent the
problem, but this should be fixed properly and this limit
removed.

BUG=176002

NOTRY=True
Since it's a CC only change and unit tests have passed.


Review URL: https://chromiumcodereview.appspot.com/12260033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182400 0039d316-1c4b-4281-b951-d872f2087c98

With this API, users of component_updater can trigger an
update or install when deemed important.  E.g., if a
component is not yet installed, but is about to be used.

There is not a guarantee that the item will actually
be updated.  There is only a good chance.  It can
still be preempted by other items that may have an update
available as well, or if multiple components
use this interface one will trump the others.

Use this to kick off a check of PNaCl if flag enabled, but
not yet installed.

Sort of related to:
BUG=107438

Review URL: https://codereview.chromium.org/12054003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182399 0039d316-1c4b-4281-b951-d872f2087c98

Resolutions AsValue did not recognize NON_IDEAL_RESOLUTION

Call rate of PictureLayerTiling::UpdateTilePriorities is very high. Dont trace it.

R=ccameron
BUG=176150

Review URL: https://codereview.chromium.org/12253021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182398 0039d316-1c4b-4281-b951-d872f2087c98

And some cosmetic changes in other Instant files.

BUG=none
R=jered@chromium.org,sky@chromium.org
TEST=none; no change in functionality.


Review URL: https://chromiumcodereview.appspot.com/12256029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=No DCHECK failure on uploading 2GB+ files with Debug build

Review URL: https://codereview.chromium.org/12217165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182394 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dsinclair@chromium.org
BUG=176210
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12212183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/12217049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182392 0039d316-1c4b-4281-b951-d872f2087c98

Before, the labels were not properly aligned. This patch aligns them by simplifying the css.

TEST=Enter Files.app, check carefully the headers. Click on the 'select all' checkbox.
BUG=175962

Review URL: https://codereview.chromium.org/12262032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175802


Review URL: https://chromiumcodereview.appspot.com/12223124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174219

Review URL: https://codereview.chromium.org/12225163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182388 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses 'E:0214: Missing description in @return tag' errors from closure linter.

All changes are in comment, hence I believe this patch doesn't change any behavior.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12212160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182387 0039d316-1c4b-4281-b951-d872f2087c98

This Cl adds missing '@return' annotations of JSdoc. The description leaves '//TODO(JSDOC)'.

All the changes are in comment. I believe this change doesn't affect any behavior.

BUG=175657
TEST=none
TBR=mtomazs@chromium.org

Review URL: https://codereview.chromium.org/12254003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182386 0039d316-1c4b-4281-b951-d872f2087c98

Active network is marked as PROXY_AUTH_REQUIRED only after 3
consecutive failing attempts. This gives enough time for the network
stack to connect to the proxied network after proxy authenication.

BUG=174061
TEST=unit_tests:NetworkPortalDetectorTest.*


Review URL: https://chromiumcodereview.appspot.com/12263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182385 0039d316-1c4b-4281-b951-d872f2087c98

Also make it impossible to call AddObserver on an individual list from outside BrowserList.
This is to make sure the paradigm becomes that the consumer code is in charge of checking for HostDesktopType (should he care) upon receiving an event; allowing AddObserver to be called on an individual list would put burden on the reader to understand whether the events are coming from multiple browser lists or a single one (which seems unecessary for now).

BUG=129187


Review URL: https://chromiumcodereview.appspot.com/12258019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182384 0039d316-1c4b-4281-b951-d872f2087c98

Reverts changes made to template_url.* in http://crrev.com/178755.

BUG=170390
R=dhollowa@chromium.org,pkasting@chromium.org,sky@chromium.org
TEST=none; no visible changes.


Review URL: https://chromiumcodereview.appspot.com/12250033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182381 0039d316-1c4b-4281-b951-d872f2087c98

Update some #includes in content/browser/dom_storage for headers that have been moved to the new Platform directory upstream

Review URL: https://chromiumcodereview.appspot.com/12226037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182380 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to propagate it to the directory so that the client-side
web-app can identify out-of-date hosts, as discussed in the referenced bug
(option 3 in Renato's comment).

BUG=173502


Review URL: https://chromiumcodereview.appspot.com/12221123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182379 0039d316-1c4b-4281-b951-d872f2087c98

Replace last couple of instances by chrome::GetTotalBrowserCount() as in https://codereview.chromium.org/12212120/.

oom_priority_manager.cc is ChromeOS only and thus only needs to care about the ash browser list.

BUG=129187

Review URL: https://chromiumcodereview.appspot.com/12211139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182378 0039d316-1c4b-4281-b951-d872f2087c98

Useful in SPDY 4 development.

This lands server change 420065749.

Review URL: https://codereview.chromium.org/12256004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182377 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182375 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=142795&stop_rev=142724&verbose=on

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/12262021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182374 0039d316-1c4b-4281-b951-d872f2087c98

The previous (x) button was very tiny - 16x16 pixels, which may be too small when using a touchpad.
This patch modifies css so the x button's clickable area is extended to the surrounding paddings. As a result, it is much easier to cancel an operation.
Along the way, simplified css for actions.

TEST=Copy a large file and try to cancel. Also delete to check if Undo link is not broken.
BUG=175950

Review URL: https://codereview.chromium.org/12218135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182373 0039d316-1c4b-4281-b951-d872f2087c98

> Base: Disable the scoped handle verifier.
> 
> This cl is intended for the beta branch.
> 
> BUG=176188
> TEST=none
> Review URL: https://codereview.chromium.org/12230034

TBR=rvargas@google.com
Review URL: https://codereview.chromium.org/12212181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182372 0039d316-1c4b-4281-b951-d872f2087c98

Fixed misnamed function call in popup.js in Chrome Extension tutorial from kittensOnFlickr_ to searchOnFlickr_.

http://developer.chrome.com/extensions/getstarted.html
http://developer.chrome.com/extensions/examples/tutorials/getstarted/popup.js


BUG=172849

Review URL: https://chromiumcodereview.appspot.com/12207102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182371 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration test SyncErrorTest.XmppAuthErrorTest was flaky on Mac due to typed_url_data_type_controller.cc not being able to access the history service.

It appears that recent changes have fixed the flakiness, and the test passes with large --gtest_repeat numbers. Enabling this once the trybots are satisfied.

BUG=165328
TEST=SyncErrorTest.XmppAuthErrorTest

Review URL: https://codereview.chromium.org/12252029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
R=ben@chromium.org

Review URL: https://codereview.chromium.org/12212013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182369 0039d316-1c4b-4281-b951-d872f2087c98

lack this property.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182368 0039d316-1c4b-4281-b951-d872f2087c98

This cl is intended for the beta branch.

BUG=176188
TEST=none
Review URL: https://codereview.chromium.org/12230034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/12251002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=3541


Review URL: https://chromiumcodereview.appspot.com/11573066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174047


Review URL: https://chromiumcodereview.appspot.com/12263007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182363 0039d316-1c4b-4281-b951-d872f2087c98

Previouly we removed it from Win8 but it is really just something
that is experimental and now that Aura is deployed we don't want
the casual user to play with it. Accelerator entry is gone as well.

The menu entry is kept in debug mode

BUG=175036
TEST=menu entry is gone in canary, see bug
Review URL: https://codereview.chromium.org/12251009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182362 0039d316-1c4b-4281-b951-d872f2087c98