- 03 Aug, 2018 40 commits
-
-
Brian Sheedy authored
This reverts commit df2048be. Reason for revert: Causing gclient sync failures https://crbug.com/870845 Original change's description: > android: build: Use .pydeps file to store Python dependencies. > > ProTip: start by looking at the pythonic_action() definition > in internal_rules.gni to review changes in this CL. > > This CL tries to make "gn analyze" smarter by ensuring that > it knows about Python module dependencies, for any python > script under //build. > > At the moment, these dependencies are computed by > build_utils.WriteDepFile() automatically (unless the > add_pydeps=False argument is passed). This adds all imported > module paths to the generated .d file written by the script. > > Unfortunately, because this .d file is generated by the > actions, the corresponding Python sources are not part of > the target's inputs, known by GN at parse time, and thus do > not appear in "gn analyze" properly. > > This CL tries to solve the problem by adding a new template > named "action_with_pydeps", which acts as "action", but also > expects a foo.pydeps file for every foo.py invoked through > the 'script' scope variable. > > This '.pydeps' file is read directly at GN parse time and > added to the action's target inputs. > > These .pydeps contain the path of each imported module, one > per line, and are generated with build/print_python_deps.py > > Benchmarking shows no significant difference in the time > taken to perform a "gn gen out/Release" on a full Chrome > for Android checkout. > > + Add --inplace option to print_python_deps.py in order to > make its usage more human-friendly (the new mode cannot > become the default because PRESUBMIT.py depends on the > current behaviour). > > + Remove some --depfile options on a few Python scripts that > don't need it anymore (e.g. when their inputs and outputs > are now fully known by GN at parse time). > > + Remove uses of compute_inputs_for_analyze in rules.gni and > internal_rules.gni (as well as exec_script() calls to > print_python_deps.py). Note that the variable itself is still > needed for grit inputs, see tools/grit/grit_rule.gni for > details). > > BUG=NONE > R=agrieve@chromium.org > > Change-Id: I8d7c07ab93b032fdc0c7f9dbeb2173767f52eeff > Reviewed-on: https://chromium-review.googlesource.com/1131190 > Commit-Queue: David Turner <digit@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580545} TBR=digit@chromium.org,agrieve@chromium.org,estevenson@chromium.org Change-Id: I626eb8997c8808fc91aec9115287be34d17d493e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: NONE Reviewed-on: https://chromium-review.googlesource.com/1162522Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580639}
-
Melisa Carranza Z authored
Bug: b/111886441 Test: Successfully cast DRM content to an Android device with CMA audio enabled. Change-Id: Ica7ef53f25a5ff305a7726cebe4fca511a43502d Reviewed-on: https://chromium-review.googlesource.com/1152464Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Melisa Carranza Zúñiga <melisacz@google.com> Cr-Commit-Position: refs/heads/master@{#580638}
-
Jun Mukai authored
ui::CreateInputMethod is called implicitly within the Setup of AshTestBase (somewhere within ash::Shell::Init()), which conflicts with ui::SetUpInputMethodFactoryForTesting(). So the CHECK fails if TextInputTest runs along with other tests in exo (i.e. without gtest_filter flags). Actually SetUpInputMethodFactoryForTesting can be called for every tests in exo, so that is moved there. BUG=870690 TEST=exo_unittests succeed without --gtest_filter flag Change-Id: I9e9bb009b7b5af3715759ee29ac6c94f9614eecf Reviewed-on: https://chromium-review.googlesource.com/1162621Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#580637}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. Looking at this code, I don't think we can escape the SERIAL_EXECUTOR here, since there appears to be non-thread-safe things happening in the AsyncTasks, and no guarantee they won't get scheduled at the same time. Bug: 869907 Change-Id: I7c1e1a74e48c2d2e774d71e04d89a83c02562e5b Reviewed-on: https://chromium-review.googlesource.com/1162662Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#580636}
-
Rohit Rao authored
This reverts commit 3b42f46a. Reason for revert: Crashing internal bots Test Case '-[GoogleServicesSettingsTestCase testOpeningServicesWhileSignedInAndConsentGiven]' started. 0803/040411.392060:FATAL:unified_consent_service.cc(155)] Check failed: identity_manager_->HasPrimaryAccount(). 0 ios_chrome_unified_consent_egtests 0x000000010d19df38 base::debug::StackTrace::StackTrace(unsigned long) + 72 1 ios_chrome_unified_consent_egtests 0x000000010d19df9d base::debug::StackTrace::StackTrace(unsigned long) + 29 2 ios_chrome_unified_consent_egtests 0x000000010ce8adac base::debug::StackTrace::StackTrace() + 28 3 ios_chrome_unified_consent_egtests 0x000000010ced068b logging::LogMessage::~LogMessage() + 315 4 ios_chrome_unified_consent_egtests 0x000000010cecf495 logging::LogMessage::~LogMessage() + 21 5 ios_chrome_unified_consent_egtests 0x000000011054785e unified_consent::UnifiedConsentService::OnUnifiedConsentGivenPrefChanged() + 638 Original change's description: > [iOS] Start unified consent service at startup > > Bug: 827072 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I2f2e14ceba73ebecbc9c0222ae87ea86e4f91a49 > Reviewed-on: https://chromium-review.googlesource.com/1159062 > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580485} TBR=msarda@chromium.org,sdefresne@chromium.org,jlebel@chromium.org Change-Id: I4d94ba1e7630c81f666d336882c17c993ac5ef02 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1162402Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580635}
-
Miguel Casas authored
This CL adds TRACE_EVENT0() to some important CanvasResourceDispatcher methods: DispatchFrame{Sync}() and PrepareFrame(), which are now used more frequently, for lowLatency cases. Bug: 869161 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I66dfd2f47eaba0183d34c5e1f09f759d6f0fcf1b Reviewed-on: https://chromium-review.googlesource.com/1161974Reviewed-by:Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#580634}
-
Artur Khachatryan authored
Change-Id: I8998c03e69247f53bc183bac631b891eada88784 Reviewed-on: https://chromium-review.googlesource.com/1162623Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580633}
-
David Black authored
Per the spec, the query view should remain at the bottom of the UI container until the response is received. To accomplish this, this CL: - Adds active_query_view_ pointer. The lifetime of a query view is now: - pending_query_view_: created when query is pended. - committed_query_view_: pointer swapped when query is committed. - active_query_view_: pointer swapped when query response is received. A committed query that is aborted will not reach the "active" state when the motion spec is enabled. To prevent regression of current UI behavior, when the motion spec is disabled we immediately "activate" a query when it is committed. See bug for spec/demos. Bug: b:112114187 Change-Id: Icea7ebccc9f0a5aa554c88d969fa79000855b9db Reviewed-on: https://chromium-review.googlesource.com/1159826 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580632}
-
Kurt Horimoto authored
This CL adds GridLayout.animatesItemUpdates, which can be used to disable animations from occurring when items are inserted or removed. This is done to prevent the interleving of the new tab insertion animation and the tab presentation animation. Bug: 864982 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7867fc475a6d399a8ecbe45df456fd6082f6d8eb Reviewed-on: https://chromium-review.googlesource.com/1161560Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580631}
-
Roberto Carrillo authored
This reverts commit 2e803140. Reason for revert: speculative revert, seems to have introduced the following failure: https://bugs.chromium.org/p/chromium/issues/detail?id=870827 Original change's description: > chromeos: splits ash's file list into public/sources sections > > I'm putting all the '.h' files into public. We can refine the list as necessary > later. > > I'm doing this as I would like to have private headers that other targets can't > include (well, except tests). > > BUG=none > TEST=none > > Change-Id: I84ab155a1449d969076dcd94feaa0150f3e9ad85 > Reviewed-on: https://chromium-review.googlesource.com/1161498 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580581} TBR=jamescook@chromium.org,sky@chromium.org Change-Id: Icfed283e1b854f9639fe111fbd83b948b8d6147f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/1162207Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#580630}
-
Farah Charab authored
Extend resource fetch priority experiment to support being enabled only in the loading use case. Bug: 870349 Change-Id: I980f078f3a48bc7ab240e475869125d6dc9ffa55 Reviewed-on: https://chromium-review.googlesource.com/1159064Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#580629}
-
Becca Hughes authored
Fix resize observer crash in PiP interstitial when we detach, re-attach and detach the video element. BUG=870449 Change-Id: I6989587384cf34c5b6da8cbaec3ab8ca48b58f94 Reviewed-on: https://chromium-review.googlesource.com/1162514Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580628}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/51da39f993c8..fb6f97363738 git log 51da39f993c8..fb6f97363738 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 athilenius@google.com Move betty-inremental from baremetal to GCE Created with: gclient setdep -r src/third_party/chromite@fb6f97363738 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I335c7bd1d8f34d162f090a59117949b17a3c6e0b Reviewed-on: https://chromium-review.googlesource.com/1162383Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580627}
-
Jennifer Apacible authored
The WM_SIZING message is now handled by HWNDMessageHandler. When the aspect ratio is set for a window on Windows OS, the handler will adjust the final RECT bounds to adhere to the given aspect ratio. Bug: 853276 Change-Id: I54099581012d3f59e3d0535ed1285a25bb512cd9 Reviewed-on: https://chromium-review.googlesource.com/1136226 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#580626}
-
Jian Li authored
Launch bug: 863984 Bug: 865140 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I021aa78fd002dc74a8c9965afce1906bdff7acdb Reviewed-on: https://chromium-review.googlesource.com/1161217 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580625}
-
Bence Béky authored
Modify ownership model of |int64_t* start| in PartialData::ShouldValidateCache() and PartialData::GetAvailableRangeCompleted(). Previously ownership was passed into a callback, which outlived the GetAvailableRange() call. However, when using a CompletionOnceCallback, that is destroyed as soon as GetAvailableRange() returns asynchronously, so a different ownership model is needed for |start| to provide the same lifetime guarantee. Bug: 807724 Change-Id: Ibd4bae1be23d6570618d2abdb93e398cd97c35e6 Reviewed-on: https://chromium-review.googlesource.com/1161963Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#580624}
-
John Abd-El-Malek authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1156566 with fixes in the fake test class for Mac debug flake in 2 tests. TBR=nasko Bug: 800212 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3e60cba6c6d501855b0197d891aea4c769a4361 Reviewed-on: https://chromium-review.googlesource.com/1162263 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580623}
-
Gabriel Charette authored
[TaskScheduler] Forward all public TaskScheduler headers to forwarding headers in preparation for source move Core move CL : https://chromium-review.googlesource.com/c/chromium/src/+/1161088 Move strategy : 1) Rebase this CL on ToT and mass migrate all callers of public base/task_scheduler headers to their matching *_forward.h header. 2) Land core move CL 3) Mass migrate away from *_forward.h headers in https://chromium-review.googlesource.com/c/chromium/src/+/1161116 This move strategy was chosen to keep as much git history as possible in (2). See code comments on forward headers for details. Once this CL and its follow-ups are approved, I will sync it to top-of-tree, mass migrate all existing users of these headers to their *_forward.h version in this CL (TBR'ed) and follow-up with the other two swiftly back-to-back. TBR=robliao@chromium.org (for mass migration of existing callers) Bug: 867421 Change-Id: Iea684e022181c0611abe7f92629599afc369822b Reviewed-on: https://chromium-review.googlesource.com/1161179 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#580622}
-
Amy Qiu authored
Since it's been a week after refreshing pathological_mobile_sites, remove the old pages. Bug: 852530 Change-Id: I75096a10510f8d9bec5838deeb6dcd00e0c55fc0 Reviewed-on: https://chromium-review.googlesource.com/1162344Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#580621}
-
Xiaohan Wang authored
The EME spec requires the order of some events. For example, after update() [1], we should "run the Update Expiration algorithm on the session, providing expiration time", then "resolve promise with true". The former is part of the ContentDecryptionModuleClient interface, while the latter is a callback on the ContentDecryptionModule interface. To preserve the order, this CL uses associated interface [2] to ensure message ordering. [1] https://w3c.github.io/encrypted-media/#dom-mediakeysession-update [2] //src/mojo/public/cpp/bindings/README.md#Associated-Interfaces Bug: 869550 Test: CDM_10/ECKEncryptedMediaTest.MessageTypeTest/0 working, see Bug Change-Id: I1afd1657581f83347235357fb26972a6ba657f1c Reviewed-on: https://chromium-review.googlesource.com/1162309Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#580620}
-
Alexis Hetu authored
The gl renderer for all chromium tests was recently changed from OSMesa to SwiftShader. OSMesa offers a synchronous API to OpenGL, while SwiftShader is asynchronous (draw calls are received and yield before the drawing operation is complete, letting chromium resume its execution). Because of this it seems like the affected MacOS tests here can become idle while rendering is happening in the background, causing the tests to fail. To solve this, we need to actually wait for drawing to be completed, rather than waiting for an idle period, in order to resume the test. Doing this allows these tests to pass. R=ccameron@chromium.org Bug: chromium:870465 Change-Id: I6f1555b93a83d80b06e72b3a469c01dde44e1312 Reviewed-on: https://chromium-review.googlesource.com/1162350 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#580619}
-
Yue Li authored
Bug: None Test: Manual Test Change-Id: Ia0ab2867db8b047049534632d4ffdbc6e618ce56 Reviewed-on: https://chromium-review.googlesource.com/1162508Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#580618}
-
Chris Lu authored
ApplicationCommands conforms to BrowsingDataCommands, but we need to explicitly dispatch them still. Change-Id: I02dbf849677c7391a6a123917f7773d2330be003 Reviewed-on: https://chromium-review.googlesource.com/1162279Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#580617}
-
Bruce Dawson authored
test_process.exe was being linked with /SUBSYSTEM:CONSOLE, despite being a windowed app with a wWinMain entry point. With lld-link.exe this seems to work fine, suggesting that lld ignores the/SUBSYSTEM flag. lld-link may change this behavior (https://bugs.llvm.org/show_bug.cgi?id=38397) so it seems worthwhile to fix the build flags for this executable. Doing so will also be less confusing. Bug: 869503 Change-Id: I52a61aab678fa135f3da8c10bc82a4cdf649b5ae Reviewed-on: https://chromium-review.googlesource.com/1157656 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580616}
-
Peter Kasting authored
This provides a consistent alignment point for theme authors, makes some themes (e.g. Dots) look correct (other themes want other values, e.g. 0, so there's no one "right way" here), and prevents mirroring above the top of the frame image in Refresh, since no mode has a frame height above the tabs > 16 DIP. Bug: 866671 Change-Id: I1d79627e2735d54a332013ee70a2c71f107a898f Reviewed-on: https://chromium-review.googlesource.com/1157878 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#580615}
-
Christian Fremerey authored
The logic deciding if the service is enabled and if it is to be run in the Browser process or a dedicated utility process is currently distributed in two methods each returning boolean. These two methods are never supposed to both return true. To make this more clear and avoid it from happening in future changes, use an internal enum. Bug: 721812, 870819 Change-Id: I32572dca80d1a687e0b292c26e1364d6d01d3585 Reviewed-on: https://chromium-review.googlesource.com/1162434 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580614}
-
Emircan Uysaler authored
This CL completes a TODO in media_stream_controls.h, by switching from std::string to MediaStreamType. Accordingly, it changes related mojo files, renderer side UserMediaProcessor and browser side MediaStreamManager. This will let us add new MediaStreamTypes for request in follow-up CLs. Bug: 326740 Change-Id: I13e2613c190d342c95f084b3a06933a9458a12a8 Reviewed-on: https://chromium-review.googlesource.com/1159839Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580613}
-
Kevin Schoedel authored
This is a step toward congruence between touch exploration on cast and cast system gesture handling. TouchExplorationManager can be persistently installed as an EventRewriter, avoiding the problem of TouchExplorationController appearing too late in the chain. Also removes some dead code. Bug: b/112073644 Test: manual Change-Id: I29b20c880c3fccce413f2f2ace981899cdcb9f9b Reviewed-on: https://chromium-review.googlesource.com/1160876 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#580612}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6027ed1df0b..27928c385ec6 git log f6027ed1df0b..27928c385ec6 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 wangge@google.com Add Failback for `chrome.gpuBenchmarking.pageScaleFactor` Created with: gclient setdep -r src/third_party/catapult@27928c385ec6 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866881 TBR=sullivan@chromium.org Change-Id: Id597e4f161e9c44b79c86132ee408695fd4c6d7c Reviewed-on: https://chromium-review.googlesource.com/1162382Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580611}
-
Piotr Pawliczek authored
Inside the method mentioned above we were not able to distinguish between manual and automatic printer installation. As a result in both cases the event metrics::PrinterEventProto::SETUP_MANUAL was reported and the event metrics::PrinterEventProto::SETUP_AUTOMATIC has never appeared in logs. To solve this problem I have added bool parameter is_automatic to the method that carries information about a type of printer installation. It allows to distinguish between these two cases and report a correct event. BUG=chromium:829542 TEST=tested manually on nautilus chrombook Change-Id: I8d1f3bf70b9b218a734726f2fb1b8ab2af537184 Reviewed-on: https://chromium-review.googlesource.com/1161099Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580610}
-
bsheedy authored
Only updates the VR controller's previous button states if the controller is connected. This fixes some flakiness with VR tests caused by the controller briefly disconnecting then reconnecting. Bug: 870031 Change-Id: If1e0e8807120e9ddba94c05b651ae553b1e4f60b Reviewed-on: https://chromium-review.googlesource.com/1159273Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580609}
-
Kyle Horimoto authored
The MultiDeviceSetup service is now responsible for owning these preferences. See go/cros-multidevice-prefs for details. Bug: 824568 Change-Id: I14fe45058585c00087d1aed88392c451bc79a6ed Reviewed-on: https://chromium-review.googlesource.com/1161337 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#580608}
-
Theresa authored
BUG=869688 Change-Id: I3d42473540556fde6b39ff3fc6d16127ed33ca3e Reviewed-on: https://chromium-review.googlesource.com/1162435Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#580607}
-
Fredrik Hubinette authored
Bug: 647725 Change-Id: I8c5ca15c75e2a0114a39f6eed64fec5fbd863b7c Reviewed-on: https://chromium-review.googlesource.com/1161321Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#580606}
-
David Black authored
The motion spec dictates that the stage should not be cleared when a new query is committed. Instead, the previous query response should fade out while we wait for the next response to come in (which should also be animated). This CL does not implement the entire motion spec, only the portion that fades out the previous query response while we are waiting for the next response to arrive. Changes are guarded behind kIsMotionSpecEnabled. See bug for spec/demo. Bug: b:112091713 Change-Id: I88cb4703f8b8b697ce87ac5a70162853d8826244 Reviewed-on: https://chromium-review.googlesource.com/1159223Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#580605}
-
Wez authored
Migrate the net::NetworkChangeNotifier implementation for Fuchsia off of using the deprecated fuchsia::netstack::NotificationListener to receive network interface change events, to use the OnInterfacesChanged event on the netstack::Netstack interface, instead. TBR=eroman Change-Id: I492a05209a27a6c5d41220b82b6bcd07dae407eb Reviewed-on: https://chromium-review.googlesource.com/1162305Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580604}
-
Michael Thiessen authored
Now that all VR code is behind the VR module, the VrClassesWrapper and a bunch of other interfaces are redundant. TBR=yfriedman@chromium.org Bug: 862639 Change-Id: I52d10c319a255515469414346c4f3730084bd617 Reviewed-on: https://chromium-review.googlesource.com/1161110Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#580603}
-
Artur Khachatryan authored
Change-Id: I247dd746fd2e559d8e2d752ff7878e68fb54846f Reviewed-on: https://chromium-review.googlesource.com/1162501Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580602}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ecae0ae..12c70426 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6cd8703cf3635fc5a5c1cb984de0b57c16e25c2b Reviewed-on: https://chromium-review.googlesource.com/1162307Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580601}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0856d23e. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22272 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/workers TBR=foolip No-Export: true Change-Id: I7c4b226374d3e80ccccef3f2a4c3a0e35b6a4476 Reviewed-on: https://chromium-review.googlesource.com/1162273 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580600}
-