GitLab

Disable CacheStorageManagerTest.TestErrorInitializingCache in Fuchsia
(flaky).

TBR=wanderview@chromium.org

Bug: 989313
Change-Id: I18802fc677a99b9a83fc99a356f7c02ff568d11b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729150Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682694}

Disable ContextProviderImplTest.CleansUpContextJobs in Fuchsia (flaky).


TBR=scottmg@chromium.org

Bug: 989085
Change-Id: Ief0416fc1f348a8d275dbfc0b8e53281dee09bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729209Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682693}

Bug: 968047
Change-Id: Ibae113c025e4db430980c75932b8625657d096ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728564
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682692}

ResurrectingPreFinalizer was defined in two different tests that may be packed
in the same jumbo file. They do not exactly belong to the same namespace (blink
and blink::anonymous) but the definition is ambiguous for the compiler.

Renamed it to HeapTestResurrectingPreFinalizer and moved to an anonymous
namespace, which is not strictly required, but it's a good practice.

Bug: 989452
Change-Id: I7717cf87a064e71fa4bc260f5a8add4f04045b6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728662Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#682691}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=guidou@chromium.org, mcasas@chromium.org

Bug: 968047
Change-Id: Ie59c787e758dba8d2d280abdf337cca18df3f0d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729069
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682690}

Bug: 987763
Change-Id: I891e4143b2d0dfe7e0ac0c05e448e61122a6b6ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724650Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682689}

The ancestor chain is the flat tree ancestors chain. There is no need to
include the shadow roots. The layout tree rebuild root is never the
Document, always an element or text node.

This is done in preparation for flat tree style recalc.

Bug: 972752

Change-Id: I011ad734c02dfa8e09ebf068dd6424d77a4a6e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727290Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682688}

Users may request to close a browser window using close requests
originated from Wayland compositors. These requests can be envoked
by Mod+Shift+Q, for example.

The API responsible for this feature is the listener interface of
xdg_v5 and zxdg_v6 surfaces.

We have already had a dumb implementation for them, but the calls
have not been plumbed. Thus, just forward the calls to the
WaylandWindow and that's it.

Bug: 989043
Test: WaylandWindowTest.OnCloseRequest
Change-Id: I748fa93738900313013a0c4f48a709f28c24c352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728549
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#682687}

Using wpt-import in Chromium 9518eef8.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ia5d985ef1eacc5cd948b129066476f176fc03454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728450Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682686}

font-variation-settings is 'normal' or a comma-delimited
list of string - number pairs.

Each string is 4 characters.

https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def


Change-Id: I9ecd80be68a1575647f4dc64864640bc36ee2b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728583
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682685}

This also eliminated the last caller to LengthInterpolationFunctions::
Composite (out of necessity), hence the two ::Composite* functions
were unified.

Bug: 981024
Change-Id: I197ad0fd246d7aabff08b326e1ee3d9e4520ee35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722941
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682684}

BUG=972848

Change-Id: I34460845917cf1032ddba9198eb0593a68c7a42b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723931Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#682683}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6697895fb46b..bf1198869aba


Created with:
  gclient setdep -r src-internal@bf1198869aba

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I67603d509afcad398f8069d749e3fa7c80b31c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729049Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682682}

Creates a new target and file with omnibox EG tests. Adds some tests.

Bug: none
Change-Id: I7e65439aaa706947124d854e49e7e08b84b8cc23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649505
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682681}

This includes moving all related functions and members.

This has a potential of reproducing this bug: https://crbug.com/957212.

The bug was initially produced after a big CL was landed that included
some changes from this CL. But due to the size of the changes, it was
hard to point out what the actual problem was.

Bug: 916537
Change-Id: I2c8b11f82e5b5197976b3cdb15de40f3032e68ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720775
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682680}

PR landed: https://github.com/w3c/csswg-drafts/pull/4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682679}

A "names" label has been added that enables the user to toggle
whether their contact names should be included in the data shared with
the website that opened the picker.

Secondly, chips for data types that have not been requested by the
developer will now be hidden. At least one type is required so we can be
certain that there is *a* chip. A LinearLayout had to be introduced to
make sure left-side spacing is consistent: previously, the first chip
(names) had a 20dp padding where others had a 10dp padding, but now any
of the chips can be first.

Urgent string updates (Issue 989208) are also included.

Bug: 985708, 988268, 989208
Change-Id: I054871b5c059a029450fd11fad961847b4e3e424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726035Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Auto-Submit: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682678}

Disable
 SSLErrorHandlerDateInvalidTest.TimeQueryHangs
 SSLErrorHandlerDateInvalidTest.NoTimeQueries
 SSLErrorHandlerDateInvalidTest.TimeQueryStarted
on Linux TSAN because flaky.

TBR=agl@chromium.org

Bug: 989289, 989225, 989128
Change-Id: I23df095539a5f0eaf5a3070ccea35067998e981b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728554Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682677}

Enforce CrashInfo#localId to always have a non-null value by accepting
it through a constructor. Hence, eliminate the need for null check in
many places where CrashInfo objects are used.

Updating and format docs and comments in CrashInfo class.

Fixes: 987806
Change-Id: If6f40cf3442ab5cf5601336601dd950a45ad74f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720870Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682676}

Bug: 966896
Change-Id: Id119c1ad1f8ca675b77a4525ba6655d978bb980b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713306Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682675}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8f74bea5b69a..747518d43f4b


git log 8f74bea5b69a..747518d43f4b --date=short --no-merges --format='%ad %ae %s'
2019-07-31 yizhou.jiang@intel.com Remove extra semicolons in shaderc (#768)


Created with:
  gclient setdep -r src/third_party/shaderc/src@747518d43f4b

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I2e6232a66f68057caabb1c5cbdff0f352d7389a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728255Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682674}

https://android.googlesource.com/platform/external/perfetto.git/+log/334a2b1fa8b9..04065f4cd9d6


git log 334a2b1fa8b9..04065f4cd9d6 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 rsavitski@google.com Merge "traced_probes: re-flush metatrace data source at DataSourceStop"
2019-07-31 rsavitski@google.com Merge "traced metatrace: encode CommitDataRequests as a "counter""


Created with:
  gclient setdep -r src/third_party/perfetto@04065f4cd9d6

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I810c7177b208a6560deb114fb11cccad6602c43b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728259Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682673}

This target will be used in EG2 tests in test process, which can not
depend on larger ios/chrome/browser:browser target which contains app
code.

Bug: 987646
Change-Id: I42a8735896a71e53f976ed11de3c30af1ed31905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726312
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682672}

dominant-baseline is specified to accept
auto | text-bottom | alphabetic | ideographic | middle | central
| mathematical | hanging | text-top

Blink hasn't implemented support for text-bottom or text-top.

https://drafts.csswg.org/css-inline-3/#dominant-baseline-property

Change-Id: I956027066788415063ee0d6b9867af458da365cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728890Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682671}

Mark
external/wpt/cookie-store/serviceworker_cookieStore_subscriptions_eventhandler_attribute.tentative.https.html
as flaky (timeout) on Linux Debug in TestExpectations and on Linux for ASAN.

TBR=pwnall@chromium.org

Bug: 989014
Change-Id: Iaf1feeede1f72d15b572c0a9124b8b482e53c94a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728872Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682670}

This patch handles parsed BundledExchanges metadata and hook the
navigation to the BundledExchange resource so that it redirects to
the main resource of the BundledExchanges.

Also this patch renames BundledExchangesFactory to
BundledExchangesHandle.

Bug: 966753
Change-Id: Ia9920c65755fc44f5632366c214c872930228a2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716046
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682669}

These calls are calling back methods from the NavigationRequest, this CL
removes the extra step.

Bug: 916537
Change-Id: I8ca129f57a97da0903e6fcd08e30c97c41748848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724684
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Reviewed-by: Lowell Manners <lowell@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682668}

https://chromium.googlesource.com/angle/angle.git/+log/1ebe6014389e..34ebecc19c6b


git log 1ebe6014389e..34ebecc19c6b --date=short --no-merges --format='%ad %ae %s'
2019-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src f04f1f93a70f..eea340047eca (1 commits)
2019-07-31 xinghua.cao@intel.com Correct barriers of glMemoryBarrier in test cases


Created with:
  gclient setdep -r src/third_party/angle@34ebecc19c6b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=geofflang@google.com

Bug: chromium:None
Change-Id: I3b00f0defe713576d0a2f3b1302cd5723742bb9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728258Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682667}

Mark
virtual/compositor_threaded_scrollbar_scrolling/fast/scrolling/scrollbars/scrollbar-button-gesture-target.html
as flaky (crash) on Win.

TBR=arakeri@microsoft.com

Bug: 987115
Change-Id: I95eeddd53240a6921b5dec33b7481bb7bbe5232e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728658Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682666}

We do not modify the DOM during style recalc, but we may remove pseudo
elements if they are no longer rendered after style recalc. The recalc
code marked the pseudo elements for reattachment before removing them
which meant the layout_tree_rebuild_root_ in StyleEngine pointed to a
disconnected pseudo element.

Avoid the marking if we are about to remove the pseudo element.

This is done as part of the preparation for flat tree style recalc.

Bug: 972752
Change-Id: Icb472bf8073e518a456c86bceb1a1ddbf48f9c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728653Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682665}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=haven@chromium.org

Change-Id: I66ca154ecb0432c3843515347ddfdd39dad6f3c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649510
Auto-Submit: Carlos Caballero <carlscab@google.com>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682664}

When swiping the advanced sign-in settings view, the cancel confirmation
dialog is displayed.
The dialog is the same than tapping on cancel.

Bug: 982300
Change-Id: I8451ece5281853e2dcdf4dc90e585affca7dd575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725916Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682663}

This is a partial revert of crrev.com/c/1694962. I was going to use frame size
by AssignPictureBuffers(). However, the frame size is also known by
ImportBufferForPicture(). The frame size in AssignPictureBuffers() even can be
wrong in secure mode. So I would dealy and call VDA::AssignPictureBuffers()
in GAVDA::ImportBufferForPicture on the first picture buffer. So the mojo change
and GAVDA change in crrev.com/c/1694962 is unnecessary.
NOTE: I haven't changed ARC++ and ChromeOS side for this mojo change. So it is
safe to revert the mojo change.

Bug: 979115
Test: None
Change-Id: Ie8f7f3dd9e4b104ed2e590379ec86e88ad76e708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720298
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682662}

Bug: 972059
Change-Id: I5d643dff5a400ee072522e874b29d261820185e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728580Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682661}

This case handles clients which haven't migrated from Keyring/KWallet into
the login database, but have entries in login database. These are clients
who either haven't updated in a long time or haven't had functioning
Keyrings/KWallets for the duration of the migration.

The unencrypted contents of login database will be encrypted in-place.

Bug: 950267
Change-Id: Id1ba10e87bfd110704a0f63ab038cbb7dda7053a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720837Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682660}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0c98484b..fb6a1792

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I12c17834d4e543d50d8c2f000db82b807aa60098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728210Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682659}

This is in reference to a comment on:
https://chromium-review.googlesource.com/c/chromium/src/+/1715283

Change-Id: I7058826e27110d84e9a846394758044b512bac09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718224Reviewed-by: Lowell Manners <lowell@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682658}

Inside the namespace performance_manager the string features
can refer either to ::performance_manager::features or to
::features depending on what the compiler knows about.

In jumbo builds the compiler has more information and will always
resolve features to ::performance_manager::features. This broke
the windows jumbo fyi builder, but the fix is trivial, just
write ::features instead of features.

(Having a sub namespace with the same name as a common top-level
namespace violates the code style guide but this is common
for features and switches and need a large cleanup.)

TBR=treib@chromium.org

Bug: 973963
Change-Id: Ida06c223f595130b48a8e4442a8e17f5476de8ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728551Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#682657}

MessageLoopForUI will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you believe your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=droger@chromium.org

Change-Id: Id81a7f75bf4fa64c4c7b4ca4d8830768ef6b2d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715819
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#682656}

The CheckIsSelfCollapsing code looked a little scary, e.g. for inline
children it was checking if a (legacy) linebox was was present.

This sets the self-collapsing bit directly for the layout overflow
calculation - which might have a slight perf improvement.

Change-Id: I1b214f915005b8ef21a32305be762f9d52f9156b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556399Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682655}