- 05 May, 2018 32 commits
-
-
Vlad Tsyrklevich authored
After hitting unexpected cfi-icall failures yesterday (e.g. crbug.com/838785) I audited calls to dlsym() and candidates that I missed in uncommon code/build configurations. I chose to disable cfi-icall by attribute for functions that only store dynamically resolved pointers on the stack since they are not favorable candidates to be attacked. base: :GetFunctionPointerFromNativeLibrary() and found a couple Change-Id: I203ea1753b466575c59654d7c3d0fc90c69967a8 Reviewed-on: https://chromium-review.googlesource.com/1044502Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556291}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/694ebb348a44..3d5b83bf9533 $ git log 694ebb348..3d5b83bf9 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 liyuqian Restore old SkBitmapDeviceFilteredSurfaceProps 2018-05-04 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ e76163e3c..336cdd903 (1 commit) 2018-05-04 senorblanco Remove GR_TESSELLATOR_LEGACY_INVERSION_HANDLING (unused). Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I6a7312dafb16b658f99c085892c323fa4210e77e Reviewed-on: https://chromium-review.googlesource.com/1045493Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556290}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The logic was pulled out in a refactor [https://chromium-review.googlesource.com/780143] to support the experimental tab strip model. Since then, the experimental tab strip has been deleted. Pulling the logic back into TabStripModel is the first step to improving the performance of TabStripModel::InternalCloseTabs by reducing the number of unnecessary notifications sent to observers. Bug: 826287 Change-Id: I371bd964d8ea6338d50454a0de329a70e5090fae Reviewed-on: https://chromium-review.googlesource.com/1010642 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
danakj authored
Removes a piece of logic from WebLayer to help us no longer need the class to exist. We plumb along with paths that set the WebLayer as the contents layer on GraphicsLayer a bool that says if the creator of the layer wants to manage the contents opaque-ness of the WebLayer itself, or let the GraphicsLayer manage it. R=enne@chromium.org Bug: 838693 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib0cf69441054dab8c031b4ac7f59d8306a0571c5 Reviewed-on: https://chromium-review.googlesource.com/1038565 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#556288}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/142a92ce8b83..ea240053f956 $ git log 142a92ce8..ea240053f --date=short --no-merges --format='%ad %ae %s' 2018-05-03 ehmaldonado gclient: Update catapult and custom-tab-client origin URLs Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id2fd9f19897a69cab6d2cece4526c9f1aa126291 Reviewed-on: https://chromium-review.googlesource.com/1045182Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556287}
-
Ryan Hamilton authored
Remove unused bytes_acked_since_queue_drained_ from QUIC's BBRSender. Merge internal change: 195185347 https://chromium-review.googlesource.com/c/chromium/src/+/1045098 Deprecate FLAGS_quic_reloadable_flag_quic_register_streams_early2. Merge internal change: 195167465 https://chromium-review.googlesource.com/c/chromium/src/+/1045133 Deprecate FLAGS_FLAGS_quic_reloadable_flag_quic_server_early_version_negotiation Merge internal change: 195167459 https://chromium-review.googlesource.com/c/chromium/src/+/1045132 Refactor validation of received QUIC versions so it can be used in TLS handshake as well Merge internal change: 195166917 https://chromium-review.googlesource.com/c/chromium/src/+/1045095 Refactor more of QuicTransportVersion to ParsedQuicVersion Merge internal change: 195163026 https://chromium-review.googlesource.com/c/chromium/src/+/1045094 Add a flag count for FLAGS_quic_reloadable_flag_quic_bbr_fix_probe_bw. Merge internal change: 195152515 https://chromium-review.googlesource.com/c/chromium/src/+/1045093 Deprecate FLAGS_quic_reloadable_flag_quic_better_crypto_retransmission Merge internal change: 195129678 https://chromium-review.googlesource.com/c/chromium/src/+/1045166 For udp proxying, munge L1=>L0 packets when needed. Protected by --FLAGS_quic_restart_flag_quic_enable_l1_munge. Merge internal change: 195118067 https://chromium-review.googlesource.com/c/chromium/src/+/1045127 Deprecate FLAGS_quic_reloadable_flag_quic_always_discard_packets_after_close. Merge internal change: 195099593 https://chromium-review.googlesource.com/c/chromium/src/+/1045109 Populate peer address and effective client address in stats for HANDSHAKE_FAILED. Protected by exsiting FLAGS_quic_reloadable_flag_quic_log_handshake_failed_in_tcs. Merge internal change: 195089255 https://chromium-review.googlesource.com/c/chromium/src/+/1045088 In QUIC BBR, when draining to the target CWND, use bytes_in_flight, not prior_in_flight. Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_probe_bw. Merge internal change: 194959773 https://chromium-review.googlesource.com/c/chromium/src/+/1045106 Add a QUIC connection option(NRTT) to cause the receiver of an initial_rtt in the handshake to ignore it. Protected by FLAGS_quic_reloadable_flag_quic_no_irtt. Merge internal change: 194927468 https://chromium-review.googlesource.com/c/chromium/src/+/1045069 Deprecate never verified FLAGS_quic_reloadable_flag_quic_bbr_add_tso_cwnd in the false position. Merge internal change: 194877002 https://chromium-review.googlesource.com/c/chromium/src/+/1044574 Deprecate max_aggregation_bytes_multiplier_ in QUIC BBR and the BBR1 and BBR2 connection options which set it. Merge internal change: 194853070 https://chromium-review.googlesource.com/c/chromium/src/+/1045045 Make all quic tests pass when quic_supports_tls_handshake is true Merge internal change: 194836449 https://chromium-review.googlesource.com/c/chromium/src/+/1044949 Add a connection option(1RTO) to only send one packet upon RTO instead of 2. Protected by FLAGS_quic_reloadable_flag_quic_one_rto. Merge internal change: 194835466 https://chromium-review.googlesource.com/c/chromium/src/+/1044965 Change-Id: I11212aa847e4fc357713e24d6b3e34411be7bd73 Reviewed-on: https://chromium-review.googlesource.com/1045173Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556286}
-
rbpotter authored
This prevents needing to have link-container implement SettingsSectionBehavior and will allow future experimental settings sections to be inside dom-ifs. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7f7ba68318fa671e4303304da17601e60b90f7a8 Reviewed-on: https://chromium-review.googlesource.com/1045585Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#556285}
-
Steven Bennetts authored
This also converts everything to inlined constexpr. Bug: 798569 Change-Id: Ia5f026a2e30b8a590e761860d063d42cfdf54bbc Reviewed-on: https://chromium-review.googlesource.com/1043647Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#556284}
-
Yafei Duan authored
RecentTabsUIAdapter and RecentTabSuggestionProvider are deprecated, so removing them as well as the flag used for it. The furthest the feature got was Canary/Dev M57 and then got cancelled. Previous launch bug: https://crbug.com/659205 Bug: 659205 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5403d6e5f642531b15a548499aae7b063d9406e1 Reviewed-on: https://chromium-review.googlesource.com/1040907Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#556283}
-
Kyle Horimoto authored
EasyUnlock tries to create Bluetooth connections at the lock screen, and when both Instant Tethering and EasyUnlock try to create a Bluetooth connection to the same device at the same time, they can cause instability. By eliminating the possibility of this conflict, we work around this issue. Note that a full-fledged fix for this problem is in the works; see https://crbug.com/752273. Bug: 839522 Change-Id: I468515579ca46cabf279e11531ca489a71eb3255 Reviewed-on: https://chromium-review.googlesource.com/1045254 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#556282}
-
Dale Curtis authored
Some of the fuzzing tests invoke errors at weird times, in the case of the linked bug: during seek, preventing the pipeline from reaching have enough again and thus hanging forever. There doesn't seem to be any reason not to include an error handler during all waits done by PipelineIntegrationTests, hanging should not be the behavior used by tests to indicate failure. BUG=834559 TEST=fuzzer test exits instead of hanging Change-Id: Ieccf1b4647ab8aa0f3e5ad22a3174c2f251468ec Reviewed-on: https://chromium-review.googlesource.com/1045562Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#556281}
-
Pedro Amaral authored
Bug: 814528 Change-Id: I1474a77352fd493eaf7635d0d76955cad9ad4608 Reviewed-on: https://chromium-review.googlesource.com/1045512Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#556280}
-
Qiang Xu authored
changes: Refactor LauncherContextMenu: don't make it a subclass of ui::SimpleMenuModel. Instead, exposing a GetMenuModel method to prevent 'calling API and returning self' problem. Bug: 803291 Test: covered by tests Change-Id: I42af308107814bc0fe7ba014b7671316acfbc8aa Reviewed-on: https://chromium-review.googlesource.com/1045097 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#556279}
-
Alexander Alekseev authored
We no longer need to modify user type in user context, so this Cl makes it read-only. Bug: 837107 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I539b033a60eab82e6295fcfeb44fe16f5bc6b99c Reviewed-on: https://chromium-review.googlesource.com/1038666 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556278}
-
David Tseng authored
- window.open's second argument is the context; in this case, we don't have one. - Polymer recommends wrapping a paper-button with an anchor when treating the button like a link. - s/options_page/optionsPage Test: load an engine with a options page. Ensure it shows up and opens that page when clicked. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4210d6c306e2392841fdd9b9fb90ea1ab5c6ffb3 Reviewed-on: https://chromium-review.googlesource.com/1040679Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556277}
-
Pavel Feldman authored
This reverts commit 191b1ead. Reason for revert: We can't process protocol synchronously in the headless embedder. Original change's description: > DevTools: change Target.disposeBrowserContext to force-close WebContents > > This patch changes the behavior of Target.disposeBrowserContext method > to force-close all the belonging WebContents. > > R=dgozman > BUG=836272 > > Change-Id: Iec3da859363120a22c2648b31102457aee20e6cb > Reviewed-on: https://chromium-review.googlesource.com/1031774 > Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555640} TBR=dgozman@chromium.org,sky@chromium.org,lushnikov@chromium.org,caseq@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836272 Change-Id: Ib5d06ad2ce6816a82c0819c693b2eb2819d3a502 Reviewed-on: https://chromium-review.googlesource.com/1045525Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556276}
-
Erik Staab authored
Bug: 731967 Change-Id: I94e8f9d5342293f8ac9e6e2af4ee0c33f082282c Reviewed-on: https://chromium-review.googlesource.com/1045445Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#556275}
-
Paul Jensen authored
Maven modules will be generated with a new script as part of http://crrev.com/c/1044349 instead of via GN build targets. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I02353acf51951b4d57fba2b846fca1fff8dfcf07 Reviewed-on: https://chromium-review.googlesource.com/1044357Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556274}
-
Edward Jung authored
Bug: 834899 Change-Id: I9bcbcda4b121d8c732f808e0745b8b33a1da647f Reviewed-on: https://chromium-review.googlesource.com/1043872Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#556273}
-
Xi Cheng authored
Methods GetProfileIdFromLaunchId() and HandleActivation() are both called in a single notification activation run. They log the same failure to UMA, which skews the UMA failure metrics. This CL fixes it. Bug: 734095, 839942 Change-Id: If7e7cd63869a19b815052bd2b470577e06660252 Reviewed-on: https://chromium-review.googlesource.com/1040349Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#556272}
-
wutao authored
Currently lots of white space between description and the shortcut. This cl dynamically adjusts the width of the desciption to fill available space. Bug: 839913 Test: manual. Change-Id: Ic39f662183faec9eb1ef9b5bfc62bda91ccc61e5 Reviewed-on: https://chromium-review.googlesource.com/1044650 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#556271}
-
Xu Xing authored
Exception is OutputSurfaceMockContext, will be handled next. BUG=837155 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If098503da8a0f52b4c9442eecdb194c41b4731ee Reviewed-on: https://chromium-review.googlesource.com/1032238Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#556270}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The WebContentsDestroyed observer notification is no longer necessary since we use strong ownership semantics for WebContents everywhere, and this class is the only one that can destroy its WebContents. Bug: 832879 Change-Id: I22fef7e4296995f6d3f6a948c1be4bc537695cd1 Reviewed-on: https://chromium-review.googlesource.com/1044891Reviewed-by:
-
David Black authored
- Mic state is newly added to the interaction model. - DialogPlate observes model and updates its icon independently in response to input modality and mic state change events. - Icon used in DialogPlate is currently a stub, state is simulated with background colors. See bug for additional details. Bug: b:79221729 Change-Id: Ic58b11257d12157579b048fb89e83d591c9632b1 Reviewed-on: https://chromium-review.googlesource.com/1043051Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
erikchen authored
This CL is a refactor with no intended behavior change. Bug: 832879 Change-Id: I4c86d936907595a631fb9e603c55af90292ff724 Reviewed-on: https://chromium-review.googlesource.com/1044892Reviewed-by:
-
Xianzhu Wang authored
Table section paints table col's background on its display item, so when table col's background changes, we invalidate all table sections. See https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/table_paint_invalidator.cc?rcl=597a899086d4baebb543eb55b7bd283a3b2068a1&l=43 Now let LayoutObject::BackgroundChangedSinceLastPaintInvalidation() be initially true, so that a new col will be treated as background changed. Bug: 837258 Change-Id: Ic8efcbeb45ee879106f045b262fc4ee8e27cf891 Reviewed-on: https://chromium-review.googlesource.com/1043350Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556266}
-
Matt Wolenetz authored
This feature has been on-by-default since M62. Included in the CL are updates of MSE-FLAC tests to not require proprietary codecs (some of these were still requiring proprietary_codecs previously). BUG=750868 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I005c1ba91fa08c9a9dac5ca616ccfda660196e6a Reviewed-on: https://chromium-review.googlesource.com/1045273Reviewed-by:
-
Erik Chen authored
BrowserCloseManager was deleting a WebContents owned by the TabStripModel. Instead, it should ask the TabStripModel to release the WebContents. Bug: 832879 Change-Id: I9f1c079e638d423d9f22e6c0be341d418e096354 Reviewed-on: https://chromium-review.googlesource.com/1044886Reviewed-by:
-
sczs authored
Screenshots: Old (CollectionView): https://drive.google.com/open?id=1XXJ_WzhtvtR26Q-Dk-iVCeUBfp3h48VX New (TableView): https://drive.google.com/open?id=15lDg6Cl07IVkXI3itntUL5lMhaeIsa-F Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5c354af2472449f92f4abf8bd8728fc04136f8aa Reviewed-on: https://chromium-review.googlesource.com/1043052 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556263}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=warx@google.com Change-Id: I3dd4b70362671bd15c7581c363147652cf2f1917 Reviewed-on: https://chromium-review.googlesource.com/1045645 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556262}
-
Yafei Duan authored
OPMTaskified has never used the event logger to log anything. So adding the usage similar with old OPMImpl for page saved and deleted. We might want to add more logging to the internal page but that's better for future CL. Also cleaning up methods which are no longer used. Bug: NONE Change-Id: I654499c8806edcfdacbe7955d7ef6d4eb19e52b8 Reviewed-on: https://chromium-review.googlesource.com/1045385Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#556261}
-
khmel@google.com authored
Fix issue when in some cases (usually reproducible on next user login) folders are rendered blank. Test: Locally Bug: 838750 Change-Id: I9249204c9416ad4a27d1754c308ffb5aa5a85453 Reviewed-on: https://chromium-review.googlesource.com/1045518 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
- 04 May, 2018 8 commits
-
-
Andrey Kosyakov authored
Works for me now, I think the DCHECK it was hitting was removed as a drive-by here: https://chromium-review.googlesource.com/c/chromium/src/+/1008974/11/content/browser/devtools/devtools_url_loader_interceptor.cc#b478 TBR: dgozman@chromium.org, lushnikov@chromium.org Bug: 721408,831887 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I886a1e302b94b5de685e4ef4442c10564df78539 Reviewed-on: https://chromium-review.googlesource.com/1044539Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#556259}
-
Daniel Cheng authored
The following methods have been made constexpr: - the implicit conversion constructor base::StringPiece(const value_type*) - the comparison operators and base::StringPiece::compare() - base::StringPiece::starts_with() and base::StringPiece::ends_with() Since std::char_traits<> isn't constexpr-ified in C++14, this CL also implements base::CharTraits<> to provide constexpr versions for the base::StringPiece implementation. Finally, this also updates a few callers in Chrome to take advantage of the new constexpr functionality. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo Change-Id: Id3cf2be14bfb5adb53a5ca1bd74ec2a48e411f60 Reviewed-on: https://chromium-review.googlesource.com/1038746Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Khushal authored
Ensure that we cache the result of color conversion in the GpuImageDecodeCache for images larger than max_texture_size, which are color converted on the cpu during scaling. R=ericrk@chromium.org Bug: 791828, 759188 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0940e516ef6b36ccac961c1c15057eee2c73d64e Reviewed-on: https://chromium-review.googlesource.com/1041465 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#556257}
-
Majid Valipour authored
We should not tick cc:WorkletAnimation on main thread. The local time is actually not updated on main thread so the produced value is incorrect and more importantly causes superfluous commits. Note: We may decide to avoid ticking all animations on main thread (See http://crbug.com/762717) in which case we can remove this. TEST: cc/animation/worklet_animation_unittest.cc Bug: 839555 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3335bfd452cc284a585e84a87b8912207b843813 Reviewed-on: https://chromium-review.googlesource.com/1042875 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556256}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I6ee797db0275cfd8ef49de57fe010e3c293bd0cc Reviewed-on: https://chromium-review.googlesource.com/1044488 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
crystallambert@chromium.org authored
Quick change to two links in get started document: /manifest linked to /apps/manifest - corrected to /extensions/manifest Background page link sent to 404 - updated TOC contained "packaging" which has a redirect to "Hosting and Updating" Removed it from side nav. Change-Id: I06a927a3d4cb52707aa5fdc214435482bedac5e2 Reviewed-on: https://chromium-review.googlesource.com/1045446Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#556254}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/870dc3a4f6b3..39e3bc6ed30a $ git log 870dc3a4f..39e3bc6ed --date=short --no-merges --format='%ad %ae %s' 2018-05-04 dtu [pinpoint] Remove `required=True` from isolate_server. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ie1b0c574d80da7a3d53c07b9db3d79a30da1b741 Reviewed-on: https://chromium-review.googlesource.com/1045305Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556253}
-
Ben Pastene authored
Building "all" for linux-chromeos is currently broken due to this target getting built despite no board being set. Bug: None Test: built "all" w/ linux-chromeos Change-Id: I79383869d3617269753db461b99068f73f7f0cfb Reviewed-on: https://chromium-review.googlesource.com/1045107Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#556252}
-
