- 13 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42db0b42abad..a04028c2e67b git log 42db0b42abad..a04028c2e67b --date=short --no-merges --format='%ad %ae %s' 2019-05-13 raul@tambre.ee Fix invalid Python file encoding "utf8" Created with: gclient setdep -r src/third_party/depot_tools@a04028c2e67b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:962277 TBR=agable@chromium.org Change-Id: I26e77664220b9bd742ebe415c818edc46a2b4e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659129}
-
danakj authored
BrowserTestBase decides to run ContentMain() or BrowserMain() based on the OS. On Android it uses BrowserMain() instead. When using BrowserMain() on Android, the test harness reimplements some of ContentMain() before calling BrowserMain(). This is done in the ContentBrowserTestSuite currently, but that can not be shared with chrome browser tests, which inherit ContentTestSuiteBase but not ContentBrowserTestSuite. To promote code sharing and move the logic to the same place where the ContentMain() decision is made, we move this setup code over to BrowserTestBase. While doing so, we update the code to more closely match what ContentMain() does. This makes Android existing browser test suites act more like desktop browser tests, which go through ContentMain() already: - Instead of hardcoding using ShellContentClient, we use the ContentMainDelegate to create the ContentClient (which will be a ShellContentClient in existing cases, but will differ in chrome browser tests). - Ordering is adjusted to match. - The ContentMainDelegate is used and called throughout the setup process the same way that ContentMain() would, including calls to ShouldCreateFeatureList(), PostFieldTrialInitialization(), PreCreateMainMessageLoop(), PostEarlyInitialization(), PostTaskSchedulerStart(), and BasicStartupComplete(). Using the ContentMainDelegate doesn't change existing behaviour for the most part though, as the ShellMainDelegate overrides largely set up for web test mode, which browser tests do not run in (content shell is run separately for that). The InitMessagePumpForUIFactory() call from ContentBrowserTestSuite must be made before the test suite is initialized, however, so it can not move to BrowserTestBase. Instead we put it in the JNI_Onload method of each browser test target. This ensures it is run first, and we DCHECK that it succeeded. In single process mode, we also must initialize a ContentRendererClient which was being done in ContentBrowserTest, so moved this up to the BrowserTestBase. R=avi@chromium.org Bug: 961849 Change-Id: Iefc105e3dc9f142774331aa97b0f1006bd701c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606424 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#659128}
-
Kyle Milka authored
The new styling should only apply to the new customization menu. Bug: 962353 Change-Id: I8f9ff9dc925a58c9403576c0d33b845d8673d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609601Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659127}
-
Eric Willigers authored
Change-Id: I6917c4ad8ae90d797e87db6a5b9409f4ae54c8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608963Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#659126}
-
Collin Baker authored
This flag was just for debugging so it is more appropriate as a command line switch. Also, this function is called in hot code, and feature flag queries are slow. A command line switch is safer to cache; tests are allowed to enable or disable feature flags on the fly, hence caching a feature flag lookup breaks this contract. This allows for caching the result without breaking expectations. Bug: 960913 Change-Id: Ibb9f9b7b7db7b9329984d71318c7488534e04f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600494Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#659125}
-
bsheedy authored
Refactors all the classes in //device/vr/windows_mixed_reality/wrappers/wmr_origins.h to inherit from an interface, and switches the mock versions to inherit from the same interface instead of subclassing the real versions. Also moves the static creation functions into factories in //device/vr/windows_mixed_reality/wrappers/wmr_wrapper_factories.h, which now guarantee that the mock and real classes can't be mixed together. Bug: 961020 Change-Id: I0928bcadc9d942bd6ea513c156c832ffcaf0433f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603748Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#659124}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f1e3609c24ce..e1de1ab33d7f git log f1e3609c24ce..e1de1ab33d7f --date=short --no-merges --format='%ad %ae %s' 2019-05-13 geofflang@chromium.org D3D: Store error message by std::string instead of const char*. Created with: gclient setdep -r src/third_party/angle@e1de1ab33d7f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:962439 TBR=syoussefi@google.com Change-Id: I546638d3392c0bfa60b032cf2b1a26668c243aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610457Reviewed-by:
-
Jeffrey Cohen authored
add utility functions to determine when to display the STTS UI Bug: 959475 Change-Id: I0318090e1b018bb4be874f967bbee0500dcff39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597909Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659122}
-
Scott Violet authored
BUG=958241 TEST=purely dead code removal Change-Id: If1235ea072f867a0cdbbbe09ece1586015e40d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605163 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#659121}
-
Danan S authored
- Create WebUI - Add PostMessageAPI* and AddSupervisionAPI* JS classes for communication with web-content. - Added switch to control the feature: ChromeOSAddSupervision Bug: 937995 Change-Id: I1e65b1a899776b5aa9028921d028030d147baaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500832 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#659120}
-
Xida Chen authored
The TickAnimationsIf is not a member function and is used in the same file. In this case, it should be in the anonymous namespace. This CL doesn't introduce any behavior change. Bug: None Change-Id: I4cc3340335dfbd8b9c3b50765710d8c46bbda603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604110Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659119}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a7a375565cdb..4a4c259fa148 git log a7a375565cdb..4a4c259fa148 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrisforbes@google.com Implement vkCmdDispatchBase Created with: gclient setdep -r src/third_party/swiftshader@4a4c259fa148 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126871859 TBR=swiftshader-team+autoroll@google.com Change-Id: I961a358bead0389c8b405ac68ef6832867497688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610458Reviewed-by:
-
Anastasia Helfinstein authored
TBR=katie@chromium.org Bug: None Change-Id: I2efb8d4ae5affe1653e4ac395cc33afeb5fac6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610521Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#659117}
-
Abigail Klein authored
To test, open a video that has a WebVTT captions file. For example, https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html is a nice example. Introduce new background opacity text track property for webvtt captions and wire it to apply opacity to the WebVTT caption HTML element. Bug: 897730 Change-Id: Ic8dabc2279117b7ff12eb75a9daa8d26c9d9bb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592622 Commit-Queue: Abigail Klein <abigailbklein@google.com> Auto-Submit: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#659116}
-
Sergey Ulanov authored
WebEngine needs to use CodecFactory interface in order to create HW video decoders, but CastRunner didn't have that service in the manifest, so the coresponding web context had to use SW decoder. Bug: Fuchsia: WEB-39 Change-Id: I9e943ef0cee06b96499992eaa1231f1021ea46b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610518 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#659115}
-
https://chromium-review.googlesource.com/1602732Nico Weber authored
It was added for that bug and is now no longer needed. Bug: 958955 Change-Id: Ib335d3946d158f566124dbf57ac5f328b14affc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609879 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
IWYU. size_t needs to come somewhere, so rather than indirectly including it via <utility>, explicitly include <stddef.h>. This fixes the libstdc++ build after commit 01ca125f ("[NTP] Define constants for max number of Most Visited and Custom Links"): In file included from ../../components/ntp_tiles/constants.cc:5: ../../components/ntp_tiles/constants.h:15:14: error: unknown type name 'size_t'; did you mean 'std::size_t'? extern const size_t kMaxNumCustomLinks; ^~~~~~ std::size_t ../../../../../../usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/x86_64-redhat-linux/bits/c++config.h:2182:26: note: 'std::size_t' declared here typedef __SIZE_TYPE__ size_t; ^ ../../components/ntp_tiles/constants.cc:9:7: error: unknown type name 'size_t'; did you mean 'std::size_t'? const size_t kMaxNumCustomLinks = 10; ^~~~~~ std::size_t ../../../../../../usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/x86_64-redhat-linux/bits/c++config.h:2182:26: note: 'std::size_t' declared here typedef __SIZE_TYPE__ size_t; ^ Bug: 957519 Change-Id: I347bef878b954779442a640213952432b329411c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608744 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#659113}
-
Patrick Monette authored
This fixes a presubmit error when modifying this file. Bug: 914910 Change-Id: I58210d65f15d2d19a7a29e51067964ff68557cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592763 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#659112}
-
Collin Baker authored
Bug: 960913 Change-Id: Ibf563c600e14b817d29643c9986d7127235541d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607124Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#659111}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8ab34bf3. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic3ea19193140b2eb46fd6c02766256279e0db0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609600Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659110}
-
Alex Ilin authored
The goal is to eliminate usage of deprecated base::SharedMemory. The shared memory region backing this 'canvas' is writable by the plugin process (PPB_ImageData_Proxy) and its hosting renderer (PPB_ImageData_Impl). Both processes must keep writable shared memory handles because PPB_ImageData_API interface exposes GetSharedMemory() method. Hence move the usage of base::SharedMemory into base::UnsafeSharedMemoryRegion. Bug: 795291 Change-Id: I4766061db7f0a1e2bedfcb9459490acee6c8b2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586039 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659109}
-
Kevin Marshall authored
The rewrite of NamedMessagePortConnector would stop reading from the control port after the first message. Fixes the issue by adding a missing call to ReceiveNextConnectRequest(). Adds a regression test to validate the fix. Bug: 961932 Change-Id: I6a486a6ad0dd1d136fdefb5e6f645ca5be7955fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607181 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#659108}
-
Joe Laughlin authored
The Windows version check is failing on some systems, so branch on the existence of the PrefetchVirtualMemeory API which is present on Win8 and above. Bug: 961669 Change-Id: I891f47fd463bf7f487b84034ce2d7ed5595c0f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607134Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Joe Laughlin <joel@microsoft.com> Cr-Commit-Position: refs/heads/master@{#659107}
-
Matt Menke authored
The test is timing out under Cluserfuzz, which likely discovered yet again that it can DoS slow, memory-instrumented fuzzers with large inputs. Also move the disabled fuzzer into the !disable_ftp_support block with the other FTP fuzzers, so that if we ever run fuzzers on platforms where we don't enable FTP support, we won't run into build issues. Bug: 962087 Change-Id: Iffb366ee6d07f0be190785e26e029baa21b8b9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610300Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#659106}
-
Ehsan Karamad authored
The new policy can be used to disable automatic focus inside a frame; this would include scripting such as element/window.focus() as well as 'autofocus' attribute on editable elements. TBR=rbyers@chromium.org Bug: 954349 Change-Id: Ib2db7de78e1eefb2aa3174deeaf691d9f0c55c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586103 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#659105}
-
John Budorick authored
Bug: 790202 Change-Id: Idf8e70ba258847a1eaf043de79160a5af395f03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607678Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#659104}
-
Alexei Filippov authored
This reverts commit 5994cc70. Reason for revert: Broke sizes step https://ci.chromium.org/p/chrome/builders/ci/win-google-rel/3728 Original change's description: > Add sizes.py isolated_script to chromium.chrome bots. (RELAND) > > This is a reland of crrev.com/c/1604471 > > Bug: 961548 > Change-Id: I3cf8d892f0f5f3dad43751dbcc78031ed52ac616 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607102 > Auto-Submit: John Budorick <jbudorick@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659047} TBR=agrieve@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: Ib49d27c6a9fcc13b391b395a34c672b19f56dc57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610519Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#659103}
-
Sinan Sahin authored
NOPRESUBMIT=true Bug: 958580 Change-Id: I579361feb5255992744150a3965bb59e2bd31ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600778 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#659102}
-
Patrick Monette authored
After moving the ModuleDatabase (and its dependent classes) to its own sequence, the service manager connector can no longer be retrieved directly using the content::ServiceManagerConnection instance. Instead pass a cloned connector when calling InitializeModuleDatabase() from the UI thread. Bug: 958505 Change-Id: I0f47cf66298d54ca82448e26181ab8b9bb358a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592350Reviewed-by:
-
Evan Stade authored
This splits out the kiosk related mojos from the login controller interface, and removes kiosk_app_info.mojom. It also removes a couple methods from mojom::LoginScreenClient, replacing them with a single callback passed to the KioskAppMenu. TBR=tsepez@chromium.org Bug: 958206, 958204 Change-Id: I59d38c83fc91397d1d0890c87f5b18fe23fac7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604333Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#659100}
-
Johannes Henkel authored
This depends on the following patch in V8: https://chromium-review.googlesource.com/c/v8/v8/+/1598254 Change-Id: Ic286f68b4cd4cd8be316ffe9ab9af0f6f24e413c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604463Reviewed-by:
-
Caleb Rouleau authored
This depends on the return code being -1 if nothing is run, which is implemented in https://chromium-review.googlesource.com/c/catapult/+/1605791 This change is safe to commit before https://chromium-review.googlesource.com/c/catapult/+/1605791 since it only does things if the return code is -1. Bug: 944909 Change-Id: I9619b2455c2cfe6e69d91c1d0c8f5a1d9c998e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604339Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#659098}
-
Dana Fried authored
Currently, we pass values into Layer::SetRoundedCornerRadius() as a vector, which means that the values are just an ordered list with implicit correspondence between order and what value they represent. Consider the following code: layer->SetRoundedCornerRadius({3, 4, 5, 6}); Which corner is getting a radius of 3? We have to look at the documentation for the function to find out that the corners are in clockwise order starting from the upper left - but it's not obvious. Passing values with specific semantic meaning in lists and vectors is generally considered an anti-pattern as it is very easy to mix up the order, and even sophisticated editors can't prompt you for the meaning of each value as you enter them. This CL introduces a new class: gfx::RoundedCornersF, which emulates the rounded corners portion of a gfx::RRectF (and indeed, we've added a version of the RRectF constructor that takes a RoundedCornersF). RoundedCornersF provides an explicit way to pass corner parameters (using named fields), and convenient constructors (with named parameters) to create sets of rounded corners with: - all the same radius - four distinct corner radii with equal x and y radii (See issue 961756 for discussion of extending this to distinct x and y radii once certain technical limitations disappear.) One consideration is that the new object is, internally, a list of four float values, while the old API took a vector of four ints. However, internally it was already being converted to an RRectF, which has eight floats. And even better, since there is a four-float constructor for RoundedCornersF, existing code that used a list initializer in calls to Layer::SetRoundedCornerRadius() still compiles (with the values representing the same corners as before, since we've preserved the order). Change-Id: I36d0037f8986468c146adf6fd5eea5c4d5dce9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600965 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:Dan Erat <derat@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659097}
-
Ovidio Henriquez authored
Adds a FakeBluetoothChooserClient associated interface that will be used by FakeBluetoothChooser to send FakeBluetoothChooserEvents to the client as they happen. Since this feature completes the Fake Bluetooth scanning API, this change also converts a test to use the new API. BUG=719827 Change-Id: I2770b3642ae93339e16b594591e4b4075e8246c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/961719 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Mason Freed authored
This is a reland of ceacea9f Original change's description: > Fix backdrop_filter_bounds location for clipped layers > > Previous to this CL, the location of the backdrop filter bounds > rect was incorrect when the containing layer was clipped by the > viewport. In that case, the offset added to the backdrop filter > bounds transform did not account for the clip. It now does, which > should fix at least four bugs. > > Bug: 618913, 927097, 932160, 940917 > Change-Id: I0dc1e4c3dde61210d8f7aa78b2e20f13fc8a2471 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602812 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658920} Bug: 618913, 927097, 932160, 940917 Change-Id: Ibc92ac25d1c2642287220b4e7feef2196bd7e060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608921Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Oriol Brufau authored
This test includes checks for bug 961407, they can be useful for other browsers like WebKit. I have refactored the test a bit to avoid checking the grids twice after each change, this was superfluous work. BUG=767015 Change-Id: I46c50b4bedcd4852fcc71fe4e37c63bbd37cb8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607061 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#659094}
-
Tony de Luna authored
This CL fixes a bug where closing the error screen sends network screen exit message to network screen handler. Luckly this does not cause any user visible bugs, but this is not the expected behavior. Now closing the error screen just hides the screen. The default hide callback will make the parent screen visible in the JS side without modifying WizardController's current_screen_. This CL also adds tests that verify the bug fix and that the basic flow of connecting to a network in the error screen works. Bug: 959340 Change-Id: I760b92bd1e1cdbe96059c7941a854f0664f93298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606572 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659093}
-
Kush Sinha authored
Adding SAML federated GSuite accounts in Chrome OS Account Manager requires loading non-GAIA URLs inside the Account Manager account additon dialog. Loading these pages triggers a 'resize' event from |authenticator.js|, which in turn causes the opening of a Chrome browser window behind the account addition dialog. |authenticator.js| accepts a parameter: |dontResizeNonEmbeddedPages| to disable this behaviour. Use that on Chrome OS. Bug: 962484 Test: Manually Change-Id: I3014c8bc827f63a52847ebd7ce2e6a76950f7791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609832Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#659092}
-
Antonio Gomes authored
Some users of PostCrossThreadTask end up posting a task to the same thread, which is not the purpose of this Blink primitive. This CL fixes it. No new behavior is expected. BUG=None Change-Id: Idf3157749308f023174375172b204fff667d45b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610317 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659091}
-
Sebastien Marchand authored
ps1 is a simple file move and rename. ps2 updates the content of the file (to rename the class etc). ps3-4: Rename the file once more (to disk_site_data_store) and update the name of the functions to use Store instead of Database. ps6: The name is not site_data_store. Bug: 961336 Change-Id: I9d94973e980f7a27fcb508237f8905fb7300cf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602599 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#659090}
-
