- 14 Jan, 2021 40 commits
-
-
Esmael El-Moslimany authored
When custom links are disabled, the shortcut tiles shouldn't be draggable. For touch, the drag start is initiated by a 'touchstart' event. This CL disables the drag for this situation. When using touch, 'touchmove' scrolls the page content. This is not desired for draggable elements like the custom shortcuts. For this reason 'touch-action' is set to 'none'. The location of the dragging tile when using touch is not correct. The code was using |pageX| and |pageY| which takes into account the scroll position. When there is a non-zero scroll offset, the location of the dragging element is incorrect. |clientX| and |clientY| should be used instead. Bug: 1161486 Change-Id: Ie0ae9c08fb396fe2d19b4c294a4698cf57184b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630007 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#843798}
-
Joe DeBlasio authored
In crrev.com/c/2504507, I added Lookalikes owners as owners of site engagement, but I missed several engagement directories. This CL updates those missed directories to point to the "main" OWNERS file at components/site_engagement/OWNERS, and adds a link out to the lookalike owners from there. Change-Id: I0a6d7ddc7cab3bf6a34672ec0006849dedf14e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628137Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#843797}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/bac5544e9832c65c95283e95062263c79a9a6733..f8f35c95550e6796ab8b2c0f8e37e7ce4bc67302 Bug: none Change-Id: I454f1272780b63e64438bd021413a0802d3b9279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628934 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#843796}
-
Gary Tong authored
Bug: 1042757 Change-Id: I720c371465c332d9128a61193d7b0af77461d94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630107 Auto-Submit: Gary Tong <gatong@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#843795}
-
Garrett Beaty authored
Bug: 1165826 Change-Id: Ie08cc5bcfa6ad53cf92e00f95a0564842f0ff6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625272 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843794}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Icb7eac31f9e11bcef9d5a42c05c4642a345ad0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630365Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843793}
-
Michael Bai authored
It seems there is a common issue need to fix. Bug: 1161326 Change-Id: I4e6a4d4660a0dec0d2b817aa7933fd3aa6a9b97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630727Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843792}
-
Katie Dektar authored
Bug: 1166803 Change-Id: I960aab4e3af48fc48b377db1493eba4bc98fe241 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630427 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#843791}
-
Mason Freed authored
It appears that this state was used previously, but is no longer needed. This should cause no behavior changes. Change-Id: I7a36dcdb735654d1ce87debeb82c71a4ccd129eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630286 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843790}
-
Sam Goto authored
Bug: 1141125 Change-Id: I3f71f116ed17eb1014e7bd08c3850421ff7a957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630425Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843789}
-
Scott Violet authored
While the typical case is EnterFullscreenModeForTab is not called multiple times in a row, there may be some corner cases with oopif that result in it being called consecutively. This ensure the delegate is only notified once. BUG=1142101 TEST=FullscreenBrowserTest.DelegateNotCalledMoreThanOnce Change-Id: Ifa094e53b714f78fe61a0d5dd46a33f08c436e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630726 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#843788}
-
John Rummell authored
Bug: 1165081, 1165082 Change-Id: Iaa9ea45ecced614b13e3c266b6302a8c2891d5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626170Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843787}
-
Sophie Chang authored
Following https://chromium-review.googlesource.com/c/chromium/src/+/2628748, this is the only code path that uses this file and I want to delete it. Plus, the browser test currently doesn't depend on the file contents so it can be any arbitrary file. Change-Id: I65dcf1665f8b35a35247b6e80f2be68fa1c1b761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629657 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843786}
-
Xiaoqian Dai authored
Bug: 1166828 Change-Id: Ic54c9c2f1c42a86802a1c9df3ce558cc18586c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630292Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843785}
-
chrome://omniboxmanukh authored
Currently, the column is only displayed when 'Show all details' is enabled. With this CL, it will always be shown. Bug: 891303 Change-Id: I66ca6c05e3821a1f375d6ee7f05042efd1c5574d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630406Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843784}
-
Mason Freed authored
Rather than manually retrieve the "id" attribute, it is cleaner and faster to use the existing blink::Element method, which is optimized [1]. This should have no behavior changes. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/dom/element.h;l=1326;drc=9f3ae654ee080ec3ccb5c3f85a51f5e880f5f18e Change-Id: Ic7634eaa8e8057315d83317862ae16428ee15078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628029Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#843783}
-
Nicolas Ouellet-Payeur authored
It already had a ScopedKeepAlive to keep the BrowserProcess from shutting down while clearing data. But it also needs a ScopedProfileKeepAlive, to keep the Profile* from being deleted while clearing. ScopedProfileKeepAlive is a no-op when DestroyProfileOnBrowserClose is false (which is the default for now). Bug: 88586 Change-Id: Ie5a133f99e2b67c0901abc3935cdbe804f2b4030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625996Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#843782}
-
Nick Diego Yamane authored
When a tab is dragged out of a maximized window, the detached window is created in restored state (ie: with different geometry) and tab drag controller needs to adjust the window and dragged tabs' bounds (more specifically x location), so that they appear under the pointer. That's done at TabStrip::TabDragContextImpl::SetBoundsForDrag() function [2], which calls into Views::SetBoundsRect() for each selected Tab view. It turns out that it is not enough to ensure the tabstrip and its parent, TabStripRegionView, get properly re-laid out, leading to issues like [1], where the dragged tab gets partially or totally occluded by the TabStripRegionView's child views. To fix it, this CL adds layout invalidation for tab strip just after setting bounds rect for each dragged tabs, ensuring both tab strip and its parent views are correctly relaid out. Bug: 1151092 [1] https://drive.google.com/file/d/1a6kEVy0DNUo9TTeiCYjkpf7d42TI3T7n [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_strip.cc;l=697-708;drc=d81c5852498699fe3cd812e78d31c77c28e29281 R=sky@chromium.org Change-Id: I51244ad4485856334ce3443ed92ce80e2fad2cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572040 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#843781}
-
Sky Malice authored
This reverts commit 6a340039. Reason for revert: Causes test failure, see https://ci.chromium.org/ui/p/chromium/builders/ci/android-bfcache-rel/7275/overview Original change's description: > [Messages] Fix clipping of message banner because of SurfaceView hole > > This CL delegates the Animator#start calls in MessageBannerMediator to > WindowAndroid#startAnimationOverContent. > > Bug: 1159429 > Change-Id: I865e62718efa46eae8e1bf733271854475edaa00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628497 > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843685} TBR=pavely@chromium.org,twellington@chromium.org,sinansahin@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id20e63d9c11d00514ce5f40796a724aa760535e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630448Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843780}
-
Brian Sheedy authored
Includes the browser type reported by Telemetry in the Gold parameters used by the GPU tests. This will help with identifying cases where two different browsers on the same hardware are producing different results, e.g. Chrome and Webview on Android devices. Change-Id: Ib7c566dcd751a0e3b23df9583a034952657f2471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630285Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843779}
-
Anders Hartvoll Ruud authored
As of this CL a StyleRecalcContext reference can be propagated from UpdateStyleAndLayoutTreeForContainer to ElementRuleCollector, although only for regular elements (not pseudo-elements and other special things). Bug: 1145970 Change-Id: I79cd317fb8ccfdd2b5d737b0d3c2f2842acf3943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627313 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843778}
-
Dave Tapuska authored
Remove dead mojo definitions. BUG=993189 Change-Id: I94d2ab50cf5314cf351a245f78f35b0769f105a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630605Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#843777}
-
Peter Kasting authored
Bug: 1159562 Change-Id: I4f81a69f44b0e0cc9efb4f75b4adbce97d7e5dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630289 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843776}
-
Tommy Martino authored
This deps roll adds a recent change to the lib which makes table support more robust. Bug: 1166753 Change-Id: If27c784af2e8fee7d26b1a3963852a4de8ecb950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629575 Commit-Queue: Tommy Martino <tmartino@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#843775}
-
Richard Chui authored
Bug: 1140597 Change-Id: I4223bd67355ace228edfcfeaaaf1d493ea97ce44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628739 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#843774}
-
Ahmed Fakhry authored
While a window is being recorded, the user may drag it to a different display. - This event must be propagated to the recording service, so that the video capturer can change its target frame sink to that of the root window of the display the window was moved to. The new display may have different bounds than that of the old display. - The recording service must also handle this case by reconfiguring the VPX video encoder as it will be getting video frames that match the new display size. This CL also fixes a bug where the recorded window shows up as squished in the output video. This was because we used to initialize the video encoder with the current window's bounds rather than the root's bounds. Demo is on the first bug. BUG=1165702, 1165708 TEST=Manually, added new tests in ash_unittests and browser_tests. Change-Id: I53b8e34d1752925d2ee356b98b21c8360e863ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623712 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843773}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - task_controller.js - task_controller_unittest.m.js Bug: 1133186 Change-Id: Ia91e2a515b85b60a9bbb10d5062d18d264d82c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629327 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843772}
-
Henrik Boström authored
Intent to Deprecate on blink-dev: https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/IY2amIigFFs Plan B SDP is still heavily used two years after Unified Plan shipped-by-default. This can cause compatibility issues with Firefox and Safari unless the application does sophisticated SDP translation. This deprecation warning is meant to discourage Plan B and encourage migration to the standardized SDP format Unified Plan, allowing us to remove Plan B when usage is sufficiently low. In the blink-dev discussion we talk about adding adding a Reverse Origin Trial at a future date in case large services still depend on Plan B when M93 comes around. Bug: chromium:857004 Change-Id: Ic95964278a5b7c693cfc7868e957517a64a4ac01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595744 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843771}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Bug: 1164523 Change-Id: Ifcb9d931ec1322496553bf551015cbe75abd841c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630287Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843770}
-
Vladimir Levin authored
This patch tries to restore the scroll offset on a locked element if it is a scroller. If the content of the element has changed, then this scroll offset may not take effect, but we still try to set it. R=chrishtr@chromium.org Bug: 1165856 Change-Id: Iade948abbb08a30280e25fbff4c2e8eefdf012c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625627 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843769}
-
Tim Sergeant authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/42f3f3cea406..adce67ac57ed $ git log 42f3f3cea..adce67ac5 --date=short --no-merges --format='%ad %ae %s' 2021-01-13 tsergeant arc: Add boot property for Play Auto Install generation 2020-12-14 sarthakkukreti cryptohome: Add constants for dm-crypt cryptohomes 2021-01-07 rajatja pciguard: provide dbus service to chrome Created with: roll-dep src/third_party/cros_system_api Change-Id: Ida7b9099e47b048088defbc0958bf64841beacd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626952 Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#843768}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610636358-77f55f013156712d320ba2c348ceb07dee8d46f1.profdata to chrome-win64-master-1610647094-91dde28e2f09f28a39a8ebc52cc90535738b2c08.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98875b4999b3273b36ff360c2edf6c2ab177a895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843767}
-
Xi Han authored
The bug was caused by not resetting the text of the URL bar when an empty text is passed via setUrlBarFocus() API. Bug: 1159352 Change-Id: I6b134fd91ae96b8f956fc0ac30c77862c5ebcde4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622875 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#843766}
-
Gayane Petrosyan authored
Fix by replacing the non text node position by its child text node, if possible. Otherwise, skip the word-completion logic, which assumes, the position is in text node. Bug: 1165317 Change-Id: Iafb82eb1f1f7e5b6644cc07034166e6f0344d184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622987 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843765}
-
Caitlin Fischer authored
Default blocklist values shipped with Chrome 55 onward (added in bug https://crbug.com/643013) and remaining test value ed5f25a4:e is added by web_bluetooth_browsertest.cc procedurally as needed if the field trial config doesn't exist. Bug: 1126640 Change-Id: I2de2d60ade269680ccf8c2a78a77a9b4d0e5a5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627376 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#843764}
-
Kyle Horimoto authored
Includes updates to the Phone Hub onboarding flow, notification flow, and settings UI. Fixed: 1166387 Change-Id: I31f2467e765f37585a8eadd0c2a7b277536e7d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628740 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843763}
-
Jeffrey Kardatzke authored
This is being changed at the request of privacy/legal to indicate 'uniquely identify' rather than just 'identify'. BUG=1146646 TEST=Verified new string in UI Change-Id: If7716b327da1e6c16e9863f88ddca6f5f8768d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629908 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843762}
-
Kyle Horimoto authored
Additionally, add a few fixes which were needed to make tests pass now that Phone Hub is active by default: (1) Call SystemTray->SetPhoneHubManager(nullptr) when PhoneHubManagerFactory is deleted. (2) Set service to NULL while testing. (3) Do not create the service when the Profile is created; instead, Create it in UserSessionInitializer. (4) Update PhoneHubNotificationController to behave correctly when a null PhoneHubManager is passed to it. (5) Do not assume that there can only be 0 or 1 Tether networks. Though this is true in practice, there are tests which use multiple networks. Fixed: 1106937 Change-Id: I15d02e114fc81284cdad072c25c3dca24ff5bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626103 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843761}
-
Stephen McGruer authored
This rolls up to WPT SHA f333959abe07e6c4cfb388f4f7a03a0a109b38a5 Importantly, it brings in https://github.com/web-platform-tests/wpt/pull/27175 which should allow us to move 'wpt manifest' calls back to Python 3. (This CL does not make that switch, it is just rolling tools). It also brings in the change that makes '--py3' the default mode for 'wpt'. Since the wptrunner bots aren't ready for that yet, I also updated testing/scripts/{run_android_wpt.py, run_wpt_tests.py} to pass --py2 to 'wpt'. Bug: 1161274, 1166741 Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I0978d0685f2ef387e22e87e433d4a191e09e7597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627882Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843760}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/786a9e746bcb..18a45a67b21a 2021-01-14 vidorteg@microsoft.com [Loc] Migrate screencast panel to Localization V2 2021-01-14 morlovich@chromium.org Emulation UA-ch editing: make help button tabable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1164345 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib711d3bb84893e559a188619111099abea3c7dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843759}
-