- 10 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/538512e8e898..34be23373b9e git log 538512e8e898..34be23373b9e --date=short --first-parent --format='%ad %ae %s' 2020-04-09 stevenperron@google.com Handle more cases in dead member elim (#3289) 2020-04-09 h.baensch.92@gmail.com Fix pch macro to ignore clang-cl (#3283) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@34be23373b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I4da9d1a7e21e6346c423d03b6ee52bb113993272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758178}
-
Harald Alvestrand authored
Bug: chromium:1049995 Change-Id: Iac13d70fb24f9dc5f36937d625ce33bd7152b092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144079 Auto-Submit: Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#758177}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c68dfaf3a529..e9713ba15b38 git log c68dfaf3a529..e9713ba15b38 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 3cfa8e28be80..e6f65d9265e7 (5 commits) Created with: gclient setdep -r src/third_party/angle@e9713ba15b38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Idbb9bcf6eaf7e0d89f4feda21a25a94f7bc3cb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145435Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758176}
-
Brian Manthos authored
Change-Id: I3cd0ce5838f274fa8b913705da9ae47a0aff7d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145258Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Brian Manthos <brianman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758175}
-
Colin Blundell authored
We are shortly going to componentize the AuthenticatorNavigationInterceptor interface for reuse by WebLayer. However, this interface is used downstream: it is both implemented and returned by an implementation of AppHooks#createAuthenticatorNavigationInterceptor(). This CL paves the road for allowing this componentization to occur upstream without breaking downstream: - We introduce an identical //components-level interface. - We add a new method to AppHooks that returns an instance of the //components-level interface. Downstream we can then have the subclass implement both the //chrome- and //components-level interfaces, and implement the new AppHooks method by returning the instance of the subclass (like the implementation of the current AppHooks method). This will in turn allow us to transition upstream to talking in terms of the //components-level interface without breaking downstream. Finally, we will be able to clean up by removing the upstream interface and all references to it downstream, followed by removing them upstream. A happy technical note: As git does content-based similarity comparisons, it picks up the new file as being the same as the //chrome-level one (i.e. git log --follow on the new file shows the history of the //chrome-level one). Bug: 1031465 Change-Id: Ifc843a550a3b96c5cbeb62cde6a3a1b140614db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144172 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#758174}
-
Javier Ernesto Flores Robles authored
Adds to the password form the encrypted password when fetching from the password store or passing through a change list. On iOS this corresponds to the UUID used to retrieve the passwords from the keychain services. This is needed in order to fetch the passwords in Credential Provider without duplicating the entries in the keychain. Bug: 1066803 Change-Id: I921ad33cdc7579835059a4ff8768761ac5e6bf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142112 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#758173}
-
arthursonzogni authored
It was very hard to understand how the blink implementation of CSP inheritance was working. The FrameLoader was sometimes defining a CSP in FrameLoader::CreateCSP(), sometime not. Then it was overridden/completed in SecurityInitContext::InitializeContentSecurityPolicy() based on the side effects of several parameters. This patch achieves the following: - FrameLoader always defines the final CSP. - SecurityInitContext does not override it. There are many small potential behaviors changes in the patch. Choices have been made to keep things simple and understandable. Maybe this will introduces some regressions. This will be the opportunity to add additional tests. As a result this marked as: DO NOT COMMIT before M83 branch cut. Change-Id: If00d28601853061556d0d5643dcb467ca262715c Bug: 1065876, 1064676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111170Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758172}
-
Christoph Schwering authored
The static assertion kInvalidValue <= 0 in IdType avoids undefined behaviour in IdType::Generator, which starts off with kInvalidValue + 1. Unsigned types however are guaranteed to wrap around, and UINT_MAX is a common invalid value. This CL therefore makes the static assertion vacuously true for unsigned types. Specifically this change is needed for CL 2141990. Bug: 1040280 Change-Id: I6ca1533be8fa256ff0a53a988c4e360048de3fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142115 Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#758171}
-
Jacobo Aragunde Pérez authored
Also modified the expected output of the corresponding tests, and the SessionCrashedBubbleView so it keeps behaving as before. Bug: 1052675 Bug: 1068316 Change-Id: I33d65c3035644ff8eb32fda7c012a3724fde925c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139712Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#758170}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/595e98f87513..8cc69b103725 git log 595e98f87513..8cc69b103725 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 thestig@chromium.org Avoid a static_assert in FxAllocAllocator in MSVC debug mode. 2020-04-09 nigi@chromium.org Make PRESUBMIT.py accept SkiaPaths expected results. 2020-04-09 thestig@chromium.org Add regression tests for a failure in FindPageIndex(). 2020-04-09 thestig@chromium.org Move testing/tools/.style.yapf to the root directory. 2020-04-09 thestig@chromium.org Rename link_annots.pdf to annots.pdf and add a widget annotation. Created with: gclient setdep -r src/third_party/pdfium@8cc69b103725 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I12ca7a32dca66ee5519dd9ec3c4e4e93ebde96d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758169}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/PanIU.....e-tS4... Created with: gclient setdep -r src/third_party/aemu-linux-x64@e-tS4... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I6c4245afc93c8363f3808bf75ab426c46c430263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145433Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758168}
-
Maksim Sisov authored
We have cleaned up ui/gl from USE_X11. These includes are not needed anymore. TBR=backer@chromium.org Bug: 1036285 Change-Id: I6420b774a6a190527f76ab3fa5cb058b54d76a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144136Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#758167}
-
Yuki Shiino authored
Stringifier.IR and IndexedAndNamedProperties.IR are not updated during the compilation, so these IRs shouldn't be used at all. Bug: 839389 Change-Id: Id74cb0f310cd234794f22a675a281ee3b078be42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141500Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758166}
-
Brian Manthos authored
No functional changes. Change-Id: Ic7d93c1c13d174a7d04a251bedcc8b5bcfb458bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145132 Commit-Queue: Brian Manthos <brianman@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758165}
-
Shakti Sahu authored
This CL includes : 1 - Rounding the tiles using RoundedCornerImageView 2 - Gradient overlay above RCIV 3 - Tile width calculation logic depending on screen size Bug: 1068666 Change-Id: I014a01f17514e8df1da65cfd12e2baf9eb931e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137818 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#758164}
-
Gauthier Ambard authored
This CL makes sure that we don't display the NTP if the loaded page is an interstitial page. This is caused by the behaviour of interstitial when the committed interstitial feature isn't enabled. In that case the workflow is: 1. about:newtab is loaded 2. User loads bad.badssl.com 3. Navigation did start for bad.badssl.com 4. Navigation ends for bad.badssl.com 5. This is a bad ssl page so Chrome actually reverts to about:newtab 6. Load stops, but at this point the visible URL is about:newtab 7. The interstitial is displayed and the visible URL is updated to bad.badssl.com 8. The observers are notified through DidChangeVisibleSecurityState 9. No further callbacks So the main issue is that there is not callback notifying that the visible URL has changed. This CL fixes it by adding a callback on DidChangeVisibleSecurityState and also on LoadStop to avoid having the NTP flashing between 6 and 7. Fixed: 1067250 Change-Id: Ifc57addf5a6fa9e6295446da34e117028add73fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141971 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758163}
-
Nohemi Fernandez authored
Updates EarlGrey tests that are impacted by the new default signout UI. Bug: 1005509 Change-Id: I688c15b7b3a7b77be6da9e87d2047dd831818aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139708Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#758162}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b60df8ed2de8..1260c0bbd0ae git log b60df8ed2de8..1260c0bbd0ae --date=short --first-parent --format='%ad %ae %s' 2020-04-10 mathias@chromium.org Update console message expectation Created with: gclient setdep -r src/third_party/devtools-frontend/src@1260c0bbd0ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2e8e1509c0ed00d8a9cb7eb4cacb6adc4a4a9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145319Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758161}
-
Colin Blundell authored
We are targeting InterceptNavigationDelegateImpl for componentization and sharing with WebLayer. The main blocker is its dependence on Tab. This CL starts decoupling InterceptNavigationDelegateImpl from Tab: - We add a //chrome-level InterceptNavigationDelegateTabHelper object to attach InterceptNavigationDelegateImpl to a Tab. - We add an InterceptNavigationDelegateClient interface that the embedder implements to give the context that InterceptNavigationDelegateImpl is currently obtaining from Tab, and populate it with an initial method. The implementation of the Client interface is currently separate from the TabHelper object due to a thorny circular dependency issue in InterceptNavigationDelegateTest.java. Once InterceptNavigationDelegateImpl is cleaned of all dependencies on Tab I suspect that this circular dependency will go away and we will be able to merge the Client implementation into the TabHelper object. Future CLs will complete the cleaning of //chrome-level dependencies from InterceptNavigationDelegateImpl. Bug: 1031465 Change-Id: I0f63b31d77efffe9d74ff68065c55e59ba163cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134290 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#758160}
-
Rushan Suleymanov authored
Currently, during the initial merge of bookmarks it may be possible that processing of local creation may cause crash if the previous neighbour wasn't processed yet (due to matching by GUID with some remote update). This patch fixes that behaviour by finding the last tracked entity. That entity will be used to calculate next UniquePosition. Bug: 1050776 Change-Id: I5275aee07d5bd5f4e4ac534734c209ec2ed78b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144160 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758159}
-
Takashi Toyoshima authored
This patch updates the policy_templates.json to update the announced removal plan. This will also update the official support page for these enterprise policies. Bug: 1053866 Change-Id: Ie31dbeb7d00b4ae9ce2b45757dc9ad4a8c62181f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134753 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#758158}
-
Alex Kalugin authored
Check for ShouldKeepErrorPageInCurrentProcess in case of failure produces incorrect log output (both new error codes). Change-Id: I405c1c901ce5abe516a37d30a408633b0c81eb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144198Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#758157}
-
Mansi Awasthi authored
This CL adds an end to end browser test for validating that PDF text fields are getting added to the accessibility tree correctly. It also includes a test to validate the value of inline text boxes for PDF with text fields. Bug: 1030242 Change-Id: I4f337ad5459b36239549b40e35ef16a52c5f16d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134092Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758156}
-
Maksim Sisov authored
Actually, I couldn't find the real use of this code. It seems like all the windows we create are aura Windows and this condition never executes. Bug: 1069469 Change-Id: Ic3caebca38769e45b873cbc15f1ef618232be390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144054 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758155}
-
Yoichi Osato authored
Bug: 1066716 Change-Id: I7dfe445604ad6e8556e7f9de462ceed7f0305fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142883Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#758154}
-
arthursonzogni authored
This reland the following patch: https://chromium-review.googlesource.com/c/chromium/src/+/2062336 The diff: https://chromium-review.googlesource.com/c/chromium/src/+/2144100/1..5 The previous CL was reverted because if was not compiling reliably. The target: //third_party/blink/common:common was missing: //services/network/public/mojom:mojom_blink However, adding it would creates a dependency cycle: ERROR Dependency cycle: //third_party/blink/public/common:common -> //third_party/blink/common:common -> //services/network/public/mojom:mojom_blink -> //mojo/public/cpp/bindings:wtf_support -> //third_party/blink/public:blink_headers -> //third_party/blink/public/common:common It means we can never #include a generated .mojom-blink.h from //third_party/blink/common:common Fortunately, there are already many .mojom-shared.h there. So we can can include web_sandbox_flags.mojom-shared.h instead. The enum definition is entirely contained in this file anyway. The mojom-shared.h is already a dependency:: /third_party/blink/common:common -> /services/network/public/cpp:cpp -> /services/network/public/mojom:mojom [generated HERE] R=kinuko@chromium.org TBR=thakis@chromium.org,mfoltz@chromium.org,iclelland@chromium.org,mkwst@chromium.org,lfg@chromium.org,arthursonzogni@chromium.org Bug: 1041376 Change-Id: I272d4971920d6d3c04a965f1aa9b90376353b446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144100Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758153}
-
Wei Lee authored
The mojom_bindings_generator.py is refactored again by https://crrev.com/c/2128966 And cause the deploy function of cca.py out of work. This CL fixes the usage accordingly. Bug: None Test: cca deploy works again Change-Id: I55003cf6317c400b1b82df8139d28d6111c0bef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142885Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758152}
-
Maksim Sisov authored
In order to be able to move X11DesktopWindowMoveClient out of ui/views to ui/base/x, we need to stop subclassing wm::WindowMoveClient. This CL does it. Basically, we implement WindowMoveClientPlatform that reroutes the requests for RunMoveLoop to DWTHPlatform::RunMoveLoop, which then is supposed to call PlatformWindow::RunMoveLoop. Current, for X11, these calls are routed to DWTHX11::RunMoveLoop. Test: verify Tab Drag works on chrome/x11. Bug: 1069469 Change-Id: I60cd60001c47ddfcefe8248cb7a0a087c85bb164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144053 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758151}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/48d345fd83fd..05e2350de5a9 git log 48d345fd83fd..05e2350de5a9 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9fa8abd9..6de7d4c5 (410 commits) 2020-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2caf7ffda74f..c68dfaf3a529 (9 commits) Created with: gclient setdep -r src/third_party/skia@05e2350de5a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ie8c5aaf09dd813ca35626a42b702f490648e8cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758150}
-
Yuki Shiino authored
Updates the implementation of cross origin properties generated by the new bindings generator. No prod change. Bug: 839389 Change-Id: I9ac45e76341f075e15d89288d5a9776bb4321f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143110Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758149}
-
Yuki Shiino authored
Adds v8_event_counts.{cc,h} and v8_is_input_pending_options.{cc,h}. Bug: 839389 Change-Id: I5c7696af4272afe209a54c79fd4adc39b41c5b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141490Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758148}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3470cbf..0bb2b300 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib042318fa896c756b1f671f57bc2e663c0f95f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144717Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758147}
-
Roman Sorokin authored
Fixed: 1067461 Change-Id: I18d02649f37c33e8c14e3fe13e4f57f3f27b6113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141896 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#758146}
-
Jenny Zhang authored
TBR=holte@chromium.org Bug: 1046006 Change-Id: I65ea50b224f85821f2e343ce3e3907340175b69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145158Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758145}
-
Julie Jeongeun Kim authored
This CL is a follow-up CL of crrev.com/c/2134466. This TC has an issue number[1] that introduced it. But, since Chromium changed the behavior at [2], it should be updated with the latter. It also updates "assert" to deliver clear messages. [1]https://bugs.webkit.org/show_bug.cgi?id=81809 [2]crbug.com/531783 Bug: 1063749 Change-Id: If3b1c761cab29e351e337eda4f3797f12679140c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143094 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#758144}
-
John Z Wu authored
This is to support butter sync where passwords are account scoped. The profile password store can be left as is because all access to the stores are controlled via WebViewPasswordFeatureManager. Bug: 1056406 Change-Id: I916beffe9b95b4e9d8216363ed3db88b1c17875f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141007 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#758143}
-
Alice Wang authored
This CL resets the AccountManagerFacade test instance to null in AccountManagerTestRule teardown. Bug: 1066800 Change-Id: I670cb1b4741ddfd6f5f126b21f17ae5b9c346887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135698Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758142}
-
Takashi Toyoshima authored
Bug: 898589 Change-Id: I814297c70cbfbe9052d6d6507e0ab01257e0b94d NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134183 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#758141}
-
Julie Jeongeun Kim authored
This CL iterates all descendants for GetSelectionCount and GetSelectedChild. When listbox has group children, it should iterates their children as well to check the select state. Bug: 1058961 Change-Id: Ib6459bf6f47023d4258ef4c2f2dc545739d7a61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115211 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#758140}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df3cc205af96..c68dfaf3a529 git log df3cc205af96..c68dfaf3a529 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 xinghua.cao@intel.com Avoid GPU-GPU copy for StructuredBuffer Created with: gclient setdep -r src/third_party/angle@c68dfaf3a529 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Id6bfd75ed19ed19e569972dfb7fa64f635d8541e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758139}
-