- 14 Jul, 2016 40 commits
-
-
robert.bradford authored
BUG=425060 TEST=Build test. Review-Url: https://codereview.chromium.org/2152883002 Cr-Commit-Position: refs/heads/master@{#405568}
-
wkorman authored
TBR=pdr Review-Url: https://codereview.chromium.org/2150993003 Cr-Commit-Position: refs/heads/master@{#405567}
-
jbroman authored
This makes it easier to see that copies of all relevant fields are correct, and also makes it easier to add new state inherited on the containing block chain. BUG=563667 Review-Url: https://codereview.chromium.org/2144733008 Cr-Commit-Position: refs/heads/master@{#405566}
-
fbarchard authored
roll libyuv for GN fix to chromium internal settings, enabling more warnings and consistant with gyp build options. Add ARGBExtractAlpha function. Fix YUV bilinear filter improved filter accuracy; uses 128-f instead of 127-f. unittest fixes for Arm scaler - use J420 for J422 pointing to same row, improving performance and accuracy. Fix ios jpeg build error. Fix BlendPlaneRow_SSSE3 impossible constraints on android full debug Fix unittests to avoid private row.h header. Fix vector_size(32) build error on yuv conversion for intel on gcc 4.4. BUG=chromium:626065, libyuv:572, libyuv:575, libyuv:579, libyuv:573, libyuv:583, chromium:601140, libyuv:582, libyuv:581, chromium:601140, libyuv:578, libyuv:581, libyuv:580, libyuv:586, libyuv:590, webrtc:5006, libyuv:593, libyuv:592, libyuv:594, libyuv:595, libyuv:597, libyuv:599, libyuv:598, libyuv:600, libyuv:602, libyuv:605, libyuv:610, libyuv:612, libyuv:618, libyuv:620, webrtc:6091, webrtc:6094, libyuv:616, libyuv:623, libyuv:624, libyuv:625 TEST=try bots pass Review-Url: https://codereview.chromium.org/2151043002 Cr-Commit-Position: refs/heads/master@{#405565}
-
thakis authored
build/config/BUILDCONFIG.gn still asserts that target_os == host_os for Windows build, so this currently can't be toggled without further local changes. No behavior change. BUG=495204 Review-Url: https://codereview.chromium.org/2148373002 Cr-Commit-Position: refs/heads/master@{#405564}
-
nzolghadr authored
Extracting most of gesture logic from EventHandler and move it to the GestureManager class. BUG=616491 Review-Url: https://codereview.chromium.org/2137113002 Cr-Commit-Position: refs/heads/master@{#405563}
-
proberge authored
BUG=372547 Review-Url: https://codereview.chromium.org/2111253002 Cr-Commit-Position: refs/heads/master@{#405562}
-
piman authored
Creating the outputter needs to create and join a thread, which is quite costly. This is to speed up the GPU fuzzer, which recreates a decoder (hence a GPUTracer) for every test case. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2151673003 Cr-Commit-Position: refs/heads/master@{#405561}
-
thakis authored
Revert of Disable "taking address of packed member" clang warning. (patchset #2 id:60001 of https://codereview.chromium.org/2148283002/ ) Reason for revert: Warning was reverted upstream again. Original issue's description: > Reland of Disable "taking address of packed member" clang warning. (patchset #1 id:1 of https://codereview.chromium.org/2066503004/ ) > > Reason for revert: > The warning was relanded upstream this morning. > > Original issue's description: > > Revert of Disable "taking address of packed member" clang warning. (patchset #3 id:40001 of https://codereview.chromium.org/2059143003/ ) > > > > Reason for revert: > > The warning got reverted upstream. > > > > Original issue's description: > > > Disable "taking address of packed member" clang warning. > > > > > > Pending cleanup. > > > > > > BUG=619640 > > > > > > Committed: https://crrev.com/e77a373b7141f2e52f79f5cba5c2577fc16a4f5e > > > Cr-Commit-Position: refs/heads/master@{#399572} > > > > TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=619640 > > > > Committed: https://crrev.com/f999d8350f0fbdefac8875135ca3540c64d2f3f4 > > Cr-Commit-Position: refs/heads/master@{#399686} > > TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org,thakis@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=619640 > > Committed: https://crrev.com/805bf6aaa5de841e0cf987e0d7005f5abd7df54c > Cr-Commit-Position: refs/heads/master@{#405538} TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org,rnk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619640 Review-Url: https://codereview.chromium.org/2145243003 Cr-Commit-Position: refs/heads/master@{#405560}
-
dgozman authored
This event doesn't make sense. Frontend can clear console messages log on navigation if it wants to. BUG=613882 Review-Url: https://codereview.chromium.org/2146163002 Cr-Commit-Position: refs/heads/master@{#405559}
-
lanwei authored
In the Issue 2130433002, Navid had to skip some pointerevent tests because they crashed for some reasons. This patch fixes it and also remove them from the TestExpectations file. BUG=620236 Review-Url: https://codereview.chromium.org/2127303002 Cr-Commit-Position: refs/heads/master@{#405558}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/7cf36ccb4419..64bbad360f30 $ git log 7cf36ccb4..64bbad360 --date=short --no-merges --format='%ad %ae %s' 2016-07-14 mtklein Revert of Expand _01 half<->float limitation to _finite. Simplify. (patchset #7 id:120001 of https://codereview.chromium.org/2145663003/ ) 2016-07-14 mtklein Expand _01 half<->float limitation to _finite. Simplify. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2148403002 Cr-Commit-Position: refs/heads/master@{#405557}
-
lazyboy authored
We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl before r243208 and used to pass the filtered/validated url to WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this to change, this CL restores the behavior. BUG=None Test=None, internal cleanup. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2151743002 Cr-Commit-Position: refs/heads/master@{#405556}
-
dgrogan authored
Instead use basic firstChild and nextSibling. This avoids a crash when the internal layout structure is dirty. Add DCHECK to discourage future mistakes. BUG=627839 Review-Url: https://codereview.chromium.org/2146163005 Cr-Commit-Position: refs/heads/master@{#405555}
-
dpapad authored
Fixes browser crash. BUG=628159 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2150983002 Cr-Commit-Position: refs/heads/master@{#405554}
-
mcasas authored
This CL: - removes some unnecessary dependencies, following up on a TODO - removes unnecessary include and MEDIA_EXPORT in recently landed code - correct photo_capabilities.h header guard BUG=626125, 618718 TEST=No new coded added, if it compiles, is good. Review-Url: https://codereview.chromium.org/2148583003 Cr-Commit-Position: refs/heads/master@{#405553}
-
ccameron authored
Make gfx::ColorSpace have an internal pointer to a globally-unique structure for the color space, where its ICC profile can be stored. BUG=622133 Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320 Committed: https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65 Review-Url: https://codereview.chromium.org/2140803002 Cr-Original-Original-Commit-Position: refs/heads/master@{#405211} Cr-Original-Commit-Position: refs/heads/master@{#405424} Cr-Commit-Position: refs/heads/master@{#405552}
-
dpranke authored
Currently v8_target_cpu can only be set to one particular architecture, and that won't work for monochrome/webview builds where we need to be able to build two different snapshots for two different architectures. The way things are set are also confusing for when you need to do builds for a target_cpu that is different from the host_cpu and the value of the v8_target_cpu might get out of sync between target and host. This change changes all that by making the cpu that v8 targets a function of the current toolchain (thus declaring a v8_current_cpu and using that instead). R=brettw@chromium.org, jochen@chromium.org, michaelbai@chromium.org BUG=625353 Review-Url: https://codereview.chromium.org/2116183002 Cr-Commit-Position: refs/heads/master@{#405551}
-
smaier authored
This should have been removed in this cl: https://codereview.chromium.org/2122993003 BUG=None Review-Url: https://codereview.chromium.org/2151533002 Cr-Commit-Position: refs/heads/master@{#405550}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b1baa103267a..627023176cd4 $ git log b1baa1032..627023176 --date=short --no-merges --format='%ad %ae %s' BUG=472699 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2149743004 Cr-Commit-Position: refs/heads/master@{#405549}
-
danakj authored
LayerTreeTests expect the output surface on the LayerTreeHostImpl to be a FakeOutputSurface, but we will be changing it to be a TestDelegatingOutputSurface in the future, with a Display, and a FakeOutputSurface in the Display instead. This removes the LayerTreeTest::CreateFakeOutputSurface() method, and has tests override the LayerTreeTest::CreateOutputSurface() instead, storing the FakeOutputSurface* themselves as needed. This also means we don't have a null FakeOutputSurface* in pixel tests, yay. In the future, this method will become CreateDisplayOutputSurface or something, so that tests can control the surface in the Display (and all the contexts), without changing the TestDelegatingOutputSurface in the LayerTreeHostImpl. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2140383005 Cr-Commit-Position: refs/heads/master@{#405548}
-
brettw authored
Previously calling target("foo", "bar") where "foo" is a template applied the defaults for the function named "target" (since this is the function call) rather than "foo". This change properly applies the defaults for "foo" in this case. BUG=624564 Review-Url: https://codereview.chromium.org/2148093002 Cr-Commit-Position: refs/heads/master@{#405547}
-
brettw authored
This is related to a comment about components being source sets on Android. A previous patch speculatively changed a build parameter with a comment referencing the speculative test. Now we know this does affect the runtime but not build performance, so we will keep the change and the comment needs to be updated to reflect this. BUG=619593 Review-Url: https://codereview.chromium.org/2152743003 Cr-Commit-Position: refs/heads/master@{#405546}
-
megjablon authored
StrictMode violation was from Calendar.getInstance() reading the /etc/timezone file. Whitelist the StrictMode violation to be fixed. Tests were flaky because the UI thread would not always launch the InfoBar before calling addInfoBarAnimationFinished(). Run the UI thread blocking so that the InfoBar has always been launched. BUG=625038, 577185, 627038 Committed: https://crrev.com/8fcd3f03a3a531f12bb291dc8665834d85511c23 Review-Url: https://codereview.chromium.org/2130083002 Cr-Original-Commit-Position: refs/heads/master@{#404506} Cr-Commit-Position: refs/heads/master@{#405545}
-
brettw authored
Converts some source sets that were source sets into static libraries. Converts additional targets in the touched files to static libraries where it seemed relevant. Update the definition of //crypto:test_support to mark it testonly and make the conditions append sources rather than subtract them in the reverse condition. A few redundant dependencies were removed (one shouldn't need to specify both "foo" and "foo:test_support"). BUG=627637 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2151653003 Cr-Commit-Position: refs/heads/master@{#405544}
-
cwallez authored
BUG=617627 TBR=kjellander@chromium.org Review-Url: https://codereview.chromium.org/2150963002 Cr-Commit-Position: refs/heads/master@{#405543}
-
gogerald authored
BUG=626999,627444 Review-Url: https://codereview.chromium.org/2143583003 Cr-Commit-Position: refs/heads/master@{#405542}
-
yusufo authored
Even if we set a renderer size during prerender, that value gets overridden on initialization due to two reasons: - On CVC construction, in setCVC for RWHVAndroid, there is a resize no matter what. This changes adds a condition to not resize if it is a brand new CVC with zero size. - In swapCVC in Tab, we actually make an attempt to use the old CVC size. In external prerender this should actually use the estimated size used previously. This change also does that. BUG=612218 Review-Url: https://codereview.chromium.org/2147543006 Cr-Commit-Position: refs/heads/master@{#405541}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9a1caf5d..74306c2f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2149923003 Cr-Commit-Position: refs/heads/master@{#405540}
-
brettw authored
Allow multipe set_defaults calls in GN to override one another, and allow imported .gni files with set_defaults calls in them to not collide with existing defaults settings as long as the settings are the same. This will allow us to be more flexible with defaults, in particular, to allow the defaults for templates to move to the template declaration location rather than having to reside in BUILDCONFIG. Add an android condition around an android-specific config in base I noticed when testing this patch. BUG=627978 Review-Url: https://codereview.chromium.org/2148993002 Cr-Commit-Position: refs/heads/master@{#405539}
-
rnk authored
Reland of Disable "taking address of packed member" clang warning. (patchset #1 id:1 of https://codereview.chromium.org/2066503004/ ) Reason for revert: The warning was relanded upstream this morning. Original issue's description: > Revert of Disable "taking address of packed member" clang warning. (patchset #3 id:40001 of https://codereview.chromium.org/2059143003/ ) > > Reason for revert: > The warning got reverted upstream. > > Original issue's description: > > Disable "taking address of packed member" clang warning. > > > > Pending cleanup. > > > > BUG=619640 > > > > Committed: https://crrev.com/e77a373b7141f2e52f79f5cba5c2577fc16a4f5e > > Cr-Commit-Position: refs/heads/master@{#399572} > > TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=619640 > > Committed: https://crrev.com/f999d8350f0fbdefac8875135ca3540c64d2f3f4 > Cr-Commit-Position: refs/heads/master@{#399686} TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=619640 Review-Url: https://codereview.chromium.org/2148283002 Cr-Commit-Position: refs/heads/master@{#405538}
-
allada authored
This fixes a regression caused from https://codereview.chromium.org/2118663002 where it would always show the padding designed for "Large View" in the spacers of timeline. BUG=628091 R=lushnikov Review-Url: https://codereview.chromium.org/2149993002 Cr-Commit-Position: refs/heads/master@{#405537}
-
agrieve authored
Ran into this when trying to add support for android_aar() template. The existing logic did not play nice with the filtering done by _FilterUnwantedDepsPaths. It now just resolves groups at the same time as _FilterUnwantedDepsPaths so that no other logic within the file should need to know about them. BUG=611171 Review-Url: https://codereview.chromium.org/2141153002 Cr-Commit-Position: refs/heads/master@{#405536}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/abda35d2b77f..7cf36ccb4419 $ git log abda35d2b..7cf36ccb4 --date=short --no-merges --format='%ad %ae %s' 2016-07-14 bsalomon Stop testing texture-backed bitmaps in drawbitmaprect GM 2016-07-14 bsalomon Rewrite GrTextureMipMapInvalidationTest using SkImage 2016-07-14 dvonbeck Added premulFourChannelColor to GrInvariantOutput 2016-07-14 bsalomon Remove SkGrTexturePixelRef and SkGrRenderTargetPixelRef aliases for SkGrPixelRef GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151873002 2016-07-14 fmenozzi Add verb field in scraping scripts 2016-07-14 bsalomon Remove unit test that tests subsetting texture backed bitmaps. 2016-07-14 bsalomon Fix leak when DFPR fails to draw path CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2144323002 Cr-Commit-Position: refs/heads/master@{#405535}
-
allada authored
Revert of [Devtools] Improved URL parser for console (patchset #6 id:100001 of https://codereview.chromium.org/2125143002/ ) Reason for revert: Regex can lockup on some console messages. Original issue's description: > [Devtools] Improved URL parser for console > > URL linkifier in console will now match a bit smarter. It > will now allow things in double quotes single quotes and tick > characters with something that beings to look like a url and > continue to match (ie: allow spaces and punctuation). If > there is no quote characters it will require punctuation or > space before and after something that looks like a url. > > BUG=535463 > > Committed: https://crrev.com/33b11974ba7343fbf2ad6673447488a1563cc8e3 > Cr-Commit-Position: refs/heads/master@{#404724} TBR=lushnikov@chromium.org,luoe@chromium.org,dgozman@chromium.org,allada@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=535463 Review-Url: https://codereview.chromium.org/2151943002 Cr-Commit-Position: refs/heads/master@{#405534}
-
konsto authored
BUG=618140 Review-Url: https://codereview.chromium.org/2150953002 Cr-Commit-Position: refs/heads/master@{#405533}
-
spqchan authored
Change the "Low Severity" color to Green. Update the icons to the MD ones. BUG=624643, 626775 Review-Url: https://codereview.chromium.org/2139573003 Cr-Commit-Position: refs/heads/master@{#405532}
-
ortuno authored
Blink should only use the blink variant of mojo bindings. Unfortunately, this means we can no longer use the same enum across content/renderer and blink. To get around this, the embedder interface (WebBluetooth) uses int32 instead of the enums and we cast to enum where appropriate. Also removes unnecessary dependencies on mojo bindings. BUG=610415 Review-Url: https://codereview.chromium.org/2142813003 Cr-Commit-Position: refs/heads/master@{#405531}
-
shekyan authored
As defined in [1], this CSP directive allows developers to block resource requests that do not contain integrity metadata. This includes contexts like external scripts, workers, shared workers, service workers, external stylesheets, preload requests, and requests originated by CSS @import. [1]: https://w3c.github.io/webappsec-subresource-integrity/#opt-in-require-sri-for Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/jyCdW1dHyYA/YefRSKs1AQAJ BUG=618924 R=mkwst@chromium.org Review-Url: https://codereview.chromium.org/2056183002 Cr-Commit-Position: refs/heads/master@{#405530}
-
svillar authored
The computeAutoRepeatTracksCount() call needs to know the available size in order to compute a number of repetitions. When computing the preferred logical widths that size is indefinite so it should just return 1. The problem is that instead it was directly calling another methods that were reentering the preferred size computation. That lead to a situation of never ending recursive calls to the preferred widths code. As we know whether we're computing the intrinsic sizes or not, we can leverage that knowledge and do not call the method in that case (the number of repetitions would be 0 or 1 depending on whether auto-fit|fill was specified or not). Made some of the attributes mutable as they are modified by the intrinsic size computation. Moved the clean up of those attributes to a new method. We'll eventually need to change the current code so that we could call the track sizing algorithm without affecting the internal state of the layout object. BUG=621517 Review-Url: https://codereview.chromium.org/2135703002 Cr-Commit-Position: refs/heads/master@{#405529}
-