GitLab

TBR=lambroslambrou@google.com

Review URL: https://codereview.chromium.org/12226106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181942 0039d316-1c4b-4281-b951-d872f2087c98

UI tests will be implemented later.

TBR=ben
BUG=137121

Review URL: https://chromiumcodereview.appspot.com/12213110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181941 0039d316-1c4b-4281-b951-d872f2087c98

As requested by Dirk Schulze, revert Chromium's brightness filter to the old spec-compliant
implementation (RGB multiplier instead of color space translation).

Dirk also updated WK/Safari to use the same brightness matrix.

http://trac.webkit.org/changeset/139770
https://bugs.webkit.org/show_bug.cgi?id=106674


BUG=


Review URL: https://chromiumcodereview.appspot.com/12033075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181940 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=alecflett

Review URL: https://codereview.chromium.org/12221138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181935 0039d316-1c4b-4281-b951-d872f2087c98

> Possible solution to synchronization problems in webrtc audio capturer.
> 
> This will hold on to a reference to the buffer while the buffer is being used by WebRTC. I also tried to fix the places where synchronization was missing (mostly for the params_ instance).
> 
> Let me know if you want an offline explanation!
> 
> BUG=173987
> TESTED=content_unittests on win and linux, chrome + apprtc on win and linux, release-built chrome with asan on original crashing test page.
> 
> Review URL: https://codereview.chromium.org/12220063

TBR=phoglund@chromium.org
Review URL: https://codereview.chromium.org/12207127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181932 0039d316-1c4b-4281-b951-d872f2087c98

Adding the meta tag to prevent translate on Files.app.

BUG=175361
TEST=none

Review URL: https://codereview.chromium.org/12212130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181931 0039d316-1c4b-4281-b951-d872f2087c98

There used to be locking in this class, but many small changes had contributed to removing all use of the lock. The lock does not appear to actually be needed, as long as the class continues to be used as it currently is used, with the deferred initialization via RegisterExtensionService always happening before the providers map owned by the object is iterated over.

This change removes the |lock_| member and adds debug-only code that verifies that this is how the class continues to be used.

BUG=none

Review URL: https://codereview.chromium.org/12223052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181930 0039d316-1c4b-4281-b951-d872f2087c98

This will hold on to a reference to the buffer while the buffer is being used by WebRTC. I also tried to fix the places where synchronization was missing (mostly for the params_ instance).

Let me know if you want an offline explanation!

BUG=173987
TESTED=content_unittests on win and linux, chrome + apprtc on win and linux, release-built chrome with asan on original crashing test page.

Review URL: https://codereview.chromium.org/12220063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=marja@chromium.org
TEST=no functional change

Review URL: https://codereview.chromium.org/12210141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181928 0039d316-1c4b-4281-b951-d872f2087c98

Add mini11-a1 (Mac ASan LKGR) to the list of hosts building Mac ASan binaries (those hosts should use a fixed Clang version)

BUG=170629, 174873
Review URL: https://codereview.chromium.org/12207126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181927 0039d316-1c4b-4281-b951-d872f2087c98

Tests all pass and are getting enabled on the bots this week.

BUG=168414
Review URL: https://codereview.chromium.org/12221109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181924 0039d316-1c4b-4281-b951-d872f2087c98

Use a variable initialized with a Function Expression instead.

Function declarations within blocks are prohibited by the style guide.
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Function_Declarations_Within_Blocks#Function_Declarations_Within_Blocks

In addition, they don't work in strict mode.

BUG=174809
TEST=presubmit passes, Files.app launched.

Review URL: https://codereview.chromium.org/12212127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181923 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175711

Review URL: https://codereview.chromium.org/12208130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181922 0039d316-1c4b-4281-b951-d872f2087c98

base::Time is relative to the windows epoch, and base::TimeTicks is entirely
platform dependent. Decision: use base::Time and manually shift it relative to
the unix epoch

This fixes fast/mediastream/RTCPeerConnection-stats*html

BUG=none
R=tony@chromium.org

Review URL: https://codereview.chromium.org/12212107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181919 0039d316-1c4b-4281-b951-d872f2087c98

This temporary change introduces the --is-asan-mac-builder flag and a blacklist of OSX hosts building ASan
on the Chromium waterfall. If either the flag is set or `uname -n` is in the list, older Clang is used.

BUG=170629,174873
Review URL: https://codereview.chromium.org/12210139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181918 0039d316-1c4b-4281-b951-d872f2087c98

Since we don't display a dialog on Mac and there's only one place we create the
shortcut, "Create shortcuts..." gives the wrong impression.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12226108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181916 0039d316-1c4b-4281-b951-d872f2087c98

Show managed mode warning banner on chrome://extensions when the profile is managed instead of when managed mode is active, and update the string accordingly.


BUG=169819


Review URL: https://chromiumcodereview.appspot.com/12225052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181915 0039d316-1c4b-4281-b951-d872f2087c98

The previous label has been confusing for users.

TBR=satorux
TEST=Check with an empty profile if the button's label is correct.
BUG=172477

Review URL: https://codereview.chromium.org/12207124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181914 0039d316-1c4b-4281-b951-d872f2087c98

[content shell] move logic that decides when a test is finished from WebKitTestController to WebKitTestRunner

This is in preparation for linking against the TestRunner library which will own the logic

BUG=111316
TEST=content_browsertests still work
R=marja@chromium.org

Review URL: https://codereview.chromium.org/12208110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181913 0039d316-1c4b-4281-b951-d872f2087c98

Two buttons - undo and redo were missing selected entities. As a result, when clicking on one of these buttons, the icon was white on a white background.

TEST=Open Files.app, click on a picture, click on the edit button, rotate left, click on undo and check the clicked icon. The same for redo.
BUG=170288

Review URL: https://codereview.chromium.org/12218114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181912 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up bugfix to r180264, which added support for using
smaller tiles to save memory if the layer size was smaller than a tile
size.  Unfortunately, this only worked if the layer size never changed
as it cleared all the tiles and didn't recreate them.

This new patch recreates tiles for the entire layer after clearing the
old ones.  If the tile size is changing, it is only going to happen for
very small layers and small numbers of tiles, so this will never in
practice be an expensive operation.

R=danakj@chromium.org
BUG=173945


Review URL: https://chromiumcodereview.appspot.com/12221129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181911 0039d316-1c4b-4281-b951-d872f2087c98

This lands server change 40997047.

Also add TODOs to upstream OnControlFrameCompressed and to fix use of GMock objects.

Review URL: https://chromiumcodereview.appspot.com/12213062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181910 0039d316-1c4b-4281-b951-d872f2087c98

(Fixing https://codereview.chromium.org/11881051/ .)

TBR=tonyg
BUG=155660
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12208128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181909 0039d316-1c4b-4281-b951-d872f2087c98

Blocked on https://chromiumcodereview.appspot.com/11434042.

BUG=163861
TEST=browser_tests:*HostResolverPrivate*

Review URL: https://chromiumcodereview.appspot.com/11411357

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181908 0039d316-1c4b-4281-b951-d872f2087c98

Disabling DownloadExtensionTest_Download_File and SearchWithinSpecialURL due to problems on the Windows Aura test bot.

BUG=175711
TBR=jochen

Review URL: https://codereview.chromium.org/12220118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181907 0039d316-1c4b-4281-b951-d872f2087c98

apparently not at fault

> Revert 181812
> 
> Speculative revert to see whether this broke browser_tests on Win Aura Tests(2)
> 
> A DCHECK() about invalid strings is hit
> 
> > Add a set passphrase dialog which allows to set a passphrase for a managed user account. In a later changelist this will be used for authentication in order to change settings of the account.
> > This changelist is extracted from the changelist here: https://codereview.chromium.org/11783008/ in order to break it up.
> > A screenshot of the set passphrase page is available here:
> > https://docs.google.com/a/google.com/drawings/d/1qXtLoSN2C8Z_qrnNB8yHlJHG96NqL79ciMGaW3amWkw/edit?usp=sharing
> > 
> > BUG=171370
> > TEST=browser_tests, unit_tests
> > 
> > Review URL: https://chromiumcodereview.appspot.com/12208068
> 
> TBR=akuegel@chromium.org
> Review URL: https://codereview.chromium.org/12210136

TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/12217132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181905 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181901 0039d316-1c4b-4281-b951-d872f2087c98

this change was not at fault

> Revert 181806
> 
> Speculative revert to see whether this broke browser_tests on Win Aura Tests(2)
> 
> A DCHECK() about invalid strings is hit
> 
> > Update NetworkStateListDetailedView, add network_icon::GetImageForTray
> > 
> > This integrates chanhes to the network list and icon code,
> > and uses the Ash icon code in the network tray.
> > 
> > This completes the changes for:
> > 161869:	Create NetworkStateHandler version of Ash network tray
> > (Still behind a flag)
> > 
> > BUG=161869
> > TBR=sky@chromium.org (for ash_strings)
> > 
> > Review URL: https://codereview.chromium.org/12221112
> 
> TBR=stevenjb@chromium.org
> Review URL: https://codereview.chromium.org/12218116

TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/12210137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181899 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert to see whether this broke browser_tests on Win Aura Tests(2)

A DCHECK() about invalid strings is hit

> Add a set passphrase dialog which allows to set a passphrase for a managed user account. In a later changelist this will be used for authentication in order to change settings of the account.
> This changelist is extracted from the changelist here: https://codereview.chromium.org/11783008/ in order to break it up.
> A screenshot of the set passphrase page is available here:
> https://docs.google.com/a/google.com/drawings/d/1qXtLoSN2C8Z_qrnNB8yHlJHG96NqL79ciMGaW3amWkw/edit?usp=sharing
> 
> BUG=171370
> TEST=browser_tests, unit_tests
> 
> Review URL: https://chromiumcodereview.appspot.com/12208068

TBR=akuegel@chromium.org
Review URL: https://codereview.chromium.org/12210136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175683
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/12220117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181897 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert to see whether this broke browser_tests on Win Aura Tests(2)

A DCHECK() about invalid strings is hit

> Update NetworkStateListDetailedView, add network_icon::GetImageForTray
> 
> This integrates chanhes to the network list and icon code,
> and uses the Ash icon code in the network tray.
> 
> This completes the changes for:
> 161869:	Create NetworkStateHandler version of Ash network tray
> (Still behind a flag)
> 
> BUG=161869
> TBR=sky@chromium.org (for ash_strings)
> 
> Review URL: https://codereview.chromium.org/12221112

TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/12218116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175683
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/12218115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181895 0039d316-1c4b-4281-b951-d872f2087c98

exists before invoking method on it.

BUG=174872
TEST=none
R=xiyuan@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12226100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181894 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12225131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181893 0039d316-1c4b-4281-b951-d872f2087c98

extension API.

Trying to land this again after clang problem.  Original review was
here: https://chromiumcodereview.appspot.com/12188027/

(TBR'ing trivial change to profile_dependency_manager.cc)

TBR=davemoore@chromium.org,kalman@chromium.org,pneubeck@chromium.org
BUG=chromium:168713


Review URL: https://chromiumcodereview.appspot.com/12225087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181892 0039d316-1c4b-4281-b951-d872f2087c98

All changes are in comments. This patch doesn't change any semantics.

BUG=175657
TEST=none

R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12225135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175439


Review URL: https://chromiumcodereview.appspot.com/12224095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181890 0039d316-1c4b-4281-b951-d872f2087c98

TEST=No user visible changes.
BUG=169191
TBR=yosin

Review URL: https://chromiumcodereview.appspot.com/12224093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181889 0039d316-1c4b-4281-b951-d872f2087c98

The test has moved since the issue was reported, and only repro'd if the
full remoting test-suite was run, suggesting that some other test is at
fault.

BUG=167260


Review URL: https://chromiumcodereview.appspot.com/12223066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181888 0039d316-1c4b-4281-b951-d872f2087c98